[15:22:01] phuedx|afk: bmansurov rmoen assume we are doing the pairing caring today? maybe we could use that to wrap up https://phabricator.wikimedia.org/T110200 from the dev side of things [15:22:33] ok [16:20:31] kaity: are you around? [16:25:39] phuedx: is quick surveys on http://reading-web-staging.wmflabs.org/ ? [16:46:03] jdlrobson: able to join the reading eng leads meeting? [16:46:16] when is it? i don't have an invite [16:46:33] jdlrobson: just sent it to you. will update the others for while joaquin is out [16:54:59] rmoen: can i get a quick +2 for https://gerrit.wikimedia.org/r/236706 ? [17:07:21] dbrant: hey, any chance you'll have time to look at https://gerrit.wikimedia.org/r/#/c/231072/ in the near future? (i already asked stephen the same before most people were on the hangout) [17:09:11] mdholloway: sure! will look [17:09:19] cool, thx! [17:13:37] mdholloway: quick question on the js refactor. do we want to remove the files copied over on the service side since they'll be outdated by this change? [17:13:44] jdlrobson: yes, sry [17:15:27] niedzielski: yeah, i was thinking about that as the next step after getting it firmed up on the app side [17:15:36] mdholloway: ok cool [17:22:50] rmoen: would also appreciate a review on https://gerrit.wikimedia.org/r/235776 if you have time - it's blocking a bunch of MobileFrontend patches :/ [17:26:36] jdlrobson: sure thing, grabbing another coffee first [17:47:14] * jdlrobson heading out for lunch bbiab [18:08:08] rmoen: https://gerrit.wikimedia.org/r/#/c/235947/3 will need a merge to [18:08:12] o [18:11:34] mdholloway: i left one comment on your js patch. due to the nature of the refactor, i had to use an external diff but other than the one comment everything looked good to me and tested fine. [18:11:42] ^ rmoen recheck will not help :) [18:11:59] niedzielski: awesome, thanks! [18:12:12] jdlrobson: something failed on the Jenkins qunit. Rechecking [18:12:17] mdholloway: so i'll be happy to +2 pending your response [18:12:41] cool, will ping you shortly [18:12:41] oh i see :/ ve.dm.MWTransclusionNode getWikitext FAILED [18:14:03] jdlrobson: i can get quicksurveys onto staging [18:14:04] sec [18:16:38] thanks phuedx [18:36:31] jdlrobson: we haven't done a qs release yet, right? [18:39:14] mdholloway: https://gerrit.wikimedia.org/r/#/c/235507/4 + server side look good to me and test fine. do you want me to merge these or wait for your refactor patch? [18:42:32] niedzielski: excellent. actually, i should probably give dbrant a chance to have a look before that's merged since it takes some stuff out including RGB halving we put in recently [18:42:48] niedzielski: am i crazy or was all that color inversion code doing essentially nothing? [18:43:26] phuedx: correct [18:43:34] phuedx: i suspect rmoen will do one today [18:44:30] niedzielski: i'm admittedly not much of a dark mode user so it's possible there's something i'm not noticing. but... it looks the same to me. [18:45:12] mdholloway: i thought it was inverting the background colors (not just the page background) of elements to try to make them stand out better [18:45:23] jdlrobson: http://reading-web-staging.wmflabs.org/wiki/Special:Version#mw-version-ext-QuickSurveys [18:45:27] mdholloway: i'm not sure how effective it was though [18:45:36] phuedx: thanks dude! [18:47:37] mdholloway: the national assembly of pakistan article looks way better post-patch [18:49:08] looking... [18:50:13] mdholloway: the RGB halving i'm pretty confident in taking out for the reasons i mentioned in the phab ticket (subject to counterargument from you or dbrant, of course); it's more my taking out the color inversion functions that i'm hesitant about [18:57:07] jdlrobson: where's the ui tracking graphed again? [18:57:13] i appear to have completely lost the link [18:57:18] http://mobile-reportcard.wmflabs.org [18:58:26] how did i not have that in my favourites?! [19:00:55] niedzielski: on the js transform refactors, i'm going to play with it a little bit and will probably do a small update; i'll keep you posted [19:01:15] mdholloway: ok cool, thanks [19:02:32] jdlrobson: you're right, the graphs really don't reflect a lost of data -- but i'm fairly certain that there should be one ;) [19:03:40] ah [19:04:12] jdlrobson: it only affected mobilewebdiffclicktracking and mobilewebbrowse [19:04:22] (the latter of which we should be getting rid of soon) [19:04:25] * phuedx looks at joakino [19:16:17] niedzielski: ok, i updated those return statements (and one in setNonGbDivWidth.js) and fixed a typo. if it still looks good to you, fee free to merge! [19:16:57] mdholloway: sweet, checking it out now [19:24:56] mdholloway: looks good to me but needs a rebase [19:41:51] niedzielski: ok! patch is rebased and jenkins is appeased. [19:43:09] mdholloway: i was checking it out. i'm not sure why but when i go to the earth article, the infobox is default expanded :/ it doesn't seem to be doing that on master. can you repro? [19:44:04] mdholloway: and it seems to only happen in dark mode [19:44:49] niedzielski: huh. yeah, i just switched to dark mode and got the same result. [19:44:53] mdholloway: i see the same thing on the obama article. if i go there in light theme, quick facts is closed. if i change to dark theme, it's oepn. [19:46:42] niedzielski: oh, i think i see the problem [19:48:57] night.invertElement doesn't exist anymore but apparently got rebased back into invertNightModeElements.js [19:49:04] updating now [19:54:20] niedzielski: invertNightModeElements should probably be renamed as well but I'll save that for a follow-up patch [19:56:29] mdholloway: ok cool. i'm checking it out now [19:57:54] kaity: are you around today [19:59:25] doh i see she sent an email about vacation [19:59:30] phuedx: so she's back monday [20:00:03] i'd really like to push the max width stuff. JonKatz who can i bother about design sign off for pushing max width work to stable? [20:00:14] jdlrobson: so im trying to update QuickSurveys master with dev branch. git checkout master && git merge origin/dev gets me the updates. . Stuck on pushing to gerrit without complaints. [20:00:22] mdholloway: ok lg2m. cool to merge? [20:00:28] niedzielski: merge it! [20:01:04] rmoen: gotta join a meeting now. I've not used Gerrit to rebase but i'm sure there's docs somewhere. [20:01:06] jdlrobson good question. bother moiz? [20:01:25] rmoen: i suspect you just need to change the head or something [20:10:01] jdlrobson: found this but not working for me. https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#git_review_doesn.27t_like_merge_commits [20:21:29] seems as if we don't have push access... [20:26:58] rmoen should be able to help you out in about 30/40mins, [20:30:32] jdlrobson: sorry jon but harry was pretty hard to get to sleep this evening [20:30:51] ok gotta eat something [20:31:03] i haven't quite gotten round to finishing my thoughts on api/foreign api stuff [20:31:14] no worries [20:31:33] i'll be finishing 'em up tomorrow morning at about 5:30 (after harry has gone back to sleep ;) ) [20:31:50] but for now… [20:32:19] g'night y'all [21:02:36] congrats FlorianSW :) [21:02:55] thanks Jon :) jdlrobson [21:02:59] :))) [21:03:05] well deserved! [21:03:19] :] [21:05:18] moizsyed: around? do you know much about the max-width design work kaity has been doing (same question to any other designer) [21:17:50] jdlrobson: i dont know much about it [21:18:17] who would? I just want to get a design sign off that the change doesn't look terrible [21:24:05] rmoen: hey i'm talking to ebernhardson about the version [21:33:35] rmoen: if https://gerrit.wikimedia.org/r/#/c/236962/ works we may need to force merge [21:33:39] my git foo is a bit crappy right now [21:36:49] hey jdlrobson! can we catch up about quicksurveys at some point? i'm digging myself out from hundreds of emails, so not usre if i missed something [21:39:06] jdlrobson: on the merge, shouldn't there be more changes in your patch ? https://gerrit.wikimedia.org/r/#/c/236962/ ? [21:39:41] rmoen: if you look at dependencies the dependencies are right. It should just be a case of moving a pointer but not 100% sure [21:42:57] jdlrobson: oh ok. so a merge then bumping the version seems like a good strategy to work around the push [21:43:13] jdlrobson: i'll test the patch then force it [21:46:06] erik b said he'd have a look at it later too [21:46:10] up to you if you want to try [21:46:23] i'm sure there's someone in wikimedia-dev who is good at this stuff [21:46:32] we'll need to remember to switch the branch back to dev afterwards [21:48:13] jdlrobson: hmmm something is not right. Not seeing the desktop enhancements or the i18n value for ext-quicksurveys-example-internal-survey-question [21:48:32] https://usercontent.irccloud-cdn.com/file/OBxJVTEA/ss.png [21:49:43] jdlrobson: I would push and merge but it seems i do not have rights. [21:50:19] git merge origin/dev && git push gerrit HEAD:master [22:03:23] jdlrobson: seems you didn't pull dev before you merged, see patch [22:19:51] kaity: hey! [22:20:03] just saw your response to the search result comments i made [22:20:16] responding now, but also you should hop into #wikimedia-ios [22:31:47] rmoen: hey more fire fighting :) where are we [22:31:56] jdlrobson: sec [22:32:17] looks like i can +2 https://gerrit.wikimedia.org/r/#/c/236972/ ? [22:32:21] glad you worked it out [22:32:26] what about changelogs [22:32:32] how do we generate those? [22:32:55] bgerstle: kaity is on vacation it seems [22:32:56] back on monday [22:33:06] oh right, forgot she's at a conference [22:33:28] jdlrobson: yeah [22:34:02] so i've a patch for beta labs. feel free to +2? https://gerrit.wikimedia.org/r/#/c/236979/ [22:34:13] or +1 idk :) [22:36:19] rmoen: i don't have +2 [22:36:22] ^ dr0ptp4kt do you? [22:36:26] jdlrobson: hmmm looks like we could https://github.com/rafinskipg/git-changelog [22:36:38] rmoen: mediawiki should have one [22:36:48] jdlrobson: yeah we do, gotta look for it [22:39:15] rmoen: https://phabricator.wikimedia.org/T95324 [22:39:25] ty [22:39:56] also mediawiki/tools/release.git [22:40:47] http://git.wikimedia.org/tree/mediawiki%2Ftools%2Frelease.git/ef6312e63ed9597a0e2b1471c1903bd00fd99fd2/make-deploy-notes [22:41:47] k [22:43:01] jdlrobson: incomming [22:43:09] 2 mins [22:43:11] php ~/git/release/make-deploy-notes/make-deploy-notes < did you use that? [22:43:27] going to [22:43:29] jdlrobson: rmoen i do have +2, but it would be best if someone familiar with the code did the honors, plus lined up the deployment [22:43:43] dr0ptp4kt: it's just enabling the extension. I don't think any of us have permission [22:43:46] (on beta labs only) [22:43:52] i've +1ed it [22:44:33] maybe MaxSem can help? [22:45:02] Just got bit by a spider ;/ meh. [22:48:04] greg-g: would https://gerrit.wikimedia.org/r/#/c/236979/ be something appropriate for a swat? cc jdlrobson rmoen [22:48:49] dr0ptp4kt: yeah, beta-cluster only changes (no-ops in prod) can go out whenever, really [22:49:14] getting the merge to happen, though, (ie: getting someone to do it) has a good chance in a swat :) [22:49:33] ^ very true [22:50:11] jdlrobson: so the strategy is to just schedule it for swat ;) [22:50:35] jdlrobson: also, i'm having issues generating the changelog with the release tools [22:51:03] behhh i'm sure we can find someone to do it before then. [22:51:03] * jdlrobson ponders who owes me a favour [22:51:30] would it be sufficient to just use joakino's git log command? [22:53:38] rmoen: yeh it looks like the core script is hardcoded for the core folders [22:53:45] just use joakins commands [23:01:01] jdlrobson: ok i ran git log 1ad54717c059bcd49093d902eab2c098b4efe91a...a0959b15c97b77b99633d7a0fcbde4a209404ad0 --pretty=format:'%h %s' --reverse | grep -v '^.\{7\} Merge\|Localisation' and put it in HISTORY file [23:02:18] jdlrobson: think this is good https://gerrit.wikimedia.org/r/#/c/236972/2/HISTORY or should we fiddle with the formatting ? [23:03:54] oops typo [23:05:10] looking [23:05:39] looks good [23:07:29] rmoen: so now we just need a patch to switch back to the dev branch as the default [23:08:13] k [23:08:58] jdlrobson: hey, do you know how long hovercards have been around? (like, in general) [23:11:45] dbrant: since the dawn of the dinosaurs! [23:11:50] :) [23:12:04] it used to exist as a gadget - kaldari may know about when that was conceived [23:12:11] but hovercards has been around at least 2 years in beta [23:12:18] (it feels like that anyhow) [23:12:27] Hovercards has been around for over a year [23:12:34] First commit was on 6th Feb 2014 [23:12:53] jdlrobson: Deskana: aha, that's cool; thanks [23:12:57] Navigation popups (https://en.wikipedia.org/wiki/Wikipedia:Tools/Navigation_popups) has been around much, much longer. [23:13:09] Like, maybe even coming on a decade. [23:13:14] I remember using it a veeeeery long time ago. [23:13:47] jdlrobson: +2 switching back to dev https://gerrit.wikimedia.org/r/#/c/236986/ [23:14:55] rmoen: your patch is blank. Think something went wrong? [23:15:06] yeah ps2 is blank [23:15:08] i rebased it [23:15:11] idk [23:15:48] ssooo confused. [23:15:52] its there [23:16:18] in .gitreview: "defaultbranch=dev" [23:16:40] jdlrobson: i'm confused too, but if you check it out and look it should be there [23:16:58] https://github.com/wikimedia/mediawiki-extensions-QuickSurveys/blame/dev/.gitreview [23:18:05] Krenair: thanks for the link. we just changed it to master in the release cut. Now we are changing it back [23:19:04] so strange [23:19:19] that commit was only on the master branch though [23:19:29] (the one that went from defaultbranch=dev to defaultbranch=master) [23:19:41] yes [23:19:44] you didn't apply it to the dev branch, so the defaultbranch value on the dev branch remained [23:19:55] rmoen: https://gerrit.wikimedia.org/r/#/c/236990/1 < rmoen works [23:20:08] as you'll see https://gerrit.wikimedia.org/r/#/c/236991/ gets posted to dev [23:20:37] merged [23:21:09] jdlrobson: oh mine pushed to dev even though we set it to master for a second [23:21:13] strange [23:22:31] rmoen: so now we just need this deployed on beta labs [23:22:41] we can swat it tomorrow ;) [23:25:01] jdlrobson: Roan says he will do it now [23:25:06] sweet! [23:39:20] jdlrobson: we are in line. Waiting for scap for echo change