[00:00:30] o/ [00:03:54] bmansuron, jdlrobson: http://en.m.wikipedia.beta.wmflabs.org/wiki/Alcatraz_Island?quicksurvey=true [00:04:49] yay [00:05:02] hmmm but getting [QuickSurveysResponses] Missing or empty schema [00:08:44] it's also weird that the survey won't show when debug=true is set in the url [00:27:34] bmansurov: why's that weird? We don't apply it when debug=true [00:27:37] good work rmoen [00:28:09] jdlrobson, why not? i must have missed that discussion [00:28:21] bmansurov: i'm just looking at the code.. :) [00:29:11] jdlrobson, can you share the code location? [00:30:43] errr.. http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FQuickSurveys.git/8b923dd0427ecb5768dd7e5e234e1049e2eb2ec0/resources%2Fext.quicksurveys.init%2Finit.js#L48 unless i'm completely misunderstanding you [00:32:01] i don't see any rule there deals with debug, something is weird [00:32:11] that deals * [00:32:19] that's because there isn't one.... [00:32:20] ? [00:32:26] there never was.. [00:32:38] we've always used quicksurvey=true to trigger it [00:32:49] why load unminified javascript just to force a survey to show? [00:33:19] i mean, I have both quicksurvey=true and debug=true [00:33:28] i just want to debug why eventlogging error is happening [00:34:24] oh so you are saying combining the two causes an error? [00:34:55] no, the error happens with quicksurvey=true, but adding debug=true won't show the survey panel [00:37:07] try capturing it in a task with how to replicate it. I'm heading off now but I'll take a look in the morning [00:37:20] i'm still not 100% sure what you mean though [00:37:45] jdlrobson, do you have a sec to talk about https://phabricator.wikimedia.org/T111472 then? [00:37:55] but i'm not seeing mw.eventLog.schemas.QuickSurveysResponses get loaded [00:38:12] jdlrobson, the first and the second bullet points seem to contradict each other [00:38:41] jdlrobson, and that task is specifically about the minerva skin right? because we have those kinds of tests already for desktop [00:39:13] bmansurov: i'd suggest focusing on the other 2 tasks in the sprint but yeh that's a typo and yes it's just verifying the mobile skin works given we have a slightly different code path. [00:39:27] ok [00:39:37] corrected task [00:39:39] gotta fly [00:39:44] thanks, cya [00:39:51] i'm not sure how easy it is to get MobileFrontend integration test working there [00:39:59] it may not be worth the effort since there will be config changes too [00:40:26] k [00:40:59] any help clearing out the MobileFrontend code review queue would be great. Currently 33 patchsets there [00:41:09] (albeit many are stalled) [00:41:15] will do [00:41:16] cya tomo [00:41:18] thanks :) [00:41:23] later [08:16:39] hullo you [10:02:44] o/ [10:08:32] hey bmansurov [10:08:38] gonna make a cup of coffee [10:08:42] brb [10:08:45] hey [10:36:30] back w/ a delicious brew [10:47:38] phuedx, can you share your settings related to wikidata for vagrant? [10:48:01] phuedx, I've enabled the role wikidata but I'm unable to create new items or properties [10:48:08] :o [10:48:09] no such special pages [10:48:25] which url are you going to locally? [10:49:02] http://wikidata.wiki.local.wmftest.net:8080/wiki/Special:SpecialPages [10:52:17] * phuedx can't remember the exact routing rules but i always used: http://wikidata.local.wmftest.net:8080 [10:52:57] bmansurov: does it appear in the site matrix? http://wiki.local.wmftest.net:8080/wiki/Special:SiteMatrix [10:54:23] phuedx, yes, I see wikidata on that page. Can you access /wiki/Special:NewItem locally? [10:54:56] * phuedx switches vagrant instances [10:55:09] pro vagrant user ^ ;) [10:57:02] i'm a total newb -- that's why i use more'n one ;) [11:01:05] bmansurov: yes -- but i did vagrant git-update yesterday [11:01:26] what roles do you have enabled? [11:02:26] explicitly enabled: mobilefrontend, visualeditor, wikidata, and scribunto (for import-dump) [11:02:37] ok thanks [11:05:09] bmansurov: not sure if i helped at all [11:05:12] lmk [11:05:47] sure you did. i know something is wrong with my setup now [14:01:43] 15 minutes for ci feedback is a little annoying [14:05:27] greg-g: yt? [14:05:43] y'know what [14:05:46] ignore that [14:05:48] i'm being lazy [14:39:37] niedzielski: mind pushing your meeting by 1/2 hour? I have a conflict. [14:39:56] dbrant: no that's cool, thanks for the heads up [14:50:43] gtg [15:06:05] phuedx|afk: :) I'm not normally online at 7am [15:21:45] mdholloway|eat: would you please cover for me for scrum of scrums today? I have a strategy meeting [15:53:36] dr0ptp4kt: sure [15:58:35] dr0ptp4kt: so basically just run down the list from the etherpad and field any questions? [16:33:39] mdholloway: exactly. then follow up with your peers [16:33:58] dr0ptp4kt: sounds good! [16:43:30] greg-g: w/e man [16:43:35] 5 am 4 lief [16:44:05] reached for the ping rather than ask a q in -releng anyway [16:44:06] mibad [16:46:31] jhobs: are you joining us for catsoup? [16:47:15] whoops didn't see the new meeting time [16:47:20] be right there [16:59:40] mbinder: niedzielski: mdholloway: fyi i'm missing standup today, because Strategy. [17:00:12] dbrant: strategy schmategy [17:00:29] thanks for the heads up [17:12:13] going to get the kids to bed [17:13:13] this schema gather clicks thing seems to be caused by eventlogging not being detected as installed on the server side and then the test in Schema#log (if mw.eventLog.logEvent) passes!? [17:13:38] we seem to want to maintain a soft dependency on eventlogging, sooo... [17:13:40] i'll fiddle [17:21:37] mbinder mdholloway etonkovidova: browser is acting shady. trying to rejoin [17:23:43] rmoen: can you take a look at https://gerrit.wikimedia.org/r/235912 ? [17:23:56] keen to get the patch from Adishaporwal that depends on it merged [17:24:17] jdlrobson: looking [17:25:42] jdlrobson: looks like the commit msg needs updated [17:42:47] coreyfloyd: dbrant I set up a couple of calendar invites for triage parties based on your calendar availability, but lemme know if those times are no bueno [17:59:47] mbinder: yeah can we push this to later today? [18:00:25] coreyfloyd: k [18:15:22] Thanks rmoen [18:41:49] jdlrobson: Thoughts on removing schema property from survey config? Since QuickSurveysResponses is hardcoded. While I'm here, thinking about cleaning that up [18:45:49] Rmoen depends [18:46:13] jdlrobson: do we need multiple schemas? [18:46:17] I guess a question for JonKatz [18:46:33] Im not sure we do [18:46:59] I guess the question is do we want one generic dumping ground for answers or do we want separate schemas for different questions [18:47:48] Lets imagine we have multiple schemas, they would need the same structure. [18:47:57] we could just put them all into one for now [18:48:10] Yeh let's do that [18:48:22] Ok [18:48:29] Looking at the schema it's generic enough to handle multiple answers that are not yes/no/maybe [18:48:46] And survey Code name allows separation of results [18:48:52] yeah [18:53:59] lets keep it in one for now---with a question field [18:54:35] ^jdlrobson actually anne is back and is pm owner for this. [18:58:57] dbrant: niedzielski mdholloway so... there's going to be an iOS Android app [18:59:10] i.e. "migrate all your android stuff to your new iOS device!" [19:03:26] Jonkatz ok will ping her but doubt it will be a problem. [19:03:47] dbrant: we meeting? [19:05:36] mbinder: sorry, previous mtg running over... 5 more min? [19:05:58] sure [19:15:34] bgerstle: is there your way of telling us that app data has to be cross platform? [19:15:50] niedzielski: just warning you... the iOS migrations are coming... ;-P [19:16:17] also some pretty interesting pricing options, including a $32/mo. subscription that lets you get a new phone every year [19:16:41] * niedzielski senses there was an apple announcement [19:18:26] bgerstle: hm, so i guess iphone 6 came out? did they say it'd be open source too? :-p [19:18:36] 6S, and no :-P [19:18:48] and iPad Pro [19:18:51] i.e. "Apple Surface" [19:18:56] bgerstle: interesting... links? [19:18:58] and, a new AppleTV, w/ apps [19:19:03] www.apple.com [19:19:32] bgerstle: "Your browser doesn’t support live streaming of the event." :-P [19:20:12] niedzielski: yeah, they force safari :-/ [19:21:58] bgerstle: i wonder if a new nexus will launch soon. i've been using this smashed tracfone for forever waiting on the next google device [19:22:24] niedzielski: too cool for samsung? [19:23:38] bgerstle: actually, i used to work there but i really like the freedom of installing whatever os i want (you can do it on samsung devices, but they try to prevent it) [19:24:14] https://developer.apple.com/tvos/developer-kit/ <- i don't suppose anybody is interested in porting our app to appletv ;) [19:24:19] ah [19:25:15] brion: hopefully we will soon ;-) [19:25:25] hehe :D [19:26:25] hmm, new appletv has A8 processor, that should handle webm playback ok [19:26:49] i'll just play with the dev tools for now and wait for the device to hit the market :) [19:27:51] bgerstle: i'm actually a huge apple fan. if i don't know any thing about sarce codes, i'd be on it in a heartbeat. i think the user hardware and software experience is truly amazing and hope it opens up more. i was really happy to hear that swift went open [19:28:22] bgerstle: i assure you i am regularly extremely jealous of ios [19:28:26] yeah, there is _some_ open-ness: http://www.opensource.apple.com/ [19:29:16] but not 100% [19:31:16] coreyfloyd: now a good time? [19:45:00] mdholloway dbrant: global south here: https://www.mediawiki.org/wiki/Reading/Roadmap [19:47:42] mdholloway: the memory profiling task is up for grabs since i'll be working on the quiet crash reporting [19:48:22] niedzielski: k [20:50:09] jdlrobson, hey [20:50:21] so I could add a defaults entry for editSchema [20:50:59] but undefined would be broken by default, it's required [20:51:46] and I don't really want it to default to new SchemaEdit() because then when that does get relied upon, we lose init events [20:51:52] thoughts? [20:53:47] mdholloway: when you have a min, please take a look at my comments to https://phabricator.wikimedia.org/T108333 [20:54:56] etonkovidova: thanks, i saw that. i should have an updated fix in shortly. [20:55:18] mdholloway: thx! :) [20:57:55] hey Krenair [20:58:17] Krenair: oh you don't need to add it to defaults - i was just suggesting you might want to document it [20:58:37] https://doc.wikimedia.org/MobileFrontend/master/js/#!/api/EditorOverlayBase < will show up there then [20:59:49] So if I just add an extra line "@cfg {Object} options.editSchema" to the inheritdoc comment it'll be fine? [21:06:10] Krenair: yup [21:06:23] although it's @cfg {Schema} [21:06:30] right [21:06:52] it's fine now it just might save confusion down the road as you port the editor to a oojs ui dialog or whatever [21:17:49] niedzielski: cool, i'll take a look at that test runner patch now, sorry for the gerrit spam [21:18:08] mdholloway: gerrit patch is wip until we figure out proguard issue [21:18:31] niedzielski: ah, right, that's why i didn't look closer earlier :) [21:18:37] :) [21:19:46] mdholloway: i _thought_ the issue, which i think is just a test flaw, was rare enough that no one else would hit it. i guess not. the patch is wip due to android test runner deps but i can extract the proposed fix if need be [21:20:44] this is the first time i've encountered it, but it seems pretty consistent with this patch. the tests pass locally. [21:22:28] mdholloway: the first time i saw it was this morning when doing translations. it should be completely independent [21:23:33] niedzielski: as for proguard, i'm with jake [21:24:51] mdholloway: i'll break the proposed fix out if need be so we don't have to do anything sudden [21:54:37] mbinder: i think we should cancel iOS design review today… katie is out… and we are reshuffling items for the beta release on monday… and Brina and I have enough to do for now [21:54:44] Brian [22:01:22] coreyfloyd: Brina and Murd, what a great TV show. Let's cancel. dbrant|brb feel the same? [22:01:50] mbinder: coreyfloyd: agreed! [22:11:37] rmoen: it's just good practice [22:12:00] you shouldn't assume how QuickSurveys is going to be used. At very least you should assert its a dependency somewhere e.g. "EventLogging is required to use QuickSurveys" [22:12:15] blowing up client side js is not the way to do that :) [22:12:26] bgerstle: hey! we're thinking about hopping on HockeyApp train. can you invite my WMF account to the organization? [22:12:38] i'm not saying we should blow up the client side. I'm saying what good is a QuickSurveys extension that cannot log responses? [22:12:42] niedzielski: sure [22:12:57] |o| [22:13:37] niedzielski: invite sent \o/ [22:13:52] bgerstle: thanks man! [22:13:54] niedzielski: is that supposed to be a T.I.E. fighter? [22:14:04] GET YOUR ASCII-ART STRAIGHT, MAN [22:14:30] щ(ಠ益ಠщ) [22:14:37] https://gist.github.com/endolith/157796 [22:14:42] bgerstle: oh, that was supposed to be me with raising my arms with accurate musculature proportions [22:14:52] rmoen: it's no good... but you should blow up more obviously. [22:15:05] jdlrobson: I agree with your point that we shouldn't assume how it will be used, but at this point I think a lot of assumptions are being made. [22:15:15] Before your patch I can see surveys fine. After your patch I can't and there's no way I know why. Expected: we should do what we do in Gather [22:15:28] niedzielski: i don't know how you'd make one w/ muscles [22:15:37] Gather outputs "Gather extension requires MobileFrontend." [22:15:39] jdlrobson: i should blow up more? What do you mean ? [22:15:56] QuickSurveys should do the same. It's then much more obvious what the issue is. I don't have to spend time debugging logs [22:16:12] (try Gather without MobileFrontend installed to see what I mean) [22:16:19] bgerstle: %o% [22:16:39] it also allows us to revisit that decision if we wanted to use something over than EventLogging in future. [22:16:46] niedzielski: lol [22:17:06] niedzielski: http://i.imgur.com/wm9Srgj.gif [22:17:27] bgerstle: you say you're not a cat person... [22:17:47] 💪 [22:17:48] niedzielski: http://www.blogcdn.com/www.urlesque.com/media/2010/12/deal-with-it.jpg [22:18:11] bgerstle: what is this strange, cat-like animal...? [22:18:31] fine: http://i.imgur.com/nNBGJwP.jpg [22:18:40] haven't used that one in a while [22:20:11] rmoen: so..? does that make sense or do you think i'm wrong? [22:20:23] mbinder: nice! [22:20:25] i just don't like things dying in non-obvious ways [22:20:41] bgerstle: that photo kind of makes me sad! [22:20:51] :muscle:o% [22:20:56] bah didn't work [22:21:04] http://memestorage.com/_nw/39/78949344.jpg [22:21:29] :) [22:21:41] ok going back to work now! o/ [22:22:08] jdlrobson: I understand. I partially agree. And I'm not saying you're wrong either. [22:24:33] what bit do you not agree on :) [22:25:09] All I'm suggesting is adding a onExtensionSetup hook [22:26:22] alternatively you could save devs the hassle of installing EventLogging to run QuickSurveys [22:26:33] and just not load the schema when it's not installed [22:27:33] I will do that, and I agree with that part. [22:31:33] which part do you not agree with..? :) [22:35:12] jdlrobson: I've already detailed my concerns in the patch. I see your points, what's left to discuss ? [22:35:31] well you said you didn't agree on something and I'm keen to understand what that is and your reasoning.. [22:35:33] we seem to be in agreement [22:51:39] Okay well I will just have to remain confused :) [23:15:13] 21:08:49 Warning: /mnt/jenkins-workspace/workspace/npm/resources/mobile.editor.common/EditorOverlayBase.js:169: Ignoring subproperty 'options.editSchema' not parent found with name 'options'. [23:15:13] 21:08:49 Warning: /mnt/jenkins-workspace/workspace/npm/resources/mobile.editor.common/EditorOverlayBase.js:169: @inheritdoc - parent member not found [23:15:19] jdlrobson, any idea how to fix this? [23:17:47] some 8 years ago, i started off by making the mobile wikipedia website run on my wii... I guess i need to buy an AppleTV to try something like that again :) [23:54:26] o/ [23:56:16] hey.. I want to participate in next outreachy round from dec2015 -March 2016. [23:57:36] Does extension:MobileFrontend has any project I can choose to work on during outreachy internship. [23:57:39] ??