[00:08:01] o/ [00:10:21] (jQuery() instanceof jQuery) === true, as well. Though it's best not to use that in practice, it does work. It's a valid constructor (with some extra functionality on top) [08:57:50] o/ [09:23:31] bmansurov: o/ [09:24:22] hello [13:25:13] woah [13:25:28] i had a big dizzy spell and had to lay down for a while [14:16:45] dbrant mbinder: i think kaity is at xoxo this week. are we still doing estimation today? [14:18:37] niedzielski: i think we could estimate as much as we can ourselves, and leave anything else under 'questions for design" [14:18:54] dbrant: sounds good [15:39:49] ^^word [16:15:45] jdlrobson: hey are you there? [16:17:27] niedzielski: send me a gchat if you need anything! [16:17:39] kaity: thanks! [16:33:38] jhobs, any q for me? [16:40:26] kaity: hey we're still good for 10am? [16:40:36] phuedx: i've been thinking more abut https://gerrit.wikimedia.org/r/#/c/236191/ [16:40:42] i don't think we need to merge it right now [16:40:54] yurik nope, I'll ping you with the patch later [16:40:54] what's the harm in leaving it around for 2 weeks so we reduce number of cached pages [16:41:20] jhobs, ok, but i won't be online after about 4 hrs [16:41:40] yurik yep, no worries [16:45:19] oh wait. This patch doesn't do what i thought it would do.. [16:46:27] niedzielski: mdholloway: hey! got time for a quick huddle? [16:46:39] dbrant: yesh! [16:46:48] dbrant: niedzielski sure, omw [16:48:17] sorry jdlrobson [16:48:21] i should've marked myself ak [16:48:22] *afk [16:48:26] just getting the boys to bed [16:48:30] after a long day [16:48:31] bbiab [16:50:53] \o [16:50:57] have a good un [16:57:48] jdlrobson: yes [17:10:02] jhobs: how'd everything go with yurik yesterday? "Ship It!" ? [17:12:16] dr0ptp4kt: not quite, I'm writing the backend part and he'll be reviewing the patch. I expect to push it today, hopefully before his flight but potentially during [17:13:02] we figured it's simple enough and still gets me a bit more experience with the backend [17:16:15] jhobs: cool, alright looking forward to seeing the patch [17:57:44] dr0ptp4kt: etonkovidova Android retro shortly :) [18:14:28] jdlrobson: can you chat about design review for a sec ? [18:16:04] rmoen: in a min. just fixing a few things up [18:17:39] rmoen: give me 5 mins and ill jump into tracy island [18:17:45] jdlrobson: ok [18:17:50] see you there [19:19:12] jdlrobson: oops meant to ping you in chan. Bout to head to lunch soon, need anything? [19:32:10] niedzielski: are you implementing HockeyApp on top of ACRA or taking ACRA out? [19:32:29] mdholloway: removing acra fully [19:33:29] niedzielski: good. besides the need to update the support libraries for the other issue, I just started poking around with LeakCanary and ACRA is a major (so far, the only) culprit [19:35:57] mdholloway: it looked hockeyapp was using weak context references but i guess i wouldn't be surprised if it was also flagged [19:36:57] niedzielski: worth keeping an eye on, anyway. [19:37:42] overall, though, flipping through images in the gallery is the only way i've found to put substantial memory pressure on the app [19:44:59] brion: interesting. TVOS for the AppleTV is a rare mixture of xml/html/JS/templates etc [19:45:17] should make for some interesting app development [20:01:42] rmoen: seeing issue with cached pages :( [20:01:55] jdlrobson: do tell [20:02:19] so i ran /dev-scripts/cachedpage.sh 97b78165ffda8923b6da1f9143ea64cc2ad73965 Albert_Einstein [20:02:43] https://usercontent.irccloud-cdn.com/file/uuNZztqY/Screen%20Shot%202015-09-11%20at%2010.11.18%20AM.png [20:02:49] whoops wrong one [20:02:57] https://usercontent.irccloud-cdn.com/file/yAUsygqo/Screen%20Shot%202015-09-11%20at%201.02.22%20PM.png [20:03:03] ^ there's a margin top [20:03:08] i think Baha has a comment about this [20:04:23] So this should still have .pre-content, so i could possibly do marign-top: 0 ? [20:05:18] jdlrobson: The margin-top bit was tricky because of the background issues pointed out. Also, I wanted to cleanup the location specific classes added in the template. [20:05:35] lemme take a closer look [20:05:54] so this would have been made a lot easier if we didn't add both pre-content and post-content classess... [20:07:52] so rmoen .stable .last-modified-bar.pre-content can having padding: 0 [20:08:15] ok [20:09:22] and you can add a margin-top: 0 to the same rule i think [20:09:27] since pre-content is not in the new patch [20:09:54] ok will add right under the fixme which indicates to remove the .pre-content stuff after cache clears [20:11:26] jdlrobson: amended [20:12:00] also interested in peeking at your dev-scripts [20:13:21] jdlrobson: once the changes last-modifed-bar are merged i have to resolve a conflict on https://gerrit.wikimedia.org/r/#/c/236226/ [20:13:41] rmoen: mm? [20:13:49] the max-width needs a rebase [20:13:51] the dev-scripts are in the repository [20:14:03] Oh :) [20:14:23] jdlrobson: i had no idea :) [20:24:37] rmoen o, [20:24:37] rmoen: i'm looking again now [20:24:49] jdlrobson: ty [20:25:23] hopefully the margin-top styles aren't overriding [20:25:27] rmoen i see the last modified bar is now inside #bodyContent, [20:25:32] and wasn't before.. is there a reason for that? [20:25:45] there was a bug with quicksurveys that this might have been causing [20:25:56] (quick survey was loading below the bar) [20:26:03] sorry only just noticed this [20:26:37] jdlrobson: Outside of bodyContent it was 100% wide without the max-width work [20:26:50] oh i see. [20:27:06] well i guess we can fix that reasonably easy in a follow up [20:27:16] I went with that because it looked the best, and to be independent of the max-width work [20:27:46] rmoen: cached pages are still problematic :( [20:27:58] :( [20:28:28] going to run the cache script to look [20:29:30] trying out work out why [20:29:59] jdlrobson: you ran dev-scripts/cachedpage.sh f9f6264d048a7b8a7bd9b48f9ca0d950cbae8519 Albert_Einstein? [20:30:00] aah ot [20:30:04] rmoen: up [20:30:12] looks like there is an existing rule wrapped in (min-width: 768px) [20:30:21] you should be able to update that rather than create a new css block [20:30:31] hmm ok [20:31:43] also typo [20:31:44] .stable. [20:31:48] so that's why it's not working :) [20:32:29] jdlrobson: doh [20:32:36] can you point me at the existing rule? [20:32:53] add it in resources/skins.minerva.tablet.styles/common.less [20:33:06] oh wait actually scrap that [20:33:10] cos it needs to apply in mobile too [20:33:22] you might be able to remove that rule [20:33:27] or rewrite it [20:33:40] there is a margin: 1.5em in links.less [20:34:00] yeh mobile is even worse [20:34:04] is the tool working for you? [20:34:06] for .return-link, mw-mf-last-modified [20:34:07] are you able to replicate the issue? [20:34:14] sec [20:34:43] cos once you can you should be clean sailing to the finish line [20:36:31] jdlrobson: hmm the cached page script is putting think at the bottom in stable for me [20:36:36] link* [20:36:53] so thats not helping [20:38:09] rmoen: well let's work out what's not working [20:38:22] echo $MEDIAWIKI_URL [20:38:22] jdlrobson: want to jump in a hangout? [20:38:25] sure [20:38:41] I can see the page it generated its jut not right [20:38:59] in tracyisland [22:14:33] rmoen: any luck fixing up that patch? [22:15:48] jdlrobson: not yet. I haven't looked at it since my meeting with Adam and Toby. [22:20:10] k [22:20:23] just wondering if it's going to spill into next sprint [22:20:30] trying to finish up preparation for monday kick off [22:45:14] jdlrobson: ok fix is in for cached page on mobile screen / tablet. I added fixmes to cache related bits [22:46:42] jdlrobson: rebasing max-width work now [22:47:13] jdlrobson: err maybe i'll wait if you're going to test ? [22:48:58] rmoen: a few minor cleanupy things. I'd rather we used post-content class since it already exists then introduce a new last-modified-bottom [22:50:07] jdlrobson: I was struggling to find a way to only apply the margin-top: 1.5em to only the bottom history link [22:50:18] I'm open to suggestions [22:50:32] rmoen: suggestions made. Minor feedback [22:50:58] can confirm it works on cached pages though so that's great :) [22:51:11] Yeah once i change it though, need to reconfirm [22:52:32] just grabbing coffee before closes [22:53:59] jdlrobson: the problem with using .post-content is it is being applied to the history link on the top of cached pages, for whatever reason [22:54:16] https://integration.wikimedia.org/ci/job/mwext-mw-selenium/1058/consoleFull - I wonder what this is... [22:56:39] is that testing against beta..? [23:14:59] rmoen you can safely rebase now :) [23:15:27] Krenair: what patch is that associated with? [23:15:39] https://gerrit.wikimedia.org/r/#/c/237738/ [23:15:50] jdlrobson: alrighty :) [23:15:58] can you replicate the browser test issue locally? [23:18:18] Krenair: note the browser test runs without EventLogging installed [23:18:25] so it's possible some exception is happening during the editing process without it [23:18:28] that would be my guess [23:19:14] So why didn't this fail before? [23:19:51] Uncaught TypeError: Cannot read property 'always' of undefined [23:20:01] i dunno maybe something changed upstream [23:20:02] Heyo :) mobileweb question: IIUC, the talkpage links at the bottom of all pages, are only shown to users who are either A) logged-in, or B) opted-in to Beta. Is that correct? And, is there a task for enabling the feature for IPs who aren't using beta? Thanks! [23:20:37] quiddity: they show for logged in users in stable [23:20:41] jdlrobson: entire chain rebased :) [23:20:41] for users who have more than 5 edits [23:20:46] and looks good [23:21:10] quiddity: background = https://phabricator.wikimedia.org/T54165 [23:22:19] jdlrobson, they also show for logged-out users, who have opted in to the beta setting. [23:22:27] quiddity: correct [23:22:33] perfect, thanks :) [23:24:32] rmoen: minor fix up and then i think we're good to push [23:24:34] cached pages again :) [23:24:44] Uncaught TypeError: Cannot read property 'always' of undefined [23:24:47] oh wait... I know why :) [23:25:00] Krenair: yup 4:19 PM Uncaught TypeError: Cannot read property 'always' of undefined [23:25:12] i haven't looked at why :) [23:25:23] It's my fault in PS2 [23:28:28] jdlrobson: got a fix in 2 mins [23:32:08] jdlrobson: done [23:32:17] rmoen: on it [23:32:47] jdlrobson: the fix ended up being removing / changing the stuff we are to remove anyway for the fixmes :) [23:37:00] jdlrobson: ty [23:37:21] rmoen: fingers crossed i didn't miss anything... [23:37:45] jdlrobson: Same. Lots of moving parts there. [23:37:59] Thanks for your hlep [23:38:01] help* [23:49:29] rmoen: shoot [23:49:30] it didn't merge [23:50:04] rmoen: 1) ResourcesTest::testFileExistence with data set #1481 ('/mnt/jenkins-workspace/workspace/mediawiki-extensions- [23:50:28] rmoen you there? I can't let it go out like this :) [23:50:36] jdlrobson: yes [23:50:46] i was responding to emails [23:50:50] Looking now [23:50:56] looks like a few changes to resources.php needed so hopefully super simple [23:55:27] jdlrobson: is it just that resources/skins.minerva.beta.styles/main.less need removed from skins.minerva.beta.styles ? [23:57:00] jdlrobson: pushed it in, waiting to see if it passes [23:57:21] rmoen: running locally.. [23:57:46] passes locally so i think you're good [23:58:12] My bad, thought I had removed all the files I deleted