[06:15:15] dr0ptp4kt: here's the patch, if you're interested https://gerrit.wikimedia.org/r/235267 [06:15:39] dr0ptp4kt: (on monday, of course) [08:35:11] hola [09:11:09] o/ [10:57:49] taking the boys to a group [13:40:11] hullo again [14:55:46] o/ [16:08:05] jhobs: you joining sprint kickoff or no? [16:19:27] kristenlans: I was listed as optional and so I assumed it was just for tech leads so I went to lunch [16:20:38] jhobs: no problemo, just checking :-) [17:05:10] i'm assuming sprint kickoff is running a bit long since nobody's in the standup ;) [17:34:57] kristenlans: what's the address for the hatjitsu page? [17:35:09] MaxSem: ^ [17:35:49] kaldari: http://hatjitsu.wmflabs.org [17:37:57] thanks! [17:41:15] dbrant: it looks like development event logging is down? [17:42:01] niedzielski: let's see... [17:43:10] dbrant: even the database and client side parser logs don't seem to be updated as far as i can tell [17:44:00] dbrant: the last entry in MobileWikiAppShareAFact_12588711 was in august [17:44:13] niedzielski: hmm..! [17:44:56] dbrant: anyway, your patch, https://gerrit.wikimedia.org/r/#/c/238136/, looks good to me but i can't test it on the server end. cool with merging anyway? [17:45:15] niedzielski: dbrant: :( [17:45:23] niedzielski: yeah, let's go for it [17:58:23] dbrant mdholloway: for the wiki main page, is the correct casing really "Main Page"? i thought it should be "Main page" with a lowercase p [17:59:53] niedzielski: nope, it's "Main Page" [18:00:29] i mean... "yes", it's Main Page [18:01:37] dbrant: doesn't that conflict with the naming conventions? https://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_(capitalization) [18:01:49] dbrant: even the link back to the main page on that link is "Main page" [18:03:11] niedzielski: i totally agree. [18:03:53] dbrant: should we change it then? [18:05:05] niedzielski: i'm not sure about the process by which you could rename the main page on enwiki... [18:06:15] dbrant: i'm not sure how to change it for other languages, but i think we could map "Main Page" to "Main page" in scripts/make-templates.py [18:07:10] niedzielski: oh you mean special-case it for English on our end. Meh, do you want to go down that route? [18:08:22] niedzielski: even if you do that, it will still appear as "Main Page" in our History list, because the title will get normalized by the server. [18:09:10] dbrant: nuts ok [18:34:38] ergg more icon issues. Found an issue with the close icon whilst doing a QA overview https://phabricator.wikimedia.org/T108657 [18:36:06] rmoen: fyi https://phabricator.wikimedia.org/T101344#1638490 [18:36:38] jdlrobson: ty [18:37:55] hrrm [18:38:28] potential engineering goal: use oojs-ui throughout? [18:43:29] just looking at the oojs-ui-related discussion about icons [18:59:39] phuedx: potential yup. [19:02:38] phuedx: if we can fix it temporarily before end of day that's great if not hopefully we can get it fixed before next deploy. [19:46:50] mdholloway dbrant|brb: there's a sporadic test failure in DoEditTaskTests that's been around for as long as i remember. i can repro it locally and on ci but both are sporadic. does anyone recognize the issue? i think we're just not getting the latest change made to the page sometimes. https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/80/artifact/logcat.txt [19:57:46] niedzielski: i don't recognize it. [19:58:09] mdholloway: ok, thanks [20:27:56] dbrant: question for possible future phab: do we need PerformMigrationsTask, DataMigrator, and friends? [20:29:39] niedzielski: i was thinking of that myself... All of that stuff is for importing data from the old Phonegap app (!) [20:30:41] dbrant: i vote it's phabbable [20:30:51] niedzielski: i would be quite inclined to remove it. [20:31:57] niedzielski: i could just do it as part of the existing task... [20:32:19] dbrant: works for me [20:34:20] niedzielski: alright, let's solve the edit test failure... [20:34:25] dbrant: :) [20:59:54] niedzielski: the only reason I can see for that test to fail is if there's a race between two simultaneous instances of this test, editing the page at the same time... [21:00:21] niedzielski: i'm not sure how well-conceived that particular test is... [21:00:38] dbrant: the server runs in serial, so unless someone else is running locally, there shouldn't be a race [21:00:43] dbrant: yeah [21:01:01] dbrant: maybe it's time to break out @FlakyTest [21:01:14] http://developer.android.com/reference/android/test/FlakyTest.html [21:05:22] niedzielski: yes, that.... Or, rethink the test somewhat. As it is now, literally anyone in the world can break our test by running it themselves, or by editing that wiki page... [21:22:07] niedzielski: lol i could have gone either way with capitalizing "internet" [21:22:18] niedzielski: i look forward to a time when it's no longer a proper noun [21:22:39] dbrant: that's why i didn't say anything on the initial patch but then i googled it and felt foolish [21:35:48] dbrant mdholloway: friendly reminder to go through the parsoid setup steps before thursday [21:36:27] i've got it ;) [21:36:36] ^same [21:39:58] well then [21:45:46] rmoen: around? any chance of a fix for https://phabricator.wikimedia.org/T112341 going out before the cut off tonight? [21:46:00] jdlrobson: typing a long email [21:46:07] roger that rmoen! [21:46:25] jdlrobson: i will try [21:47:08] jdlrobson: feel free to swoop that up if you spot a quick fix [22:22:58] coreyfloyd: hey are you around? [22:28:26] ok rmoen gonna swoop in and have a look [22:28:33] thanks jdlrobson [22:28:36] have a meeting [22:56:30] jdlrobson: https://phabricator.wikimedia.org/T93826 [22:57:09] jdlrobson: https://www.mediawiki.org/wiki/Reading/Features/Article_lead_image [23:56:49] o/ [23:57:21] bmansurov: heeeyy [23:57:32] just in time! got a couple of patches i'm keen to get on the train! [23:57:37] sure [23:57:51] https://phabricator.wikimedia.org/T112341 being most important :) [23:57:58] followed by https://phabricator.wikimedia.org/T112600 [23:58:07] apart from that i think we are in good shape! [23:58:25] ok