[00:23:55] thx bmansurov [00:24:06] feeling much better about next deploy now :) [00:24:07] np [00:24:31] hopefully there's various things to keep you busy whilst i sleep :) anything you need before i go (i'm planning to leave in about 15 mins) [00:24:46] cool, i'll resubmit my patch [00:24:51] .printonly patch [08:10:05] hullo [10:00:55] o/ [10:05:55] phuedx, good catch [10:19:45] ? [10:20:00] what did i catch? [10:20:06] i mean, obviously it was a good catch… [10:20:09] :D [10:22:03] bmansurov ^ [10:22:24] something important ;) [10:24:46] okie poke [10:45:29] taking an early lunch [10:45:35] can't concentrate at the moment :/ [10:50:56] bon appetite [11:25:51] yo [11:34:09] phuedx, i submitted a fix, but not sure if we should revert at this stage [11:34:32] bmansurov: i'll take a look at the fix and we'll make a decision [11:34:34] cool? [11:35:41] sure [11:56:22] bmansurov: your patch lgtm [11:56:25] tested locally [11:56:35] just need to test the effect on cached stable pages [11:57:02] potential engineering goal for next quarter: review and simplify our dom/css [11:57:23] come up with/adopt patterns for constructing new ui components/features [12:09:11] good idea [12:27:23] is there a task in phabrictor for the idea of not loading collapsed content on pageload on the mobile site? [12:29:33] gilles: yes and i think you've commented on it before ;) [12:29:36] gilles, the idea came up multiple time [12:29:36] sec [12:29:43] s [12:31:18] gilles: https://phabricator.wikimedia.org/T90867 [12:31:28] conversation is also embedded elsewhere, as mentioned by jdlrobson [12:31:48] thanks! [12:32:51] well, that task's not strictly dedicated to that idea? [12:33:10] that's what I meant, it's been brought up before in various discussions but I couldn't find it as a task of its own [12:33:44] if there isn't one, I can make one [12:33:54] gilles: yeah -- i wrote that task specifically for the hackathon [12:33:54] I don't see that exact idea in the list on https://phabricator.wikimedia.org/T98986 [12:34:05] feel free to open one up [12:34:06] :) [12:34:16] will do [12:37:11] ah, actually I guess it's functionally equivalent to jdlrobson [12:37:24] jdlrobson's implentation of the lead section load [12:37:55] it's just a different way of saying it. somehow I thought there was collapsed stuff in the current mobile site but that doesn't seem to be the case at a glance [12:48:43] collapsing works on small screens [12:48:53] by default i think [13:04:37] o\ [13:43:00] hey aude! [14:17:12] hi dbrant [14:17:53] aude: is it cool if I pile on a few enhancements to the Maps patch? [14:18:06] like what? (but sure) [14:18:57] at some point it might be nice to merge (maybe with feature flag) and then make new patches to further improve specific aspects [14:19:05] e.g. break into subtasks [14:20:51] aude: basically productizing it a bit, and making it look more like the new mocks. [14:21:03] sounds ok [14:21:54] btw, we are working now on making special nearby work with wikidata :) [14:22:07] * aude imagines the possibilities [14:22:38] excellent! [14:49:32] o/ [15:30:25] mdholloway: were you planning on doing the hook up of some restbase data source so we can exercise one of the endpoints? [15:31:35] niedzielski: planning to look at service stuff today. but you should be able to use the restbase route in the app already. [15:32:41] mdholloway: awesome. yeah, i mean actually put something in we could release on the beta channel to some percentage of users type thing [15:33:52] niedzielski: sure. it's on the agenda for the afternoon! [15:34:00] dbrant mdholloway: are we confident that our alpha user audience is too small to do anything useful with? [15:34:06] mdholloway: that's great! [15:34:26] niedzielski: pretty confident. [15:34:43] dbrant: ok thanks [15:50:52] no paring caring? [16:05:22] dr0ptp4kt: coming to ios meeting? [16:05:24] dr0ptp4kt: hey, nuria and i are in the analytics meetin [16:19:44] :) [16:19:48] benestar: commented on: https://gerrit.wikimedia.org/r/#/c/234730/ : [16:20:18] FlorianSW: I was about to comment two days ago but somehow forgot to click "Review" xD [16:21:07] but when assinging a completely new array, I think the reference to the actual object is lost? [16:21:15] benestar: yeah, I know this problem, sometimes I look into my "Draft comments" and I'm wondering that there are some :P [16:21:31] benestar: sure, and the problem? :? [16:21:44] FlorianSW: the change won't be reflected after the api call? [16:21:51] there is nothing like &$foo in javascript afaik [16:24:20] benestar: it should work, objects are passed by reference in JavaScript :) [16:24:45] You can test it, simply add a listener to the hook, change the object there and output the variable after the hook fires [16:24:46] FlorianSW: but you're replacing the object [16:24:50] you reassign the parameter [16:25:28] benestar: I must say: I'm not sure, let me test :D [16:25:40] ^^ [16:30:42] hmm [16:30:48] benestar: ^ [16:31:35] hmm isn't the most meaningful message [16:32:40] benestar: :P Sorry, but you're right, I haven't thought about that :( [16:33:31] benestar: would you be ok with an object { apiQuery: ..., query: ... } ? [16:34:05] bah, why not first run the hook? [16:35:31] benestar: because no one can know, what the actual query is (like I wrote in my comment). A hook isn't used only to _replace_ something, it can (and should) be used to extend it, too. [16:38:05] gilles: did i see movement on lead section card!? :) [16:44:52] FlorianSW: but currently there is no usecase for such a thing... [16:45:22] but I see your point... [16:45:27] benestar: I don't want to change the code later, just because know there is such a use case :) [16:45:35] *know -> now [16:45:52] so if it doesn't annoy you too much to have parameter warnings we can just go the current way [16:48:03] benestar: why not use an object with the apiquery and the search query?! *wondering* [17:00:18] bmansurov: sorry -- had to give the boys a bath because of the meeting [17:00:43] phuedx: bmansurov did we fix the max-width issues before deploying or do i need to do some LD today? [17:01:21] jdlrobson: bmansurov's fix got merged early this afternoon (gmt) [17:01:24] but… [17:02:17] jdlrobson: https://gerrit.wikimedia.org/r/#/c/238382/ included in wmf/1.26wmf23 [17:04:01] so that didn't make it in phuedx ? ? [17:04:02] :/ [17:04:52] jdlrobson: really worth an ld? [17:06:23] phuedx: LDing https://gerrit.wikimedia.org/r/#/c/238382/ ? [17:06:33] yeah [17:06:45] yeah -- i guess it would round off the section of work [17:06:52] s/section/block [17:07:09] i think it's pretty visible so we probably should [17:08:19] I'll evaluate it when it's up on mediawiki.org at 1pm and make a decisio [17:12:07] yeah fixed [17:15:47] thanks guys i super appreciate it [17:30:02] jdlrobson: i'm looking at the wikidata mobile search task [17:30:23] appears the only reason mobile uses ApiQueryPrefixSearch is for page images? [17:32:41] kristenlans: we're waiting for the room [17:33:04] FlorianSW: because when using an object you mix parameters, especially you mix an object and a string [17:33:22] dr0ptp4kt: 10-4 [17:35:45] benestar: and the problem? An object can hold multiple types of attributes?! Any object we have in MobileFrontend has different types of attributes (objects, strings, arrays, functions,...) [17:36:25] I just consider that a code smell... ;-) [17:36:48] but we can still do this if no better option can be found [17:37:23] aude: it's also used to get wikidata descriptions in the beta search api [17:40:40] ok [17:40:50] opensearch supports descriptions [17:41:40] benestar: for short term, generators and short term solution are fine :) [17:42:20] the descriptions in opensearch are extracts from wikipedia [17:42:37] but theoretically could be an option or an extension could override that [17:42:47] there is a hook point for such [17:44:53] * aude off [18:08:16] aude: do you want to lift -2 from this? https://gerrit.wikimedia.org/r/212922 [18:32:31] o\ [18:32:35] phuedx: https://gyazo.com/add7425db6bf0063ce457e04c37e39d6 [18:32:54] YES [18:32:56] YES [18:32:57] YES [18:33:00] invite the rest of the team [18:33:07] haha sounds good [18:35:03] jdlrobson: got 30 minutes? [18:35:34] grabbing a late lunch [18:37:12] kaity: hey have a minute? [18:48:26] phuedx: after meeting ya [18:59:15] niedzielski: alright, so I'm not really seeing any other Gingerbread-related items that are worth doing... [18:59:26] niedzielski: so the question is, should we wait until HockeyApp? [19:00:22] dbrant: manprit is currently working through a chain of folks [19:00:32] dbrant: we don't know what the eta is [19:02:26] niedzielski: would we lose a whole lot if the GB version continues to use ACRA + email for crashes? [19:03:45] dbrant: my opinion is no. we'll be monitoring this last planned release for crashes to make sure it's stable before upgrading to 15 [19:15:55] jdlrobson: was about the meeting [19:15:57] gotta dash! [20:12:13] dbrant: done [20:12:48] at a glance, the code looks nicer and would like to try it out tomorrow morning [20:14:17] aude: i think you might like it ;) [20:17:11] yay! [20:17:25] i would like to get the first iteration merged and then see what other tasks are needed [20:17:34] ideally [20:21:27] that's the idea. [20:23:36] kristenlans: can you do a bulk edit for me on https://phabricator.wikimedia.org/project/sprint/board/1053/query/TRiVy4zOMdR./ ? [20:23:43] change all priorities to low...? [20:25:49] kristenlans: will help me with triaging.. [20:26:42] Krenair: rebase needed on https://gerrit.wikimedia.org/r/#/c/237738/ [20:26:53] Did you check that it works jdlrobson? [20:29:02] Krenair: oh wait i misread your comment. You'll need to add the schema to https://gerrit.wikimedia.org/r/#/c/237738/6/includes/MobileFrontend.hooks.php [20:29:19] getEventLoggingSchemas takes care of the magic for loading the schema [20:29:59] do you know why we reverted it? [20:31:21] A WikimediaMessages compatibility issue from what I understand? [20:31:39] `Conflicts with WikimediaEvents, completely breaking beta (will break production in a week if left as-is)` [20:31:46] according to commit message for revert [20:33:28] niedzielski: mdholloway: so then, I think I'm about ready to declare the cutoff for GB... What say you? [20:34:14] * niedzielski bites fist [20:34:25] dbrant: it's an exciting time to be alive! [20:35:02] dbrant: so we're going to cut a release then? [20:36:46] niedzielski: right; actually, how about I take until the end of the day to track down https://phabricator.wikimedia.org/T112519 which is being rather elusive, and we'll do a release tomorrow regardless of whether it's fixed? [20:37:18] dbrant: works for me [20:38:33] dbrant: niedzielski: just took one last look in phab. do it! [20:39:55] phuedx|afk: am writing a test for https://phabricator.wikimedia.org/T112207 [20:49:36] jdlrobson, yes [20:49:46] jdlrobson, the problem is that both MF and WikimediaEvents were trying to load the schema module [20:49:53] trying to register* [20:50:37] not WikimediaMessages either [20:51:09] That is why MF should not be loading the schema [21:09:26] niedzielski: dbrant: you guys have time to hop on a hangout to talk about the content service status, or should i schedule a meeting for tomorrow a.m.? [21:09:48] mdholloway: either way works for me [21:10:03] mdholloway: i have a couple minutes [21:10:13] great! see you in the batcave [21:18:11] jdlrobson: can do, it might not be until tomorrow AM though, is that OK> [21:47:51] dbrant|bbl: would you be able to rep for reading tomorrow at scrum of scrums?