[00:02:44] o/ [00:13:21] rmoen: any chance you have time to review that interstitial patch today? I can hop in a hangout if there are any questions or anything; I'll be working late tonight [00:13:57] rmoen: most of it you've already seen, but it would be nice to get at least one frontend reviewer on it before merging if possible [00:19:23] kaldari, waaah? WP - centric survey? [00:19:55] yep, as usual :) [00:20:06] although it does include Commons [00:20:42] MaxSem: The Wishlist survey we're doing next month will include all projects though [00:21:15] * MaxSem bites kaldari [00:22:08] it could be worse ;) [00:22:16] kaldari, "15 years or more" - really? [00:24:36] I didn't write that part [00:24:44] maybe it's to detect people that are lying :) [00:25:36] also, hi mobile team! [00:25:49] maybe I should change that one [01:05:18] MaxSem: I changed it to '14 years or more'. Which translation of that is better, 14 лет и более or 14 лет и дольше ? [03:09:17] o\ [08:07:32] hullo [09:54:38] heading over to a coffee shop [13:05:33] o. [13:05:39] o/ [13:30:55] \o [13:50:22] niedzielski: dbrant|brb: g'morning! before i turn to other things, is there anything outstanding that needs to get done/reviewed for the GB release? [13:51:02] mdholloway: hello! i am reviewing dmitry's sequence patch. i'm not sure what else we want to get in [13:51:52] phuedx, over here ;) [13:56:04] ? [13:56:19] turns out i forgot to re-open the irccloud tab :/ [13:56:22] bmansurov: over where? [13:56:26] over here here? [13:56:32] yes ;) [13:56:41] i'm keen to merge your patch [13:56:43] not over there there [13:56:46] no [13:56:55] ok here here it is [13:56:57] left a comment [13:57:02] but just to be clear clear [13:57:07] ok i've got nothing [13:57:15] :) [13:57:45] huh [13:57:48] i did not see that [13:57:52] both to the swp and to the comment [13:57:52] magic [13:57:54] sec [13:58:11] that's what you get for -a [14:32:02] niedzielski: mdholloway: i think we're all set... [14:32:18] dbrant: great! [14:33:10] dbrant mdholloway: cool, i'll start the release process [14:33:16] o/ [15:32:04] dbrant mdholloway: looking good so far. gb testing is mostly wrapped up and i'll now be focusing on newer devices [15:32:27] niedzielski: excellent [17:01:46] phuedx: standup [17:01:53] i know i know [17:09:15] mdholloway dbrant: i'm not sure why but FullSearchTaskTests.testEmptyResults() is failing consistently and i can't merge the version bump. the cause is a timeout but the response comes back promptly when i test in browser. i'm looking into it [17:10:08] dbrant: you able to do the Scrum of Scrums repping for Reading today? it's in 20 minutes. i can forward the invitation if so. [17:10:34] dr0ptp4kt: ah yes, sure [17:11:47] dbrant: thx [17:12:29] dbrant: done. see it in your calendar? [17:12:34] dr0ptp4kt: yep! [17:13:00] dbrant: thx [17:18:28] gotta go get the kids to bed [17:18:30] bbiab [17:20:21] jdlrobson: traiged gather tasks. That leaves only 57 Reading Web team tasks left to triage! [17:20:36] kristenlans: thanks! you're a superstar! [17:21:19] jdlrobson: Soaking's mind will be blown when he gets back [17:21:26] haha JoaKing! [17:31:31] dbrant mdholloway: would one of you mind checking out this patch (small)? https://gerrit.wikimedia.org/r/#/c/238795/ [17:34:45] niedzielski: looking now [17:34:58] mdholloway: thanks! [17:36:59] niedzielski: looks fine, I'll +2, but any idea what's causing the failures? [17:37:55] mdholloway: no, both sites are coming back with an empty result which the test expects. i was wondering if that certificates issue had anything to do with it [17:38:34] niedzielski: that sounds plausible to me. [17:52:54] bmansurov: around stll? [18:02:44] mdholloway dbrant: please review the proposed release notes when you can [18:04:45] mdholloway dbrant: on a different note, i've been thinking about wiktionary more and i'm very excited at the prospect of including it for word look ups in app. beyond a great app improvement, i think it will be the first time many users use the site! [18:06:59] I want to contribute to wikimedia and for that Outreachy intership program looks perfect fit for me. [18:07:00] jdlrobson, yes [18:07:35] I am looking for project idea related to (https://phabricator.wikimedia.org/T98986)task, I will be thankful if someone can suggest any idea to me to contribute for wikimedia. [18:07:39] bmansurov: hey so i took a look and the printonly class is a wiki construct [18:07:56] i've commented on bug and patch i just wanted to check you were okay with that [18:08:23] looking [18:08:25] adisha: that task isn't really suitable for a outreachy internship program- it's pretty advanced and it's not 100% clear how we do that yet [18:08:35] yurik: hey! regarding the maps tiles... how does one obtain tiles with street names on them? [18:08:38] ok [18:08:51] dbrant, use osm-intl source [18:08:53] ideally you'll be looking for something which is tangible and easily achievable in the duration of the program [18:09:13] dbrant, /osm/ no labels, /osm-intl/ with [18:09:41] yurik: aha, brilliant. thanks! [18:09:55] jdlrobson, i'm not sure how to display it. inline? inline-block? block? I just want to leave it to the cite tag. [18:10:30] bmansurov: i'm saying you don't need to do anything. The bug is fixed as editors made the class up :) [18:10:54] jdlrobson: ok..Can we choose few sub tasks from goal so that we can come closure to what the task aim at, i.e. , make mobile web more performent [18:11:01] jdlrobson, that's weird because the same rule exists in core [18:11:14] bmansurov: where? I see noprint but not printonly [18:11:23] lemme find it [18:12:12] adisha: i suspect you'll have better luck once you find someone who is able to mentor. Is there a page of mentors anywhere? [18:12:27] no.. [18:12:35] Can you help me in finding a mentor [18:13:04] jdlrobson: As I know you are not available.. [18:13:13] jdlrobson, my bad. It's in the citation template: https://en.wikipedia.org/wiki/Template:Citation/core#Supporting_CSS [18:13:39] i know very little about this program... could you point me at the page for this program that is giving you instructions? [18:14:23] adisha, you're interested in outreachy right? [18:14:28] yes... [18:14:46] adisha, I was hoping to be a mentor ;) [18:14:55] niedzielski: yeah, it'll be cool to start incorporating content from another wiki* project, for sure! [18:15:02] ok I will be great to have amentor [18:15:14] bmansurov: [18:15:18] you can help me [18:15:28] adisha, cool. what timezone are you in? [18:15:38] niedzielski: looking at the release notes momentarily [18:16:04] adisha, because my schedule is weird these days [18:16:33] No issues.. [18:16:44] my timezone is UTC +5:30 [18:16:58] bmansurov: what is your timezone?? [18:17:04] adisha, oh cool, mine is +5 these days [18:17:14] that's cool [18:17:18] so it's late here now, but i'd love to chat tomorrow [18:17:24] ok.. [18:17:39] niedzielski: in the meantime, if you get a chance, could you please have a look at this content service patch (a one-liner): https://gerrit.wikimedia.org/r/#/c/238801/ it'd be great to get it deployed during the window this afternoon. (cc dbrant) [18:17:42] hopefully we'll find something interesting for you tomorrow [18:17:51] mdholloway: sure thing! [18:17:56] ok that's great.. [18:18:00] bmansurov: [18:18:10] jdlrobson, so no action is needed for the citation patch? [18:18:14] can you suggest me time according to your timezone [18:18:22] bmansurov: i don't think so. It's fixed on svwiki anyhow [18:18:53] jdlrobson, don't we care about other wikis? [18:19:27] adisha, usually i'm online at these times: 5am-8am, 3pm-6pm, 9pm-11pm [18:19:52] bmansurov: well given these wikis are using their own css/js we can't scale and fix all their issues. They have to fix their own stuff :) [18:20:18] jdlrobson, i see [18:20:22] i'm not sure which wikis use it [18:20:35] but at least now there is one wiki that knows about it so it should filter out into other projects [18:20:42] bmansurov: ok I will contact you during this duration..thanks a lot..will catch you later.. [18:20:52] adisha, cool, later [18:22:04] jdlrobson, i don't see it fixed on svwiki: https://sv.m.wikipedia.org/wiki/Anv%C3%A4ndare:Quiddity_%28WMF%29/sandl%C3%A5da [18:22:17] jdlrobson, nm, it was loading [18:22:43] jdlrobson, thanks for looking into the bug. i'll abandon the patch [18:22:49] niedzielski: sweet, thanks! [18:22:55] np [18:27:41] o\ [18:33:56] coreyfloyd: kaity is nizrar on IRC? [18:35:14] bgerstle: yea its nzr [18:35:38] ah [18:35:47] doesn't appear to be in this room... [18:35:50] * bgerstle goes to find him [18:36:15] can't find him... in -dev or -office [18:36:25] kaity: if you could, ask him to join this channel and #wikimedia-ios [18:36:29] you should join -ios too [18:37:03] bgerstle: retro? [18:37:06] ooh i didnt know it existed! [18:37:11] coming [18:55:09] niedzielski: notes look just fine to me! In the email we should just remind that this is slated to be the last GB release. [18:55:20] dbrant: sounds good [19:25:19] niedzielski: i made a couple of edits. looks good! [19:25:59] reminds me of an actually good vanity license plate i saw recently: "EDTIOR" [19:26:02] mdholloway: ah, let me know when you're still making changes. i've already published in the stores and was about to send the release mail [19:26:08] that is a good plate [19:26:11] oh, no big deal [19:26:39] i said i would earlier and then got distracted by my excitement over wiring up the service! [19:27:13] sorry i spaced on it before [19:28:35] mdholloway: np [19:29:20] mdholloway: hm, actually, do you mind if we keep it as it was? we had a second change to _add_ white background colors for the tab headers in dark mode too [19:31:29] niedzielski: ah, i see, i'm fine with keeping it as is [19:31:39] mdholloway: cool, thanks! [19:51:21] niedzielski: dbrant: according to Google Play stats, just shy of half of our beta app users (78,289 out of 161,809) have a device language of en-us or en-uk. so if we enable restbase loading for LPs on 10% of devices, we'd theoretically end up with 5% of our beta users, or just shy of 8,000, getting the feature in the first rollout [19:52:07] niedzielski: dbrant: or i guess we could cut a separate release for english speakers and enable it for 5% if we wanted to go that route [19:53:33] mdholloway: i think we want to avoid multiple apks where possible. i'm fine with 10% + Play staged rollout (if needed) [19:54:10] niedzielski: yeah, i wouldn't particularly want to start getting into multiple apks either. [20:34:35] jdlrobson, did you see https://phabricator.wikimedia.org/T112814 ? [20:35:14] hey Krenair [20:35:22] i do now [20:37:45] it's broken on all sites but wikipedia [20:38:10] Krenair: mind if i tweak it so we don't resurface the other bug? [20:38:15] sure [20:39:34] actually i'm worried we'll also bring back another bug. I'll merge that as is. [22:02:42] FlorianSW jdlrobson: yey, we can do the search thing completely without any js hook [22:03:27] benestar: great! :) [22:03:59] FlorianSW: hat doch was gebracht, dass ich die Woche in Berlin verbringe ^^ [22:05:52] benestar: hier wird Englisch geschrieben :P Persönliche Gespräche sind von Zeit zu Zeit doch sehr sinnvoll :) Nun aber gute Nacht! [22:07:00] dr0ptp4kt: jdlrobson looks like twitter already does "link previews" if you hover over the author of a tweet [22:07:04] kinda nice actually [22:08:02] FlorianSW: good night :) [22:41:26] @jdlrobson: That description of the origin parameter makes my head hurt (https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#Parameters_to_the_.7B.7BPAGEBANNER.7D.7D_function) [22:42:01] kaldari: heh edit it :) kaldari ideally i want to make this a service with its own editor [22:42:08] not quite there yet though :-/ [22:42:15] help getting it into wikidata would be great [22:42:16] that would be awesome [22:42:29] once it's in wikidata would be super easy to setup a gadget [22:42:41] bgerstle mhurd coreyfloyd /cc dbrant|bbl mdholloway: hey! do you ios folk have any tests that run against the test wiki? we had a couple failures today only on that wiki that we haven't been able to pin down yet [22:42:51] Personally, I think it should be in wikibase, but not wikidata [22:43:06] niedzielski: nope, we don't have any tests AFAIK that hit the network [22:43:10] or commons.. [22:43:11] we use fixtures [22:43:42] bgerstle: we have only just started using mock responses for some of our tests [22:45:16] dr0ptp4kt: who is "mr test wiki" around here? we had a couple test failures today that only occur on test.m.wikipedia.org. i don't have the details yet [22:53:24] @jdlrobson Tried to rewrite it: https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#Parameters_to_the_.7B.7BPAGEBANNER.7D.7D_function [22:53:55] kaldari: i've got a few patches i need review for relating to it if you are interested [22:54:01] trying to get feature parity between mobile web [22:54:07] and the wikivoyage page banners [22:54:27] https://gerrit.wikimedia.org/r/238655 and https://gerrit.wikimedia.org/r/238654 [22:56:01] mbinder: is there a strategy meeting at 7:05? [22:56:03] EDT [22:57:21] bgerstle_afk: yes, but I think east coasters could skip that and get caught up later, if they were OK with others representing them. Kristen will be there, though. [22:57:33] coreyfloyd: are you going? ^ [22:58:36] bgerstle_afk: coreyfloyd Now that Josh is on board, Adam is going to chat with you guys about delegating strategy meeting time [22:58:48] jdlrobson: so https://gerrit.wikimedia.org/r/#/c/238654/ would move the wikivoyage banner outside of #bodyContent? [22:58:54] exactamondo! [22:59:25] jdlrobson: have you tested it with CentalNotice? [22:59:42] bgerstle_afk: i assumed so [22:59:49] but have no problem if josh goes [22:59:53] instead of us [22:59:59] whatevers [23:00:06] would be good to see how that interacts with siteNotices, i.e. if they show up before or after the wikivoyage banner [23:00:17] kaldari: in Vector prebodyhtml is after the h1 [23:00:27] so should be super safe [23:00:35] yeah, i didn't realize it was at this time [23:01:06] bgerstle_afk: coreyfloyd don't kill yourselves, lots of meetings lately, your call [23:01:23] and tomorrow [23:01:26] apparently i'm double booked [23:02:05] niedzielski: mmm, depends. jdlrobson, would you or tgr (on a different channel?) be able to help out niedzielski with testwiki questions? [23:02:48] thanks, i'll bother them [23:03:06] jdlrobson: prebodyhtml? [23:03:15] mbinder: coreyfloyd JoshM i'm more interested in Problem 1 to be sure [23:03:16] kaldari: yup scan VectorTemplate you'll see [23:03:39] niedzielski: can you summarise [23:03:50] jdlrobson: yep, just a moment [23:07:46] jdlrobson: followed up in dev where tgr is [23:09:19] dr0ptp4kt: are you guys in a room? [23:24:06] jdlrobson: reviewed https://gerrit.wikimedia.org/r/#/c/238654/ [23:24:26] seems like a decent idea though [23:58:54] o/