[00:06:00] <bmansurov>	 jdlrobson, can you share a screenshot of your local http://127.0.0.1:8080/wiki/Quick_survey_test_page_with_infobox_with_image?quicksurvey=true desktop site?
[00:06:23] <jdlrobson>	 bmansurov: it's in the review no?
[00:06:26] <jdlrobson>	 oh desktop
[00:06:27] <jdlrobson>	 sure thang
[00:06:46] <bmansurov>	 the one in review looks different to mine.
[00:06:48] <jdlrobson>	 bmansurov: desktop looks great though
[00:06:58] <bmansurov>	 jdlrobson, what is the problem on mobile then?
[00:07:28] <jdlrobson>	 bmansurov: did you check out the follow up patch to yours and run browser tests?
[00:08:00] <jdlrobson>	 and copy styles from enwiki MediaWiki:Common.css to your localhost?
[00:08:00] <bmansurov>	 jdlrobson, no I haven't, link?
[00:08:10] <bmansurov>	 link to follow up
[00:08:10] <jdlrobson>	 ok check out https://gerrit.wikimedia.org/r/#/c/238833/
[00:08:28] <jdlrobson>	 and then run browser tests, as soon as browser opens you can terminate the test and you'll have the new pages
[00:08:55] <bmansurov>	 thanks
[00:09:49] <jdlrobson>	 bmansurov: you can merge that patch too if it works
[00:09:53] <jdlrobson>	 so we are all on the same page
[00:10:01] <bmansurov>	 ok
[00:10:11] <jdlrobson>	 Remember to copy https://en.m.wikipedia.org/wiki/MediaWiki:Mobile.css too
[00:10:39] <bmansurov>	 k
[00:15:07] <bmansurov>	 jdlrobson, so the problem on mobile is that the survey is floated to the left, right?
[00:15:17] <bmansurov>	 but it should be to right?
[01:02:57] <jdlrobson>	 bmansurov: corret
[01:03:02] <jdlrobson>	 sorry for the delayed reply
[01:03:21] <jdlrobson>	 on TABLET to be clear
[01:03:24] <jdlrobson>	 mobile is full width still
[01:03:30] <jdlrobson>	 doesn't need to do any floating - should be full screen
[01:03:30] <bmansurov>	 so the panel should alwasy be right aligned on Tablet?
[01:03:40] <jdlrobson>	 yes. See the screenshots I posted in review
[01:03:47] <jdlrobson>	 they demonstrate how it should look on tablet and mobile
[01:03:50] <jdlrobson>	 i've checked them with kaity
[01:04:14] <bmansurov>	 ok, just to double check, the requirement doesn't hold anymore?
[01:14:38] <jdlrobson>	 bmansurov: i've already doublechecked with Kaity. Yup. Sorry.
[09:52:40] <bmansurov>	 o/
[11:02:42] <phuedx|afk>	 lunch!
[13:52:03] * aude is updating android studio and all the things
[14:03:41] <phuedx>	 aude: go make a couple cups of coffee? ;)
[14:05:28] <aude>	 it's all working now :)
[14:05:58] <aude>	 gave some feedback and shall wait and see how to proceed with the patch
[14:06:12] <dbrant>	 aude: what is this 'sleep mode' you speak of?
[14:06:26] <aude>	 somehow, i'd like an initial (even if not perfect) version merged and then have subtasks and small patches to follow
[14:06:56] <aude>	 dbrant: it was starting to go into sleep (e.g. reduce brightness)
[14:07:05] <aude>	 then i clicked to stop it
[14:07:44] <aude>	 so, when i open nearby, it's super zoomed out
[14:08:01] <aude>	 then i click on the map and it zooms in very far to my office location (current)
[14:09:03] <aude>	 maybe i clicked on the location button
[14:09:32] <dbrant>	 aude: gotcha. So, the plan right now is to stabilize the patch in its current state, and merge it; and then we can work on additional subtasks.
[14:09:42] <aude>	 now the location button thinks i am in a previosu location
[14:09:49] <aude>	 (i have seen this issue with mapbox sdk)
[14:10:04] <aude>	 dbrant: sounds good
[14:10:24] <aude>	 now the location button works like it should ... ok zoom level and correct locatin :)
[14:11:11] <dbrant>	 aude: one thing I did was to offload the handling of the user's position to the mapbox sdk. That's why it's fully zoomed out while it's detecting your location, and then zooms in once it gets a lock.
[14:11:23] <aude>	 ok
[14:11:50] <aude>	 ideally it would calculate a bounding box from the nearby points
[14:12:01] <aude>	 which somewhat seems to do now
[14:12:15] <dbrant>	 right; we'll have to see if we can override the zoom level when the location is detected...
[14:13:13] <aude>	 i think there is a bug in geodata for this, but would be nice if the locations were sorted by distance
[14:13:40] <aude>	 or they appear to be already, but seems buggy
[14:14:20] <dbrant>	 they should be sorted in the list, i think
[14:14:44] <aude>	 they are, but seems my location is off sometimes
[14:15:16] <aude>	 even though the point on the map is correct
[14:16:21] <aude>	 anyway, if i have time during the weekend, i might poke at the code and try to figure out how we might solve some of the issues
[14:16:29] <aude>	 but not amend the patch directly
[14:16:43] <dbrant>	 aude: excellent!
[14:16:56] * aude excited to have android studio updated :)
[14:17:34] <aude>	 and thanks for helping with the patch to move it forward
[14:20:28] <dbrant>	 no problem! it's a very important bit of new functionality
[14:20:43] <aude>	 :)
[15:12:25] <niedzielski>	 bgerstle: i happen to be in otrs and noticed some ios beta sign up requests there. fyi
[15:12:39] <bgerstle>	 niedzielski: thanks, yeah there are a bunch
[15:12:45] <bgerstle>	 we're waiting to invite them in batches once the app is ready
[15:12:51] <bgerstle>	 i'm trying to keep track of them
[15:12:56] <niedzielski>	 bgerstle: ok cool
[15:13:06] <bgerstle>	 also, you're a brave man for venturing into OTRS
[15:13:16] <bgerstle>	 taking tech lead seriously, i see ;-)
[15:13:35] <bgerstle>	 actually... speaking of which, i'm futzing around w/ TWN. do you have any experience w/ it yet?
[15:17:34] <niedzielski>	 bgerstle: i've been doing twn sync for a little bit. i still find the process confusing but i can normally manage
[15:51:50] <bgerstle>	 brion: were you at all involved with setting up TWN for the iOS app?
[15:58:12] <bmansurov>	 o/
[16:13:46] <niedzielski>	 dbrant aude: i left some comments on the map patch the other day. i'm happy to help how i can, whether that's working to address them myself or just reviewing. let me know how i can be of service
[16:14:16] <niedzielski>	 aude: i couldn't seem to find the crash report you made. if you find the stack trace somewhere, it'd be great to look at
[16:21:09] <etonkovidova>	 niedzielski: helo there! When you have a min, can you take a look at my comment at T97504 "Dragging across header text doesn't scroll"
[16:21:29] <niedzielski>	 etonkovidova: yes, will follow up momentarily
[16:21:55] <etonkovidova>	 niedzielski: I'd like to make sure that we are OK with long press action on titles... 
[16:27:23] <niedzielski>	 mdholloway|lunch: for the update js files patch, none of these files are actually in use on the service, right?
[16:30:04] <mdholloway|lunch>	 nope, not at present
[16:30:17] <mdholloway|lunch>	 ^ niedzielski 
[16:30:30] <niedzielski>	 thanks :)
[17:01:16] <dbrant>	 niedzielski: i'll make the changes in the maps patch. I think it's best to get it merged, and then let aude make more granular subsequent patches.
[17:01:31] <niedzielski>	 dbrant: sounds good
[17:17:09] <bgerstle>	 mbinder!!!!!!!
[17:17:11] <bgerstle>	 STAND UP
[17:25:43] <aude>	 niedzielski: https://phabricator.wikimedia.org/P2067
[17:26:30] <niedzielski>	 aude /cc dbrant: thanks!
[17:26:52] <aude>	 sure
[17:32:41] <mdholloway>	 dbrant: niedzielski: i've been meaning to ask for your thoughts on https://gerrit.wikimedia.org/r/#/c/238747/ -- any ideas off the top of your head why iterating over the component views of the link preview and setting the width would fix the problem going landscape->portrait but cause truncation going in the other direction?  that patch is what i'll be
[17:32:41] <mdholloway>	 working on this afternoon
[17:34:12] <mdholloway>	 niedzielski: i'll probably dig up that link you sent me a while back on the view hierarchy
[17:35:16] <niedzielski>	 mdholloway: does View.onConfigurationChanged() not iterate all its children?
[17:35:54] <mdholloway>	 niedzielski: i'd have to look
[17:36:08] <niedzielski>	 mdholloway: and i would guess you'd want to operate on rootView not dialogViews
[17:36:10] <bgerstle>	 dr0ptp4kt: hey, i have a question when you have a second. need to get the ball rolling on adding Apple's Universal Links association files to MediaWiki, but bd808 is on vacation
[17:37:01] <mdholloway>	 niedzielski: it's the rootviews i'm iterating over (which makes me think the answer to your first question is yes, though that would be surprising)
[17:37:16] <bgerstle>	 niedzielski: dbrant mdholloway RE: test fixtures, quick google search turned this up: http://www.mock-server.com/
[17:37:59] <niedzielski>	 mdholloway: hm i think would just try calling onConfigurationChanged on whatever view you want to update and see if the framework will update the configuration of all the children
[17:38:18] <niedzielski>	 bgerstle: we use mockwebserver
[17:38:20] <mdholloway>	 niedzielski: cool, i'll give it a try
[17:38:22] <bgerstle>	 oh nice
[17:38:59] <bgerstle>	 we've got something roughly similar on iOS, but are only just starting to write those kinds of tests. glad you guys are ahead of the game :-)
[17:39:09] <niedzielski>	 bgerstle: it can be used for android instrumentation tests (on device junit tests) and standard jvm junit tests
[17:39:19] <niedzielski>	 bgerstle: we have of lot of work to do in test land :)
[17:40:12] <bgerstle>	 ditto
[17:40:32] <bgerstle>	 don't let our current code coverage badge fool you, our coverage is closer to 16%
[17:40:53] <bgerstle>	 (codecov is broken for new Xcode, but they already developed a fix to support it w/ some help from us :-) )
[18:00:19] <niedzielski>	 mdholloway: very cool to see extracts working :)
[18:00:44] <mdholloway>	 niedzielski: yeah, i'm stoked!
[18:08:48] <multichill>	 hi dynosaur
[18:08:59] <dynosaur>	 multichill: hi! 
[18:10:56] <dynosaur>	 working on mobile development multichill? ;)
[18:15:48] <multichill>	 That's been a while dynosaur. How are you doing?
[18:17:22] <dynosaur>	 hah. Sick with a bad cold :( otherwise good! you?
[18:19:22] <jdlrobson>	 kristenlans: how dod i setup custom queries on https://phabricator.wikimedia.org/dashboard/manage/125/ ?
[18:22:37] <kristenlans>	 jdlrobson: I think sections 5 and 6 can help you: https://www.mediawiki.org/wiki/Team_Practices_Group/Phabricator_tips#Using_Maniphest_.28Advanced_Search.29
[18:25:03] <multichill>	 That sucks dynosaur! Just catching up. Lot's of messages/emails today ;-)
[18:25:30] <dynosaur>	 haha... you better get on that multichill!
[18:35:31] <jdlrobson>	 kristenlans: i don't think i have permissions.
[19:03:52] <dr0ptp4kt>	 bgerstle: i see your email on the topic. will reply to you there.
[19:04:20] <bgerstle>	 k, thanks
[20:14:05] <kristenlans>	 jdlrobson: hmm that's curious. Do you get some kind of access denied message?
[20:17:20] <niedzielski>	 mdholloway: saw your comment on the google now card. it's funny, i was literally checking this morning to see if now had a public api
[20:19:12] <mdholloway>	 niedzielski: yeah, they did that press release kind of a while ago now, i wonder what's going on with it?  it would be really great to take advantage of that kind of platform integration
[20:19:57] <niedzielski>	 mdholloway: it would be neat if Now was the status bar drawer and all notifications were Nowtifications
[20:24:46] <dbrant|brb>	 niedzielski: mdholloway: we've asked our contacts about that, too. They're still keeping it limited to a select group of partners.
[20:25:30] <mdholloway>	 dbrant: :/
[20:25:37] <niedzielski>	 dbrant mdholloway: kind of crazy to me that shazam can get access but wikipedia can't
[20:25:57] <niedzielski>	 dbrant mdholloway: shazam's a competitor!
[20:27:27] <mdholloway>	 niedzielski: sound pattern identification is crazy awesome, to be fair, but still.
[20:37:32] <niedzielski>	 dbrant: map patch looks good to me. i figure once this gets merged we're saying goodbye to gingerbiscuit... when did we want to do that?
[20:38:27] <dbrant>	 niedzielski: haven't we already?
[20:38:56] <niedzielski>	 dbrant: well, we have't bumped the minSdkVersion
[20:40:37] <dbrant>	 niedzielski: is TSG done with testing? If so, we're plowing forward
[20:48:09] <niedzielski>	 dbrant: they did. let me clarify a couple things with them
[23:23:29] <FlorianSW>	 jdlrobson: ping
[23:23:47] <jdlrobson>	 hey FlorianSW 
[23:24:00] <FlorianSW>	 hi :) How are you?
[23:24:47] <FlorianSW>	 jdlrobson: is there a list of allowed parameter for WPB? (https://gerrit.wikimedia.org/r/#/c/239325/) Or is origin the only missing one?
[23:25:21] <jdlrobson>	 FlorianSW: https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#Parameters_to_the_.7B.7BPAGEBANNER.7D.7D_function
[23:25:30] <jdlrobson>	 i think the issue was in the code though since you added origin as a valid parameter
[23:25:43] <FlorianSW>	 *facepalm* the extension page :P
[23:26:23] <FlorianSW>	 jdlrobson: origin isn't in the list, I'll add it and write a unit test for the function :)
[23:29:03] <jdlrobson>	 FlorianSW: L20 no? https://gerrit.wikimedia.org/r/#/c/239325/2/includes/WikidataPageBanner.hooks.php
[23:29:41] <FlorianSW>	 lol, I read the list TWICE and haven't seen origin! I swear! :)
[23:29:45] <FlorianSW>	 Let me investigate what happens
[23:48:15] <jdlrobson>	 FlorianSW: able to merge https://gerrit.wikimedia.org/r/#/c/234592/ ? 
[23:50:33] <FlorianSW>	 jdlrobson: the task says, that the new modue was introduced in wmf21? I haven't checked, but if this is true, that would be only 3 weeks for wmf24? Is this correct?
[23:50:42] <jdlrobson>	 correct
[23:50:44] <jdlrobson>	 and that's fine
[23:50:48] <jdlrobson>	 the desktop equivalent has been merged
[23:51:09] <jdlrobson>	 it's now more important that we don't load gallery css unnecessarily on all existing articles :)
[23:56:53] <FlorianSW>	 jdlrobson: ok, let me test locally and I give my +2 :)