[09:59:47] o/ [10:58:49] hey bmansurov [10:58:56] * phuedx is provisioning a new vm again :( [11:03:56] sorry [11:04:43] bmansurov: it's all your fault [11:04:46] so you should be ;) [11:05:05] hah, i am [11:14:48] okie poke -- i'm travelling back home [11:16:49] hi [11:17:30] https://phabricator.wikimedia.org/T113289 [11:17:40] i have some questions related to this bug [11:18:03] must i have something like an android device to fix this bug and test? [11:18:32] because i wanted to fix the bug and use my web browser to test [11:18:45] is there a way i can use something like m.wikimedia.org? something like that? [11:18:48] will it work? [11:18:51] any help please. [11:23:27] d3r1ck, you don't need an android device, a web browser will do it [11:24:14] d3r1ck, have you installed mediawiki (with the mobilefrontend extension) locally? [11:24:27] d3r1ck, can you browse to it using your web browser? [11:24:45] well bmansurov first of all, it might interest you that this is my fourth bug i am fixing [11:24:59] all is well, i just have to clone the extension and then start fixing the bug. [11:25:02] :) [11:25:09] d3r1ck, cool [11:25:15] bmansurov: so the web browder will do right? [11:25:32] d3r1ck, yes, but you don't even need it. [11:25:47] need what? [11:25:50] d3r1ck, your changes won't reflect in the browser, it's just a hygiene patch [11:25:58] need a web browser [11:26:23] ok [11:26:34] i understand, i will need a console to test it right? [11:27:05] d3r1ck, not event, because nothing shows up in console after or before your change [11:27:11] event -> even [11:27:24] hmmm, ok [11:27:36] bmansurov: can you link me up to the gerrit repo? [11:27:42] i need to clone the extension please [11:28:04] d3r1ck, let me ask this first. did you install your MW using vagrant? [11:28:23] if yes, you can just enable the mobilefrontend role [11:28:54] if not, https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MobileFrontend [11:29:21] bmansurov: well truely, the VM is really to long to do even though it is simeple [11:29:25] or simpler [11:29:45] bmansurov: but i will do it later. I will just clone the extension and makke the changes. :) [11:29:52] go for it [11:35:50] bmansurov: ok i am going for it :) [11:47:43] bmansurov: need to rest a bit. I am cloning the extension now and when it is done, i will fix the bug. :) [11:48:18] cool, as long as the task is assigned to you no one will dare to work on it ;)) [11:48:46] bmansurov: hahahaha..... [11:48:57] bmansurov: well, you are a developer too? [11:49:05] bmansurov: student or mentor? [11:49:34] neither, but i may mentor a student for the upcoming outreachy [11:49:52] bmansurov: nice. What about GSoC next year? [11:49:54] 2016? [11:50:03] will you like to mentor? [11:50:07] it's long way till then, but why not [11:50:24] bmansurov: i can see you are an admin? [11:50:30] in the organisation :) [11:50:37] no just a developer [11:50:43] well what are your areas of intereset if you will like to mentor? [11:51:00] mostly front end [11:51:02] *interest [11:51:12] ahhhh,, Mobile? [11:51:17] or just FE in general [11:51:17] yep [11:51:22] both [11:51:41] ok i see. I am planning to do GSoC next year. So am learning the code base and fixing bugs too [11:51:53] cool [11:51:56] and as a plan, i will make my GSoC project as my FYP [11:52:08] what's FYP? [11:52:09] FYP: Final Year Project [11:52:21] i am a senior [11:52:31] oh ok, ping me when you need a mentor. I may be able to help. [11:52:35] University of Buea. From Cameroon. [11:52:48] bmansurov: ahhh, you will like to mentor me? [11:53:02] :) [11:53:18] if our interests match, sure [11:53:24] bmansurov: will you like to see the bugs i fixed? [11:53:26] hello to Cameroon [11:53:31] sure [11:53:33] hahahahaha..... [11:53:39] ok let me send the links [11:54:03] can you access my gerrit account? [11:54:06] https://github.com/wikimedia/mediawiki-extensions-Echo/commit/ba4789760c0ae4a79d7af156ec6f6a8e44961f6b [11:54:44] i'm not familiar with echo code but it looks good [11:55:00] bmansurov: nice [11:55:02] another one [11:55:06] https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi/commit/ddaeff4e5249d9c1edd98ad4de192a50289b70ff [11:55:34] bmansurov: another one [11:55:37] https://gerrit.wikimedia.org/r/#/c/240071/ [11:56:06] you're all over the place. good job [11:56:16] yeah, Echo Code is bulky man, you can see how many patch sets i sent before my patch could be accepted. [11:56:42] bmansurov: check this out https://gerrit.wikimedia.org/r/#/c/239301/ [11:56:51] i submitted 26 patch sets :) [11:57:10] i think that's normal when you're learning [11:57:19] yeah thats true [11:57:43] bmansurov: well like i said earlier, i am really passonate about GSoC and MediaWiki. [11:58:01] i want to put in full time interest in it before next year. [11:58:24] bmansurov: If i continue like this, are my guaranteed to do GSoC 2016 in this organisation? [11:58:59] d3r1ck, i'm not sure about that part, qgil or niharika maybe able to answer that question [11:59:32] bmansurov: i will ask them. But what is your thinking about that? [11:59:43] just tell me what you think [12:00:20] hard to say because I don't know their acceptance criteria [12:00:39] d3r1ck, i also haven't mentored anyone before ;) [12:00:55] haha.. [12:01:06] ok let me ask qgil [12:02:05] yo [12:02:46] phuedx: yo :) [12:04:48] o/ d3r1ck [12:04:54] * phuedx reads the scrollback [12:06:52] phuedx: cool, when done with your reading of scroll back, ping me. :) [12:09:42] d3r1ck: syn [12:10:51] phuedx: nice. Anything new from what you read? [12:11:42] nothing new to add [12:12:00] phuedx: nice [12:12:01] i'd be interested in anything you find out about re acceptance criteria for gsoc [12:12:01] :) [12:12:22] phuedx: ahahaha....., ok [12:12:40] phuedx: having a chat with qgil now [12:12:43] on that [12:16:31] * phuedx follows the conversation in -dev [12:17:28] phuedx: ask something, you are free? are you a mentor or student? [12:18:02] neither -- i'm haven't mentored before but i'm a dev at wmf [12:18:22] what is wmf? [12:19:12] wikimedia foundation [12:23:28] ok [12:58:00] i made the mistake of running vagrant git-update [12:58:09] * phuedx sighs [12:58:59] it fixed some problems when I ran it last time ;) [13:41:51] mdholloway: the image widening only seems to be broken on one of my devices (api 18). It's also the only device I have that is xxhdpi... I wonder if the widening logic is dependent on screen density? [13:42:38] dbrant: that sounds very plausible -- the algorithm does take screen density into account. [13:43:13] dbrant: i haven't started looking yet (just finishing up some google play account transfer stuff so it's out of the way) [13:43:38] ok cool [13:48:13] dbrant: but it worked previously on that device, right? there hasn't been a substantive change to the code that i'm aware of (but off to check now). [13:51:41] mdholloway: i don't actually recall whether it worked on this device :( but yes, it probably isn't due to any recent changes. [13:56:41] mdholloway: i see what's happening -- the widening code is working, but it's making it use the CSS style intended for tablets (60% width) [13:57:47] aha. [13:58:15] it might just need a couple more specific @media selectors [13:59:39] dbrant: what's the device? [14:00:02] dbrant: nm, i see it in the updated ticket [14:00:03] Galaxy S4 [15:41:52] ugh [15:42:22] https://phabricator.wikimedia.org/T113355 fixed it [15:42:32] but rebuilding took a while [15:42:43] s/it/my mediawiki-vagrant issues [16:03:13] dr0ptp4kt: are you in office? [16:04:13] josh are you in meeting hangout? [16:04:37] dr0ptp4kt: ah it's a speedy meeting! I thought everyone was dissing me! [17:03:08] cant connect to hangout :( [17:03:22] bmansurov: you standing? [17:03:34] trying to connect [17:06:29] kristen|away: internet is wonky, got booted from the standup. [17:11:05] rmoen: can you send standup over email? [17:13:54] kristenlans: definitely [17:18:34] mdholloway: want to make the switch now ? [17:20:20] tfinc: in standup, ping you in ~5-10 mins? [17:20:37] mdholloway: sure [17:20:41] tfinc: cool thx [17:29:00] niedzielski: sorry for late question, but any chance you could cover for reading engineering at scrum of scrums? [17:29:14] dr0ptp4kt:sure [17:29:19] niedzielski: thanks much! [17:29:59] np [17:32:03] tfinc: let's do it [17:34:03] mdholloway: can let me load it up [17:35:14] mdholloway: just to double check, you just want me to check 'Developer Name' from 'Wikimedia Foundation' => 'Wikimedia' [17:35:24] tfinc: i should be signed out [17:35:33] tfinc: that's correct [17:36:17] mhurd: confirm log out and i'll change it [17:36:49] mdholloway: ^ [17:36:49] niedzielski: dbrant|mtg bearND dr0ptp4kt if you're in the google play dev account, could you log out? [17:37:40] mdholloway:i am out [17:38:12] mhurd: can't "There is already another Google Play developer with this name" [17:38:17] err mdholloway --^ [17:38:31] tfinc: ;) [17:39:44] tfinc: that's... odd. we have "WMF Android" as a placeholder in ours. [17:40:26] mdholloway: in a 1:1 now, i'll have to pick this up after [17:41:00] tfinc: ok, i'll see what i can dig up on acct naming rules in the meantime [17:41:27] tfinc: someone is using the dev name "Wikimedia CH", it seems... [17:41:55] i don't think i've ever used this account [17:46:12] etonkovidova: ok meeting time is over. what was your question about emulators? [17:47:15] niedzielski: when I saw two issues in QA sign off about pre-Lollipop devices [17:47:31] niedzielski: I thought that I need to do it on emulator [17:47:56] niedzielski: then I remembered that I do have 4.1(?) device - need to double check [17:48:02] niedzielski: should be fine :) [17:48:05] etonkovidova: yeah, pre-lollipop devices are pretty common [17:48:19] etonkovidova: but you can create an emulator for most api levels these days [17:49:12] niedzielski: yeah.. the problem with the emulator is - it's try-and -error when it comes to creating certain combination [17:49:26] niedzielski: at least it seems like that to me ... [17:50:16] etonkovidova: hm, do they just not launch? [17:50:45] etonkovidova: if you stick with x86, those tend to work pretty well. BTW, we're API 15 and above only now [17:51:32] niedzielski: yeah,, it says - not supported or smthing... But it might be just to my little knowledge of proper combination of OS and etc [17:51:59] niedzielski: anyway, next time I run into a problem like that - I let you know [17:53:39] etonkovidova: sounds good [17:59:48] tfinc: when you get the chance to try again, can you try 'Wikimedia Android Team' as the developer name? i'm wondering if 'Wikimedia CH' is blocking just 'Wikimedia' [18:00:13] mdholloway: done, it's now set to 'Wikimedia Android Team' [18:00:38] mdholloway: which list can i sign up for to make sure i can still access this after ? [18:01:32] * tfinc should have bartered with that before handing the keys :D [18:02:11] tfinc: great! the new account is now named 'Wikimedia Foundation' -- I'll send the request to google to start the transfer [18:02:47] tfinc: you will always have ownership of the account you created -- I can grant you access to the new one [18:04:09] niedzielski: I don't see any reason not to release to production. [18:04:22] dbrant:+1 [18:06:33] mdholloway: thanks [18:06:54] tfinc: thank you! i'll keep you up to date on the status [18:33:52] concerning this bug [18:33:53] https://phabricator.wikimedia.org/T113289 [18:34:06] are my suppose to do the same thing like the example in the bug? [18:36:31] hey d3r1ck :) [18:36:37] jdlrobson: hey [18:36:45] did you see my question? [18:36:54] So M.define( 'foo' ).deprecate( 'moduleName' ) says register a module called 'foo' but allow people to reference it using 'moduleName' [18:37:16] hmmm, i see [18:37:19] After completing the bug the only way to get the module would be via 'foo' [18:37:25] so in this case M.define( 'foo' ); [18:37:45] wait [18:37:48] the only care to take is when you submit the patch it may get automatically -1ed by Jenkins because some people are using the old name [18:37:53] in which case we'll need to update those references [18:38:04] so M.require( 'moduleName' ) becomes M.require( 'foo' ) [18:38:09] something is not clear [18:39:06] d3r1ck: ask away :) [18:39:41] we are registering a module called 'foo' [18:40:16] but at thesame time getting the module using 'foo' but by referencing it differently? [18:43:31] mdholloway: I see the Google Play account has been updated [18:49:50] jdlrobson: still there? [18:51:03] dbrant: yep. about an hour ago i submitted the request to google to move the apps over to the new account. [18:51:23] mdholloway: cool! no hiccups, i take it [18:51:39] dbrant: none so far. [19:00:26] spagewmf: hey [19:03:26] etonkovidova: hey [19:04:57] niedzielski: i've released to 20%, and will bump to 100% by the end of the day. [19:05:02] o/ [19:05:16] dbrant: sounds good :) [19:06:22] jdlrobson: any idea on this? https://phabricator.wikimedia.org/T113457 [19:06:26] i will like to make that fix too [19:06:31] any hint? [19:10:15] d3r1ck: yes it's just a question of referencing the moduel [19:10:30] d3r1ck: see my comment about that task [19:10:40] I've suggested it's just a case of switching to a '> [19:10:51] The span makes sure the heading is inline with the edit and toggling icon [19:10:56] switching what? and in which file? [19:11:11] I'm not sure which file but where that css rule is in the description [19:11:23] .content .in-block span i suspect needs to become .content .in-block > span [19:11:26] but you'll have to test [19:11:32] yes i will [19:11:40] hey, how do i do that? [19:11:42] the test [19:16:40] jdlrobson: i have looked and i can't see that link of code any were. I mean the rule [19:17:12] Lemme see. What search are you using [19:17:16] it looks like it might be in resources/skins.minerva.base.styles/ui.less [19:17:28] i searched for in-block [19:18:48] i used grep [19:18:57] git grep to be precised [19:20:15] jdlrobson: is this the piece of code(rule) [19:20:18] .in-block { [19:20:18] // Safari needs this. @see T106347 [19:20:18] display: table; [19:20:18] .mw-headline { [19:20:19] width: 100%; [19:20:21] } [19:20:23] span { [19:20:26] display: table-cell; [19:20:28] vertical-align: middle; [19:26:06] jdlrobson: that is it [19:26:15] i have searched all over. [19:26:21] i have just one it. [19:32:16] d3r1ck: hello :) [19:35:18] etonkovidova: hi [19:35:25] struggling to fix something out [19:35:29] did you see the logs? [19:35:48] d3r1ck: logstash? [19:35:58] no i mean irc logs? [19:36:00] ok wait [19:36:21] https://phabricator.wikimedia.org/T113457 [19:36:27] fixing that bug [19:36:56] i have made the change and now i want to submit a review but i am asked for my password [19:37:05] i am putting it and err [19:37:09] authentication failed [19:37:53] ohhh, know why [19:38:03] i should be using ssh not https :) [19:38:08] d3r1ck: that's great :) [19:38:19] etonkovidova: what is great? [19:38:50] d3r1ck: that you've figured it out. Does it work? [19:39:40] hang on [19:42:40] yes its workin [19:42:43] *working [19:44:33] etonkovidova: check it out. It worked and i submitted the review [19:45:10] d3r1ck: will do. Thx! [19:46:07] yey awesome d3r1ck i just need to grab lunch but i will look at your patches in about an hour [19:46:09] is that okay? [19:48:15] jdlrobson: hey awesome jdlrobson i am not awesome but you are [19:48:21] :) [19:48:35] jdlrobson: before you go for launch, i have a big problem [19:48:46] jdlrobson: can i ask? it will take like 3mins [19:48:48] of your time [19:49:03] d3r1ck: sure [19:49:23] ok, when i clone a repository from gerrit, it has some permissions attached to it [19:49:37] lets say by default all the files are 755 [19:50:08] now when i change permission to .git folder to access commit-msg which generates the Change Id of each comit, [19:50:39] and then do some modifications, when i want to submit a review, all the changes i have made so far is sent as patches [19:50:50] i want to get rid of this, how can i do that? [19:51:16] they shouldn't matter... [19:51:22] what is the problem you are hitting? [19:51:24] Ok, to make the long question short, how can i submit just a single comit to be reviewd from many commits? [19:51:45] Are you using branches? [19:51:55] e.g. git checkout -b bugFixForT45632 [19:51:56] yes [19:52:12] i am usin a branch d3r1ck01 [19:52:22] So do you want to merge all your commits into one? [19:52:40] hey, i think that sounds like a good idea [19:52:47] because they are separated [19:52:50] So have a look at git rebase [19:53:00] http://git-scm.com/docs/git-rebase [19:53:25] it will allow you do things such as reorder your commits, throw away commits, squash/fixup multiple commits into one [19:53:30] i think that's what you are asking about? [19:53:34] jdlrobson: because when i do git review after multiple changes and commits, it submits all the changes i have commited which i don't want [19:54:00] jdlrobson: yes that is it. [19:55:29] jdlrobson: you uploaded another patch? on that bug? [19:56:47] d3r1ck: i just cherry picked it [19:57:00] jdlrobson: ok [19:57:04] it's your one but now it's based against master rather than your abandoned patch [19:57:14] ohhh, nice [19:57:20] emm, is ok and does the fix? [19:57:25] like you demanded? [19:59:46] d3r1ck: i haven't checked. I still need lucnh :) [19:59:48] i'll look when i get back :) [20:02:00] jdlrobson: ok awesome jdlrobson :) [20:20:31] jdlrobson: ping me when you are back. [20:47:10] d3r1ck: takaing a look now [20:59:24] jdlrobson: ok [21:02:36] jdlrobson: so what is wrong with the patch? [21:03:15] nothing just hoping that jenkins doesn't complain this time [21:03:25] i just had to test it out on various pages [21:04:01] Krenair: hey what's the status of the mobile patch. I saw lots of reverts so i've been wondering what's going on but not following. Can you summarise the status quo? [21:04:20] jdlrobson, it's in production but I'm not comfortable with it [21:04:26] jdlrobson: why mediawiki-extensions-qunit FAILURE in 1m 26s? [21:04:37] I think it's dual-logging some things and at some point I thought it was missing some other things, can't remember why [21:04:39] looking at log seems to be another extension. They happen sometimes [21:04:40] jdlrobson: and it worked? [21:04:43] shouldn't be related to your patch [21:04:52] Krenair: how can i help get it merged? [21:05:02] i could probably commit some significant time tomorrow if you need my help [21:05:17] I don't know if we want to merge it or not anymore [21:05:32] No one else seems bothered by the potential issues [21:05:36] * Krenair shrugs [21:07:37] who's `we` and by potential issues you mean double logging? [21:08:00] people involved with the patch [21:08:14] ye [21:08:15] yes* [21:11:04] hmm. So i'm not sure what to do here. You want me to code review it? you to abandon it and go and talk to James? [21:11:35] mdholloway: "Thanks for contacting Google Play Developer Support. I’m happy to let you know that your app transfer is complete!" [21:12:01] tfinc: awesome, thanks! i see they're up in the new account [21:12:16] mdholloway: did you send me the invite ? [21:12:39] tfinc: not yet, turning to that now [21:14:29] jdlrobson: hey, gerrit bot accepted it. [21:38:51] mdholloway: got the invite but was then told it was invalid when i signed into the console [21:39:23] mdholloway: "Sorry, you do not have a valid invitation at this time. Your invitation may have expired or was already accepted" [21:39:43] tfinc: hmm. i know at least dmitry and i have accepted successfully. one sec... [21:40:59] jdlrobson: so you know i have to work on the other patch [21:41:06] sorry bug [21:41:13] but i need clarifications [21:41:16] on what to do. [21:50:20] hey dbrant im not sure how to search reviews [21:50:24] is it on this page? [21:50:25] https://play.google.com/store/apps/details?id=org.wikipedia&hl=en [21:51:43] kaity: oh no, you need access to the actual developer console back-end. we'll see if we can get you access to it. [21:52:34] oh ok cool [21:52:34] kaity_: I was also going to dump the relevant user feedback onto an etherpad and share it. [21:52:59] dbrant: that would be perfect, thanks! [21:53:09] kaity_: is there anything android-related for the design review mtg? [21:53:19] no need for developer access then [21:53:38] dbrant: hmm i dont have anything ready to review with you [21:53:51] alright then, i'll sit this one out [21:54:22] dbrant: hi [21:54:40] dbrant: how do i see maps in the alpha? [21:55:20] kaity_: it still hasn't been merged yet :( we're this close: >||< [21:55:30] d3r1ck: hello [21:56:12] dbrant: good at Mobile? [21:56:16] it seems jdlrobson is busy [21:56:20] will need your help [21:56:24] kaity_: with you too [21:56:38] d3r1ck: hi sorry what's up [21:56:51] jdlrobson: well i want to work on the other bug [21:57:02] which bug? A link would help [21:57:35] jdlrobson: https://phabricator.wikimedia.org/T113289 [21:57:48] M.define('foo').deprecate('... [21:57:51] something like that [21:57:54] oh you still have questions about it? [21:58:02] I thought we discussed this one earlier? What can I help with. [21:58:37] well i did not clearly understand what to do [21:58:50] are the functions marked as deprecated? [21:59:03] so i can then use the .deprecate() function call [21:59:05] ? [21:59:33] jdlrobson: or what are my suppose to do? [22:00:43] i think i answered this before let me try again. So you can remove the deprecate calls for these modules [22:00:59] but there may be bits of code that reference the old module names [22:01:21] in which case they may make jenkins unhappy and you'll have to fix those too as part of this before your patch can be merged [22:01:22] ohhh, so i am instead removing not calling? [22:01:39] Removing yup. We deprecate functions, allow time for code to get updated then remove them [22:01:49] when removing them we have to ensure all code has been updating to reference the new names :) [22:01:55] hopefully we caught most of them / all of them :) [22:02:05] hmmm [22:02:12] do you know the files are many? [22:02:14] :) [22:02:37] i am suppose to go through all of them and remove the .deprecate() [22:03:00] then if jenkins is unhappy with any one, i will have to go and put it back right jdlrobson ? [22:03:36] d3r1ck: if jenkins is unhappy find the extension where the issue is and update the call [22:03:52] so if it is doing M.require( 'deprecatedModuleName' ) change it to M.require( 'newModuleName' ) [22:04:15] ok [22:04:28] jdlrobson: the files are many do you know that? [22:04:40]