[00:02:21] o/ [00:24:01] hey bmansurov [00:24:16] morning [00:59:55] gotta go, will be online later [10:00:20] o/ [10:13:47] hey bmansurov [13:04:53] nick phuedx|afk [13:04:58] ^ professional [13:05:04] ... [14:15:24] yo [14:16:17] yo [16:03:59] jobs got a mo to jump into a hangout? [16:04:56] jhobs: ^ [16:05:04] not "jobs" ;-) [16:06:22] kristenlans: out at lunch, can we do after the standup? [16:09:23] sure jhobs ping me when u back [16:10:15] cool thanks [16:56:36] just got back kristenlans [16:56:47] you have time after the standup? [16:57:28] jhobs: we just were meeting total about Q2 eng goal and I forgot to add you to invite :-( [16:57:45] so not sure what the best way to catch you up is jhobs [16:58:10] jhobs: you can check ou this messy etherpad to start :-) https://etherpad.wikimedia.org/p/q2_eng_goal [16:58:12] kristenlans: oh ok. Got an etherpad or recording or anything I can catch up with? [16:58:49] etherpad appears to be broken again, but i'll check it out as soon as it loads for me [16:59:10] jhobs: freakin' etherpad... [17:00:56] rmoen: you joining standup? [17:05:25] dbrant|brb: niedzielski bearND this is a total nit, but should we capitalize wikidata descriptions when showing them, for consistency with the rest of our presentation? [17:06:27] mdholloway: are we not? it looks like mobileview is captialized [17:07:30] niedzielski: i have the app up with dbrant's patch from testing just now, and they're definitely not capitalized [17:07:52] mdholloway: good catch! they should be. i'll make a patch real quick. [17:08:17] mdholloway: hm, so from the edgar allen poe article, i tap "literary criticism" and the casing looks right to me. is this patch specific? [17:09:51] niedzielski: for me it's all lowercase. I haven't looked into the cause. [17:11:01] niedzielski: yep, patch specific [17:15:22] kids -> bed [17:17:17] dbrant mdholloway bearND: it looks like a broke the alpha build. i have a patch to fix it here. https://gerrit.wikimedia.org/r/#/c/231697/ [17:17:37] er here: https://gerrit.wikimedia.org/r/#/c/240753/ [17:30:08] rmoen: around? do you want me to take over/fixup https://gerrit.wikimedia.org/r/#/c/239993/ ( https://phabricator.wikimedia.org/T110662 )? [17:33:29] jdlrobson: we meeting? [17:36:09] JonKatz: kristenlans https://phabricator.wikimedia.org/project/sprint/board/1535/ [17:39:23] JonKatz: jdlrobson https://phabricator.wikimedia.org/tag/reading_web_planning/board/ [17:41:33] dbrant: niedzielski: bearND: did you see the pull request for the old PhoneGap app on Github? [17:41:55] mdholloway: no [17:41:59] mdholloway: no, i don't think i watch that repo [17:42:09] https://github.com/wikimedia/WikipediaMobile/pull/337 [17:43:40] mdholloway bearND|afk dbrant: looks like alpha builds are back [17:43:48] o/ [17:44:34] nice [17:51:49] jdlrobson: JonKatz https://phabricator.wikimedia.org/T104200 [17:59:37] jdlrobson: I'm trying to test phuedx's mediaviewer patch locally, but mediaviewer isn't automatically opening on my vagrant instance. Is there something else I need to do to enable it besides enabling the "multimediaviewer" role? [18:00:15] jdlrobson: and as soon as I type something, I figure it out. Nevermind [18:04:07] JonKatz: nice fakeout in sprint planning. Psyche! [18:04:37] niedzielski: mdholloway: is this a cause for concern: https://phabricator.wikimedia.org/T113601 ...a good number of these coming in today. [18:04:41] kristenlans i told you my head wasn't in the game :( [18:05:19] JonKatz: it's OK, it's the warmup sprint. [18:05:25] * kristenlans cues eye of the tiger [18:05:37] dbrant: ...yes. [18:05:37] aaaddrian [18:06:33] etherpad is being etherbad [18:07:12] dbrant mdholloway: doesn't look good. digging in [18:09:18] dbrant mdholloway: hm, i think we did an upgrade of the version number _after_ actually making the change. this would effect updated database but not the updated version [18:12:24] kaity_: is there a read more page on mediawiki.org? [18:13:23] dbrant mdholloway: although i'm having trouble digging it up in git so far [18:13:59] niedzielski: mdholloway: i can't reproduce... or find a probable cause myself. [18:14:54] niedzielski: dbrant: perhaps https://gerrit.wikimedia.org/r/#/c/231325/ then https://gerrit.wikimedia.org/r/231738? [18:17:06] i messed up in https://gerrit.wikimedia.org/r/#/c/231325/9/app/src/main/java/org/wikipedia/pageimages/PageImagePersistenceHelper.java and ended up specifying a nonexistent db version, which we then bumped [18:18:24] mdholloway: yeah, but we didn't make a release in between those two patches... [18:18:29] dbrant mdholloway: i guess i'm a little confused why DBOpenHelper has one version and each database has another version [18:19:02] dbrant mdholloway: i was thinking we bumped SavedPagePersistenceHelper.DB_VER_NAMESPACE_ADDED too late, but it's remained steady [18:20:17] dbrant mdholloway: do we have one version for all databases? [18:22:11] niedzielski: there's just one database... [18:22:50] dbrant mdholloway: oh, so each of these are tables then? [18:22:57] right [18:22:59] niedzielski: yep [18:23:15] niedzielski: mdholloway: i've tried installing the previous app version, and upgrading to the current version, repeating the process for all versions since the beginning of this year, but still can't repro. [18:24:27] jdlrobson: Deskana|Away might be able to answer that [18:25:35] jdlrobson: hmm there probably isn't, I don't think the apps usually made a mediawiki page for small features [18:25:45] jdlrobson: I'll start one [18:30:47] dbrant mdholloway: so it might be users going from 109 to 111, not just 110 to 111 [18:31:00] dbrant mdholloway: or any version [18:35:49] niedzielski: that's what i meant to say -- i tried upgrading from all versions, down to 92 [18:42:17] niedzielski: mdholloway: i mean, it's probably not too serious; we would see an avalanche of reports if something was *that* messed up. [18:42:51] dbrant mdholloway: i didn't realize adb let you install a downgrade app version without the -d option (-d: allow version code downgrade) [18:44:04] niedzielski: hmm, i didn't know that, either [18:45:04] dbrant mdholloway: i unsurprisingly got a different database version error (different) when i did it not realizing i already had the app installed on my emulator [18:46:19] yeah, we get db downgrade errors in OTRS once in a while, too [19:09:43] sweet thanks [19:20:41] mbinder: FYI you might want to join #wikimedia-ios [19:20:44] all our phab notifications go there [19:20:59] makes it easier to track the conversation w/o stuff getting bulldozed in -dev [19:21:34] word, thx bgerstle [19:22:17] dbrant: does android have a similar channel? ^^ [19:22:36] kaldari: Hi there, thanks for merging that patch, we weren't totally sure it was ready yet though [19:22:51] kaldari: Do you remember the TOS concerns we had? [19:23:02] mbinder: no [19:23:35] yes [19:23:43] bearND: interested? [19:24:02] marktraceur: I talked to the folks at Flickr [19:24:23] mbinder: i think -mobile is just fine [19:24:24] marktraceur: also the patch needed some tweaks, but I fixed it up [19:25:08] kaldari: And I see merged your tweaks [19:25:18] Fine, but a little sudden for us in -multimedia [19:25:26] cool [19:25:34] Thanks for clearing it up [19:25:53] marktraceur: sudden? wasn't that patch a few years old? [19:25:59] kaldari: Do you have documentation of our exception to the Flickr TOS somewhere? [19:26:14] kaldari: Sudden in that we weren't expecting it to get merged because we're all busy with other things [19:26:16] yes, it's in the phab ticket [19:26:23] OK, perfect [19:27:02] marktraceur: I also tested it locally [19:27:53] OK, I have the full story, thanks for helping out [19:35:06] marktraceur: next time I'll get someone from multimedia to double-check. didn't mean to jump the gun :) [19:39:03] marktraceur: BTW, it's still limited to only uploading 50 at a time, so hopefully won't cause any explosions [20:19:16] jdlrobson: we need to wait 30 days for the cache, right (https://gerrit.wikimedia.org/r/#/c/240567/) ? [20:20:18] hmmm [20:22:21] it's kinda a weird situation. I guess category pages need 30 days to get the new module... On the other hand we're now double loading on __all__ standard articles. Given the amount of articles compared to category pages and the more traffic they get, i'm divided about whether we need to worry about caching here [20:23:38] jdlrobson: Categories are very important for commonswiki (and probably other wikis, too). So I strongly argue that we need to find a solution which keeps category pages working, too. [20:24:08] FlorianSW: but they should also be getting purged more frequently because of the nature of commons [20:24:15] i guess we should wait a week at least [20:24:31] the thing that's strange is the revert is still going to take time to roll out [20:25:02] even though we reverted we're still serving cached html to those right ? [20:25:03] jdlrobson: the revert was cherry picked to wmf24 and swat deployed by ori to fix the commonswiki problem :) [20:25:11] sure.. so how did that get round cache? [20:25:14] did we cache flush? [20:25:41] if we didn't then that suggests to me caching is not a signficant problem on commons or is still a problem and hasnt been reported [20:25:43] the revert is a fix in Resourceloader which takes only around 15 minutes to clear itself [20:26:16] oh true. i hadn't thought about that [20:26:22] and as far as I know, Steinsplitter (who reported the problem) was logged in, me too, while testing. And logged in users doesn't get cached pages [20:26:26] yeh your right. So I guess we just have to wait again...:/ [20:26:45] Unfortunately yes [20:27:01] i dunno. As I said it's about trade offs i guess. I'm just concerned that all wikis are double loading css now. [20:29:05] jdlrobson: where do we load it the first time? [20:29:13] (or where do we load it twice?) [20:29:14] hmm? [20:29:18] on all pages [20:29:24] yes, but where in the code :P [20:30:34] actually let me rephrase. All pages load the gallerys stylesheet unnecessarily (https://gerrit.wikimedia.org/r/#/c/240567/6/resources/Resources.php) [20:30:43] pages with galleries load it twice (due to the above and the gallery module) [20:31:27] jdlrobson: ah, ok :) That's how I understood it :P Thanks for clarifying! [21:10:15] heading out o/