[00:03:20] <bmansurov>	 o/
[08:22:48] <d3r1ck>	 hi
[08:22:53] <d3r1ck>	 jdlrobson: hi
[09:27:31] <phuedx>	 d3r1ck: jdlrobson is using irccloud, which is a permanently – well, almost permanently – connected irc bouncer
[09:27:39] <phuedx>	 he may have forgotten to mark himself as afk
[09:37:52] <bmansurov>	 o/
[13:15:45] <d3r1ck>	 phuedx: are you there?
[13:16:09] <phuedx>	 d3r1ck: i'm about to go to lunch
[13:16:16] <phuedx>	 is there anything i can help you with?
[13:16:21] <d3r1ck>	 can you review a patch?
[13:18:32] <phuedx>	 d3r1ck: i can certainly take a look
[13:18:42] <phuedx>	 which project is it against?
[13:19:27] <d3r1ck>	 Mobile FE
[13:19:32] <d3r1ck>	 can i send you the link?
[13:20:14] <d3r1ck>	 phuedx: let me just add you as a reviewer?
[13:20:22] <d3r1ck>	 what is your name on Gerrit
[13:20:22] <phuedx>	 d3r1ck: just add me as a reviewer
[13:20:33] <phuedx>	 d3r1ck: take a wild guess ;)
[13:20:36] <phuedx>	 (it's phuedx)
[13:21:18] <d3r1ck>	 phuedx: i have added you.
[13:25:42] <phuedx>	 d3r1ck: after quick look it looks ok
[13:25:52] <phuedx>	 has the thanks extension been updated to not use the toast module?
[13:28:59] <d3r1ck>	 phuedx: well i don't understand
[13:29:08] <d3r1ck>	 just +2 the one i added you to
[13:29:16] <d3r1ck>	 so it can be merged by Gerrit bot
[13:29:24] <d3r1ck>	 i want you to review another one
[13:29:28] <d3r1ck>	 i have just two
[13:31:33] <phuedx>	 d3r1ck: https://gerrit.wikimedia.org/r/#/c/240611/4/resources/mobile.toast/toast.js <- the change to that file appears to break another extension
[13:32:09] <d3r1ck>	 ohhh, so i should undo it?
[13:32:31] <phuedx>	 d3r1ck: yes and make a note that the Thanks extension will have to be updated
[13:32:56] <d3r1ck>	 phuedx: ok
[13:33:12] <phuedx>	 d3r1ck: the comment from jenkins-bot on sep 24, 9:19 pm as what i was alluding to earlier
[13:33:22] <phuedx>	 (as did jdlrobson on the patch itself)
[13:33:34] <phuedx>	 where it says "Gate pipeline build failed"
[13:33:58] <phuedx>	 the build marked as failed reports that the thanks extension's unit tests failed
[13:34:08] <phuedx>	 because a file is trying to require the "toast" module
[13:37:23] <d3r1ck>	 ok
[13:37:29] <d3r1ck>	 phuedx: i will do that now
[13:43:38] <d3r1ck>	 phuedx: wit
[13:43:41] <d3r1ck>	 phuedx: wait
[13:44:46] <d3r1ck>	 phuedx: done. Check it out now.
[13:49:48] <d3r1ck>	 phuedx: you can +2 it now.
[13:49:58] <d3r1ck>	 so gerrit bot can just merge it. 
[13:55:25] <phuedx>	 d3r1ck: what exactly did you change?
[13:56:35] <phuedx>	 i see no changes to the toast.js file
[13:56:40] <d3r1ck>	 wait
[13:56:41] <d3r1ck>	 mistake
[13:58:39] <d3r1ck>	 phuedx: done
[14:00:09] <phuedx>	 d3r1ck: not quite -- you appear to have submitted the wrong patch in place of the original
[14:00:13] <phuedx>	 :)
[14:04:35] <d3r1ck>	 phuedx: yes i want to do that now
[14:08:08] <d3r1ck>	 phuedx: check it out now.
[14:09:22] <d3r1ck>	 phuedx: can you cherry pick it to master?
[14:09:27] <d3r1ck>	 please it is not going to me.
[14:09:35] <d3r1ck>	 phuedx: do i need to rebase?
[14:10:44] <phuedx>	 d3r1ck: i suggest that you abandon those two patches that you've just submitted and work of this one
[14:10:46] <phuedx>	 https://gerrit.wikimedia.org/r/#/c/240611/4
[14:12:24] <phuedx>	 that one you requested that i review
[14:12:32] <phuedx>	 it only requires a minor change
[14:12:46] <d3r1ck>	 phuedx: ok
[14:13:29] <mdholloway>	 dbrant: any reason for me not to hit the big button and merge maps in nearby: tng?
[14:14:32] <d3r1ck>	 phuedx: hope you will merge it
[14:14:33] <d3r1ck>	 :)
[14:14:43] <dbrant>	 mdholloway: well, it has a soft dependency on https://gerrit.wikimedia.org/r/240286 , since it hasn't been tested on GB...
[14:14:57] <phuedx>	 d3r1ck: i'll take a look
[14:15:38] <dbrant>	 mdholloway: but... any reason we're hesitating merging https://gerrit.wikimedia.org/r/240286 ?
[14:15:46] <dbrant>	 niedzielski: ^
[14:15:48] <phuedx>	 d3r1ck: how familiar are you with git and gerrit (git-review specifically)?
[14:16:11] <mdholloway>	 dbrant: yeah, i've had my eye on that one.  does it makes sense to get quiet crash reporting in first?  /cc niedzielski 
[14:16:47] <d3r1ck>	 phuedx: i am very good at it.
[14:17:17] <mdholloway>	 dbrant: that's the only thing i'm holding back on
[14:17:22] <d3r1ck>	 phuedx: you can look at it now.
[14:17:24] <phuedx>	 d3r1ck: ah, i've just seen that you've submitted a new patch
[14:18:05] <d3r1ck>	 phuedx: yes
[14:21:15] <mdholloway>	 dbrant: i'm fine with that patch as well, except that (as you noted) the possibility of an infinite crash/restart loop should be addressed
[14:24:55] <d3r1ck>	 phuedx: waiting
[14:26:02] <dbrant>	 mdholloway: i believe we've already agreed that GB will remain on ACRA crash reporting (but niedzielski can confirm).
[14:26:10] <dbrant>	 mdholloway: the last crash report we've received from 2.3.x was over a month ago, and there have been no reports from 2.3 for the last production version.
[14:26:42] <phuedx>	 d3r1ck: adding a deprecation warning is far less destructive than removing one -- any remaining clients relying on the old module name will break
[14:27:26] <phuedx>	 i'm verifying that all of the extensions that i have cloned locally (which, honestly, isn't that representative a sample) don't rely on the old module names
[14:27:50] <phuedx>	 which, as you've noted, is taking a little time
[14:28:47] <phuedx>	 unit tests help us here
[14:29:08] <phuedx>	 but we don't run all unit tests for all extensions every build
[14:30:21] <d3r1ck>	 phuedx: ok. I am waiting
[14:30:24] <mdholloway>	 dbrant: i must have missed that.  nothing blocking a +2 for https://gerrit.wikimedia.org/r/240286 for me, then.
[14:30:24] <d3r1ck>	 to see the results
[14:41:43] <d3r1ck>	 phuedx: i see all is well
[14:41:57] <d3r1ck>	 i just hope jenkins will be happy and gerrit bot will merge
[14:43:00] <phuedx>	 i ran the integration tests myself, so jenkins should be ok there
[14:44:58] <niedzielski>	 dbrant mdholloway: confirm
[14:45:22] <niedzielski>	 dbrant mdholloway: quiet crash reporting will definitely be post-gb
[14:45:41] <niedzielski>	 dbrant mdholloway: still waiting on an agreement to take shape
[14:45:58] <mdholloway>	 niedzielski: dbrant: cool.  if you have any objection to my +2'ing the version code bump, speak now
[14:46:14] <niedzielski>	 mdholloway: go for it!
[14:47:01] <mdholloway>	 DONE
[14:48:08] <d3r1ck>	 phuedx: yes it is fine
[14:48:13] <d3r1ck>	 phuedx: it is merged
[14:48:31] <niedzielski>	 :)
[14:48:33] <d3r1ck>	 phuedx: so it seems the bug can be marked as resolved because i have done all
[14:51:55] <d3r1ck>	 niedzielski: hi
[14:53:12] <phuedx>	 d3r1ck: i see 34 calls to deprecate in the mobilefrontend codebase
[14:53:15] <niedzielski>	 d3r1ck: hello
[14:53:43] <phuedx>	 (using ag -a '\.deprecate' resources/ | wc -l)
[14:54:11] <mdholloway>	 niedzielski: you cool with the maps patch going in?
[14:54:21] <d3r1ck>	 phuedx: hey, meaning they are not yet finished?
[14:54:27] <mdholloway>	 niedzielski: i understand there's to be some follow-up UI work
[14:54:28] <niedzielski>	 mdholloway:yep!
[14:54:33] <mdholloway>	 niedzielski: cool
[14:54:49] <d3r1ck>	 phuedx: it seems ... Wait let me check again
[14:55:03] <dbrant>	 http://media.giphy.com/media/8fen5LSZcHQ5O/giphy.gif
[14:55:17] <mdholloway>	 :)
[14:55:44] <mdholloway>	 womp womp
[14:56:09] <mdholloway>	 merge failed.
[14:56:27] <dbrant>	 rebasing...
[15:01:23] <d3r1ck>	 phuedx: have you updated your repo?
[15:01:34] <d3r1ck>	 git fetch origin master :)
[15:04:19] <d3r1ck>	 phuedx: i have made another patch
[15:04:26] <dbrant>	 mdholloway: lock and load
[15:04:52] <d3r1ck>	 phuedx: check it out an test, the probably +2 for gerrit to merge
[15:06:29] <phuedx>	 d3r1ck: git fetch won't merge refs/objects into the branch that you're working on
[15:07:04] <phuedx>	 it'll only fetch them from the remote that you specify
[15:07:31] <phuedx>	 (just in case)
[15:07:40] <d3r1ck>	 phuedx: so must do git pull?
[15:07:49] <d3r1ck>	 but check the patch i sent
[15:07:53] <d3r1ck>	 you can test it.
[15:09:22] <phuedx>	 d3r1ck: git pull will git fetch and then git merge fetch_head, so yes
[15:10:05] <mdholloway>	 niedzielski: yeah, i noticed the same a few days ago, cool stuff!
[15:10:40] <phuedx|afk>	 brb -- fetching shopping in from the car
[15:11:10] <mdholloway>	 niedzielski: dbrant: i don't think we have a ticket for it yet, but it would be nice to move to an on-demand location permission when using nearby instead of at install time
[15:11:27] <niedzielski>	 mdholloway:i think that would be covered by bearND|afk's m list
[15:12:53] <d3r1ck>	 niedzielski: so whats up?
[15:13:17] <niedzielski>	 d3r1ck: oh just going through the morning patches. you?
[15:13:23] <mdholloway>	 niedzielski: i remember him talking about making a list but if it's in phab i must not be subscribed to it, looking now
[15:18:06] <dbrant>	 it may have been a wiki page...
[15:18:12] <niedzielski>	 mdholloway: https://www.mediawiki.org/wiki/Notes_from_Google_I/O_15#Action_Items
[15:18:27] <niedzielski>	 sorry, i was lost in a sea of wikis
[15:19:27] <dbrant>	 niedzielski: mdholloway: I'll be sure to make tasks out of those items
[15:19:33] <d3r1ck>	 niedzielski: well nothing muchni
[15:19:37] <mdholloway>	 niedzielski: no worries, thanks!
[15:19:38] <d3r1ck>	 niedzielski: can you checkout mine?
[15:20:38] <niedzielski>	 d3r1ck: er, which repo is that?
[15:20:45] <d3r1ck>	 niedzielski: i have added you as reviewer
[15:20:51] <d3r1ck>	 niedzielski: Mobile Frontend
[15:22:14] <niedzielski>	 d3r1ck: does this affect android?
[15:22:43] <d3r1ck>	 niedzielski: i don't think
[15:22:51] <dbrant>	 d3r1ck: not everyone here is a mobile-web engineer. niedzielski and I work on the Android app.
[15:23:03] <d3r1ck>	 dbrant: ohhhh, i see
[15:23:23] <d3r1ck>	 dbrant: then jdlrobson and phuedx will look at it when they come back
[15:23:28] <niedzielski>	 d3r1ck: yeah, i don't think this one would be a good one for me review
[15:24:02] <dbrant>	 d3r1ck: yep! they're quite busy; give them some time...
[15:32:16] <d3r1ck>	 dbrant: yes
[15:32:34] <d3r1ck>	 phuedx: hmmm, i no longer see afk on your handle :)
[15:35:58] <phuedx>	 d3r1ck: yep, i'm here
[15:36:25] <phuedx>	 i'm finishing off a piece of work that i've been working on for a while at the moment
[15:36:56] <phuedx>	 keep submitting the patches and they'll be reviewed -- but not necessarily within 10 minutes ;)
[15:37:07] <d3r1ck>	 ok
[15:41:34] <d3r1ck>	 phuedx: i need to fix like 50 bugs GSoC next year :)
[15:54:03] <phuedx>	 d3r1ck: yowza -- that seems like a whole lot
[15:54:38] <d3r1ck>	 phuedx: a whole lot of what?
[15:54:49] <d3r1ck>	 phuedx: i have updated using git pull.
[15:54:59] <d3r1ck>	 i think that is the last patch
[16:03:48] <phuedx>	 d3r1ck: ag -l --js '\.deprecate' resources/ https://www.irccloud.com/pastebin/8rfCQ38K/
[16:04:01] <phuedx>	 cross-post from -dev
[16:04:38] <d3r1ck>	 phuedx: have you did git pull?
[16:04:49] <d3r1ck>	 on the MobileFrontend extensions?
[16:05:00] <phuedx>	 d3r1ck: yes
[16:05:23] <d3r1ck>	 phuedx: and you still see that?
[16:06:19] <phuedx>	 d3r1ck: here's a similar search on github: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/search?utf8=%E2%9C%93&q=.deprecate
[16:06:38] <phuedx>	 you can ignore the mobile.modules file, which is the definition of the function
[16:06:56] <phuedx>	 and there are a few instances of the word deprecate in documentation there
[16:07:13] <d3r1ck>	 yes i know
[16:07:19] <d3r1ck>	 phuedx: i have submitted a patch already
[16:07:28] <d3r1ck>	 merge it and then pull 
[16:08:57] <d3r1ck>	 phuedx: so when you merge it then i think all is well then
[16:10:36] <phuedx>	 d3r1ck: you're talking about https://gerrit.wikimedia.org/r/#/c/241052/ ?
[16:10:43] <phuedx>	 or have i missed another patch?
[16:11:43] <d3r1ck>	 phuedx: yes
[16:11:47] <d3r1ck>	 that is it.
[16:13:48] <phuedx>	 ok, then i think there'll still be 16 ish occurrences of deprecate to clear up
[16:14:12] <d3r1ck>	 phuedx: wait
[16:14:14] <d3r1ck>	 they are
[16:14:29] <d3r1ck>	 i used: git grep -E ".deprecate"
[16:15:42] <d3r1ck>	 and i got no call
[16:16:04] <d3r1ck>	 to the deprecated module
[16:16:17] <d3r1ck>	 let me pastebin it and show you.
[16:17:02] <d3r1ck>	 phuedx: http://pastebin.com/VY1NNhQs
[16:23:49] <phuedx>	 d3r1ck: here's what i get from a new clone of the mobilefrontend extension https://www.irccloud.com/pastebin/2DczO8PT/
[16:24:06] <phuedx>	 have you submitted all of your changes to gerrit?
[16:24:10] <phuedx>	 and have they all been merged?
[16:24:38] <phuedx>	 d3r1ck: i've got to go and have dinner but i'll be back later
[16:25:38] <phuedx>	 jdlrobson might be coming online soon
[16:25:46] <phuedx>	 so he /may/ be able to help you out in the interim
[16:26:03] <phuedx|afk>	 okie poke -- bbiab
[16:26:15] <d3r1ck>	 ok
[16:27:39] <d3r1ck>	 jdlrobson: hey
[16:27:57] <d3r1ck>	 awesome jdlrobson, welcome
[16:30:46] <jdlrobson>	 hi there
[16:31:33] <mbinder>	 dbrant|brb: niedzielski mdholloway|afk bearND Sprint name? "Holmium"?
[16:31:51] <d3r1ck>	 jdlrobson: so what have you been working on?
[16:31:54] <dbrant>	 mbinder: you got it!
[16:32:18] <jdlrobson>	 not much unfortunately. Mostly code review and defining future work :)
[16:32:43] <d3r1ck>	 jdlrobson: hahaha.... :)
[16:33:06] <d3r1ck>	 jdlrobson: i am planning to reach the level of reviewing code. I want to help you when you are not there.
[16:33:07] <niedzielski>	 +1
[16:33:31] <niedzielski>	 this sprint is about to get sprung
[16:34:06] <d3r1ck>	 niedzielski: what?
[16:34:29] <niedzielski>	 d3r1ck: was chatting with the android devs :)
[16:34:55] <d3r1ck>	 ok
[16:35:38] <FlorianSW>	 hi jdlrobson :P
[16:35:48] <jdlrobson>	 d3r1ck: there's a few more deprecated function calls. Would be great to get those fixed up
[16:36:07] <jdlrobson>	 hey FlorianSW  :) We broke Monobook on Wikivoyage :) https://phabricator.wikimedia.org/T113746
[16:36:11] <jdlrobson>	 (well mostly me ;-))
[16:36:13] <d3r1ck>	 jdlrobson: ok. Let me check it out.
[16:36:24] <jdlrobson>	 d3r1ck: you'll need to install the Thanks extension
[16:36:47] <d3r1ck>	 jdlrobson: i have it already
[16:36:48] <FlorianSW>	 jdlrobson: bähh :P
[16:37:23] <jdlrobson>	 d3r1ck: awesome.
[16:37:36] <FlorianSW>	 jdlrobson: if you rebase, I'll check and merge :)
[16:37:36] <jdlrobson>	 i think we'll be able to wrap that bug up and get it closed today ! yay! :)
[16:37:44] <d3r1ck>	 jdlrobson: remember i fixed a bug for them back some few days ago
[16:37:47] <jdlrobson>	 FlorianSW: on it
[16:38:35] <niedzielski>	 dbrant mdholloway|afk bearND: would one of you devs mind reviewing this when you can? https://gerrit.wikimedia.org/r/#/c/237024/
[16:38:42] <d3r1ck>	 jdlrobson: when i run: git grep -E ".deprecate"
[16:38:46] <d3r1ck>	 jdlrobson: i have this
[16:38:49] <d3r1ck>	 jdlrobson: http://pastebin.com/VY1NNhQs
[16:38:58] <dbrant>	 niedzielski: looking now
[16:39:01] <jdlrobson>	 FlorianSW: done! :)
[16:39:04] <d3r1ck>	 which calls should i remove from there?
[16:39:08] <niedzielski>	 dbrant: thanks :)
[16:39:15] * FlorianSW is checking jdlrobson's change
[16:39:22] <jdlrobson>	 d3r1ck: it's possible you didn't submit a change
[16:39:28] <jdlrobson>	 are you on a clean master branch?
[16:39:30] <jdlrobson>	 git checkout master
[16:40:02] <d3r1ck>	 jdlrobson: i am there
[16:40:06] <jdlrobson>	 https://gist.github.com/jdlrobson/5a4b6b9844041c182a24 > d3r1ck that's what i am seeing
[16:41:00] <d3r1ck>	 jdlrobson: ok
[16:41:03] <d3r1ck>	 let me fix those
[16:41:18] <jdlrobson>	 d3r1ck: you almost certainly have something on your master branch that hasn't been pushed to gerrit. If you do a `git log` do you see any patches that haven't been merged?
[16:42:32] <d3r1ck>	 jdlrobson: i see it.
[16:42:53] <d3r1ck>	 jdlrobson: fixing it now. But toast breaks the Thanks extension. I will have to fix that too.
[16:44:00] <jdlrobson>	 d3r1ck: there's this bug if you're interested afterwards - https://phabricator.wikimedia.org/T113667 - should be an easy fix. We'll have you up to speed and reviewing in no time :)
[16:44:21] <bearND>	 niedzielski: looking too
[16:44:33] <niedzielski>	 bearND: cool thanks
[16:50:20] <d3r1ck>	 jdlrobson: let me look
[16:54:05] <d3r1ck>	 jdlrobson: let me fix the calls to deprecated modules too
[16:54:23] <d3r1ck>	 when i finish up with that, then i will go for the one you just asked
[16:54:38] <jdlrobson>	 yeh you'll need to do those first. Ping me when patches are up and i'll merge them asap
[16:56:06] <d3r1ck>	 ok
[17:13:42] <d3r1ck>	 jdlrobson: checkout the one i just send
[17:13:45] <d3r1ck>	 *sent
[17:16:45] <d3r1ck>	 jdlrobson: check it out
[17:20:29] <d3r1ck>	 jdlrobson: are you there?
[17:20:58] <d3r1ck>	 lets finish up with this one and then let me fix the other one. :0
[17:21:02] <d3r1ck>	 :)
[17:34:37] <jdlrobson>	 d3r1ck: yup taking a look now
[17:44:38] <d3r1ck>	 jdlrobson: i don't even know how that file got added.
[17:44:44] <d3r1ck>	 but what should i do now
[17:48:21] <d3r1ck>	 jdlrobson: done, you can review now
[17:55:50] <jdlrobson>	 d3r1ck: back to you
[17:56:23] <d3r1ck>	 jdlrobson: yes, gerrit bot will surely merge it
[17:56:38] <d3r1ck>	 jdlrobson: lets resolve the bug now.
[17:57:19] <d3r1ck>	 jdlrobson: hey we have a problem
[17:57:24] <d3r1ck>	 qunit refused the patch
[17:57:26] <d3r1ck>	 mediawiki-extensions-qunit https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/12998/console : FAILURE in 1m 32s
[17:58:26] <d3r1ck>	 jdlrobson: can you do a recheck?
[17:58:57] <jdlrobson>	 d3r1ck: click `full log`and you'll see there is a qunit failure in Actual: ext.thanks.mobilediff,tests.ext.thanks.mobilediff
[17:59:02] <jdlrobson>	 you'll have to update Thanks first
[17:59:09] <jdlrobson>	 it's preventing us from deploying broken code so this is good it caught it
[18:00:00] <d3r1ck>	 jdlrobson: wait, so how do i update Thanks?
[18:00:13] <jdlrobson>	 The Thanks extension is referring to the old deprecated names
[18:00:21] <d3r1ck>	 jdlrobson: can you walk me through?
[18:00:35] <jdlrobson>	 so you'll have to install Thanks
[18:00:39] <d3r1ck>	 jdlrobson: i have it
[18:00:46] <jdlrobson>	 I suspect if you visit a diff page on mobile you'll see warnings in the JavaScript console
[18:00:51] <jdlrobson>	 Do what the warnings ask you
[18:01:49] <d3r1ck>	 jdlrobson: wait, i don't get it.
[18:03:00] <mbinder>	 bearND: kaity_ retro?
[18:04:31] <d3r1ck>	 jdlrobson: i see it. There is a call to toast
[18:04:36] <d3r1ck>	 which is deprecated.
[18:04:48] <jdlrobson>	 d3r1ck: exactly. So you'll need to update a patch to avoid the deprecation warning
[18:04:58] <d3r1ck>	 jdlrobson: so i need to submit a patch for Thanks too?
[18:05:03] <jdlrobson>	 yup
[18:05:06] <d3r1ck>	 men will you review it?
[18:05:15] <jdlrobson>	 yes i will review it if you link me to it
[18:05:55] <d3r1ck>	 ok
[18:06:02] <d3r1ck>	 jdlrobson: so what is the module name?
[18:06:22] <d3r1ck>	 is it: 'mobile.toast/toast'
[18:06:25] <d3r1ck>	 in
[18:06:38] <d3r1ck>	 M.define( 'mobile.toast/toast', new Toast() )
[18:06:48] <d3r1ck>	 or i just have to put the whole line of code?
[18:08:07] <d3r1ck>	 jdlrobson: so from the link of code i pasted, what is the module name?
[18:13:50] <d3r1ck>	 jdlrobson: done. The call has been updated. :)
[18:13:55] <d3r1ck>	 let me link you to the patches
[18:22:16] <phuedx|afk>	 d3r1ck: the module name is the first argument to M.define
[18:22:25] <phuedx|afk>	 'mobile.toast/toast'
[18:23:29] <phuedx>	 i'm not around for long -- just checking in
[18:24:50] <d3r1ck>	 phuedx: it is done.
[18:25:01] <d3r1ck>	 phuedx: mooney is revieing it
[18:25:16] <d3r1ck>	 but i have submitted another patch with updated toast issue
[18:25:27] <d3r1ck>	 it should be fine now jdlrobson is busy :)
[18:27:05] <jdlrobson>	 \o phuedx go enjoy your weekend :P
[18:27:50] <d3r1ck>	 jdlrobson: :) then you will do the work :D
[18:45:53] <jdlrobson>	 d3r1ck: take a look a the report (click full log at top)
[18:45:57] <jdlrobson>	 https://www.irccloud.com/pastebin/QR6fjUTK/
[18:46:59] <d3r1ck>	 jdlrobson: ok
[18:50:46] <d3r1ck>	 jdlrobson: i don't still seem to figure out how to fix thatpart
[18:50:48] <d3r1ck>	 *part
[18:52:53] <d3r1ck>	 jdlrobson: checkt his out
[18:52:56] <d3r1ck>	 *this
[18:52:57] <d3r1ck>	 18:42:58 Chromium 45.0.2454 (Ubuntu 0.0.0) ERROR: 'Error: Module not found: loggingSchemas/SchemaMobileWebClickTracking', Error{}
[18:53:11] <d3r1ck>	 I don't know how to go about this.
[19:06:28] <mbinder>	 mhurd: http://hatjitsu.wmflabs.org/58033
[19:18:34] <jdlrobson>	 There will be clues in the log d3r1ck 
[19:18:42] <jdlrobson>	 i suspect SchemaMobileWebClickTracking is being used in Thanks as well
[19:19:02] <jdlrobson>	 Part of the fun is working out where the problem lies :)
[19:26:43] <mbinder>	 dbrant|brb: got worktype tags for items for next sprint?
[21:09:31] <niedzielski>	 bearND dbrant mdholloway: ok it looks like the last commit is merged. are we doing a release then?
[21:10:00] <niedzielski>	 bearND dbrant mdholloway: also, is the next version / name 2.1.131?
[21:11:58] <dbrant>	 niedzielski: nothing really blocking a release, but I'd really like us to look at the sqlite upgrade bug a bit more. Maybe release on Monday?
[21:12:18] <niedzielski>	 bearND dbrant mdholloway: sounds good
[21:12:32] <bearND>	 2.1.131 sounds good to me
[21:12:58] <bearND>	 yeah, monday is probably better. Do we also want to get the HA stuff in?
[21:14:39] <niedzielski>	 bearND: i'd love to but we're still waiting on the agreements :/
[21:16:02] <niedzielski>	 bearND: last response from ha didn't sound favorable so i'm guessing it needs to cook for a bit
[21:16:17] <niedzielski>	 bearND: that was yesterday
[21:16:51] <bearND>	 niedzielski: ok, good to know. It wasn't clear in the patch. Maybe -1 it so we don't accidentally merge it
[21:17:10] <niedzielski>	 bearND:will do
[21:17:45] <bearND>	 dbrant: i think https://phabricator.wikimedia.org/T110686 should go to Design review column so kaity can take a look
[21:18:38] <dbrant>	 bearND: good call
[23:26:26] <yurik>	 aude, around? are the maps in nearby done?  how can i play with it?
[23:26:49] <yurik>	 dbrant|brb, ^?
[23:27:04] <yurik>	 bearND, you also commented on it
[23:27:15] <yurik>	 (was looking at https://gerrit.wikimedia.org/r/#/c/212922/