[18:18:40] <d3r1ck>	 jdlrobson: hey
[18:19:12] <d3r1ck>	 with respect or in reference to my (9) patch concerning removin deprecated modules, i have already updated the Thanks extension
[18:19:18] <d3r1ck>	 but i still have errors
[18:24:25] <d3r1ck>	 jdlrobson: ohhh, i got something
[18:24:38] <d3r1ck>	 FlorianSW: will update it now.
[18:25:26] <FlorianSW>	 d3r1ck: hmm? :)
[18:28:24] <d3r1ck>	 FlorianSW: i just updated the call to the Tracking deprecated module
[18:28:29] <d3r1ck>	 i submitted a patch
[18:28:33] <d3r1ck>	 check it out. :)
[18:28:49] <FlorianSW>	 d3r1ck: can you link me to it?
[18:32:08] <d3r1ck>	 ok
[18:32:15] <d3r1ck>	 let me add you as reviewer
[18:32:59] <d3r1ck>	 FlorianSW: i added you as a reviewer
[18:33:31] <d3r1ck>	 FlorianSW: you can check it out now.
[18:39:34] <d3r1ck>	 FlorianSW: i lined you up to it. Did you see?
[18:45:44] <FlorianSW>	 d3r1ck: yes :D I already added a change: https://gerrit.wikimedia.org/r/#/c/241480/1 ;)
[18:46:37] <d3r1ck>	 FlorianSW: wait, i don't understand
[18:47:04] <d3r1ck>	 FlorianSW: just accept this one that i added you to. I did some chages to the Thanks extension and it was merged already
[18:47:28] <d3r1ck>	 FlorianSW: just review this two changes and let jenkins merge it before i leave please :)
[18:47:31] <d3r1ck>	 i will soon go
[18:48:11] <d3r1ck>	 FlorianSW: +2 it so that it can be merged.
[18:48:17] <d3r1ck>	 FlorianSW: it is fine now.
[18:49:01] <FlorianSW>	 d3r1ck: wait, I don't +2 a change just because someone says I've to do so :)
[18:49:35] <d3r1ck>	 FlorianSW: yes, but i know what i have to do to make the code work :) butt review it and then you will know whether to +2 it or not :)
[18:49:37] <FlorianSW>	 d3r1ck: what I meant before is, that I already uploaded a change to fix the Thanks extension a long time before you, like I mentioned in your change in MobileFrontend, so I'm a bit confused, why you uploaded a second one
[18:50:17] <d3r1ck>	 FlorianSW: My patch was not merging because of the call to a deprecated module
[18:51:17] <d3r1ck>	 but i have just uploaded a patch that fixes it.
[18:51:25] <d3r1ck>	 well i did not see that part
[18:51:27] <FlorianSW>	 d3r1ck: yes, that's what I wrote in your change -> https://gerrit.wikimedia.org/r/#/c/241084/ and thatÄs why I linked to the change in Thanks which I uploaded
[18:51:40] <d3r1ck>	 ahhh, i see
[18:51:45] <d3r1ck>	 but it was not merged.
[18:51:48] <d3r1ck>	 check the patch out
[18:52:09] <d3r1ck>	 FlorianSW: your patch was not merged that is why
[18:52:13] <d3r1ck>	 maybe
[18:53:09] <FlorianSW>	 d3r1ck: the reason of code review is, that someone else reviews the code. Even if I think that both changes are good, I would feel bad, if I merge a change which is (in fact) a copy of one change I already uploaded. That would feel like a self-merge, which isn't allowed for good reasons :)
[18:53:34] <d3r1ck>	 FlorianSW: i see. No problem
[18:53:58] <d3r1ck>	 what about the patch here https://gerrit.wikimedia.org/r/#/c/241084/
[18:55:03] <d3r1ck>	 that patch fails because of the call to the deprecated call in Thanks extension
[18:55:27] <FlorianSW>	 d3r1ck: we wait, until Thanks is fixed :)
[18:55:39] <d3r1ck>	 but this patch fixes it. https://gerrit.wikimedia.org/r/#/c/241543/
[18:55:45] <d3r1ck>	 https://gerrit.wikimedia.org/r/#/c/241543/ fixes Thanks
[18:55:55] <d3r1ck>	 so that is why i was telling you to check it out :)
[18:56:18] <d3r1ck>	 since jenkins has already verified it. It would be good to +2 :D
[18:58:19] <FlorianSW>	 d3r1ck: like I said above: I will not self-merge changes :) And https://gerrit.wikimedia.org/r/#/c/241543/ feels like a copy of https://gerrit.wikimedia.org/r/#/c/241480/ which would feel like a self-merge. And both changes aren't that urgent, that we need to live with this feeling, right? :)
[18:59:02] <d3r1ck>	 FlorianSW: yes thats true :)
[18:59:14] <d3r1ck>	 well i gues i will just move over to the next bug i have to fix :)
[23:57:36] <bmansurov>	 o/