[08:25:59] hey y'all [09:35:22] hey [10:05:46] o/ [12:01:43] hey again [12:33:41] travelling home [13:30:18] derp [13:30:24] forgot to open up irccloud again :/ [14:04:31] i will forever be cloning mediawiki/core [17:01:47] phuedx: standup? [17:15:45] getting the kids to bed [17:17:47] jdlrobson: is there a way to enable deprecation warnings for my local environment? [17:17:55] note: it's vagrant [17:27:38] mhurd_afk: bearND niedzielski highly recommend you check out google's approach to progressively rendering *our own content* https://phabricator.wikimedia.org/T100258#1654457 [17:28:40] bgerstle: thanks! [17:29:23] jhobs: 1s [17:29:41] https://www.irccloud.com/pastebin/6E0ghxv5/ [17:29:49] thanks! [17:30:06] in just any PHP file? [17:31:07] mhurd_afk: niedzielski bearND also: https://docs.google.com/document/d/1qWIYN-0ZVpSDiM5RChYKp_5n_fGZkHEtAeZ0ufUTQAk/edit [17:39:22] jhobs: LocalSettins.php [18:15:07] jdlrobson: I just noticed the "settings" module is deprecated. Has it moved to "mobile.settings/settings" or something, and if so, do I need to update any dependencies as well? [18:15:19] jhobs: correct [18:15:26] thanks [18:15:29] jhobs: I didn't realise Zero was using this [18:15:37] you probably want to check production it may have broken things [18:15:43] wait [18:15:45] jdlrobson: production just has warnings [18:15:46] it's mw.storage now [18:15:52] oh [18:15:54] jhobs: that will change on thursday [18:16:00] we have code riding the train right now that removes that [18:16:09] yeah i have to push out a hotfix anyways so it'll be ok [18:16:21] jhobs: add an integration test [18:16:27] so that it gets picked up by MobileFrontend in future! [18:16:40] jdlrobson: ok I'm unsure how to do that but I'll look into it [18:16:52] jdlrobson: i'll add it to the agenda for our re-onboarding [18:17:14] so if it's mw.storage now, i just do M.require('mw.storage')? [18:20:47] jdlrobson: hmm... I already had those error reporting lines set in local settings and I'm still not getting deprecation warnings like in production [18:28:23] jhobs: check your php error log [18:28:54] jdlrobson: oh i was looking for console deprecation warnings like what you see on production. I'll check the php logs though [18:31:39] jdlrobson: reason being that this urgent error with Zero banners appears to only happen when console warnings are showing [18:32:25] the javascript deprecation logs? [18:32:28] they should just show.. [18:32:45] provided your core/mobilefrontend etc is up to date [18:37:15] ping dr0ptp4kt [18:38:20] jdlrobson: they don't on my local environment :/ [18:40:24] dr0ptp4kt: yt? [18:40:33] want to reschedule our one on one? [18:40:37] or no? [18:47:31] jdlrobson: if you have some time later today, I'd appreciate some fresh eyes on https://phabricator.wikimedia.org/T114128 over a pairing session [18:54:09] mdholloway: by jove! [18:54:14] mdholloway: so wait, did you open the app for the first time after upgrading? or was it already upgraded? [18:54:49] dbrant: i downloaded the upgrade when it came out, but hadn't actually started it up until now [18:55:34] mdholloway: and how did you start it? (from the launcher, or from an external link, i.e. browser) [18:55:45] dbrant: from the launcher [18:56:11] mdholloway: do you know which exact version you had before upgrading? [18:56:53] dbrant: i would have had the previous version installed. [19:09:58] phuedx: rescheduling [20:04:26] yurik: need a rush review/merge/deploy on https://gerrit.wikimedia.org/r/#/c/242661. There's some deprecations in MobileFrontend about to ride the train on Thursday [20:18:56] kaity_: ping