[08:31:36] <phuedx>	 hey
[11:10:09] <phuedx|afk>	 going for an early lunch
[11:46:10] <phuedx|afk>	 back
[13:34:38] <phuedx>	 i bought my son a bubble blower gun thing that blows massive bubbles
[13:34:44] <phuedx>	 but he's not home
[13:34:55] <phuedx>	 the walls of my office have a lot of bubble solution over them :/
[13:36:52] <mdholloway>	 phuedx: gotta test it first and make sure it's safe, right?
[13:36:59] <phuedx>	 yeah…
[13:37:02] <phuedx>	 testing
[13:37:16] <phuedx>	 that's exactly what i've been doing
[13:38:55] <phuedx>	 i'm going to go test it some more
[13:39:00] <phuedx>	 just to make sure it still works
[13:39:20] <phuedx>	 really though i'm going to go try and buy a new bike
[13:39:26] <phuedx>	 because mine got stolen
[13:39:31] <phuedx>	 i was just trying to be funny
[13:39:39] <phuedx>	 :/
[13:39:40] <phuedx>	 AWAY!
[13:43:17] <mdholloway>	 phuedx|afk: it was.  my response probably could have used a humor/irony indicator.  ah, textual communication.
[15:08:27] <niedzielski>	 mdholloway dbrant bearND|afk: hey devs. i'm seeing a regression that i think should block beta promotion. certain menus are rarely and sporadically becoming transparent. i think i forgot to mutate a drawable somewhere
[15:08:51] <niedzielski>	 mdholloway dbrant bearND|afk: i'll look into it and hopefully have a patch soon
[15:09:51] <dbrant>	 oh? i haven't seen this...
[15:11:51] <mdholloway>	 niedzielski: yeah, i haven't seen it either, but that doesn't sound good.
[15:13:24] <niedzielski>	 mdholloway dbrant bearND|afk: it doesn't seem to happen consistently. i'll see if i can nail down repro steps
[15:23:04] <bearND>	 niedzielski: what kind of drawable mutation are you talking about?
[15:24:33] <niedzielski>	 bearND: drawables share state by default unless mutate is called. i think my status bar patch applied a color filter somewhere without calling mutate on the drawable first
[15:27:26] <phuedx>	 that took a lot longer than i expected
[15:55:58] <dbrant>	 bearND: got a minute for hangout?
[15:56:41] <bearND>	 dbrant: sure. Cave?
[15:56:45] <dbrant>	 yep
[15:57:21] <dbrant>	 bearND: occupied... i'll call directly
[15:57:30] <bearND>	 ok
[17:01:31] <jhobs>	 phuedx: standup?
[17:01:31] <bmansurov>	 phuedx, ping
[17:19:16] <jdlrobson>	 phuedx: https://gerrit.wikimedia.org/r/#/c/242921/
[17:34:00] <phuedx>	 thanks jdlrobson 
[17:34:06] <phuedx|afk>	 gonna get the kids to bed
[17:48:36] <jdlrobson>	 phuedx|afk: jhobs one thing to bear in mind with the read more feature, is that in future we may want to swap cards for a list of items (the mobile PageList) - if that's a list of cards that's great. I just want to make sure you think about that :)
[17:56:10] <jhobs>	 jdlrobson: https://www.mediawiki.org/wiki/Extension:ZeroBanner#Setting_up_local_wiki
[17:56:27] <jdlrobson>	 thanks @jhobs will review during metrics
[18:02:21] <jdlrobson>	 Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['remote']['url']: API URL is not set, and this config is not being stored locally [Called from JsonConfig\JCSingleton::init in /Users/jrobson/git/core/extensions/JsonConfig/includes/JCSingleton.php at line 112] in /Users/jrobson/git/core/includes/debug/MWDebug.php on line 300
[18:02:23] <jdlrobson>	 jhobs ^
[18:03:50] <jhobs>	 huh, what's your url param set to for the $wgJsonConfigs['JsonZeroConfig'] array?
[18:03:55] <jhobs>	 ^ jdlrobson 
[18:05:01] <jdlrobson>	 jhobs: i just used the config in the mediawiki page
[18:05:04] <jdlrobson>	 guess its out of date?
[18:05:11] <jhobs>	 it's probably wrong for local instances
[18:05:16] <jhobs>	 lemme double check what I have
[18:05:40] <jdlrobson>	 jhobs: https://www.mediawiki.org/wiki/Extension:ZeroBanner#Configuration is out of date for sure
[18:05:47] <jdlrobson>	 would be good to have a good local version
[18:06:37] <jhobs>	 well it's technically not an incorrect config if you were trying to tie into the production partner configs
[18:12:03] <jhobs>	 jdlrobson: just updated https://www.mediawiki.org/wiki/Extension:ZeroBanner#Configuration, try removing the "url", "isLocal", "username", and "password" params.
[18:13:15] <jdlrobson>	 jhobs: still Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['remote']['url']: API URL is not set, and this config is not being stored locally [Called from JsonConfig\JCSingleton::init in /Users/jrobson/git/core/extensions/JsonConfig/includes/JCSingleton.php at line 112] in /Users/jrobson/git/core/includes/debug/MWDebug.php on line 300
[18:14:17] <jhobs>	 jdlrobson: on my copy I have everything that has $wgJsonConfigs['JsonZeroConfig']['remote'] commented out
[18:14:42] <jhobs>	 jdlrobson: so the only line with $wgJsonConfigs is the one I have in the documentation now. Is that how yours is?
[18:33:38] <jdlrobson>	 jhobs: do you have local config?
[18:33:43] <jdlrobson>	 if so what is a local config
[18:38:39] <jhobs>	 jdlrobson: i'm unsure what you mean
[18:39:04] <jhobs>	 I sent an email to Yuri with a link to the instructions I wrote, so hopefully he can bring some insight into something I may have missed
[18:39:07] <jdlrobson>	 jhobs: the error says  "and this config is not being stored locally "
[18:39:36] <jdlrobson>	 I'm wondering if you thus have a config stored locally whatever that means
[18:39:54] <jhobs>	 yeah I don't know why that's happening; like I said I don't even have anything with "remote" uncommented
[18:40:15] <jhobs>	 local config might just be the Zero:TEST page that I have in the instructions
[18:46:40] <jdlrobson>	 jhobs: I edited that but nothing seemed to happen
[18:46:53] <jdlrobson>	 jhobs: do you have a Zero:TEST page ?
[18:51:14] <jdlrobson>	 jhobs: nope can't get setup.. can't test. Sorry i've wasted too much time on this. You'll have to poke yurik. Patch looks fine though
[18:59:20] <jhobs>	 jdlrobson: yeah sorry it's been a long time since I set up my environment, plus I'm using vagrant so that probably did some of it for me. I can tell you that the banner loaded fine for me with the patch even when throttling the connection though
[19:14:34] <phuedx>	 jhobs: i'm going to poke around the relatedarticles extension
[19:39:00] <jdlrobson>	 jhobs: i got zerobanner working
[19:39:03] <jdlrobson>	 but i can't open the overlay
[19:39:30] <jdlrobson>	 (Also concerned to see oo ui in there... why is that loaded unconditonally for our zero users? that's a big performance hit on first paint)
[19:40:54] <jdlrobson>	 there's a lot of scary code in this extension... :)
[19:47:37] <mdholloway>	 bearND: on the spoken files patch, about going back to PS4, did you specifically want to go back to moving the loop into runDomTransforms?  
[19:48:09] <mdholloway>	 bearND: or did you just have the selectors in mind?
[19:48:30] <bearND>	 mdholloway: just the selectors. maybe i named the wrong ps?
[19:48:57] <mdholloway>	 bearND: ok, i should be done shortly then
[19:49:12] <phuedx>	 ok
[19:49:21] <bearND>	 mdholloway: i think I should have said ps6
[19:49:34] <phuedx>	 customdata and relatedarticles are small but are interesting
[19:49:44] <phuedx>	 i'll cut the dev branch tomo
[19:49:55] <mdholloway>	 bearND: something breaks rmBracketSpans when i move the for loop and i can't seem to be able to track it down.  but if you weren't concerned about that anyway i'll just change it back and worry about it no more
[19:49:56] <phuedx>	 but for now…
[19:49:58] <phuedx>	 zzZ
[19:50:00] <mdholloway>	 bearND: otherwise, it works great
[19:51:03] <bearND>	 mdholloway: i think having the for loop in the route is good
[19:51:19] <bearND>	 i mean the mobile-html-sections.js file
[19:51:35] <bearND>	 where it is on master
[19:51:37] <mdholloway>	 bearND: yep.  makes more sense there.
[20:15:08] <jdlrobson>	 jhobs: please review https://gerrit.wikimedia.org/r/243014 
[20:46:20] <jdlrobson>	 jhobs: around?
[21:30:00] <greg-g>	 jdlrobson: https://phabricator.wikimedia.org/T114417 :)
[21:30:48] <greg-g>	 jdlrobson: the change in pageimage broke MW/Beta Cluster, lego is reverting
[21:33:14] <jdlrobson>	 did reverting fix it?
[21:33:23] <jdlrobson>	 greg-g: we'll take a look and have another go :)
[21:33:40] <greg-g>	 just please baby sit it next time
[21:33:45] <greg-g>	 :)
[21:34:17] <greg-g>	 we're waiting on another merge that was forced past Zuul, which angered the stay puft marshmellow man
[21:34:23] <jdlrobson>	 greg-g: baby sit?
[21:34:35] <greg-g>	 make sure it doesn't break beta after it is deployed there
[21:35:00] <greg-g>	 luckily Elena and Rummana found it because their team's products were broken
[21:35:05] <greg-g>	 respectively
[21:35:09] <greg-g>	 ie: it broke a lot of shit
[21:35:49] <jdlrobson>	 greg-g: i took a look and didn't see anything broken on mobile web. I'll have to look closer at what was causing the issues they ran into
[21:36:12] <greg-g>	 there's more to life than mobile web :P (but yeah, thanks for looking)
[21:36:22] * greg-g moves along with you and lego on it