[05:43:16] <jhobs>	 Driving to DC. I should be back online around 11am phuedx|afk time
[07:26:10] <joakino>	 good morning!
[08:14:48] <phuedx|afk>	 morning y'all
[08:55:11] <joakino>	 how are you doing phuedx 
[09:00:10] <phuedx>	 joakino: alright -- just getting ready to cycle over to old street for beanzzz 4 ams
[09:00:15] <phuedx>	 yourself?
[09:03:57] <joakino>	 phuedx: ready to go :)
[09:05:22] <phuedx>	 \o/
[09:05:27] <phuedx>	 what're you up to this weekend?
[09:07:05] <phuedx>	 hold that thought
[09:07:09] <phuedx>	 back in a bit -- cycling
[09:07:58] <jhobs>	 morning/afternoon/i can't quite tell anymore o/
[09:09:36] <joakino>	 hey jhobs !
[09:09:41] <joakino>	 welcome to europe morning haha
[09:11:28] <jhobs>	 haha thanks. Except it's about 2-3pm to my sleep schedule
[09:11:38] <jhobs>	 haven't quite made it to ams time yet ;)
[09:13:12] <joakino>	 :)
[09:54:56] <phuedx|bike>	 yo
[09:55:21] <phuedx>	 no wifi at the coffee shop
[09:55:22] <phuedx>	 boo
[09:56:52] <phuedx>	 hey jhobs!
[09:57:03] <jhobs>	 what upppp
[09:57:48] <phuedx>	 so now the majority of the team is /working/ close to gmt
[09:57:57] <phuedx>	 can we make all meetings gmt times?
[09:58:39] <jhobs>	 i'm already bad with converting PST to EST, that might just break my brain
[10:01:05] <phuedx>	 brb
[10:01:13] <phuedx>	 eating eggs benedict while doing code review
[10:05:04] <bmansurov>	 yay for GMT meetings
[10:06:30] <jhobs>	 gonna go grab some lunch (a.k.a. breakfast) real quick, so brb
[10:12:27] <phuedx>	 oh
[10:12:29] <phuedx>	 me
[10:12:29] <phuedx>	 oh
[10:12:30] <phuedx>	 my
[10:12:31] <phuedx>	 oh
[10:12:36] <phuedx>	 those eggs were delish!
[10:25:14] <jhobs>	 back, with food!
[10:26:09] <phuedx>	 jhobs: you're a drummer, right?
[10:26:14] <jhobs>	 yessir
[10:26:23] <phuedx>	 any recs for concert ear plugs?
[10:26:33] <phuedx>	 i have a couple lined up
[10:26:42] <jhobs>	 lemme see what you got
[10:26:59] <jhobs>	 (lined up that is)
[10:27:05] <phuedx>	 and after the last one (jakob) the ringing didn't go away
[10:27:21] <jhobs>	 wait
[10:27:24] <jhobs>	 i misunderstood that lol
[10:27:37] <phuedx>	 you may have done ;)
[10:27:39] <joakino>	 bmansurov: how's the visa business going? :S
[10:28:06] <jhobs>	 umm unfortunately I don't really own anything great myself so I probably couldn't give you the best recommendations
[10:28:07] <bmansurov>	 joakino, hey
[10:28:14] <jhobs>	 but lemme take a look
[10:28:24] <bmansurov>	 joakino, it's not ready yet ;(
[10:29:24] <phuedx>	 :s
[10:29:31] * phuedx crosses everything
[10:29:39] <jhobs>	 vic firth isn't bad
[10:29:58] <joakino>	 bmansurov: so you're going to check on monday again? or today?
[10:30:06] <jhobs>	 i use their over-the-ear headphones for casual playing
[10:30:11] <joakino>	 :(
[10:30:20] <jhobs>	 and i have no complaints with those, so i'd imagine the earplugs are of similar quality
[10:30:31] <bmansurov>	 joakino, later today
[10:32:39] <jhobs>	 but tbh phuedx if you have concerts lined up then you'd probably already know better than i would :D
[10:33:00] <jhobs>	 i just drum for fun, can never get enough people together to jam too often
[10:33:19] <phuedx>	 i've been recommended these: http://www.amazon.co.uk/Elacin-ER20S-musicians-hearing-protection-x/dp/B0034ZI9AQ/ref=cm_rdp_product
[10:33:39] <phuedx>	 was just wondering before i pressed the "JUST TAKE MY MONEY" button
[10:35:04] <jhobs>	 i'd imagine you're good with those. Ideally you'd have earbuds and be hooked into the monitor, but idk what your setup is
[10:35:33] <jhobs>	 unless it's an acoustic set
[10:36:22] <phuedx>	 brb
[10:39:16] <jhobs>	 could always go with lightning/hot rod sticks too to reduce piercing/ringing sound if the venue/genre allows for it
[10:50:41] <phuedx>	 question for y'all: would you merge a commit with the commit message "Don't ask. Just merge."
[10:51:22] <jhobs>	 would probably depend on the change
[10:51:25] <joakino>	 most certainly not
[10:51:30] <jhobs>	 although i guess that defeats the purpose
[10:51:44] <joakino>	 for that just do automerge and explain in the comments/commit msg.
[10:51:45] <jhobs>	 plus i don't have +2 so... ;)
[10:52:22] <phuedx>	 i will be having words with our inglorious tech lead: https://gerrit.wikimedia.org/r/#/c/246801/
[10:54:35] <jhobs>	 that I actually would merge, but that's because in a QA-led browser test session last all-hands they said occasionally sleep commands can make artificially failing tests pass
[10:54:53] <phuedx>	 oh don't get me wrong
[10:55:03] <phuedx>	 the actual change i'm fine with
[10:55:12] <phuedx>	 it mirrors the test underneath it
[10:55:31] <phuedx>	 and beta can sometimes grind so hard that the timeouts for these things expire
[10:55:43] <phuedx>	 i take issue with the commit message ;)
[10:55:55] <jhobs>	 ah, I see
[11:00:26] <phuedx>	 wait_until is being removed
[11:00:31] <phuedx>	 from capybara
[11:00:42] * phuedx reads some bloggy blogs
[11:02:24] <phuedx>	 ah
[11:02:32] <phuedx>	 i see now, we're testing for the wrong thing
[11:03:02] <phuedx>	 the init script is the bootstrap script that fires off another request 
[11:03:18] <phuedx>	 testing for the init script to be present isn't indicative of the page having been fully loaded
[11:03:54] <phuedx>	 alright -- i'm caffeinated, have beans for ams, and have had brekkie 
[11:04:06] <phuedx>	 i'm going to cycle home after i post my thoughts on that patch
[11:04:23] <jhobs>	 phuedx: did you still wanna have a chat with me and baha regarding Read More? I'll probably only be working for about another hour or so but i'll be around all (your) day and can hop in a hangout pretty much whenever
[11:04:48] <jhobs>	 (like i said earlier, it's about 4-5pm to my body right now)
[11:05:08] <phuedx>	 jhobs: it'll take me ~30 minutes to get home
[11:05:14] <phuedx>	 hangout then? /cc bmansurov
[11:05:25] <bmansurov>	 ok
[11:05:25] <jhobs>	 works for me!
[11:11:46] <phuedx>	 cool
[11:11:47] <phuedx>	 heading off
[12:02:04] <phuedx_webchat>	 ugh
[12:02:21] <phuedx_webchat>	 irccloud is intollerably slow to load/won't load right now
[12:02:38] <phuedx_webchat>	 they're having network failures
[12:02:45] <phuedx_webchat>	 jhobs, bmansurov: y'all still around?
[12:02:47] <jhobs>	 it kicked me offline a bit earlier
[12:02:52] <jhobs>	 yep
[12:03:01] <bmansurov>	 yes
[12:04:20] <phuedx_webchat>	 i'm on tracy island
[12:06:48] <joakino>	 phuedx|bike: 
[12:06:50] <joakino>	 phuedx_webchat: 
[12:06:53] <joakino>	 WTF
[12:14:41] <bmansurov>	 https://integration.wikimedia.org/ci/job/mwext-testextension-zend/12369/console
[12:15:12] <bmansurov>	 https://gerrit.wikimedia.org/r/#/c/246137/
[12:30:52] <bmansurov>	 hashar, hi, would you please review https://gerrit.wikimedia.org/r/#/c/246818/ ? Thanks
[12:32:35] <hashar>	 bmansurov: hello :)
[12:34:21] <hashar>	 bmansurov: does Cards really depends on MobileFrontend ?  ;D
[12:34:43] <hashar>	 potentially if it could be used standalone, the resource loader might want to skip registration when MF is not around
[12:34:48] <bmansurov>	 hashar, yes I need to use hogan templates for now https://gerrit.wikimedia.org/r/#/c/246137/3
[12:34:57] <hashar>	 ok ok :-}
[12:36:02] <hashar>	 and seems that is the same stuff for relatedArticles :/
[12:36:11] <bmansurov>	 yes
[12:36:14] <bmansurov>	 for now at least
[12:37:32] <hashar>	 we have a job that is triggered by all mobile related extensions
[12:37:39] <hashar>	 maybe Cards and RelatedArticles should be added to it
[12:37:55] <bmansurov>	 hashar, ok, can you tell me where it is?
[12:38:02] <hashar>	 this way, whenever one send a change to say MobileFrontend,  that will runs Cards and RelatedArticles tests
[12:38:06] * hashar digs
[12:38:12] <bmansurov>	 hashar, thanks!
[12:38:20] <hashar>	 and this way you no more have to define the dependencies
[12:38:30] <bmansurov>	 cool
[12:38:38] <hashar>	 bonus point:  MF will not be allowed to break Cards/RelatedArticles
[12:39:37] <hashar>	 bmansurov: in integration/config for Zuul you will want to add the template 'extension-gate'
[12:40:13] <bmansurov>	 hashar, ok
[12:40:13] <hashar>	 which causes it to trigger the "shared" jobs mediawiki-extensions-zend and mediawiki-extensions-qunit
[12:40:18] <hashar>	 then in jjb
[12:40:32] <hashar>	 the job need to be adjusted to also clone Cards/RelatedArticles
[12:40:34] <hashar>	  (sorry that is undocumented :/)
[12:40:50] <bmansurov>	 hashar, and this will help me get rid of the error in https://gerrit.wikimedia.org/r/#/c/246137/3 ?
[12:41:12] <hashar>	 that is in jjb/mediawiki.yaml  there is a list of dependencies with an alias "&gatedextensions"
[12:41:19] <hashar>	 you would want to add Cards and RelatedArticles to it
[12:41:26] <bmansurov>	 ok
[12:42:32] <hashar>	 on the Cards change  https://gerrit.wikimedia.org/r/#/c/246137/ ,  I have commented 'check experimental' which triggers the shared jobs
[12:42:46] <bmansurov>	 cool
[12:42:47] <hashar>	 https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/35981/consoleFull
[12:43:03] <hashar>	 somewhere at the beginning, you will see it clones a bunch of various repositories
[12:43:05] <bmansurov>	 so, once I change jjb/mediawiki.yaml, there is no need for the change in the python file right?
[12:43:27] <hashar>	 that is the  list in  jjb/mediawiki.yaml  &gatedextensions
[12:43:32] <bmansurov>	 yes
[12:43:37] <hashar>	 yup no need to list the deps
[12:43:47] <bmansurov>	 great
[12:43:50] <hashar>	 so originally, we added that dependency system as a hack
[12:44:21] <hashar>	 and I eventually came up with a jobs that clone X repositories and is triggered by all those X repositories
[12:44:28] <bmansurov>	 i see
[12:44:41] <hashar>	 on https://gerrit.wikimedia.org/r/#/c/246137/
[12:44:57] <hashar>	 you will see the shared job   mediawiki-extensions-* are passing properly
[12:45:32] <hashar>	 so in Zuul layout,   you can add the  'mediawiki-gate'  template   and we will want to remove the more specific jobs that are now useless ( mwext-testextension*  cause they fail)
[12:46:35] <bmansurov>	 ok
[12:46:36] <hashar>	 sorry it is all complicated with lot of moving / legacy part overlapping :-((((
[12:46:47] <bmansurov>	 np, thanks for helping
[12:47:08] <bmansurov>	 hashar, should I remove extension-unittests-generic too?
[12:48:02] <hashar>	 yeah that one bring the   mwext-testextension* jobs   which rely on the python dependency list
[12:48:06] <hashar>	 but the template also add a bunch of other jobs
[12:48:26] <bmansurov>	 ok
[12:48:41] <hashar>	 I am looking at the available templates
[12:50:24] <hashar>	 bmansurov: so yeah  drop  extension-unittests-generic
[12:50:35] <hashar>	 and replace it with:   composer-test
[12:50:39] <hashar>	 and   extension-gate
[12:50:54] <hashar>	 extension-unittests-generic  is a super set of composer-test
[12:51:10] <bmansurov>	 ok
[12:51:49] <hashar>	 anything that rely on the python script to inject dependencies should probably be migrated the same way and then we can remove the lame dependency injecter.   But lets make sure Cards is passing first
[12:51:54] <hashar>	 i can deal with the migration of the rest
[12:52:03] <phuedx>	 joakino: i have multiple presences
[12:52:07] <phuedx>	 just for funsies
[12:52:16] <bmansurov>	 hashar, updated the patch
[12:53:32] <hashar>	 the crazy Zuul change can be seen more or less at https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/6044/console
[12:53:38] <hashar>	 though that is 13MBytes :D
[12:54:27] <hashar>	 bmansurov: ah my bad
[12:54:35] <hashar>	 bmansurov:  s/mediawiki-gate/extension-gate/
[12:54:36] <hashar>	 sorry
[12:54:44] <bmansurov>	 np, 1 sec, I'll repush
[12:55:13] <bmansurov>	 done
[12:56:35] <hashar>	 waiting for the job to complete
[12:57:53] <hashar>	 bmansurov: slightly more readable https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/6045/consoleFull
[13:00:16] <bmansurov>	 hashar, i suppose texts in red are errors?
[13:00:23] <hashar>	 oh
[13:00:24] <hashar>	 that is a diff
[13:00:25] <hashar>	 sorry
[13:00:31] <bmansurov>	 ok
[13:00:42] <hashar>	 what the job does is it ask Zuul to output its workflow layout with HEAD^ 
[13:00:49] <hashar>	 then with the proposed patch (HEAD)
[13:00:52] <hashar>	 and does a colordiff -u
[13:01:08] <bmansurov>	 additions should be marked with green imo ;)
[13:01:10] <hashar>	 that is the poor man way of comparing what is the result of a change to zuul/layout.yaml
[13:01:12] <hashar>	 yeah
[13:01:35] <hashar>	 we really need a better diff system though
[13:02:10] <hashar>	 deployed!
[13:02:12] <bmansurov>	 i know next to nothing how these things are set up, so I trust you when you say we do ;)
[13:02:14] <bmansurov>	 thanks!
[13:02:17] <hashar>	 so you can now 'recheck' both patches
[13:02:21] <hashar>	 and hope it is passing :-}
[13:02:54] <hashar>	 having to trust me is a bit of a trouble for CI / the community :-(
[13:03:07] <hashar>	 we are slowly removing dependencies though
[13:03:38] <bmansurov>	 i see
[13:03:52] <hashar>	 I rechecked both
[13:03:58] <bmansurov>	 thanks
[13:04:02] * hashar cross fingers
[13:04:29] <bmansurov>	 joakino, btw, got my visa
[13:07:11] <bmansurov>	 hashar, i suppose the failure it not related to the patch?
[13:07:48] <hashar>	 for related articles https://gerrit.wikimedia.org/r/#/c/246463/  , nop
[13:07:57] <hashar>	 that was a left over git lock file
[13:08:04] <hashar>	 known bug that happens from time to time ;-/
[13:08:32] <bmansurov>	 ok
[13:08:36] <bmansurov>	 thanks again, hashar 
[13:08:45] <bmansurov>	 gonna rest up a little bit before meetings later today
[13:09:04] <hashar>	  Warning: mysql_real_escape_string() expects parameter 1 to be string, array given in /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/db/DatabaseMysqli.php  
[13:09:06] <hashar>	 :(((
[13:09:12] <hashar>	 whatever it can mean
[13:09:18] <bmansurov|away>	 oh no
[13:09:23] <hashar>	 that is from https://gerrit.wikimedia.org/r/#/c/246463/
[13:09:32] <hashar>	 which seems totally unrelated
[13:09:43] <bmansurov|away>	 ok i'll recheck later, maybe that'll help
[13:11:01] <hashar>	 ahh
[13:11:38] <hashar>	 one of the two extensions i breaking it
[13:12:32] <hashar>	 and I am pretty sure it is RelatedArticles
[13:24:43] <phuedx>	 hashar: looks like it
[13:24:50] <hashar>	 definitely https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/35991/console
[13:25:07] <hashar>	 that is the shared job  mediawiki-extensions-hhvm  with RelatedArticles being injected to it
[13:25:12] <hashar>	 (via  'check experimental'
[13:25:32] <hashar>	 https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/35991/testReport/
[13:25:44] <hashar>	 seems RelatedArticles causes Echo / Flow to fail among others
[13:25:50] <phuedx>	 hashar: any way i can get a stack trace out of it?
[13:26:10] <hashar>	 each test result should have more or less a stacktrace
[13:26:38] <hashar>	 seems they all get DeferredUpdates.php
[13:26:49] <phuedx>	 mibad
[13:26:59] <phuedx>	 skimmed over it because it's hella spammy
[13:28:27] <hashar>	 the usual cause for test breaking is when one of the extension hook in mw core
[13:28:32] <hashar>	 and change its behavior
[13:28:47] <hashar>	 then the tests of others extensions fails because the mw/core "contract" has been altered
[13:31:55] <hashar>	 trying to repro
[13:32:44] <phuedx>	 hashar: got it i think
[13:32:56] <phuedx>	 > then the tests of others extensions fails because the mw/core "contract" has been altered
[13:33:26] <phuedx>	 must remember to return true from hooks
[13:33:37] <phuedx>	 nice catch test harness!
[13:35:57] <jhobs>	 phuedx: is there a way to format something as code in a gerrit comment?
[13:36:11] <phuedx>	 jhobs: sorta
[13:36:12] <hashar>	 ohh
[13:36:16] <phuedx>	 put four spaces in front of it
[13:36:16] <hashar>	 phuedx: so have you solved it ? 
[13:36:22] <jhobs>	 thanks
[13:36:22] <phuedx>	 hashar: yup
[13:36:43] <phuedx>	 you put me on the right track with the core <-> extensions comment
[13:39:04] <hashar>	 Warning: bin2hex() expects parameter 1 to be string, array given in /Users/amusso/projects/mediawiki/core/includes/db/DatabaseSqlite.php on line 817
[13:39:05] <hashar>	 huhu
[13:40:02] <hashar>	 no clue where this one comes from
[13:40:43] <phuedx>	 wha!?
[13:40:51] <hashar>	 unrelated
[13:40:55] <phuedx>	 same issue different db driver?
[13:41:02] <hashar>	 my php / mediawiki setup are most probably broken
[13:41:30] <phuedx>	 jhobs: re: the gateway stuff, it certainly has been renaming a lot of the api classes
[13:41:38] <phuedx>	 but also getting rid of the inheritance hierarchy
[13:41:51] <phuedx>	 you'll notice that the gateways are pojos
[13:42:09] <phuedx>	 and compose rather than extend
[13:42:16] <phuedx>	 *inherit
[13:42:40] <jhobs>	 I understand it gets rid of the inheritance, but it still seems like the process one has to go through to perform the desired actions is a bit more convoluted than it could be
[13:43:01] <jhobs>	 like you still would have to have a pretty good idea of how the api works
[13:43:16] <jhobs>	 rather than just "gateway.giveMeTheShitIWant()"
[13:43:57] <jhobs>	 more looking to start a discussion than block; maybe it's something we can bring up in Ams
[13:46:03] <hashar>	 seems related articles inject an array somewhere :-/
[13:50:53] <hashar>	 phuedx: found it. Seems that is caused by RelatedArticles hook onParserClearState
[13:51:00] <hashar>	 $parser->getOutput()->setProperty( 'RelatedArticles', array() );
[13:51:13] <hashar>	 that injects an array somewhere which eventually tries to be quoted with sqlite addQuotes()
[13:51:24] <hashar>	 but that one rejects array
[13:51:48] <phuedx>	 jhobs: i agree -- the gateways need /a lot/ of work
[13:52:24] <phuedx>	 f'rinstance, appearing to operate on pages but not taking instances of Page
[13:52:25] <jhobs>	 phuedx: yeah, I'll comment again to clarify my intentions though
[13:52:27] <phuedx>	 returning objects
[13:52:54] <phuedx>	 well, /not instances of the objects to which they refer/
[13:53:07] <phuedx>	 so { foo: bar } as opposed to mw.Title
[13:53:35] <phuedx>	 hashar: hrrm
[13:53:36] <phuedx>	 sec
[13:54:14] <hashar>	 I can reproduce with sqlite  and having solely Echo and RelatedArticles . If I comment out the above line it is all fine.  Maybe I should just fill a task about it ?
[13:55:13] <phuedx>	 hashar: that's a bug
[13:55:19] <phuedx>	 i'd be delighted to fix it for you
[13:55:23] <hashar>	 I have no idea
[13:55:28] <phuedx>	 but please raise a task :)
[13:55:34] <hashar>	 I worked hard and forgetting everything I knew about php
[13:55:41] <phuedx>	 lol
[13:56:30] <phuedx>	 hashar: you'll see that in onFuncRelated we use $parserOutput->setExtensionData
[13:56:34] <hashar>	 I am looking toward https://ooc-lang.org/   (looks like PHP, generates pure C)
[13:56:35] <hashar>	 and haskell!
[13:56:49] <phuedx>	 we should be using setExtensionData in the onParserClearState hook handler too
[13:58:49] <phuedx>	 hashar: looks interestin
[13:58:55] <phuedx>	 does nim compile to c99
[13:59:11] <phuedx>	 looks like python, generates c :D
[13:59:36] <jhobs>	 hashar phuedx: I like the line at the bottom: "If you use ooc and like it, please consider showing your token of support by smiling at your screen."
[14:00:12] <phuedx>	 "Discovering new ways of perceiving, designing, and manufacturing pieces of software is always a worthy pursuit."
[14:04:03] <hashar>	 phuedx: filled at https://phabricator.wikimedia.org/T115698
[14:05:33] <hashar>	 ah http://c7.se/from-go-to-ooc/
[14:06:21] <jhobs>	 ok, hopping off. Might pop back in on some of the patches this weekend and/or on the plane. See you reading web folks on Monday!
[14:08:45] <hashar>	 jhobs|afk: have a good week-end
[14:14:02] <phuedx>	 later jhobs|afk 
[14:22:04] <phuedx>	 hashar: the build looks good to me on https://gerrit.wikimedia.org/r/#/c/246836/
[14:22:51] <hashar>	 ahh
[14:23:45] <hashar>	 phuedx: has it ever been pushed to prod?
[14:24:37] <phuedx>	 hashar: hrrm -- it's on beta and on wikivoyage
[14:24:45] <phuedx>	 i'll add in a thing to remove the parser output property
[14:24:48] <hashar>	 I am wondering if it causes any havoc there
[14:24:56] <hashar>	 and if we will need to cleanup something from the databases
[14:25:23] <hashar>	 I am not sure what happens with  $parser->getOutput()->setProperty( 'RelatedArticles', array() );  and a MySQL database
[14:25:31] <hashar>	 maybe it just spurts a warning
[14:25:40] <hashar>	 and in this case nothing is inserted in the db so we are all fine :-}
[14:26:14] <phuedx>	 hashar: i'll have to take a look at grafana
[14:26:23] <phuedx>	 brb
[14:26:36] <hashar>	 there is another setProperty down in onOutputPageParserOutput()
[14:26:54] <hashar>	 so maybe the clear was intentional
[14:26:57] <hashar>	 commenting on gerrit
[14:27:21] <phuedx>	 hashar: different object, duplicate method name ;)
[14:27:29] <phuedx>	 but go for it
[14:31:38] <phuedx>	 hashar: actually, i think it's going out next week
[14:31:56] <hashar>	 yeah that is a bit of a mess
[14:32:07] <hashar>	 there is a ParserOutput->unsetProperty()
[14:32:15] <hashar>	 but no such thing in OutputPage class
[14:32:23] <phuedx>	 outputpage is no biggy
[14:32:46] <phuedx>	 hashar: https://gerrit.wikimedia.org/r/#/c/244379/ is included in master, wmf/1.27.0-wmf.3
[14:33:10] <phuedx>	 we're on wmf.2 iirc
[14:33:21] <dbrant>	 mdholloway: got a minute for hangout regarding the image licenses?
[14:33:37] <mdholloway>	 dbrant: sure, omw
[14:33:41] <phuedx>	 nevertheless, due diligence!
[14:33:52] <mdholloway>	 dbrant: after i locate my headphones, that is
[14:35:48] <hashar>	 phuedx: if only we had tests :-}
[14:38:11] <phuedx>	 quiet you!
[16:37:03] <phuedx>	 ugh
[16:37:48] <phuedx>	 i had to dash off because my wife had to go to the hospital for a blood test
[16:37:52] * phuedx sighs
[16:41:43] <joakino>	 phuedx: alright changing cities pre-trip
[16:41:49] <joakino>	 see you in ams!
[16:41:53] <phuedx>	 later!
[16:54:20] <phuedx>	 dr0ptp4kt: having network issues
[17:15:49] <mbinder>	 mhurd_afk: mdholloway niedzielski dbrant all by my lonesome in standup
[17:22:31] <phuedx|afk>	 going to get the kids ready for bed
[18:23:10] <DanielK_WMDE_>	 Hi all! In the context of the discussion around displaytitle and wikidata labels, I have investigated a bit, and found that core indeed treated displaytitle as HTML. 
[18:23:13] <DanielK_WMDE_>	 Related patch: https://gerrit.wikimedia.org/r/#/c/246878/
[18:24:01] <DanielK_WMDE_>	 The fix in the API module is trivial enough, but I'm afraid in its current form, this will cause a lot of double escaped output. If you can tell me how to avoid that, please comment on the ticket.
[18:40:34] <FlorianSW>	 DanielK_WMDE_: I think, that the mobileview api isn't really used in mobile web, it's used in mobile apps, as far as I know (where displaytitle is used, too). AFAIK, MobileFrontend doesn't use the displaytitle prop of the mobileview api.
[18:42:44] <DanielK_WMDE_>	 *sigh*
[18:42:47] <DanielK_WMDE_>	 more fun dependencies
[18:42:56] <DanielK_WMDE_>	 can you add the relevant people to the ticket?
[18:44:18] <DanielK_WMDE_>	 this is a breaking change to the api. well, or a fixing change, depending on your perspective
[18:53:11] <FlorianSW>	 DanielK_WMDE_: sure (I assume, you mean the change :))
[18:55:45] <DanielK_WMDE_>	 FlorianSW: yes, indeed. but now it seems like we actually need to track this in a ticket....
[18:56:02] <DanielK_WMDE_>	 would you create one? I'm a bit at a loss about the appropriate tags/projects to use, people to ping, etc.
[18:57:15] <FlorianSW>	 DanielK_WMDE_: would you like to create the ticket and let me add project(s) and CCs? :P I'm not entire sure, if I understand correctly what use case you want to fix :]
[18:57:37] <FlorianSW>	 therefore it seems better, if you describe it in phabricator :)
[18:57:41] <DanielK_WMDE_>	 ok
[18:58:08] <FlorianSW>	 great, thanks!
[19:05:22] <DanielK_WMDE_>	 FlorianSW: https://phabricator.wikimedia.org/T115747
[19:06:09] <FlorianSW>	 DanielK_WMDE_: seen already on #wikimedia-dev I accidently removed your project (Wikipedia-App-MobileApp-extension), thanks phabricator. Let me check, if this is really needed :)
[19:06:42] <DanielK_WMDE_>	 FlorianSW: no idea what tag the app people use...
[19:07:06] <DanielK_WMDE_>	 FlorianSW: does the description on the ticket make sense to you?
[19:07:07] <FlorianSW>	 ah, ok, no, this project is for the mobile app ext (https://github.com/wikimedia/mediawiki-extensions-MobileApp) :)
[19:07:19] <DanielK_WMDE_>	 as opposed to the actual app?...
[19:07:23] <DanielK_WMDE_>	 i'm so confused
[19:07:31] <DanielK_WMDE_>	 so, what tag would the actual app use?
[19:09:13] <FlorianSW>	 Wikipedia-Android-App for the android app and Wikipedia-iOS-App-Product-Backlog (I think), I added Mobile-Apps, too, to make sure, that iOS people see this task :)
[19:09:34] <FlorianSW>	 the mobile app extension provides styles for the apps, only.
[19:10:19] <FlorianSW>	 DanielK_WMDE_: yes, the description makes sense (that's what I thought before, too, so: great commit message! :))
[19:10:35] <DanielK_WMDE_>	 \o/
[20:36:12] <mdholloway>	 niedzielski: ok
[22:30:11] <dr0ptp4kt>	 FlorianSW|away & DanielK_WMDE_ i just added Wikipedia-ios-App-Development to that task and added JoshM (jminor) and bgerstle_afk  to the CC. i had added bgerstle_afk and niedzielski to the corresponding gerrit patch
[22:31:18] <dr0ptp4kt>	 JoshM: i realize that's maybe not the best place for the task, please throw a foam soccer ball at me if i should tag it differently
[22:32:27] <JoshM>	 dr0ptp4kt: nope thats fine. I'll move it into our Tracking column...