[02:00:54] <cortex_>	 hello
[04:02:07] <Nicolas_Raoul>	 Hello niedzielski-afk :-) Would you mind adding your usual timezone to https://phabricator.wikimedia.org/T115101? Looking forward to working with you!
[04:02:53] <Nicolas_Raoul>	 sorry https://phabricator.wikimedia.org/T114358
[15:20:21] <bgerstle>	 niedzielski: you around?
[15:20:31] <niedzielski>	 bgerstle: yeppers
[15:20:44] <niedzielski>	 what's up?
[15:20:45] <bgerstle>	 niedzielski: so, i'd like to verify that DISPLAYTITLE patch as well
[15:21:05] <niedzielski>	 bgerstle: oh right. maybe we can do a batcave or something and chat a bit?
[15:21:08] <bgerstle>	 yeah
[15:21:10] <bgerstle>	 that'd be great
[15:21:16] <niedzielski>	 you free now?
[15:21:17] <bgerstle>	 is now an OK time, or do you want to do it later?
[15:21:19] <bgerstle>	 yeah, sure
[15:21:24] <niedzielski>	 ok cool. omw
[15:43:24] <FlorianSW>	 dbrant: do you know, when the fix for https://phabricator.wikimedia.org/T109983 goes out to prod?
[15:44:31] <dbrant>	 FlorianSW: we're hoping to release a new Beta this week; so hopefully will make it to production a week after that.
[15:44:54] <dbrant>	 FlorianSW: we're watching this one closely; it's the top source of negative reviews currently.
[15:45:03] <FlorianSW>	 ah, ok, I'm sure you will sent a notice to mobile-l and mention the bug?
[15:45:08] <FlorianSW>	 oops, ok :/
[15:45:13] <dbrant>	 yep
[15:45:17] <FlorianSW>	 Hopefully this will solve the problem :)
[15:45:43] <FlorianSW>	 I want to write the reporter of the bug an e-mail and ask, if the new version solves the problem :) (and this requires, that the fix is included in a prod release :P)
[15:45:52] <FlorianSW>	 great, thanks dbrant!
[15:47:34] <dbrant>	 niedzielski: any unexpected trouble with DISPLAYTITLE?
[15:48:36] <niedzielski>	 dbrant: none that i saw but my testing was very light
[15:50:28] <dbrant>	 niedzielski: I tested it by hard-coding a Page displaytitle to contain the HTML entities that could be returned by the htmlspecialchars() function, and it looks like Android's fromHtml() handles them correctly.
[15:51:16] <niedzielski>	 dbrant: nice! if you want, share the test string and i'll dump it into my local vagrant
[15:51:51] <niedzielski>	 dbrant: probably not necessary but happy to try it out if you like
[15:52:29] <dbrant>	 niedzielski: i'm pretty sure it's not necessary...
[15:52:41] <dbrant>	 (famous last words)
[15:52:46] <niedzielski>	 :)
[15:59:35] <bgerstle>	 niedzielski: made some progress w/ vagrant, but QQ: where are the submodules cloned?
[16:00:10] <niedzielski>	 bgerstle: i think it's just in the root vagrant install: git submodule update --recursive --init
[16:00:27] <bgerstle>	 "root vagrant install" you mean the mediawiki-vagrant repo?
[16:00:38] <bgerstle>	 or do i need to ssh into the box?
[16:00:52] <niedzielski>	 bgerstle: yes, wherever you cloned the root repo, https://gerrit.wikimedia.org/r/mediawiki/vagrant
[16:00:57] <bgerstle>	 ok
[16:00:59] <bgerstle>	 thought i tried that
[16:01:08] <bgerstle>	 it's downloading the trusty vbox now, so might be a while
[16:01:33] <niedzielski>	 bgerstle: after you do a vagrant up, you can do ./setup.sh and "vagrant git-update", i think
[16:01:56] <niedzielski>	 just make sure you check out the right patch in the end
[16:02:02] <niedzielski>	 that's all stuff just to get the box up to date
[16:02:07] <bgerstle>	 i already did ./setup.sh
[16:24:22] <yurik>	 dbrant, hi, what do you think of the ideas for Nearby in https://phabricator.wikimedia.org/T113827
[16:26:14] <dbrant>	 yurik: love 'em. We'll get around to it eventually. I'll also loop in Kaity and Nirzar on that task, to give them inspiration for mockups.
[16:27:39] <yurik>	 dbrant, what is the timeline to get map nearby to production version?
[16:27:52] <yurik>	 (seems that the servers can support them just fine)
[16:31:14] <dbrant>	 yurik: it needs just a bit more UX polish to be production-worthy. I'm guessing it will be two production releases from now. (with the next one being end of next week)
[17:41:14] <dr0ptp4kt>	 dbrant: what's the url for the android goals (phab/mw/other)?
[17:41:47] <niedzielski>	 dr0ptp4kt: you mean this guy? https://phabricator.wikimedia.org/tag/mobile-app-goals/
[17:42:13] <dr0ptp4kt>	 niedzielski: is this the thing dbrant said he updated the other day?
[17:42:58] <niedzielski>	 dr0ptp4kt: hm, maybe a better question for dbrant after all :) i know he made this board quite recently, so i would _guess_ yes
[18:03:27] <dbrant>	 dr0ptp4kt: hey, sorry; Yes, that Phab board is the one to look at for the Epics we're working on. There's also this spreadsheet where the goals had been drafted: https://docs.google.com/a/wikimedia.org/spreadsheets/d/13aLsGMMXirC5oYmc_N_6s-UW1ZjcidhcIKdgL05ZuMk/edit?usp=sharing
[18:13:38] <coreyfloyd>	 etonkovidova: when you are filing bugs can you put them on the product backlog board instead of the development board? https://phabricator.wikimedia.org/tag/wikipedia-ios-app-product-backlog/
[18:13:59] <etonkovidova>	 coreyfloyd: sure
[18:14:28] <coreyfloyd>	 etonkovidova: thanks! (it may have been different the last time you did QA  -we made some process changes)
[18:15:23] <etonkovidova>	 coreyfloyd: np! I was just trying to make "Regression" bugs more visible by putting them on Dev board ... 
[18:16:11] <coreyfloyd>	 etonkovidova: ok - Josh probably doesn't look in the dev column to triage bugs - so if you put them there they may get ignored
[18:16:38] <etonkovidova>	 coreyfloyd: I see :)
[18:17:24] <coreyfloyd>	 etonkovidova: if you think something is really important, I would ping Josh after you file it to make sure he addresses it quickly.
[18:18:33] <etonkovidova>	 coreyfloyd: ok -  understood. Usually, yes, if something is important enough, I talk to someone directly 
[18:36:00] <yurik>	 dbrant, could you check the status of https://phabricator.wikimedia.org/T113829
[18:36:11] <yurik>	 can we do something to help?
[18:38:51] <dbrant>	 yurik: so basically, we would need to include the unique app install ID along with each tile request?
[18:39:29] <yurik>	 dbrant, i think something should be included in the useragent if i uderstood it correctly
[18:39:35] <yurik>	 looking...
[18:41:34] <yurik>	 dbrant, yes, i think we should force mapbox to pass wiki app UUID together with the mapbox's sdk version
[18:41:52] <yurik>	 i don't think its a good idea to have a different identifying method specifically for the app
[18:42:06] <yurik>	 because that would mean we would have to hack varnsh, and ops don't like that )
[18:42:51] <dbrant>	 yurik: so you mean put the UUID in the useragent, correct?
[18:43:00] <yurik>	 dbrant, yep
[18:43:15] <yurik>	 dbrant, ideally we should have both - mapbox info and uuid
[18:43:20] <dbrant>	 I think that's probably doable.
[18:44:02] <yurik>	 dbrant, uuid should probably be the "main" UA, with the mapbox sdk version being included somewhere inside
[18:44:18] <yurik>	 just like you have it for all other requests
[18:46:16] <dbrant>	 yurik: not sure what you mean there; we currently don't put the uuid in the UA...
[18:46:39] <yurik>	 dbrant, what do you have in the UA?
[18:47:20] <dbrant>	 yurik: Right now the UA is of the form "WikipediaApp/[version] (Android [version])"
[18:49:10] <yurik>	 dbrant, i don't want to add any user-identifying info beyond what is being passed by other webrequests. So simply add MapboxSDK [version] right after Android
[18:49:35] <yurik>	 yes, we won't be able to track unique users, but that's preferable to sacrificing privacy
[18:49:48] <dbrant>	 yurik: right; I think we can do that
[18:50:26] <yurik>	 dbrant, excellente, thanks!  do you want to create a separate task for it?
[18:50:44] <dbrant>	 yurik: yep, will do
[18:50:54] <yurik>	 thx!
[19:09:11] <yurik>	 dbrant, sec, i'm a bit confused - so you ARE sending UUID with all requests?
[19:18:17] <FlorianSW>	 dbrant: can you say me, how you've created the new WP logo image in the app? https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/res/drawable-xxhdpi/w_nav_mark.png :)
[19:28:49] <dbrant>	 yurik: we are sending the UUID with all MW API requests. But we would need to add it to the MapBox requests separately, though.
[19:30:06] <dbrant>	 FlorianSW: there was a .SVG file for it.... but now I can't seem to find it.
[19:31:41] <FlorianSW>	 dbrant: damn :( It looks great and I would use it as a base for another project (without the W and another logo in it) :/ But my graphic experience isn't good enough to figure out, how to change the png in a nice way, without loosing the awesomness of the base.
[19:32:29] <dbrant>	 FlorianSW: oh wait, it's this: https://github.com/wikimedia/apps-android-wikipedia/blob/master/icon-svgs/128/w_nav_mark.noflip.svg
[19:33:55] <FlorianSW>	 dbrant: ahh, great! You're my star today :P
[19:37:25] <dbrant>	 ;)
[19:55:01] <dbrant>	 bearND: i'm ready to merge the sdk-23 patch, if you don't object
[20:14:37] <bearND>	 dbrant: I just merged it
[20:14:47] <dbrant>	 o/
[20:34:56] <niedzielski>	 mdholloway: is T116006 a regression of https://gerrit.wikimedia.org/r/#/c/247100/ or present in master?
[20:37:01] <mdholloway>	 niedzielski: unfortunately, i'm not sure, since i haven't figured out exactly how to repro it to check on master.
[20:37:34] <niedzielski>	 mdholloway: ok cool. i'll see if i have any luck
[21:10:52] <niedzielski>	 mdholloway bearND dbrant|brb: i'm noticing some WebView flickering on my (super slow) API 19 device. is this just me or are other folks seeing it?
[21:11:16] <niedzielski>	 only on long articles like obama
[21:11:37] <niedzielski>	 i think it's the hardware acceleration change :|
[21:12:15] <mdholloway>	 niedzielski: hmm, i haven't, but i have noticed some *severe* slowdown on my nexus 9 (which bernd isn't seeing on his)
[21:16:38] <niedzielski>	 mdholloway: can you try something for me on your nexus 9? remove android:layerType="hardware" from the webview in fragment_page.xml
[21:16:53] <niedzielski>	 mdholloway: it seems to have cleared up my flicker issue :(
[21:18:58] <niedzielski>	 mdholloway bearND dbrant|brb: something really weird is going on with the search box too. sometimes when i enter a single letter, several pour in at once
[21:19:20] <mdholloway>	 niedzielski: of course it's working fine now; i'll try next time it seems bogged down
[21:19:43] <niedzielski>	 mdholloway bearND dbrant|brb: and the backspace key seems to repeat all caharacters?
[21:19:52] <niedzielski>	 this is bananas
[21:20:51] <mdholloway>	 niedzielski: i definitely haven't seen anything amiss with the search box.  
[21:21:06] <niedzielski>	 like i type "w", then "a", and it jumps to "wwa". i hit back space and get "ww". then backspace again and get "www"
[21:21:25] <niedzielski>	 mdholloway:guess i'll try rebooting... :)
[21:26:32] <niedzielski>	 ok, switched to master and did a reboot. both flickering and the keyboard issue are present :(
[21:26:48] <dbrant>	 niedzielski: yep, i'm seeing the keyboard issue. likely a result of the text-filter patch
[21:29:38] <niedzielski>	 dbrant mdholloway: ok and just reconfirmed flickering resolves when i turn off hardware accel :|
[21:33:43] <dbrant>	 i'm not, however, seeing flickering on my devices (api 18 and 19).
[21:36:07] <mdholloway>	 i haven't noticed any slowdown on my api 19 device, either. 
[21:37:49] <niedzielski>	 my api 19 device is exceptionally slow. slow as in, i check my notifications while i wait for apps to launch
[21:40:35] <mdholloway>	 niedzielski: yeah, that sounds like how my nexus 9 has (usually) been lately.  like, can count on an ANR popup just trying to expand the quick facts
[22:07:11] <niedzielski>	 mdholloway|afk dbrant|afk: hm, no flickering on my galaxy note ii (api 19)
[22:15:45] <etonkovidova>	 dbrant: niedzielski: so the issue with keyboard is a known one? I filed it as https://phabricator.wikimedia.org/T116091 [Regression 2.0.131-alpha-2015-10-20] Attempting to enter search criteria produces 'The server could not complete the request'
[22:26:01] <niedzielski>	 etonkovidova: different keyboard issue i think
[22:27:08] <etonkovidova>	 niedzielski: sigh - ok. Looks very dramatic...
[22:27:44] <niedzielski>	 etonkovidova: i have seen this issue you describe on the API 23 emulator i think after booting up. looks like it's not emulator only :(
[22:28:15] <etonkovidova>	 niedzielski: sigh again :(