[14:47:03] <niedzielski>	 bearND|afk dbrant mdholloway: hello! friendly bump to review open patches. i've got 5 ready for review
[14:48:29] <dbrant>	 niedzielski: not necessary for beta, right?
[14:48:44] <niedzielski>	 dbrant: none are necessary, all would be nice
[14:49:06] <mdholloway>	 niedzielski: dbrant: yeah, i can have a look at any I haven't already but i figured we were holding off on non-user-facing stuff 'til after the beta release
[14:49:55] <niedzielski>	 mdholloway: i wasn't sure either. i figured if we're going to do a ton of testing, it'd be nice to have these changes benefit from that rather than continue rebasing
[15:13:29] <dbrant>	 mdholloway: good catch
[15:13:36] <mdholloway>	 dbrant: thanks :)
[16:02:07] <niedzielski>	 dbrant mdholloway bearND: if you use gradlew installDevDebug or similar, watch out. it looks like this silently fails when multiple devices are connected and one misses an upload
[16:02:47] <bearND>	 niedzielski: good to know. thanks
[16:09:44] <niedzielski>	 dbrant mdholloway bearND: ok i'm going to kick of ye ole beta build once that preferences patch finishes merging. any objections?
[16:10:15] <dbrant>	 niedzielski: g2g
[16:10:54] <mdholloway>	 niedzielski: go for it!
[16:20:51] <bearND>	 niedzielski: what about the other patches?
[16:21:04] <bearND>	 i mean your other patches
[16:21:23] <bearND>	 i might have a styling patch coming up that would be nice to have as well
[16:21:28] <niedzielski>	 bearND: looks like there going to take a while to push through. feel free to review
[16:21:47] <niedzielski>	 bearND: does the styling patch have any dependencies?
[16:22:08] <bearND>	 niedzielski: no. but it's useful for when we switch to Parsoid
[16:22:41] <niedzielski>	 bearND: cool, if it's going to be too far out, i'd be happy to wait for it
[16:22:50] <niedzielski>	 not going*
[16:24:23] <etonkovidova>	 bgerstle: yesterday as I said, I installed 5.0.0.434 from TestFlight on iPhone 5 (9.0.2), but it seems that I cannot install it on mini iPad with 8.2
[16:24:54] <etonkovidova>	 bgerstle: https://rink.hockeyapp.net/manage/dashboard displays to me  only a beta version last updated on Oct 16
[16:25:54] <bgerstle>	 etonkovidova: we're not releasing stuff under "Wikipedia Beta" yet
[16:26:14] <bgerstle>	 you should be able to download on any device via TestFlight as long as you're signed in with the same AppleID
[16:33:02] <wikinaut>	 hello
[16:33:19] * niedzielski is excited and terrified at the thought of accurate crash reporting
[16:33:33] <dbrant>	 hey wikinaut!
[16:33:41] <wikinaut>	 hi dbrant 
[16:33:49] <niedzielski>	 welcome! :)
[16:33:52] <wikinaut>	 (now, I am landed here.....)
[16:34:09] <wikinaut>	 I am in Berlin, where are you?
[16:34:30] <dbrant>	 the States (Ohio)
[16:34:35] <niedzielski>	 i'm near denver, colorado in the states as well
[16:34:57] <bearND>	 Willkommen, wikinaut!
[16:35:22] <etonkovidova>	 bgerstle: yes, I am able to download - but I am not able to open it on iPad mini
[16:35:24] <mdholloway>	 hey wikinaut!
[16:35:38] <mdholloway>	 in Michigan USA here
[16:35:49] <bgerstle>	 etonkovidova: from TF? what happens when you try to open?
[16:36:24] <niedzielski>	 bearND dbrant mdholloway: hey! i'm working on the ol release notes while bernd finishes his styling changes. feel free to participate early. otherwise i'll hit you up closer to publishing time
[16:36:25] <wikinaut>	 (being again part of a large family...)
[16:37:02] <etonkovidova>	 bgerstle: when I click on 'open' from TF, the initial  screen with wiki logo appears and disappears immediately 
[16:37:04] <wikinaut>	 BTW: the app is very nice. I always have bugs or suggestion, but the app I (close to be) perfect
[16:37:14] <wikinaut>	 s/I/is/
[16:37:17] <bearND>	 niedzielski: dbrant mdholloway : i've pushed a couple of patches to change styles. The first one is to update to the latest from MobileFrontEnd, then second one is to get an extra module loaded which is needed for Parsoid content.
[16:37:27] <wikinaut>	 (standby)
[16:37:50] <bearND>	 The main concern is actually in the first patch, looks like the top/bottom margin around content was reduced
[16:37:50] <bgerstle>	 etonkovidova: i have an idea for what that might be
[16:38:10] <bgerstle>	 mhurd_afk: just changed something that would insta-crash on iOS 8, stand by for the next build. we should be merging his PR early today
[16:38:34] <bgerstle>	 etonkovidova: sorry you had to encounter it, but glad someone's testing on iOS 8 ;-)
[16:38:43] <bgerstle>	 etonkovidova: it has to do w/ 3D touch stuff that was added recently
[16:39:56] <etonkovidova>	 bgerstle: thx!
[16:40:17] <bearND>	 The patch that changed this is in MFE https://gerrit.wikimedia.org/r/#/c/238382/
[16:40:51] <bgerstle>	 etonkovidova: this is an interesting case for our acceptance criteria discussion yesterday ;-)
[16:40:57] <bgerstle>	 "As a user, I should be able to run the app on iOS 8"
[16:41:13] <etonkovidova>	 bgerstle: I tried to diversify my testing :) iPhone with ios 9 and ipad with ios 8 (I like iPad mini! - it's cute)
[16:41:13] <bgerstle>	 which is something we should check every time we do something iOS 9 specific
[16:41:21] <bgerstle>	 etonkovidova: hehe yeah it's nice
[16:41:31] <bgerstle>	 better than those ANDROID TABLETS amirite? ;-)
[16:41:33] <bgerstle>	 hey guys 👋
[16:41:48] <niedzielski>	 lol
[16:42:36] <etonkovidova>	 bgerstle: Android tablet requires charging non-stop - very tiring :) 
[16:42:49] <bgerstle>	 ohh zing ⚡️
[16:42:55] <bgerstle>	 🔥
[16:43:04] <niedzielski>	 etonkovidova: what's the amperage on your charger?
[16:44:43] <niedzielski>	 bgerstle actually told me privately that he secretly really wants an android tablet... "in love with them" i think were the words he used :)
[16:45:41] <bgerstle>	 niedzielski: i dunno, man. if _anything_ i think the surface is somewhat more appealing than iPad Pro
[16:45:46] <bgerstle>	 on the surface, at least
[16:45:49] <niedzielski>	 :)
[16:45:52] * bgerstle cue rimshot
[16:45:53] <niedzielski>	 that surface is pretty slick looking!
[16:46:09] <bgerstle>	 i just like the idea of tablet that i can actually do stuff on. truth be told i've never been big on tablets
[16:46:15] <niedzielski>	 i love how the keyboard seems to be closely tied it
[16:46:27] <bgerstle>	 i was gifted one, but it's main use is kitchen reference device
[16:46:32] <dbrant>	 ಠ_ಠ
[16:46:32] <niedzielski>	 bgerstle: i think they keyboard makes it much more capable than your average tabby
[16:46:34] <bgerstle>	 (pull up tonight's recipe, look something up, do a quick calc w/ siri)
[16:46:35] <etonkovidova>	 niedzielski: a smart question  about amperage - need to google it  - dunno
[16:46:47] <bgerstle>	 niedzielski: ipad pro has a keyboard, but it's still iOS
[16:46:49] <bgerstle>	 can't write code
[16:47:05] <niedzielski>	 etonkovidova: if you bought the charger in usa, it should say on it somewhere (might be hard to read / hidden)
[16:47:08] <bgerstle>	 can't write (some) code
[16:47:16] <bgerstle>	 i'm sure there are some iOS IDE's
[16:47:26] <bgerstle>	 i guess i _could_ write code if i used VNC/SSH & vim
[16:47:29] <bgerstle>	 and connected to my mac
[16:47:35] <niedzielski>	 bgerstle: i think carmack mentioned some racket ide or something he uses for fun on ios
[16:47:52] <bgerstle>	 which is an interesting idea, if not for the fact that working on swift/ios projects is pretty tough when limited to a terminal
[16:48:02] <bgerstle>	 but not impossible
[16:48:11] <bgerstle>	 aside from the fact that you can't see the simulator
[16:48:30] <etonkovidova>	 niedzielski: yeah, there is some info - hard to read... wait
[16:48:34] * bgerstle imagines multitasking on an ipad between terminal app for coding and VNC app for debugging on a remote device/simulator
[16:48:43] * bgerstle 😰
[16:48:58] <bgerstle>	 i'll stick to a OS X for development for now, i think
[16:49:11] <bgerstle>	 OS X machine*
[16:49:31] <bgerstle>	 although, being able to write, run & debug code _all on an iOS device_ would be pretty insane
[16:49:37] <niedzielski>	 i used to vnc on my rooted ipod touch five years ago. i had a little bluetooth keyboard. people were _obviously_ envious in meetings
[16:49:40] <bgerstle>	 that's what OS X development must be like
[16:49:46] <bgerstle>	 lol
[16:50:32] <niedzielski>	 bgerstle: i'm really hoping for the day i can run android studio on android itself, but i'm not sure that day is anywhere in the near future
[16:51:04] <bgerstle>	 someone somewhere is hacking it
[16:53:55] <etonkovidova>	 niedzielski: the charger is called travel adapter  and has  amperage 0.2A 
[16:53:58] <etonkovidova>	 niedzielski: but it
[16:54:09] <niedzielski>	 .2A!?!?!??!
[16:54:17] <niedzielski>	 that's less than USB!
[16:54:38] <dbrant>	 lol impossible
[16:54:55] <etonkovidova>	 niedzielskit's not a problem of slowly being charged  -it's a problem of the tables to discharge rapidly
[16:55:08] <niedzielski>	 etonkovidova: oh hm
[16:55:35] <niedzielski>	 etonkovidova: you might check your android system settings to see battery usage
[16:55:53] <etonkovidova>	 maybe I misread the amperage ... it's cloudy in SF yet need the sun to read info 
[16:57:37] <etonkovidova>	 Battery - 81%screen, wikipedia alpha 7%, android OS 7%, device idle 2%,  
[16:58:19] <niedzielski>	 bearND: are you planning to make adjustments to the similar pages / page issues offset dbrant mentioned?
[16:58:35] <niedzielski>	 etonkovidova: hm, maybe tone down your screen brightness
[16:59:45] <etonkovidova>	 niedzielski: yeah - maybe and amperage 
[17:00:07] <etonkovidova>	 will look at amperage again when the sun comes out :)
[17:01:53] <niedzielski>	 :)
[17:02:52] <bgerstle>	 etonkovidova: also, please join us in #wikimedia-ios
[17:03:02] <bearND>	 niedzielski: ok, will see if I can manually undo some of those changes
[17:04:34] <etonkovidova>	 bgerstle: just did it
[17:15:19] <mbinder>	 Apps Avengers Assemble
[17:18:09] <bearND>	 niedzielski: dbrant: update the css patch a couple of minutes ago
[17:18:16] <bearND>	 s/update/updated/
[17:37:31] <etonkovidova>	 niedzielski: turned out  amperage output is 1.2 A
[17:38:16] <niedzielski>	 etonkovidova: ok that's decent!
[17:38:25] <etonkovidova>	 niedzielski: yup
[18:33:03] <mbinder>	 coreyfloyd: retro
[18:34:58] <mbinder>	 mhurd: https://etherpad.wikimedia.org/p/MobileAppRetrospective
[19:03:15] <mbinder>	 ios: http://hatjitsu.wmflabs.org/38758
[19:04:39] <mbinder>	 ios: https://phabricator.wikimedia.org/project/sprint/board/782/query/zqB.2GIKlMly/?order=priority
[19:06:36] <greg-g>	 for a second I thought someone had the nick "ios" in here
[19:06:51] <greg-g>	 :)
[19:10:34] <dr0ptp4kt>	 mdholloway (+dbrant, niedzielski, bearND|afk ) lmk if you want a device that's listed on the testing page and i'll have it shipped your way. the devices that are pending are kindle fire 7 6-pak, g3, z3, mi 4, estar tablet. cc mbinder 
[19:10:56] <niedzielski>	 dr0ptp4kt: thanks!
[19:11:38] <mdholloway>	 dr0ptp4kt: thanks, i'll check it out!
[19:14:04] <niedzielski>	 bearND|afk dbrant mdholloway: kicking off beta 4 realz yoz.
[19:14:28] <mdholloway>	 niedzielski: nice. i'll take a look at the docs now, before i forget...
[19:14:53] <niedzielski>	 mdholloway: feel free to make heavy mods. i just kind of munged them together from the changelog
[19:15:04] <wikinaut>	 Android-app. How to make the _delete_(history)_button (icon) on (Article) History invisible? I cannot find a formal definition for this button
[19:15:07] <mdholloway>	 niedzielski: sounds good!
[19:15:33] <wikinaut>	 need a hint, has it to do with the Loader / builder ?
[19:16:08] <wikinaut>	 in HistoryFragment.java ?
[19:16:24] <niedzielski>	 wikinaut: if you delete all history, i think it's supposed to become invisible. i'm not sure it does currently
[19:16:54] <niedzielski>	 wikinaut: yeah, it looks like the saved pages buttons work correctly but the history button does not
[19:17:47] <wikinaut>	 niedzielski: I want to manually make that invisible. Where is it "defined" ?
[19:18:20] <wikinaut>	 May be in the android call for listview
[19:18:48] <wikinaut>	 (the other delete button, in the _search_ history, I already managed that)
[19:19:13] <niedzielski>	 wikinaut: i believe it's in menu_history_context.xml
[19:20:25] <wikinaut>	 niedzielski: (the search-history button is       deleteButton = (ImageView) rootView.findViewById(R.id.recent_search ) just FYI
[19:23:12] <niedzielski>	 wikinaut: ok cool
[19:25:05] <wikinaut>	  niedzielski: menu_history* : may be: yes, I am working on that, too
[19:29:20] <niedzielski>	 bearND|afk dbrant|brb mdholloway|brb: reminder to test on beta + prod since we have some behavioral differences (map, for example)
[19:45:00] <wikinaut>	  niedzielski: I think (in the present code), the delete button is always shown, b/c it is set  onPrepareOptionsMenu enu.findItem(R.id.menu_clear_all_history).setEnabled(historyEntryList.getCount() > 0)
[19:45:11] <wikinaut>	 but never dynamically set or reset
[19:45:21] <wikinaut>	 must be done via onResume()
[19:45:54] <wikinaut>	 (give me some time, perhaps I can fix this, too, in a separate commit)
[19:47:15] <niedzielski>	 wikinaut: hm, that sounds familiar. i think we have similar logic for some of the other menu items. you might check in the settings activity for the logic shows / hides the dev settings button, for example
[19:47:21] <niedzielski>	 wikinaut: and obviously, no rush :)
[19:47:53] <niedzielski>	 wikinaut: keeping independent changes in separate patches is great practice
[19:48:10] <wikinaut>	 (listening to SomaFM Groove Salad) http://somafm.com/player/#/now-playing/groovesalad
[20:12:14] <bearND>	 dbrant: niedzielski mdholloway : Made the patch independent from the MFE CSS changes (https://gerrit.wikimedia.org/r/248364)
[20:14:16] <wikinaut>	 niedzielski: ok, done!
[20:14:30] <wikinaut>	 fixed what I wanted to fix...
[20:14:43] <wikinaut>	 incl. the delete button issue 
[20:14:54] <niedzielski>	 wikinaut: \o/
[20:18:29] <niedzielski>	 bearND mdholloway dbrant: i think im seeing a weird issue on my note 2 (API 19) and the api 19 emulator. i can't save images. the problem doesn't occur on my tracfone (API 19), API 15, 22, or 23 emulators,.
[20:18:50] <niedzielski>	 bearND mdholloway dbrant: i get a FileNotFoundException
[20:19:14] <dbrant>	 curious...
[20:19:16] <mdholloway>	 niedzielski: huh.  i'll have a look.
[20:21:17] <dbrant>	 works on my Galaxy s3 (API 19)
[20:21:50] <niedzielski>	 dbrant: hm, i thought it was going to be an "all samsung devices" type issue
[20:22:09] <dbrant>	 lol it usually is...
[20:22:53] <niedzielski>	 bearND mdholloway dbrant: sorry, spoke too soon. not a regression but will file for a future fix
[20:25:45] <wikinaut>	 niedzielski: do you want me to open bug ticket in phabricator for _every_ even the smallest change commit ?
[20:27:15] <niedzielski>	 wikinaut: i think dbrant it's a good person to ask on that :) i personally do not file tickets for most hygiene work like "refactor disparate view components to custom view" but they usually have a related phab ticket that i'm working towards and mention in the commit message. however, i concede i am not the best person to ask
[20:28:22] <wikinaut>	 dbrant: ^ 
[20:28:31] <wikinaut>	 it's about this small improvement https://gerrit.wikimedia.org/r/#/c/248479/
[20:34:57] <wikinaut>	 niedzielski: I quickly added a "T"
[20:35:22] <wikinaut>	 https://phabricator.wikimedia.org/T116431
[20:35:32] <niedzielski>	 wikinaut: i would say that's probably the safe thing to do :)
[20:39:20] <dbrant>	 wikinaut: even though your change is very minor, it still affects certain visual elements in the app. Therefore it's good practice to create Phab tasks so that all interested parties (Designers especially) can be aware of it, and can comment on it.
[20:41:44] <wikinaut>	 dbrant: yep, already done!
[20:41:49] <wikinaut>	 b/c of Design
[20:41:53] <wikinaut>	 I added the "T"
[20:44:44] <dbrant>	 wikinaut: if you're looking for things to fix in the app, a good idea might be to look at our bug backlog: https://phabricator.wikimedia.org/tag/wikipedia-android-app/  There's an entire column called "Bug backlog", as well as "Product backlog".
[20:45:22] <wikinaut>	 dbrant: ok
[20:52:12] <dbrant>	 kaity_: got a little time today for Design Signoff?
[20:52:20] <dbrant>	 (especially items with points on them)
[20:52:21] <kaity_>	 dbrant: sure
[20:52:47] <dbrant>	 thx!
[20:52:54] <kaity_>	 oh its piled up sorry
[20:55:04] <kaity_>	 dbrant: just seeing the new (old) continue to article button, it looks good! I think its working much better
[20:55:22] <dbrant>	 kaity_: nice!
[21:00:12] <kaity_>	 dbrant: can we work on the task to add descriptions to all the lists in an upcoming sprint?
[21:00:13] <kaity_>	 https://phabricator.wikimedia.org/T115035
[21:01:23] <dbrant>	 kaity_: yes we can!
[21:02:04] <kaity_>	 dbrant: not very high priority but it would be nice
[21:02:16] <kaity_>	 dbrant: cleared the design sign off column
[21:02:31] <dbrant>	 kaity_: awesome! thanks
[21:05:07] <etonkovidova>	 dbrant: Image Gallery - some pictures have a strange teal-colored square which is a link to wikidata. Is it a correct behavior? 
[21:06:45] <dbrant>	 etonkovidova: it's certainly not "correct" behavior, but we are aware of it. It falls under the issue of "we don't handle HTML in the Commons description very well".
[21:06:53] <dbrant>	 etonkovidova: it's not a regression, is it?
[21:07:36] <etonkovidova>	 dbrant: nope 
[21:08:40] <etonkovidova>	 dbrant: it's in 2.0.11-r-2015-09-16
[21:09:49] <dbrant>	 etonkovidova: yeah, I'm sure this has been the case since the beginning of the Gallery.
[21:10:28] <niedzielski>	 kaity_: i don't know if it'll work out in the designs, but it'd be sweet if the wiktionary definition sheet included a link or text extract for the highlighted term when it exists. lots of articles exist but aren't necessarily linked
[21:11:31] <dbrant>	 you mean a link to the Wikipedia article for the highlight?
[21:12:46] <niedzielski>	 dbrant: exactly. i don't really care for the whole contextual action bar experience as it is. i want something a lot cleaner that hopefully has the information i need in itself, but if it doesn't, provides a gateway to get it
[21:13:03] <dbrant>	 yeah, that'd be cool
[21:14:02] <niedzielski>	 dbrant: for example, on the dog article. the first canis lupus might be linked but often times subsequent references (sometimes pages down) aren't
[21:14:31] <niedzielski>	 dbrant: i want the wiktionary word definition and a wikipedia text extract (like link preview)
[21:14:35] <dbrant>	 yep, good observation
[21:21:54] <niedzielski>	 bearND mdholloway dbrant: testing looks good on my end. any objections with moving forward with the beta?
[21:27:06] <mdholloway>	 niedzielski: none here!
[21:30:47] <bearND>	 niedzielski: no objections, your honor
[21:30:57] <niedzielski>	 :)
[21:31:47] <bearND>	 niedzielski: since dbrant is offline I think you can go ahead and cut the build
[21:32:26] <niedzielski>	 bearND: build is cut. you think it's cool to publish on the playstore?
[21:32:53] <bearND>	 niedzielski: sure
[21:33:00] <niedzielski>	 o/
[21:59:58] <MaxSem>	 etonkovidova, http://www.amazon.com/gp/product/B00DMIW4KQ?psc=1&redirect=true&ref_=oh_aui_detailpage_o00_s00
[22:02:45] <etonkovidova>	 MaxSem: thx!! 
[22:05:35] <kaity_>	 niedzielski: hmm good idea
[22:29:12] <niedzielski>	 dbrant: did we want to do tsg today or let things cook in beta for a while?
[22:32:37] <dbrant>	 yes, I don't see why not. I'm really anxious to get the CPU fix to production
[22:32:57] <dbrant>	 niedzielski: ^
[22:33:11] <niedzielski>	 dbrant: sounds good
[22:40:01] <niedzielski>	 now we wait :)
[22:40:12] <niedzielski>	 i'll be keeping an eye on hockeyapp
[22:41:03] <dbrant>	 oh right! hockeyapp \o/