[00:50:36] jdlrobson: have you seen https://phabricator.wikimedia.org/T115228#1752223 ? [14:58:03] niedzielski: mdholloway hey! do we know what's going on with our tests? [14:59:06] dbrant: nope, not yet :| [14:59:59] dbrant: unfortunately, no. will investigate. [15:12:00] dbrant mdholloway: it looks like the problem is that there's a dash in "sub-section": https://test.wikipedia.org/wiki/Test_page_for_app_testing/Section1 [15:12:56] https://test.wikipedia.org/w/index.php?title=Test_page_for_app_testing%2FSection1&type=revision&diff=245205&oldid=244518 [15:13:13] dbrant mdholloway: i think we're the only folks that edit this page so i'm not sure how it got changed [15:13:37] dbrant mdholloway: anyway, i was going to just try changing the wiki. if something flips it back to "sub-section", i'll change the tests [15:14:19] https://test.wikipedia.org/w/index.php?title=Test_page_for_app_testing%2FSection1&type=revision&diff=244588&oldid=244582 [15:14:36] well, now i'm getting a MediaWiki internal error [15:15:07] something to do with schema.Search which i think oliver mentioned [15:15:07] can we just disable those tests? [15:15:49] [half kidding] [15:19:03] dbrant: if test.wikipedia.org is down, i think many tests will fail [15:21:06] is mw.org down for anyone else? https://www.mediawiki.org/wiki/Reading/Web https://usercontent.irccloud-cdn.com/file/Y8FfuZkw/Screen%20Shot%202015-10-26%20at%2011.20.34%20AM.png [15:21:36] jhobs: yes :| [15:21:43] welp :/ [15:21:49] jhobs: different error on test.wikipedia.org though [15:21:50] jhobs: wikipedia is down :-/ [15:21:54] D: [15:21:55] also [15:22:14] ah back now. [15:22:16] wait, wikipedia is working fine for me [15:22:17] ah [15:22:18] lol [15:22:36] quick recvoery [15:22:51] \o/ [15:25:25] dbrant: Nothing in "Done" column in sprint 68. I thought I recalled several cards there last Friday. Did we move them? I wanna calculate velocity. [15:26:24] mbinder: the tasks are all there, but they're "Resolved". It's 13 points total. [15:26:32] ah, ok ,thanks [15:27:59] bmansurov: all of the extensions we maintain are listed under projects on our Phab dashboard, right? [15:28:14] jhobs: let me check [15:30:03] bmansurov: I ask because I'm adding the "maintained by Reading Web" template to extensions and I want to make sure it should be on all of the projects in that list (and nothing more) [15:30:19] jhobs: can you share the link? [15:30:32] bmansurov: https://phabricator.wikimedia.org/dashboard/manage/125/ [15:31:08] jhobs: cards is missing [15:31:37] jhobs: but projects listed there sound right [15:31:38] bmansurov: yeah, I was gonna add that one in if I have edit rights on the dashboard. But the others look good right? Like we maintain TextExtracts and PageImages? [15:31:41] ok col [15:31:43] cool* [15:32:12] not sure about pageimages, but yes to textextracts [15:41:55] bmansurov: hmm... I don't think we've explicitly had a discussion on whether we own Zero now or not. I'll leave the template off that one for now [15:42:32] ok [15:43:17] joakino: Can you add Cards to the list of extensions we watch on the Reading Web Dashboard? I don't have edit rights. And maybe RelatedArticles if we maintain that now too [15:53:48] \o [15:53:59] jhobs: i can [15:55:21] dbrant mdholloway bearND: bernd's patch (https://gerrit.wikimedia.org/r/#/c/248364/) seems to be working for me. any objections to merging? [15:55:47] niedzielski: nope (just +1'd, actually). [15:56:04] niedzielski: go for it [15:56:42] jdlrobson: didn't think you'd be up yet, but thanks! [15:57:01] niedzielski: mdholloway: we can probably squeeze this guy in, as well https://gerrit.wikimedia.org/r/248416 [15:58:37] niedzielski: thanks [15:59:37] jhobs: jet lag! :D [15:59:37] bmansurov|away: good point about the documentation around DoNotTrack. I'll fix it as soon as vagrant finishes provisioning (so in like a day and a half ;) ) [16:00:07] jdlrobson: haha yeah same. I couldn't make it past 9pm last night and woke up far too early today :D [16:01:11] dbrant mdholloway bearND: andy was asking for some guidance on our device matrix for testing. each device tested increases cost. with this in mind, i was going to ask him to task one phone and one tablet that run different versions of android. sound good? [16:02:21] niedzielski: fine with me. (i'm guessing the phone has the more recent version of Android? (that would be preferable)) [16:02:40] dbrant: i do not know but i can make the request [16:09:22] niedzielski: sounds good to me. In the future we should also add 6.0 devices. [16:10:11] bearND: i think in the future we might want to test less on 6.0. the reason being that presumably most of our development would happen on the latest and greatest [16:16:13] dbrant mdholloway bearND: ok, final patch pending for the new release is in the pipeline. will kick off a new build once it's all merged [16:18:09] niedzielski: i just uploaded this, too: https://gerrit.wikimedia.org/r/248897 think we can get it in? [16:20:00] dbrant: yeah, code looks pretty minimal. let me give it a spin [16:21:43] jdlrobson: where do discussions around RFCs happen? The one you linked to in that patch (thanks for that btw!) has a redirect on its talk page [16:39:58] jhobs: usually on talk page.. not sure what's going on there. https://www.mediawiki.org/wiki/Requests_for_comment [16:52:43] dbrant mdholloway bearND: ok, i think everything is really in now. everyone cool with starting a release build? [16:53:08] yep! [16:54:14] niedzielski: go for it [16:55:39] jdlrobson: it seems conversations for RFCs now happen on a phabricator board, but I don't see a card for the Minifier. Weird [16:56:23] bgerstle_afk: https://phabricator.wikimedia.org/T115747#1753872 [16:57:04] jdlrobson: thanks! [16:57:17] jdlrobson: you don't happen to have an instance running w/ this patch do you? [16:57:28] if not i can resume my attempt to get it running locally w/ mw-vagrant [16:57:39] oh wait, that's already pointing at labs [16:57:41] fantastic [17:13:05] niedzielski: coolio [17:16:31] kristenlans: when was that meeting you mentioned in the chat? I'm about to leave for lunch [17:18:22] jhobs I was thinking about the story prioritization mtg later today (6 PM ET). jdlrobson do you think jeff should be there if we're going to talk about kiwi surveys, or can we catch him up tomorrow at kickoff?? [17:18:33] ^ jdlrobson [17:18:57] ok cool it's not until later then so I'm gonna head off. Lemme know and I'll make it if needed. [17:19:14] probably kick off [17:19:15] should be fine [17:28:59] hey codezee ! [17:30:29] hey mbinder [17:30:41] howdy kaity_ [17:30:51] mbinder: do you know how to filter the board to show both alpha and beta? [17:31:07] when i filtered both those tags it showed nothing [17:32:26] kaity_: hmm, I see the issue, gimme a sec [17:33:22] jdlrobson: hello! [17:35:00] mbinder: oh I think I've got it, I just selected "In any beta" and In any alpha' [17:35:30] kaity_: yep perfect, nicely done [17:44:49] niedzielski: what value is it supposed to add? [17:45:33] dbrant: we ship what we test [17:45:40] niedzielski: it seems like it's caused nothing but headaches [17:46:42] niedzielski: there was a weird crashing bug this worked around: https://phabricator.wikimedia.org/T78197 [17:47:07] niedzielski: related to that http://stackoverflow.com/questions/32723868/noclassdeffounderror-android-support-design-internal-navigationmenu-on-android is quite interesting [17:47:53] bearND: i was just looking at that, too [17:48:29] niedzielski: we probably should add the items found in the "#Android" section of the accepted answer. [17:50:49] niedzielski: on second thought, that might make the previous fix inactive [17:55:24] bearND: if i understand correctly, we need ProGuard for a rename of the support library? [17:56:19] bgerstle_lunch: do you want me to merge that patch to test? [17:56:42] jdlrobson: sorry, having some issues recompiling the version of the app that's in the store right now (the one i'm most worried about) [17:56:50] jdlrobson: mind waiting a bit longer? [17:57:04] okay. just wanted to check you know it's not live on beta labs. [17:57:15] the branch is cut tomo morning so i could merge when you are ready to test and revert if there are any issues [17:57:24] jdlrobson: the links you posted in phab aren't using that patch? [17:57:56] nope. That patch hasn't been merged yet. I could setup an instance to use it but that would take some time and i don't have bandwidth to do that today [17:58:06] ah i see [17:58:20] jdlrobson: ok then yeah if you merging it makes it go live in labs then go ahead [17:58:26] that will make it easier to test [17:58:38] niedzielski: yeah, it seems like some of the samsung devices included parts of the appcompat library [17:58:45] and the patch looked pretty minor, so on the off chance that there's a problem reverting it shouldn't be too troublesome [17:58:52] bgerstle_lunch: cool. Let me know by 6pm PST if it broke things [17:59:33] jdlrobson: would you mind pinging me when it's deployed to beta labs? [17:59:37] or how would i know? [17:59:57] also, you're saying that this will go live to production if i don't say otherwise by 6pm PST today? [18:07:38] niedzielski: sorry, have to run to an appointment. Feel free to release what we have for now. [18:07:56] bearND: ok thanks. see ya! [18:29:06] bgerstle_lunch: deployed now [18:29:24] jdlrobson: thanks, on it [18:29:32] dbrant mdholloway: so i can try to strip android.support.design.internal.NavigationMenu but i don't have a great way to test it [18:30:17] dbrant mdholloway: and i'm not super clear on how that even works if it's not supposed to be present in platform [18:33:14] niedzielski: i'm no more clear on that myself :( [18:33:40] dbrant mdholloway: the only previous issue i see that is similar in otrs is here: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8696544 [18:33:51] dbrant mdholloway: but it looks different so i worry this is a regression [18:35:02] yeah, it looks different [18:41:54] niedzielski: i think we should proceed with release. [18:43:48] dbrant ok, will do [18:44:37] dbrant mdholloway: if we have problems, i think we should try the jarjar rename solution. i think that would work the same way no matter the device and also allow us to drop proguard if we wanted. there might be some added complexity with aars so we'd want to check that out too. the oems kind of put us in a bind on this :| [18:45:42] oems... (╯°□°)╯︵ ┻━┻ [18:45:57] ha! [18:46:31] niedzielski: that sounds reasonable to me. i remain in favor of dropping proguard if possible. [18:48:57] jhobs|afk: we'll catch up with you at kickoff, don't worry about the meeting tonight [19:37:57] dbrant|brb bearND mdholloway: i've got pretty minor release notes going in the etherpad. please take a peek when you can [19:38:53] niedzielski: those look fine to me [19:39:32] niedzielski: lgtm [19:42:18] niedzielski: lgtm [19:43:24] dbrant bearND mdholloway: neat, we see reports for fdroid already https://rink.hockeyapp.net/manage/apps/226649/app_versions/3/crash_reasons [19:43:46] dbrant bearND mdholloway: anyway, crash reports look as expected for 133. i'm going to move ahead with the release unless there are any objections [19:44:09] none [19:44:22] niedzielski: nope, go for it [19:46:24] niedzielski: make it so, #1 [19:46:39] :) [19:55:01] FlorianSW: aude > https://gerrit.wikimedia.org/r/#/c/246282/ [19:55:09] if you want to make the next cut :) [19:56:22] jdlrobson: I'm a little bit confused?! I already +2ed the change, what happened? :/ [19:56:38] ah, a dependency, which you removed already? [19:59:21] FlorianSW: yeh i just cherry picked to master [19:59:28] seems dependency not needed [20:04:00] jdlrobson: a displaytitle (e.g. s colored text) is now plain html in search results :/ [20:04:56] see http://i.imgur.com/xAGOqQD.png [20:21:50] FlorianSW: ohhh no [20:22:03] nice catch [20:22:23] I commented on the change, too :) [20:31:57] jhobs|afk: ping me when back [20:34:23] jdlrobson: i'm having trouble sending mobileview requests to beta labs [20:34:27] i don't need to be on VPN do i? [20:34:43] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Display%20title%20test&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidt [20:34:43] h=640,%20NSErrorFailingURLStringKey=https://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Natural%20Philosophy&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfro [20:34:43] mtitle%7Cindex§ions=all&thumbwidth=640 [20:34:48] oops [20:34:51] "http://en.wikipedia.beta.wmflabs.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Display%20title%20test&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwid [20:34:52] th=640,%20NSErrorFailingURLStringKey=https://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Natural%20Philosophy&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfr [20:34:52] omtitle%7Cindex§ions=all&thumbwidth=640" [20:34:53] ... [20:34:55] sorry everyone! [20:35:14] API request URL https://www.irccloud.com/pastebin/jKg3WbLV/ [20:35:31] error says "page doesn't exist" [20:35:43] oh wait sorry that's my bad [20:36:04] k, work snow [20:36:07] copy/paste error [20:36:14] bgerstle: no vpn should be necessary [20:36:26] right [20:36:26] Florian with respect to back to top [20:36:47] FlorianSW: i think you should take a sample of users and see in what % of sessions the feature is used [20:36:52] rather than just measure clicks. [20:46:52] jdlrobson: is there a documented way to track clicks by session? Or should I trigger for clicks and check, if a cookie/localStorage variable is set, and if so, don't log the click? [20:47:15] FlorianSW: 1s [20:49:29] FlorianSW: essentially we'd look for something like https://gerrit.wikimedia.org/r/#/c/246437/7/resources/mobile.loggingSchemas/SchemaMobileWebSectionUsage.js [20:50:47] FlorianSW: let me talk to jon katz today and see if we can work out a good way to measure it [20:54:15] jdlrobson: ah, ok :) Let's wait until we have such a feature and then I will change the change ;) [20:54:34] i have to say FlorianSW i'm finding it really useful [20:54:39] although am wondering if it should be blue :) [20:54:46] progressive? [20:55:03] FlorianSW: the feature is there already. You just need to add a schema with the samplingRate and isSampled attributes defined [20:55:04] FlorianSW: yup [20:55:30] hmm, if I follow the design spec, it should be constructive (it's finishing a "workflow"), but I've no strong preference, I'm "just" happy to have it :D [20:57:11] jdlrobson: ah, yes, wouldn't it make sense to create a base "SchemaMobileWebUsage" object, which set's sessionId, isTablet, the sampling rate and so on in it, so that SchemaMobileWebSectionUsage and probably a schema for back to top can inherit from it? [20:58:23] i'm hoping one day all our schemas can just inherit from Schema [20:58:29] but we're a long way from that FlorianSW :) [20:58:33] or MobileWebSchema [20:58:57] I would like to deprecate 'mobileMode' on SchemaMobileWeb [20:59:01] and replace it with isTablet [20:59:07] yes, but sometimes, sometimes :D [20:59:10] sampling rate should be defined on a per-schema basis [20:59:17] jdlrobson: http://i.imgur.com/p4qbdZG.png [20:59:20] ? [20:59:37] FlorianSW: i've asked kaity_ for some feedback on the design :) [20:59:42] hopefully she can give you some ideas [20:59:49] ok, great :) [21:00:43] jdlrobson: so, a new schema with isSampled: true and a sampling rate would be enough for https://gerrit.wikimedia.org/r/#/c/247044/1/resources/mobile.backtotop/BackToTopOverlay.js ? [21:01:19] FlorianSW: hey! it looks good [21:01:30] kaity_: blue, yes? [21:01:36] kaity_: and: hi :D [21:01:37] FlorianSW: only concern was that it looks a lot like the table of contents button in the app [21:01:48] people might get confused if they use both [21:02:14] kaity_: another idea (as an extension of it) would be, to implement such a feature, instead of a back to top, but that's a lot of work :) [21:02:23] let me change it to progressive for now : [21:02:25] :) [21:02:47] FlorianSW: yea I think blue is a good start, and excited to see the usage data [21:03:11] FlorianSW: Table of contents would be great, I really hope to work on it someday [21:04:05] kaity_: +1 :) -> https://gerrit.wikimedia.org/r/#/c/248993/ [21:07:44] dr0ptp4kt: jdlrobson FYI the displayTitle stuff should be good to go [21:07:47] not sure if you saw my comment [21:08:16] bgerstle: thx [21:11:32] dr0ptp4kt: jdlrobson FYI beta cluster is harder to test on iOS because it doesn't log bad SSL certs [21:11:41] sorry, iOS 9 doesn't like* bad SSL certs [21:11:50] had to do some hacking to use HTTP [21:11:52] bgerstle: thanks for checking! :) [21:12:24] FlorianSW: reply to your 2pm comment - yes that should be enough [21:12:27] np, thanks for poking me about it [21:12:35] lemme chat to jon about a good test for measuring engagement [21:12:58] jdlrobson: ok, i'll upload a "dummy" change to indicate, what I mean so we can build on top of it :) [21:22:12] bearND dbrant mdholloway: first legit crashes on 133: https://rink.hockeyapp.net/manage/apps/226650/app_versions/4/crash_reasons/49897113?scope=devices&type=statistics [21:23:42] niedzielski: i'm already not missing OTRS. [21:24:09] dbrant: :D [21:24:19] dbrant: i guess that's like saying you don't like sunburns [21:30:55] niedzielski: i really like the aggregation aspect of it, and that we can just sort by count of occurrences. [21:32:15] * niedzielski struggles not to disparage foss otrs [21:32:47] niedzielski: we still need it for the written feedback [22:18:15] https://phabricator.wikimedia.org/T111445 [22:50:41] web team: anyone got time for a quick code review? [22:50:42] https://gerrit.wikimedia.org/r/#/c/248813/ [22:50:46] https://gerrit.wikimedia.org/r/#/c/247969/ [22:52:43] jdlrobson: ^ [23:16:08] mbinder: you around? [23:16:59] kaity_: yep [23:17:26] mbinder: I'm looking for a phabricator template for a new product that has high level goals and stuff [23:17:40] mbinder: I remember seeing it on iOS, does android use those too? [23:23:54] hmm, not sure what that means. Do you have the iOS example? [23:24:04] kaity_: ^ [23:25:10] mbinder: I found one for mobile web: https://phabricator.wikimedia.org/T94906 [23:25:57] Do you know if android ever uses templates like this? That have summary, outcome, goal, success metrics, etc [23:26:29] kaity_: hmm, first I've seen, but I can do some research [23:27:16] kaity_: I found this on the Android board: https://phabricator.wikimedia.org/T104200 [23:27:22] kaity_: under "templates" [23:27:37] mbinder: thanks! [23:27:49] kaity_: sure, lemme know if it's not what you need [23:28:33] mbinder: I'm writing a task for a new experiment I'd like to do [23:28:34] https://phabricator.wikimedia.org/T116692 [23:28:54] Do you think a big template is appropriate for this idea? [23:30:15] kaity_: awesome. I think I would confer with dbrant|afk to see if that fits his flow, but it seems like the answer to your question is another: "Does this feel like an Epic?" [23:37:40] bgerstle: you ios folk don't have any fancy tool for converting hockeyapp tickets to phab tasks, do you? [23:42:29] jdlrobson i just updated the description of 'implement first version of read more' to note the edge cache and origin server stuff mentioned this morning. https://phabricator.wikimedia.org/T113635#1755841 . cc kristenlans - this was my follow up item from this morning iirc