[00:07:20] bearND /cc mdholloway|afk: hey! are you cool with me +2ing reviewed stuff into the content service? i wasn't quite sure if you want to keep that a little more controlled to just you and michael or not. [00:11:40] niedzielski: i think you can +2 the small .gitignore change. For the bigger stuff like the Parsoid patch I would hold off until Marko had a chance to review it. I'm actually working on an amend for that right now. [00:12:03] bearND: ok cool [00:12:13] bearND: yeah, i wouldn't +2 that unless you told me to :) [01:56:04] jdlrobson, hey [11:01:51] good morning [14:32:45] bgerstle: just noticed the meme functionality in phabricator [15:26:20] hi [15:45:00] is someone listening here, who is an expert in the "history search" mechanism of the Wikipedia-Android-App ? [15:45:17] wikinaut: hello! i'm looking at your recent searches patch right now :) [15:45:18] wikinaut: that'd be dbrant niedzielski bearND mdholloway [15:45:37] niedzielski: have you time for short chat? [15:45:45] jdlrobson: can you look at https://gerrit.wikimedia.org/r/#/c/247969/ again? [15:45:52] wikinaut: sure, what's up? [15:45:54] joakino: belated buenos dias :-) [15:45:57] I'd like to get it into the next branch [15:46:37] niedzielski: the point is, that ... [15:46:41] ... in https://gerrit.wikimedia.org/r/#/c/248565/2/app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java [15:47:13] when the search history is shown on start, the Delete Button is not always shown/not shown according to the condition [15:47:36] wikinaut: i'm running on the debugger on it right now. i too am a little puzzled why the result set is zero length [15:47:53] yep, prima [15:48:10] perhaps it has to do with the PERSITENT part of the code [15:48:37] or that placing it in onLoadFinished is wrong [15:48:58] ... once started, it is working as designed [15:49:12] wikinaut: onLoadFinished() seemed appropriate to me. and the view would be invalidated by changing the visibility [15:50:04] wikinaut: maybe it has to do with someone else adding to the dataset and should go in updateList()? [15:50:26] wikinaut: (in addition to onLoadFinished()) [16:00:13] wikinaut: oh. it looks like we're checking the listview's size before the cursor is swapped out (which feeds the listview items) [16:02:13] niedzielski: I was afk. Now back. thanks for your lines above [16:02:17] wikinaut: should be something like this https://phabricator.wikimedia.org/P2240 [16:02:26] (looking) [16:03:38] have you tried that? [16:04:15] wikinaut: yes. is it not working on your end? [16:04:31] did not yet deploy. Pls. wait. [16:05:30] (will try in the emulator, _and_ an two physical devices) [16:13:38] niedzielski: looks to be okay now. But please > wait < until I test the same change in my other patch (the incognito patch. Advantage: there I can change the search history on/off live. The delete button must then reflect that change immediately. I'll report here. [16:16:56] I'm having to bump my Gradle vm size to 4096m to get our build working :/ [16:19:50] dbrant: that's not good. [16:22:10] my internet is crazy spotty right now [16:22:14] dbrant: here's my ~/.gradle/gradle.properties: https://phabricator.wikimedia.org/P2242 [16:22:58] niedzielski: will try [16:23:59] dbrant: the other thing you might try is killall all the daemons. since we just upgraded, there might be two versions running? [16:41:16] bearND: do you mind if i rebase your 6.0 disable backup patch? [16:43:27] niedzielski: I checked your small change. +1 [16:43:50] and changed my pending changes. See e-mails and so on. [16:46:44] wikinaut: ok is the patch ready for review then? [16:49:19] niedzielski: go ahead [16:50:07] niedzielski: in general I think it's good to always rebase before merging. This keeps the git log simpler. [16:50:49] bearND: hm, i wonder if there is a gerrit / differential setting to force that [16:51:16] idk [16:51:56] niedzielski: i just do it when I want to merge something and the rebase button in Gerrit is enabled [16:58:06] niedzielski: yep, both are ready for review. I added a comment, so that everyone knows [16:58:48] niedzielski: I did a git rebase on both [16:59:14] wikinaut: ok cool. will review when i finish up with these other patches [17:01:01] jdlrobson: regarding https://gerrit.wikimedia.org/r/#/c/246437/, isn't pageId a required field? [17:03:11] bmansurov: shouldn't be... [17:03:19] lemme look at the schema [17:03:35] yup you are right my bad [17:06:49] dbrant: do you think maps will see prod soon-ish? [17:07:32] niedzielski: i would estimate... end of Q2. [17:07:45] niedzielski: ok. I am very happy abnd proud to have finished this, thanks for your help [17:07:53] s/abnd/and/ [17:08:06] wikinaut: thanks for your patch! [17:08:07] (standby) [17:08:45] bmansurov: fixed! [17:09:10] reviewing [17:19:00] bmansurov joakino could one of you merge the new quick surveys release [17:19:02] so i can sign off [17:19:14] https://gerrit.wikimedia.org/r/248986 [17:19:16] ok [17:20:11] mdholloway: hey have a minute to chat about the lead paragraph pr? [17:20:25] mhurd: sure, batcave? [17:20:36] mdholloway: ya! [17:20:42] mhurd: omw [17:20:49] jdlrobson: how did you come up with the version number? Shouldn't it either be 0.5.0 or 0.4.1? [17:21:07] jdlrobson: not that it matters too much [17:21:14] i felt we are half way between a next release [17:21:19] the number should reflect the amount of changes [17:21:31] we should definitely talk about how to choose release numbers [17:21:41] for instance i guess when we deploy it we want to go to 1.0.0 ? [17:21:43] i dunno :) [17:21:48] i thought we followed semver [17:21:57] bmansurov: is it written down on the release page? [17:22:02] let me check [17:22:38] cc joakino ^ [17:22:42] happy to change it [17:22:49] jdlrobson: seems, no [17:23:08] shall i change it to 0.5.0 then? [17:23:15] yes [17:23:42] whoops i forgot to change extension.json anyway [17:24:04] bmansurov: pushed [17:24:16] bmansurov: do we have that mail list yet? This would be a good topic for it [17:24:46] yep [17:24:46] in any case, 0.X in semver means do whatever you want [17:24:51] after 1.0 is when you follow the breaking changes rules [17:25:12] jdlrobson: there is a task for that https://phabricator.wikimedia.org/T116610 [17:27:35] also joakino i need a comment from you on https://phabricator.wikimedia.org/T114663#1754885 [17:28:01] jhobs: https://phabricator.wikimedia.org/T115580 [17:29:40] jdlrobson: yeah I saw. I'm not sure how we can have you test it though if we couldn't set up zero on your local instance before [17:29:54] jdlrobson: oh wait duh it's been deployed [17:30:01] i'll respond on the card with instructions [18:13:57] niedzielski: as you certainly read, DBrandt has decided against it. I contacted someone else to support it. I think, a non-deployment is unfair against users, who forgot to delete their histories (users have to know about the settings and has to delete it on two places) [18:14:20] I wish a broader discussion. [18:14:41] here https://phabricator.wikimedia.org/T96546 [18:18:18] hm, that's a bummer. i too have had some patches in that past that just weren't ripe enough to get in or get in quite how i wanted them to. i'm still building a case for a certain library dependency that i hope to one day make a compelling argument for :) however, that's one of the things we all agree to when working together: compromise. i'll revi [18:18:18] ew the dialogue but we definitely have to come to a consensus and it might not always be the outcome you're looking for [18:18:25] wikinaut: ^ [18:18:30] dr0ptp4kt, make sure you add yourself if you want to use the IDE - https://office.wikimedia.org/wiki/JetBrains [18:18:41] wikinaut: i'll follow up on the ticket shortly [18:19:51] wikinaut: a wider discussion is always welcome, and we certainly appreciate your feelings toward it. (That task is currently in the "Open questions/Discussions" column on our workboard)) [19:00:05] yurik: are you able to see a banner on enwiki right now if you spoof the headers? Because I'm not and I see no js errors, but I am able to locally... [19:00:42] jhobs, i haven't tried. Have you tried to add your ip? [19:00:59] e.g. to some partner? [19:01:11] yurik: not yet, and I meant to phrase that as "could you please try" [19:01:46] sure [19:02:09] it's working on zero wiki right now for me, but not enwiki. I'll try adding my IP [19:03:09] jhobs which zero partner is configured to use it? [19:03:19] jhobs, PM please [19:12:13] jdlrobson: fyi, I'm working on getting a way for you to test the Zero card, but the header-spoofing we normally do doesn't appear to be working. Investigating manually adding my IP or if there's a serious bug. [19:12:25] jhobs: you can always get dan foy to sign off [19:12:28] if he can replicate [19:12:51] right now even I can't replicate, hence the investigating [19:14:00] dont spend too long on this [19:14:03] other work in sprint is more important [20:09:54] hey dbrant I saw you had a look at the related article tiles https://phabricator.wikimedia.org/T116692 [20:10:27] kaity_: yes! [20:12:39] dbrant: thanks! Do you think it needs more info like goals and success metrics? [20:15:02] kaity_: good idea; i'll see if I can flesh it out as an official Epic for our Goals board ( https://phabricator.wikimedia.org/tag/mobile-app-goals/ ) [20:15:20] dbrant: thank you! [20:21:15] jdlrobson: do you think we could pair on this bug tomorrow: https://phabricator.wikimedia.org/T116821 ? Is a result of jquery not always being loaded in time, which you said you had ideas for refactoring a month or so back [20:32:21] hey jhobs [20:32:28] yo [20:32:41] who's pushing on you for this zero work? [20:32:52] it wasn't communicated to the team and added to the sprint.. [20:33:08] i logged that one because I noticed it when checking for how you could test the other task [20:33:36] and it's causing zero banners to not be loaded roughly 50% of the time, which is pretty serious [20:33:42] hence why i brought it up [20:48:58] jhobs: do you want to bring it up in tomorrows standup? [20:49:05] should make sure the team is okay to take the hit [20:49:23] jdlrobson: yeah, sounds good. I assume we'll be fine though with the 2 things that got cancelled right after kickoff [20:49:28] it's in triage so we should be fine [21:29:57] niedzielski: regarding https://phabricator.wikimedia.org/T116711 , do you see any issue with me building a one-off special channel build (based on the latest version bump), and uploading it to the Partners folder? [21:33:58] dbrant: none that i can think of, just make sure you build from the git beta / release tags since that's what we're testing and do please share the exact command line you build with so i can update my local "build all partners" script [21:35:00] dbrant: we'll have to add some date injection abilities in the future so we can mimic old builds better [22:25:29] jdlrobson, around? [22:47:33] hey Krenair whats up [22:47:37] meetingz meetingz meetinz [22:47:39] oh, I just sent you an email [22:47:53] sorry, just wanted to get your opinion on something [22:48:01] * jdlrobson reads mail [22:48:22] Krenair: i think that sounds great! [22:48:29] can you +1 it? :) [22:48:59] done! [22:49:19] thanks [23:24:06] niedzielski: you have a "legacy" usb cable for ios? i'm wondering if i can save the one i have here if you already have one that you can use with the 4s [23:24:27] dr0ptp4kt: let me double check [23:26:12] dr0ptp4kt: i'm not sure qualifies as legacy, but i confirm i have one that is compatible with itouch 3g [23:26:30] * niedzielski needs to refactor his boxes of electronic junk [23:27:39] dr0ptp4kt: i would say if we're unsure, don't send the cable. i can always pick it up in january [23:28:47] niedzielski: that's the one. i'll send without the cable [23:28:59] dr0ptp4kt: sounds good. thanks!