[00:30:07] violetto: https://www.mediawiki.org/wiki/API:Styling_content has the load request to get some default wikipedia CSS [10:34:08] morning! [12:06:56] joakino, hey [12:07:08] joakino, are you able to ssh to any of the reading-web-staging instances? [12:07:23] hi bmansurov ! [12:07:27] let me check [12:07:41] yes [12:07:50] just sshd into reading-web-research [13:17:47] out to walk the dog and lunch, will come back later [15:15:15] bgerstle: did you integrate github bug tracker with hockeyapp? it looks like ha supports it [15:24:55] jdlrobson: around? [15:26:35] aude: sure i can talk for a little. How can I help? [15:29:05] i'm having some trouble with special:nearby (even on en.wikipedia.org on my phone) [15:29:20] it's just stuck on the spinner and i am tyring remote debugging [15:30:03] just wonder if you have any suggestions... could it be just me? [15:30:47] i am deleting all my chrome data and maybe it works [15:30:48] oh really? huh [15:31:10] do you have location enabled? [15:31:13] clicked "allow" for my location [15:31:14] i do [15:31:21] * aude double checks [15:31:34] i recommend loading google maps or some other app that uses location services [15:31:46] yes, i hve location [15:31:46] and check some other pages in the browser that use geolocation [15:31:55] ok [15:32:02] i've found sometimes the browser has difficulty getting location for some reason [15:32:02] it's good [15:32:18] if you're just seeing a spinner and no errors it's likely geolocation is still trying to obtain a location. [15:32:24] ok [15:32:37] it works fine on desktop [15:32:39] aude: did the changes to the search stuff help you fix Wikidata mobile? [15:32:46] (to not show labels) [15:33:21] not? [15:33:35] we have labels on nearby, but not yet on search [15:34:06] * aude tries openstreetmap.org [15:34:56] jdlrobson: you might be right about difficulty in getting location [15:37:08] jdlrobson: got time today after standup to pair on https://phabricator.wikimedia.org/T116821 ? [15:47:00] dbrant: ^^ if i make a script to do hockeyapp exports, is currently the template i plan to use for the output [15:47:00] does anyone know where the releasetagger codebase lives? [15:47:46] what does that point to? [15:48:28] oh oop [15:48:43] sorry, that first message was supposed to be in the dev channel [15:49:06] https://phabricator.wikimedia.org/T117049 [15:49:43] ah, cool [15:55:24] dr0ptp4kt dbrant: i had a question on https://www.mediawiki.org/wiki/User:ABaso_(WMF)/Extension_Responsibility . is android really the primary team responsible for the mobileapp mediawiki extension? [15:56:41] niedzielski: we kind of are, i think. [15:56:43] for better or worse [15:57:49] dr0ptp4kt dbrant: ok, and i was a little confused over what SLA meant. google says "service level agreement" but the column seems to suggest a turn around time for a patch maybe? [16:09:37] jhobs: i have a window at 10.30 pst [16:09:58] jdlrobson: sounds good [16:39:51] kristenlans: fyi joaquin and i probably missing standup :( will mail in status after [16:40:32] jdlrobson: aww bummer, thx for heads up. Anything cray going on? [16:40:48] will update later - just meeting scheduling pains [16:43:58] ok, good luck jdlrobson [16:52:56] 🚀 👾👾👾👾 [17:12:55] kristenlans: no idea what was up with my mic... didn't do anything different from yesterday lol [17:13:16] when in doubt, blame hangouts [17:15:18] jhobs: classic jhobs [17:15:25] :D [17:22:58] dbrant mdholloway bearND: have you guys been having trouble getting the android studio debugger to attach lately? [17:23:13] niedzielski: i have not [17:23:25] :| [17:23:53] niedzielski: i haven't tried super recently, but last time i did try i had no problems [17:24:54] mdholloway: it seems like this week it's been having problems. i was thinking it was my target but now i've tried a different one and am having the same troubles [17:25:04] niedzielski: works for me (using AS 1.4.1) [17:25:21] bearND: hm, i'm on 1.5 preview 2 [17:25:46] i just tried and it worked for me also (on latest stable AS version) [17:26:42] ok thanks guys. seems like it's just a stephen thing [17:26:50] (tm) [17:30:08] jdlrobson: ready? [17:32:04] jhobs: sure. Want to jump in tracy island? [17:32:07] yeah [17:56:33] niedzielski: the sla notion is how fast we will do a first code review, primarily if it's a patch submitted by someone outside of the team. first code review for patches submitted from within the team should definitely be no longer than that sla, although in practice i assume would be done sooner because they would have planned for a given sprint. if [17:56:34] volunteers or other employees move stuff through the quarter/sprint planning process, code review could be as routine as it would be for a patch submitted by someone within the team. but volunteers and other employees often don't have work on the extension or codebase as their primary focus, and they aren't "expected" to be responsive to code reviewer [17:56:34] feedback (especially for volunteers - they're volunteers!) the way an employee in the team would be. [17:58:58] dr0ptp4kt: ok thanks! [18:05:03] yurik: around? [18:05:18] jhobs, hi [18:06:05] yurik: got a minute to hangout? I can't hit the codepath locally for the zero bug [18:09:24] jhobs, one sec, just had an interview, finishing up [18:09:50] yurik: i have no more meetings rest of day, so just let me know when is convenient [18:13:04] y'all already dropped ios 7 support right? [18:13:13] or am i misremembering? [18:14:16] brion: i'm not 100% sure, but I believe I read that as well. mhurd? [18:16:40] it'll make my life simpler if you did as i can build some of the video support stuff as dynamic libraries for ios8+ :D [18:16:41] jhobs, back [18:17:13] brion: jobs: ya the upcoming version of the app does drop 7. we're supporting current and previous versions - so, for example, when iOS 10 comes out, we'll drop support for 8. [18:17:23] jhobs ^ [18:17:29] mhurd: perfect... i'll target for the new version :D [18:17:32] *autocorrect*!! [18:18:02] brion: cool! [18:18:23] yurik: when is convenient to go over some of the zero backend? I need to be able to replicate the bug locally [18:18:26] have to retool it a bit to support working alongside swift frameworks in cocoapods :D [18:18:35] jhobs, we can do it now [18:18:50] yurik: ok, will call you [18:20:08] brion: bgerstle is fast becoming a swift wizard - if you hit any bumpy spots he may have some tips. he's actually at a swift conference here in sf today and tomorrow [18:20:15] sweet! [18:20:28] all the video code's obj-c but i'll want to make sure it's easy to call from swift [18:20:32] so might need to break out the annotations [18:47:40] jdlrobson: I think I got it now. This is what would be injected: https://phabricator.wikimedia.org/P2260 [18:47:51] and I was able to test locally and all seems fine [18:48:39] Jhobs what do you mean [18:49:09] yuri found a workaround to be able to test the codepath locally [18:49:17] and I believe I fixed up what you and I started [18:49:32] that paste shows what js gets injected [18:51:07] So there are issues with that [18:51:11] Js is in global scope firstly [18:51:45] Also can you guarantee body tag is available? I assume we inject this code after closing the body tag? [18:52:03] If Dom is not ready it won't work [18:54:54] I think we can guarantee that. I'm looking at the Network tab and the script doesn't begin to be loaded until after Main_Page is [18:56:21] jdlrobson: The last file in this screenshot is the js code from the paste. It seems to wait until Main_Page is done before it begins loading https://usercontent.irccloud-cdn.com/file/ffKWYqV7/Screen%20Shot%202015-10-29%20at%202.55.03%20PM.png [18:58:39] Jhobs how is the script loaded? [18:58:42] Js still needs to be scoped though [19:04:55] MaxSem: your trolls and LOLs are truly epic #stroopwaffels :P [19:06:04] haha you too jdlrobson #stroopwaffels [19:06:19] :) [19:07:02] jdlrobson: the ZeroSpecialPage file actually refers to Special:ZeroRatedMobileAccess. That file gets loaded if the proper headers are set. If it's a js browser, it returns as a script, otherwise, it returns as a GIF and gets added directly to the page [19:07:45] by scoped I assume you mean just wrap it in a self-calling function? [19:08:10] anonymous function* [19:09:47] jdlrobson: i can go over it with code and in more detail over hangout next time you're free if you'd prefer [19:11:01] What sorcery is this?!? [19:11:11] Jhobs yup that's what I mean by scoped [19:11:30] Lemme just grab lunch but maybe we can run through it afterwards? [19:11:35] sounds good [19:11:54] I have some stronger words than "sorcery" around this system too :D [19:53:07] hey mobile, I mean reading, Gather is blocking deployment to wikipedias: https://phabricator.wikimedia.org/T117089 [19:53:20] jdlrobson: jhobs ^ [19:53:30] not sure who owns it [19:54:01] Greg first I've heard of it. Will take a look. [19:54:14] it just happened [19:54:34] Yurik might know what's going on [19:54:39] Most of php code is him [19:54:56] * yurik hides [19:55:10] Oh it's resource loader? Interesting... [19:56:01] jdlrobson, what's the q? [19:56:38] yurik: gather is broke in production wmf.4, we rolled back to wmf.3, see the bug above [19:56:51] iow: gather is blocking wmf.4 going to wikipedias [19:57:08] greg-g, i haven't touched gather for half a year )) [19:57:22] is there a task/link/? [19:57:32] see the fucking bug abve as I said [19:57:50] oop,s didn't see it ) [19:57:53] seriously, I don't care who touched this, this is a reading team issue that is blocking deployments, fix the fucking issue [20:00:16] greg-g, i'm not in the reading team, please calm. I'm looking into it, but i suspect there is a circular dep or something like that in the resource loader dependecies [20:01:47] greg-g, any resource loader experts around? [20:02:06] "RL expert" == "timo and roan" for me, unfortunately [20:02:14] maybe ori [20:02:49] MaxSem, do you know much about the resource loader updating sql on load? https://phabricator.wikimedia.org/T117089 [20:03:17] thank you yurik [20:03:31] greg-g, nothing to thank me for, just looking [20:04:51] yurik, is this even a Gather-specific problem? [20:05:16] MaxSem: i doubt it [20:05:22] Gather hasn't changed in months [20:05:51] am trying to see if there are any circular dependencies but i cant replicate the issue locally [20:05:58] MaxSem, not sure, but it does try to update gather's refs in sql [20:06:06] yup [20:06:35] and from the looks of it, there's nothing in there that would require continuous REPLACEs [20:08:10] MaxSem, do you know why load.php would ever update on get? [20:08:23] I do [20:08:28] because it has a bug [20:09:59] looking at RL, it has a few changes... [20:10:07] https://github.com/wikimedia/mediawiki/commit/32705d44cfabf15ca4b4ca7b4d7713ad0b7deed6 [20:10:57] is krinkle even around? [20:11:26] in #-ops [20:11:48] https://github.com/wikimedia/mediawiki/commit/a0809dfa5a5942a6e183eeda57e2f82bd61b7f53 [20:12:50] the ;latter might have caused massive invalidations [20:12:53] or not... [20:16:09] quick fix: undeploy gather [20:17:22] the only thing that's changed in Gather is https://gerrit.wikimedia.org/r/#/c/247534/4/extension.json [20:17:42] (since last deployment) so something has changed in core somewhere that's either surfaced an issue in Gather or other [20:28:23] thanks for looking into this, all [20:28:41] sorry I was pissy, I blame unrelated stress that is causing me physical pain [20:45:05] i just ran through dependencies in gather, seems all ok [20:52:31] jhobs, who's reviewing https://gerrit.wikimedia.org/r/#/c/249874/ ? [20:52:43] jdlrobson, ? [20:52:49] I added you and jdlrobson [20:52:58] greg-g, have you poked RL ppl about it? [20:53:00] I still need to go over it with jon though [20:53:09] ok [20:54:20] yurik: jhobs code looks fine as long as you can test it i'm okay merging once you've responded to my comments [20:55:13] jdlrobson, +1 it when its good, i will test it and merge [20:55:24] might even depl today [20:56:01] greg-g, zero has been broken for the past day or so, need to deploy it once jdlrobson is ok with it - https://gerrit.wikimedia.org/r/#/c/249874/1/includes/ZeroSpecialPage.php [21:04:39] jdlrobson: uploaded new PS [21:12:02] jdlrobson: got some time to go over it? yurik will test as well but I want to put confidence in that +1 first ;) [21:25:32] yurik: he's +1'd. If you still think you can test/merge (and maybe even deploy) today, go for it! [21:25:47] * yurik looks [21:26:02] i've also run through it with him [21:36:37] * yurik still testing [21:53:34] jhobs, that bug that i just fixed - i saw it because of the idea storm - it highlighted that you didn't init that var. :)) [21:53:58] keeps proving the value there ) [22:00:48] heading out for the night. yurik: I'll stay logged in on my phone in case you decide to deploy today. ping me if you need me [22:01:06] jhobs, it will be deployed in one hour [22:01:12] during SWAT [22:01:41] yurik: alright, just ping me if you need anything and/or when you're done so I can test [22:02:34] hey jdlrobson & reading-web. with an external QS, what are we logging to EL? Working on privacy policy for the first survey [22:03:54] jhobs, ok [22:42:38] JoshM: https://phabricator.wikimedia.org/T117118 needs a project assigned [23:20:59] thanks bd508, fixed [23:33:13] bd808 :) [23:52:02] o/