[00:56:42] o/ [06:53:54] jdlrobson: http://www.gossamer-threads.com/lists/wiki/wikitech/611381 [06:54:34] good thing the current frontend standardization group is sitting about five feet from you :) [07:18:01] tgr: we were discussing this last night, without having seen that email [07:18:17] the "something is better than nothing" part of it anyway [07:18:20] :) [07:59:24] hallo [08:02:56] yep, i answered http://www.gossamer-threads.com/lists/wiki/wikitech/611381#615538 [08:02:57] hehe [08:03:05] nobody followed up lol [08:10:03] phuedx|coffee: for testing the html-only version would spinning up the server and making http.get requests be a good idea? [09:05:38] tacit agreement? [09:05:53] yo [09:09:05] joakino: integration tests are the first ones to write [09:09:13] then we refine and refine while writing unit tests [09:09:41] i say that as if it is fact, but schools of thought contend [09:09:43] 👍 [09:11:03] phuedx: i'd like to see some live coding on these matters to see how people approach it [09:11:05] have any links? [09:13:45] i don't have any links to live coding [09:14:51] or scripted coding :p [09:16:59] nope [09:17:15] * phuedx double checks [09:37:34] joakino: nope [10:09:10] o/ [10:10:56] o/ [10:11:53] hey y'all [13:20:07] yo [13:20:24] trying to get tired children to bed is /so/ hard [14:10:25] brb [15:48:30] mdholloway: i haven't made strong headway on the test issue yet. still looking into it [15:50:11] niedzielski: cool, thanks. I'm unfortunately still dealing with laptop trouble. the work laptop didn't seem to take well to the el capitan upgrade. [15:51:24] mdholloway: that's a bummer :| i remember being a little disappointed with the mavericks install after a month or so [15:51:33] mdholloway: just didn't seem as stable [15:53:47] it's been great on my personal laptop, an early 2011 Macbook Pro (which I'm on now) but my wife says it's been sluggish on hers, which is also a MBP from around the same time [16:04:34] mdholloway: my wife is a luddite when it comes to upgrades :) she's on lion or something ancient [16:05:06] mdholloway: look at this: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-test/buildTimeTrend . so, i think i started noticing these changes when i disabled the hardware acceleration for the webview which corresponds to a minute spike in the build time [16:05:13] changes = test failures [16:05:28] niedzielski: ooh, that's interesting. [16:18:02] niedzielski: i'm liking that passing test build! :) [16:18:19] mdholloway: i think the tests were just timing out [16:19:41] niedzielski: yep. i started thinking that again last night after poking around some more and the buildTimeTrend chart you posted supported that. awesome! [16:20:59] niedzielski: i wonder where that 0 ms timeout value in the error message was coming from. [16:21:28] mdholloway: yeah, that was confusing. i was seeing timeouts locally using the arm emulator but they didn't quite look like that [16:45:04] mdholloway bearND dbrant: would someone mind reviewing this so we can get some of the other patches merged in? https://gerrit.wikimedia.org/r/#/c/251262/ [16:45:30] niedzielski: sure, looking now [16:45:39] thanks! [17:24:47] rebasing... [17:26:57] mdholloway bearND dbrant: would someone mind reviewing https://gerrit.wikimedia.org/r/#/c/251141/ ? this is blocking some of the test patches i have cooking [17:27:50] niedzielski: sure thing, just finishing up a comment on the syntaxhighlightertest patch and i'll hit that next [17:27:59] mdholloway: thanks :) [17:33:02] bmansurov, bearND, gwicke, phuedx reminder meeting in t minus 2 minutes [17:33:35] dr0ptp4kt: ty, i'm ready [17:37:27] jdlrobson: I'm seeing "Error: Unknown dependency: ext.gather.watchstar" in my js console all over the prod sites. Known issue? [18:00:49] jdlrobson: be right there [18:01:28] kristenlans: he's not here yet either! D: [18:04:42] jhobs: start without me [18:14:31] dbrant: in PreviewFetchTask we are asking for the WD description and a thumbnail. I think we don't really need that since we're not using that anymore. Is that correct? [18:17:09] heading to tracy island if anyone is bored to talk to joaquin [18:19:35] bearND: checking... [18:22:10] bearND: yep, we don't need the description there; but we do need the thumbnail. [18:23:49] dbrant: where do we use the thumbnail? We had one in the earlier link preview version but not anymore [18:24:35] phuedx: bmansurov can you join tracy islan quickly? [18:24:56] bearND: we're bringing back one of the earlier link preview designs for one final a/b test ;) https://gerrit.wikimedia.org/r/250724 [18:29:43] dbrant: i see. Do you think we would want one with a WD description in the future? We had a meeting earlier about common text extracts API calls powered by a new RestBase service. https://phabricator.wikimedia.org/T117082 [18:29:52] bmansurov: ping [18:32:16] bearND: It's possible... but I would rather have an extract than a WD description. If we can improve the extract, all the better. [18:32:59] dbrant: ok, thanks. I'll update the task to remove the description [18:37:43] dr0ptp4kt: r34 [19:02:02] niedzielski: are all the hygiene patches ready for merge? [19:02:26] dbrant: yep! [19:30:40] heads up: https://en.wikipedia.org/wiki/Talk:Main_Page#Adding_Template:Main_Page_banner_to_the_Mobile_site_front_page [19:50:18] mdholloway: hey! i saw your note about the api 15 emulator not running well on el cap. i *think* that intel dmg installer thing in the sdk directory is supposed to run automatically now, but you might run it again after verifying you have the latest and greatest [19:50:31] mdholloway: i think the sdk manager sometimes lags behind. you might try https://software.intel.com/en-us/android/articles/intel-hardware-accelerated-execution-manager [19:50:43] mdholloway: and, of course, make sure you image is x86 [19:50:54] mdholloway: api 15 actually runs teh fatest for me [19:51:51] if nobody has an issue with it, I'm gonna be afk for < 1hr around 4pm est. I'll make up lost time this afternoon. [19:52:05] niedzielski: yep, trying to load x86. i'll give the haxm install a closer look; i actually just freshly installed AS on this laptop and it claimed to be installing haxm but it's worth checiking for an update [19:52:56] mdholloway: i just seem to recall that after upgrading to mavericks i had to manually download the latest haxm and it didn't appear in the sdk manager for a little while. maybe i'm not recollecting correctly though [19:55:16] mhurd_afk bgerstle coreyfloyd: would one of you fine gents code review this fine extensions patch? https://gerrit.wikimedia.org/r/#/c/249750/ [19:55:30] mhurd_afk bgerstle coreyfloyd: it's a two (image) file change [19:55:40] niedzielski: what should i be looking at here? [19:56:16] bgerstle: i think you just need to check out the patch and rebuild your css-age [19:56:36] so this image will apply to iOS too? [19:56:57] bgerstle: afaik, you should see an update to your pencil icons if [19:57:06] bgerstle: *after you rebuild your css [19:58:50] niedzielski: to be clear, our CSS doesn't reference any edit button files [19:59:02] i take that back [19:59:13] i guess the "base" css we pull down from MAE does [20:00:27] niedzielski: e.g. the background-url is set to background-image:url(//en.wikipedia.org/static/1.27.0-wmf.2/extensions/MobileApp/images/edit-locked.png?2ded5) [20:00:28] currently [20:00:34] not sure what that query param is [20:00:59] bgerstle: yeah, so just rebuild that to use a local copy [20:01:32] niedzielski: k, i don't have vagrant setup atm. does design realize this will affect iOS too? [20:01:35] kaity_: nzr ^ [20:01:49] bgerstle: sup? [20:01:58] android wants to use a "Material" edit button [20:02:05] if them & JoshM are ok with it, i'd say merge and we can double-check after it's deployed [20:02:08] and revert if necessary [20:02:16] it won't affect the production app since we don't update that stuff OTA [20:02:37] bgerstle: we can also have our own pencil, right/ [20:02:45] bgerstle: won't merging the patch affect production? [20:03:04] bgerstle: i.e., that is a url pointing to an image in the css [20:03:09] bgerstle: i need to talk to dmitry about that too about pencil with a lock icon. i dont think material design has that icon. it just has the encil [20:03:11] niedzielski: ah crap you're right [20:03:38] bgerstle: nzr: that's been approved by kaity_, i believe [20:03:48] but has she seen what it looks like on iOS? [20:05:10] nor iOS can have our own [20:05:17] nzr [20:05:54] niedzielski: dbrant is there even a reason why you're fetching this from MAE? [20:05:59] can't you serve it from the app itself? [20:06:03] we're doing that w/ some stuff [20:06:35] e.g. make your CSS overrides point to some URL w/ a custom scheme to get edit button and other UI-related stuff that's not shared w/ web UI [20:07:09] bgerstle: yeah, that's probably a better way to go. [20:16:22] bd808: where are you seeing that? [20:16:33] jdlrobson: I'm seeing "Error: Unknown dependency: ext.gather.watchstar" in my js console all over the prod sites. Known issue? [20:16:45] not a known issue.. but wikidata reported something similar yesterday [20:17:04] I was seeing it on mw.o and enwiki but ... I can't reproduce now [20:17:28] err not enwiki, metawiki [20:18:11] jdlrobson: I can reproduce on https://meta.wikimedia.org/wiki/Main_Page [20:19:03] bd808: I see no js errors on that page... :/ [20:19:57] hmmm... let me see if I have anything weird turned on there [20:21:08] I have hovercards beta feature enabled and my normal global js -- https://meta.wikimedia.org/wiki/User:BDavis_%28WMF%29/global.js [20:21:14] nothing else funky [20:24:25] bd808: could be this line in your global maybe...? [20:24:25] mw.loader.using( 'ext.gather.watchstar' ).done( function () ... [20:24:42] I /think/ we pulled watchstar out of gather [20:24:47] bearND|afk dbrant mdholloway|afk: all the pronunciation patches + the test proguard patch are rebased and ready for review :) [20:25:10] jhobs: doh. yup [20:25:35] cool, hope that fixes it [20:26:57] I totally didn't remember that I had copy-pasta'd that from jdlrobson. Error gone after editing my global js [20:27:19] awesome, glad to help [20:42:44] bd808: weird... meta doesnt have gather [20:43:06] jdlrobson: it was stuff in my global js file [20:43:16] so a complete n00b false alarm [20:43:38] ah so you copied global js into meta without testing it [20:43:41] ;-) [20:53:19] bearND: is it ok to remove HtmlPageLoadStrategy? [20:53:45] niedzielski: yes [20:53:56] bearND: great. thanks! [20:54:03] no, thank you! [21:18:00] dbrant|brb: ok to merge https://gerrit.wikimedia.org/r/#/c/251354/ ? [21:19:29] jdlrobson: hey, maybe we can clarify the wikibase search thing quicker on irc? [21:35:18] niedzielski: ok! [21:40:07] hey benestar [21:40:08] what's up [21:45:24] hey, I just wondered what you think I can do better at https://gerrit.wikimedia.org/r/#/c/251203/4 [21:52:20] jdlrobson: --^ :) [21:52:29] benestar: looking [21:53:03] benestar: so firstly why can't you edit wgMFSearchAPIParams safely? [21:53:26] it's just a global you set after defining MobileFrontend ? [21:53:47] from within Wikibase? [21:54:17] in the site configuration [21:54:37] ah, ok. Yeah that would work perhaps but still the other issue is there [21:54:49] because there may be Wikibases installed without MobileFrontend [21:55:01] Just as Wikibase is optional for MobileFrontend, MobileFrontend should be optional for Wikibase [21:55:18] so in which case all you need a config variable for is generator prefix [21:55:22] not generator.name [21:55:56] or am i missing something? [21:56:44] oh.. data.query[generatorName] ? ergggh [21:57:07] yes, that's the issue :( [21:57:19] okay i see more where you are coming from now [21:57:40] It's not your fault the API does that bad. Can we drop _getSearchGenerator though and simply make this a property inside the constructor? [21:57:50] e.g. this.generator = mw.config.get( 'wgMFSearchGenerator' ) [21:58:14] You shouldn't need a fallback - it should always be defined [21:58:16] sure :) but I fear we cannot get around specifying both the prefix and the generator name in the config :S [21:58:23] ok [21:58:38] I think your patch is fine in current form knowing what i know now [21:58:45] I just think it can be cleaned up a little [21:58:50] if you can do that in next 30 mins i'll merge [21:58:55] hehe :) [22:03:01] jdlrobson: I think one of us must be misunderstanding the other when it comes to the last test on that cirrus search patch. Got time to tracy island? [22:03:24] sure let me grab my headphones [22:06:03] dbrant: feel free to comment on https://phabricator.wikimedia.org/T117082#1786932 (re:text extracts for link previews) [22:06:42] bearND: cool, will do [22:06:52] ty [22:08:52] jdlrobson: should the custom wikibase search generator be defined in the config or as a soft dependency within Wikibase? [22:09:11] The second option would make it work on other Wikibase installations without more configuration needed [22:10:58] when defining it within wikibase, we should perhaps provide the default value in the javascript [22:16:33] ok, I'm off now [22:16:38] bye [22:19:25] Hey. [22:19:38] New here. [22:19:55] I’m trying to build the iOS app at the moment and am having a bit of trouble. [22:20:05] Anyone available around to give me a hand? [22:22:36] I’m having trouble with Swift. I’m getting tonnes of errors and it’s failing to compile. [22:23:03] I’ve got all the dependencies from what I can see, I’ve installed the pods…etc [22:23:14] And still nothing. Don’t know what I’m missing? [22:25:36] Everybody busy then? [22:25:54] mattesee: hello! the iOS team is comprised of: bgerstle_afk, coreyfloyd, and mhurd_afk [22:26:25] Cool. [22:26:41] Oh, so this is for Android and iOS I see. [22:26:52] yep, as well as mobile Web [22:27:00] Ah ha. [22:27:04] Right. [22:27:13] I’m guess they aren’t about then? [22:27:32] I see, they have changed their names to afk. [22:27:47] I’ll pop back later then. [22:27:48] mattesee: i would guess not; I'd check back during EST working hours [22:28:57] Ah, it’s 5pm there. I just missed them. Ah well. Thanks! [23:35:57] bearND: i have a question for you regarding a restbase response. do you have time now or should i shoot you an email for tomorrow?