[00:41:04] niedzielski-afk: sorry, I missed you. I'm going to respond via email. [00:57:33] o/ [04:29:49] jdlrobson: hey, got some review work to do. [08:37:59] morning [09:18:33] morning [09:50:23] thanks for that email joakino [09:53:21] which none? [09:53:25] *one? [10:06:12] post lila update one [10:06:13] hey bmansurov [10:06:24] hello ;) [10:10:37] hi bmansurov [10:10:46] hey king [10:49:05] Can anyone explain to me where/how in the app code the delete symbol ( in the search article top window line ) is defined. I mean the "X" symbol left of the language button, I do not mean the delete trash button icon [10:49:45] "delete symbol" = empty the search input field [11:16:55] wikinaut: apps apps folks are usually online during PST working hours if I'm not mistake [11:17:10] n [11:22:20] ok [11:22:22] yep [11:22:24] bye [12:52:17] if there is any Android Dev around, I am wondering if we could target Android TV :-} [12:52:41] cause the play store or f-droid don't let me install my favorite app on my TV ! [13:10:13] anyone else having problems loading irccloud? [13:12:46] later [14:27:00] Can anyone explain to me where/how in the app code the delete symbol ( in the search article top window line ) is defined. I mean the "X" symbol left of the language button, I do not mean the delete trash button icon ("delete symbol" = empty the search input field) [14:47:19] Hi wikinaut, that's defined in the SearchView source code as opposed to any of our code. According to StackOverflow, the X itself is actually an ImageView with the ID search_close_btn. [14:47:29] https://stackoverflow.com/questions/24794377/android-capture-searchview-text-clear-by-clicking-x-button [14:48:36] wikinaut: https://github.com/android/platform_frameworks_base/blob/master/core/java/android/widget/SearchView.java#L281 [14:54:35] mdholloway: I supposed this already. thanks for the pointers. I will try to find a solution (it#s about the incognito mode I am still working on. I noticed that I overlooked the remains in the search input field) [14:55:40] mdholloway: 1000 thanks! [14:56:29] wikinaut: No problem! [16:50:03] jdlrobson: I'm loving the clickbait email subjects :P [17:10:52] Hi FlorianSW [17:11:02] Hi fuzheado :) [17:11:11] Can i ask you a quick question? [17:12:11] fuzheado: sure [17:12:29] I was reading this thread on Mobile-L [17:12:30] https://lists.wikimedia.org/pipermail/mobile-l/2015-November/009916.html [17:12:47] that doesn’t seem to be the mode that en.m.wikipedia.org is in, is it? [17:12:58] (I’ve never edited the mobile “front page” before) [17:13:14] so I’m not sure what page to edit for the mobile front on en.wp [17:22:16] fuzheado: you can edit [[en:Main_Page]] directly (if you've the permission to do so) [17:22:18] @link [17:22:18] http://enwp.org/Main_Page [17:22:43] I do… but does that really map to what i see on en.m.wikipedia.org? [17:22:57] it may be wrapped in layer upon layer upon layer of templates perhaps? [17:23:39] fuzheado: Main page is a bit different :) First, all elements, that has a specific id are visible, then all elements with id starting with mf- will be appended to the output [17:23:52] it should work, if you change mp-banner to mf-banner [17:24:23] yeah for this one instance perhaps… i’m just trying to figure out the general task of editing any/all elements of the main page on mobile [17:24:38] Like right now, there’s a massive “Welcome, Foobar!" [17:24:50] message on the mobile interface… which is just kind of lame, given how much space it takes up :) [17:25:34] fuzheado: I can't find your edit here: https://en.wikipedia.org/w/index.php?title=Main_Page&action=history :/ ? [17:26:01] I didn’t edit… I’m still trying to understand how [[Main_Page]] generates what I see on mobile.. [17:26:36] and can I change the left sidebar that opens up when I click on the hamburger icon [17:26:54] It’s all rather mysterious [17:26:58] fuzheado: the welcome message lives in [[en:MediaWiki:mobile-frontend-logged-in-homepage-notification]] (it's a system message) [17:26:59] @lin [17:27:01] @link [17:27:01] http://enwp.org/MediaWiki:mobile-frontend-logged-in-homepage-notification [17:27:44] fuzheado: the main page magic mostly lives in https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L170-L243 (if you understand some php :)) [17:28:00] fuzheado: no, the left flyout menu isn't configurable, currently [17:28:09] aha, this is what i’m looking for [17:28:18] :P [17:28:38] So I’m not sure if you saw the Phabricator request, but is there a reason why a “Contributions” item is not in the left flyout menu for logged in users? [17:28:59] https://phabricator.wikimedia.org/T117970 [17:30:30] so i suppose the $10,000 question is how MobileFormatter.php relates to https://www.mediawiki.org/wiki/Mobile_Gateway/Mobile_homepage_formatting [17:30:46] it’s not clear to me, as a neophyte on the mobile interface [17:31:38] My overall motivation — It’s time to eat the dogfood. If the majority of our visitors will be from mobile, it’s about time for Wikipedia veterans to start using mobile to see what it’s like [17:33:42] yo JoshM, got a minute for a Hangout? [17:34:10] JoshM: if the answer is No, that's ok [17:36:32] fuzheado: the guide on mediawiki, you linked, is a bit outdated, but the main functionality should still be the same. You should, probably, think about having a more responsive design, instead of relying on our main page special handling (which needs to be deprecated in the future, sometimes, maybe ;)). [17:37:03] mdholloway: are you interested in what I will improve ? [17:37:21] So, the best would be, if you create a page, which isn't the main page, which would look great on a desktop and on a mobile phone. After that it should work, if you simply move the page to the main page. You should avoid any div with an "mf-" prefix [17:41:15] wikinaut: sure, what did you have in mind? i am curious. i know there was an incognito mode patch out that dbrant|brb and some others were looking at, but last i heard it was not going to be merged. [17:41:42] FlorianSW: thanks, that was what I was thinking, that we have a rat’s nest on the front page that probably needs an overhaul anyway [17:42:18] fuzheado: that would be great, if enwiki is doing that :) [17:42:25] mdholloway: yes. This morning I found, that when you entered "xxx" into the search input, this was _not_ deleted [17:42:30] jdlrobson: ^ *yay* *fingerscrossed* :D [17:42:37] now, with your help, I could fix that, too [17:42:41] commit follows soon [17:42:43] Well, how BOLD will the community allow people to be in mucking around with it… not sure :) [17:42:52] :P [17:43:17] I hope they will accept it, a movile optimised main page for enwiki would be a massive step in the right direction :) [17:44:08] wikinaut: i see. at what point what it be deleted in what you're working on now? [17:48:14] mdholloway: here https://gerrit.wikimedia.org/r/#/c/248075/13/app/src/main/java/org/wikipedia/search/SearchArticlesFragment.java [17:48:20] tested. works very well [17:48:32] one can cherry-pick the whole change [17:49:02] I use it in my version [17:49:43] mdholloway: I did not "use" the delete button, I "simply" clear the edit search text [17:50:10] searchEditText.setText(""); [17:50:32] and, provisionally, searchView.setQuery("", false); [17:50:38] wikinaut: ah, i see. yes, an incognito mode would definitely not want to persist old searches [17:50:39] ;-) [17:52:01] Yes. But the https://gerrit.wikimedia.org/r/#/c/248075/13 has almost everything (except of really clearing previous caches. This can be done later.) [17:52:21] it would be nice, if you can help to bring it forward (to deployment) [17:52:30] technically. it's fine [17:52:52] politically ? I am not in the Design or Policy group... [18:00:15] wikinaut: well, dbrant is the Product Owner for the app, and niedzielski is the tech lead, and I see they already commented on T96546 about why they didn't merge it. i'm not really in a position to override them, even if I disagreed. [18:00:50] wikinaut: i think they're correct that we'd need a larger refactor in order to really provide the privacy guarantees that an incognito mode implies. [18:02:48] phuedx|nom: you able to quickly elaborate on https://gerrit.wikimedia.org/r/#/c/250866/15/resources/ext.relatedArticles.readMore.bootstrap/index.js when you get back? [18:02:57] whoops [18:03:03] ^ better [18:03:54] jdlrobson: during testing (w/ debug=true), i regularly hit a race condition between the loading of minerva/index.js and the required pagelist.scripts module [18:04:12] so M.require( '...' ) would fail /hard/ [18:04:50] the minerva-specific module doesn't have a dependency on the mobile.pagelist.scripts module iirc [18:04:55] it probably should do :) [18:04:58] (mibad) [18:05:26] jdlrobson: In the future if a card is design heavy can you have Nirzar sign off on it? Like this one https://phabricator.wikimedia.org/T113635 [18:06:10] and i think that it's uncovered by removing the $( function () { } ); wrapper [18:06:35] jdlrobson: I agree that we just wanted to get a quick version out but its easier to keep it all in 1 task instead of making a separate task to fix the first - like this one https://phabricator.wikimedia.org/T116810 [18:07:06] phuedx: thx [18:07:39] jdlrobson: i think it's a quick fix (add the dep) [18:10:35] phuedx: yup [18:12:25] phuedx: thanks for the config patch [18:12:27] i squashed it in [18:12:32] mbinder: We decided to start ios standups on Monday right? [18:12:40] jdlrobson: cool [18:12:44] i didn't see it as a blocker [18:12:46] are you able to take another look phuedx - i'm off on vacation tomorrow [18:12:52] so keen to get it wrapped up before i got :) [18:12:54] (email shortly) [18:12:58] jdlrobson: looking now [18:13:50] phuedx: ahrggh i forgot [18:13:51] kaity_: we're doing a planning meeting this monday, so no iOS standup then. Trying to move to iOS only standups after that, but we've had a hard time with scheduling, working on it [18:13:54] RL complains if dependency not there [18:14:09] mbinder: ok thanks! [18:15:47] omw to hangout... [18:16:18] jdlrobson: YAY!!! [18:16:29] mdholloway|mtg: bgerstle_afk mhurd_afk standup [18:16:54] hrrrm [18:17:03] mbinder: vacation:) [18:17:16] mhurd_afk: oops, sorry. Get off IRC! [18:18:08] mbinder: haha on way to breakfast [18:18:58] phuedx: fixed [18:20:53] hrrm [18:22:20] jdlrobson: could you add a comment explaining why that's included [18:22:36] it's a compromise that i'm just about ok with [18:23:44] phuedx: done [18:28:36] jdlrobson: just testing locally [18:32:09] dbrant: estimation [18:50:00] dr0ptp4kt: we're starting up retro early if you want to join [18:50:08] ok [18:50:12] getting the kids to bed [18:56:54] etonkovidova: getting an early start on android retro if you would like to join [19:42:31] phuedx|afk: joakino jhobs sent a detailed email with instructions for while i am gone [19:42:36] let me know if you have any questions [19:43:18] Thanks jdlrobson! [20:06:02] niedzielski: hi [20:06:47] wikinaut: hello! [20:06:55] You asked: [20:06:57] do we want to erase the input when there's no incognito mode yet? I think of the user as picking a search result and if it's not quite what they're looking for, they can pick anothe [20:07:28] In my incognito patch, the input is _only_ deleted, if this is incognito is active [20:07:56] I think, we should not change the "standard" behaviour [20:08:05] (= non-incognito mode) [20:08:15] was this, what you meant? [20:08:37] wikinaut: i think so. since the app doesn't have incognito mode, we shouldn't pick this change [20:08:54] I do not understand [20:09:07] My patch is for >incognito< only [20:09:16] I simply added what was forgotten [20:09:43] wikinaut: ah, ok. makes sense. i misunderstood [20:09:56] everything clear now ? [20:10:13] wikinaut: yep, thanks :) [20:10:20] I reopened that change, added my additional code, and abandoned [20:10:23] formally [20:10:36] but so, we can resurrected that, once it is wanted [20:10:55] and: everyone who needs this now. can cherry-pick it immediately [20:11:18] (my wikimedia-app has this built-in) [20:12:18] niedzielski: I guess, you don't have the time, but you >should< try it [20:12:23] wikinaut: sounds good. if you're really interested in promoting this feature, you should fork the repo, make the feature amazing and compelling, and then make a pull request. this will also allow users wanting interim releases to get it [20:12:40] pull request ? [20:12:45] on github ? [20:12:50] er, sorry, gerrit patch [20:13:04] ? it _is_ a gerrit patch [20:13:07] isn't it ? [20:13:13] it is but it's incomplete, right? [20:13:16] NO [20:13:21] it is complete [20:13:40] all the caching stuff and ui is there? [20:14:01] ui: yes. Fully ready. [20:14:27] delete buttons are not shown, if there is nothing. Texts are shown, guiding users to the settings [20:14:27] when i say ui, i mean the considerations we talked about in phabricator about supporting an incognito mode. not just the checkbox [20:15:01] nobody stated, what they regard as missing. [20:15:22] I mean, everything is solved from _my_ perspective [20:15:22] wikinaut: ok cool. will check it out [20:15:48] so, for a user 2, no inputs or history from a previous user 1 is visible [20:16:09] may be, that if you run the app on the SD Card, that then something could be hacked fromn the device.... [20:16:27] This is up the "security", not to "Design", in my view. [20:16:35] s/the/to/ [20:16:52] You should test it. [20:17:21] it is up to date, can be rebased at any time [20:17:30] (ony it is reopened) [20:17:33] once [20:18:49] niedzielski: just ping me, if you have further questions, or issues. I will be in standby, or come back here, if you call me [20:19:22] wikinaut: thanks, i'll follow up in the phab [21:14:05] jdlrobson: hi [21:14:19] Thanks for +2 ing the patch. I hope it was ok? [21:17:31] jdlrobson: around or busy? [21:58:30] niedzielski: hey, should audio output in https://gerrit.wikimedia.org/r/#/c/250903/ be working if i, say, hard-code pronunciationUrl to an audio file from Commons? [21:59:05] mdholloway: yeah, just make sure it's not the file page. has to be a link to the audio file itself [21:59:24] mdholloway: https://upload.wikimedia.org/wikipedia/commons/f/f3/En-us-Neptune.ogg should work [21:59:49] mdholloway: it might sound a little distorted in the emulator [22:00:23] niedzielski: ok cool. I tried just now with a Gandhi speech, but sure enough, looks like I foolishly requested the file page [22:00:47] mdholloway: i made the same mistake at least twice so it was the first thing i thought of [22:00:49] jdlrobson: around now? [22:01:00] niedzielski: i'm trying on my 6P [22:02:25] niedzielski: nice! [22:02:31] \o/ [22:09:26] jdlrobson: does 'wmgQuickSurveysConfig' need to have "'enwiki' => true" as well, or is 'default' enough for that one? [22:09:39] sorry, i meant wmgUseQuickSurveys [22:11:07] jdlrobson: nevermind, forgot the survey config was started on an old patch set of the extension config [22:11:20] should be fine once it actually merges [22:16:52] jdlrobson: ping when you get a chance [22:17:16] jhobs: hey [22:17:28] jdlrobson: the survey config still has an example link [22:17:38] instead of the qualtrics survey [22:18:19] if you can quickly fix, I'll +1 and bug baha or sam to merge next week [22:19:18] good catch [22:19:19] will fix [22:19:34] jdlrobson: missing for sometime now [22:19:55] Well i am back. Thanks for merging my patch set :) [22:20:34] hey d3r1ck_ [22:20:56] hey, long time jdlrobson [22:22:30] jdlrobson: So how has the Mobile Frontend been moving? [22:23:01] jhobs: fixed [22:23:18] jdlrobson: not really... try going to that url [22:23:19] https://docs.google.com/a/wikimedia.org/forms/d/17vKKxhVF4A3iO71JNQ4xbvc42Md3U87W%20gnYwmXISqoM/viewform [22:23:26] jhobs: it's not enabled yet [22:23:29] oh ok [22:23:34] i expect you to check the url before it goes live :) [22:23:52] jdlrobson: will do [22:24:02] d3r1ck_: it's been moving a little slowly ... would be great if you have time to help us clear out the workboard :) https://phabricator.wikimedia.org/dashboard/manage/125/ [22:25:42] jdlrobson: so what should i do on the workboard? [22:25:52] Is there a task for me to do specifically? [22:44:22] jdlrobson: any last things you need from me before I head out for the weekend? [23:03:15] d3r1ck_: anything under "Tasks suitable for beginners" :) [23:03:24] jhobs: i'm good! have a great weekend and see you in december! [23:03:49] jdlrobson: have a great vacation! [23:04:32] jdlrobson: really? [23:05:17] d3r1ck_: yes :) [23:05:21] ok, i will try my best to help :) [23:06:22] jdlrobson: ok. I will start from tomorrow :) [23:11:12] mdholloway: you around? [23:11:23] dr0ptp4kt: yep, i'm here [23:11:43] got a webcam so we can troubleshoot your computer thing? [23:12:06] mdholloway: i had to deal with this not so long ago. i may have an idea of what to do. [23:12:36] dr0ptp4kt: sure, i have an external one that i can grab from downstairs [23:12:40] (i have a faulty battery on my machine, although issues were surfacing before that was emerging from the efi/bios whatever) [23:12:51] mdholloway: k, lemme know when you're ready [23:13:00] dr0ptp4kt: that'd be great. ok, one sec [23:21:04] dr0ptp4kt: ok, wanna give me a call? [23:29:20] mdholloway: sorry, got distracted! you still there? [23:29:27] dr0ptp4kt: yep!