[00:45:22] leila: did you get staff rights on enwiki? We need to put the survey link here (https://en.wikipedia.org/wiki/MediaWiki:Reader-segmentation-1-link) instead of directly in the code [00:47:38] there are no staff rights on enwiki only [00:47:54] you have to get global staff rights, or global interface editor rights [00:48:17] this is done through the CA team IIRC [00:51:20] jhobs, https://office.wikimedia.org/wiki/Community_Advocacy#How_to_get_user_rights_changed [00:51:35] Krenair: that's fine, whatever, I more meant that we need a new page created which leila has done or gotten done before already for this project [00:55:36] seems to be 'gotten done': https://en.wikipedia.org/wiki/Special:Contributions/LZia_(WMF) [01:15:58] finally heading out for the night. Hello & goodbye bmansurov o/ [01:16:10] evening jhobs [01:16:28] leaving already? i've been going through your emails [01:16:46] i can stick around for a few minutes if you needed something or had any questions [01:16:54] that'd be great [01:16:59] shoot [01:17:13] (not as an exclamation, but as a command) [01:17:15] is there anything i can help with to make surveys work properly on prod? [01:17:37] there's only one thing left and the only way you could help is if you have global wiki staff rights [01:17:52] i'm not sure i have that [01:17:57] then you probably don't [01:18:02] ok [01:18:03] (I don't either) [01:18:19] alright then, have a good evening [01:18:33] basically the only problem left is that JonR didn't realize the link part of the config still took a message key [01:18:40] and neither did I for that matter [01:18:45] i see [01:19:01] so we have to create a new key for it, which means creating a Mediawiki namespaced page on enwiki [01:19:15] ok [01:19:20] which leila has gotten done before, so I'm hoping she should be able to do it before the evening swat [01:19:28] but thanks for offering! [01:19:47] if you want, you could review https://gerrit.wikimedia.org/r/#/c/252606/2 [01:20:01] ok i will [01:20:11] thanks. 'night o/ [01:20:17] night [01:30:58] jhobs: guillom helped me with it the other time (I didn't have the rights needed to create a page myself). I'll ask him to help. [01:31:06] jhobs: can you share a test link? [01:31:22] leila https://test.wikipedia.org/wiki/Rivers_in_mexico/zh?quicksurvey=external-survey-reader-segmentation-1 [01:31:58] note that the Visit Survey link will not take you to to the proper place for the reasons I outlined in my email [01:32:25] yup, seeing it jhobs. [01:32:45] We also didn't discuss what the readers should see when they click on "No thanks". [01:32:49] The current message is a bit confusing. [01:33:32] jhobs: what is the reason that it takes a long time for the survey to appear when I land the page? the loading time is long. [01:33:54] leila: I believe the behavior when they click Visit Survey and No Thanks are the same for external surveys [01:34:06] and probably for button presses for all surveys [01:35:19] as for the time taken to load, that's just the behemoth that is our codebase AFAIK. It doesn't start loading until after the lead section is loaded I think [01:35:32] mm, how can it be the same, jhobs? If you Visit Survey, you will be taken to an external site, right? and if you click No Thanks, you stay on site, and you will see a message. [01:36:01] leila: sorry, I should've been clearer. The behavior on the wiki is the same. Visit Survey additionally takes you to the external site [01:36:10] but in a new tab [01:36:12] I see. [01:36:37] you can see what i mean if you try out both buttons [01:36:51] and notice that they have the same result on the page [01:37:16] same result text* [01:40:13] leila: if we want to change the behavior of clicking on "No Thanks", it won't get done in time to affect the first survey. I think it's that way due to the original design of QuickSurveys (2-3 button responses that all provide valuable feedback). Personally I don't think it's too bad the way it is though; after all, "No thanks, I'd rather not take your [01:40:13] survey" is still kind of feedback [01:40:39] :D [01:40:44] let's keep it jhobs then. [01:41:55] excellent. And it seems Guillaume got the key added, so we should be all set for tomorrow. I can even bump us up to morning SWAT if the survey is live. [01:42:06] otherwise I'll leave it for the Evening SWAT [01:42:45] Let's go with the morning SWAT. I'll open the survey. Just let me know when it will go live (I'm assuming 11am PST now) [01:42:48] (morning is 8am PST & evening is 4pm PST) [01:43:03] okay, let's go with 8am PST then. :-) [01:43:04] leila: sometime between 8 and 9am [01:43:09] got it. [01:43:10] cool, i'll bump it up [01:43:28] I'll turn the survey on around 7am PST. [01:43:44] thanks a lot jhobs. :-) [01:44:12] sounds good, although there's probably not too much harm in turning it on now even if you want to save yourself a couple more hours of sleep ;) [01:44:57] I can't sleep when these things go live anyway. :P [01:45:08] haha ok [01:45:25] ok out for the night for real this time :D o/ [01:45:25] just kidding. I may turn it on before I sleep tonight if I see it's too late in the evening. [01:45:33] :D [01:45:38] have a good night [02:02:47] jhobs: any chance you are still around? [02:03:37] leila I never leave when I should :D [02:03:42] :D [02:03:43] What's up? [02:04:03] so, when I click on Take Survey, I get a Bad title page [02:04:08] The requested page title contains invalid characters: "<". [02:04:34] jhobs, ^ [02:04:48] Yeah, that's what I was saying about us hard-coding the link [02:05:00] That's why we had to create the new wiki page [02:05:12] It'll be fine on enwiki [02:05:14] ooo, you're saying this will be fixed in tomorrow's deployment [02:05:17] ah! got it. [02:05:18] Yep [02:05:22] sorry. thank you jhobs [02:05:27] No problem [09:12:04] morning all [09:52:21] gd mrnng [09:52:41] stripping vowels to save on bandwidth for mobile devices [09:53:03] imagine a &uselang=x-en-novowels [10:00:27] o/ [10:07:44] good morning! [10:08:18] joakino: how's life? all is cool? [10:09:14] bmansurov: yeah, a bit of pain on the gum of my mouth. i hate dentists [10:09:22] and i hate myself for not taking care of my mouth too [10:09:30] sorry dude [10:09:38] how are you doing bmansurov [10:09:42] is it cold therE? [10:10:03] i'm doing well. not cold today. [10:10:13] but the long cold winter is upon us [10:12:03] hashar: (hshr?): YES! [10:12:08] i mean YS! [10:12:34] m nt sr hw t wll b rcvd b nd sr [10:12:52] doesn't make sense .... "I am not sure how it will be received by end user [10:13:29] hashar: how about low-quality ascii art instead? [10:13:46] I think someone proposed that [10:13:50] LOL [10:13:58] to generate thumbnails for text browsers [10:14:25] using libcaca ("caca" in french is "poop" , "shit") which converts an image to plain ascii [10:16:47] also in spanish :D [10:17:04] youtube did it as an april fool a few years ago https://www.youtube.com/watch?v=YFwaV-0XZvc [10:17:08] mgzzZ! [10:17:39] and VLC should support it as an output method [10:18:01] i have seen the future [10:18:06] and it's caca [10:18:33] (libcaca has been written by Sam Hocevar who also contributed to VLC) [10:20:31] https://github.com/cacalabs/libcaca/tree/master/caca-php [10:20:33] !!! [10:20:37] LET'S DO THIS!? [10:21:22] brb [10:24:52] Sam is nice [10:25:04] his official resumé list in languages: Japanese: while drunk. [12:00:43] i'm out for lunch [12:19:39] Hello how do I stop a background android app via an intent uri ? [12:39:27] otroViajero7: android devs will be online during PST working hours if I'm not mistaken [12:47:09] Hi! basic question here I can’t find on my own [12:47:45] what is the equivalent of my “skin.php” file on the mobile frontend? [12:48:06] where there’s html code I can see.. [12:48:25] (and modify) [12:51:48] kuaiat: mobile stuff is in the MobileFrontend extension [12:52:08] let me get the link for you [12:52:17] I know, I have installed it [12:52:25] and it works for me [12:52:32] kuaiat: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php [12:54:34] I installed if from https://www.mediawiki.org/wiki/Special:ExtensionDistributor/MobileFrontend [12:55:07] thanks for your link, It might be what I’m looking for [12:55:13] cool [12:55:55] phuedx: hello [12:56:20] phuedx: you cool if I move https://phabricator.wikimedia.org/T117108 to todo? [12:57:51] bmansuro_: yeah, you going to make cards a lib and add it as a submodule or $otherStrategy? [12:58:16] phuedx: yes, that's right [12:58:21] i'm not sure that it blocks T117444 though [12:58:41] we've yet to do a release of relatedarticles – i'm holding off for a little while [12:59:00] phuedx: you're right, i was thinking read more [12:59:11] which is available on mobile only [12:59:33] ok cool -- i'm more than happy for you to work on T117108 [13:00:04] read: gogogo! [13:00:21] phuedx: sure, just a question [13:00:28] phuedx: where would we host the lib? [13:00:42] gerrit, just like everywhere else [13:01:32] alright, any similar libs in gerrit so that I can copy&paste stuff in phab when requesting a repo? [13:02:30] why the need for a new repo? [13:02:38] could the cards repo be reworked? [13:02:47] because cards is an extension right now [13:03:43] shoot google says my password has been changed less than an hour ago [13:03:47] ?! [13:03:48] i didn't change it [13:04:25] personal or work? [13:04:49] work [13:05:23] eep [13:06:44] email oit (and ops?) with a notice that your account has been compromised [13:06:48] phuedx: naturally i can't use mail work email to send an email to techsupport@wikimedia.org [13:06:57] phuedx: can you do that for me? [13:10:19] phuedx: nm, i can use my personal email [13:10:44] bmansurov: okie -- see pm [13:12:34] later [15:43:52] all right, third attempt to go ship in my dead laptop, wish me luck [15:44:12] mdholloway|afk: good luck :) [15:55:01] bmansurov: o/ [15:55:05] everything cool? [15:55:17] hi, yeah, just waiting for techsupport to get back [15:55:33] can't access email till then [15:56:01] i wonder how this happened. I did upgrade my phone recently though. maybe i installed some malicious software that stole my data [15:56:16] phuedx: hi [15:57:32] hullo d3r1ck [15:57:37] how're you? [15:58:19] phuedx: fine. Its been a while :) [15:59:46] d3r1ck: it has, have you been working on other projects? [16:00:22] phuedx: not really. Just chool and my internship (school) [16:00:30] chool -> school [16:01:13] had a pressing school report to write. But i am fine now, i have to work on the movement :) [16:01:22] phuedx: i hope i have not been left behind :) [16:03:10] d3r1ck: so what's next? [16:03:19] also, i doubt that you've been left behind :) [16:03:41] * dbrant works on a movement of his own... [16:03:57] dbrant: heyyyooo [16:04:06] phuedx: well i have to fix as many bugs as possible :) [16:04:26] phuedx: i am a bit relieved that i have not been left behind [16:11:35] phuedx: back to our previous conversation. so should I use the existing repo for cards lib? [16:12:29] bmansurov: i don't see why not -- it's not in production; we only treat it like an extension because that's what we thought we should do [16:13:21] phuedx: ok, and it is not a big deal if the url looks like this: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Cards right? [16:14:10] bmansurov: how about http://git.wikimedia.org/summary/mediawiki%2Fextensions%2FCards.git [16:14:12] ? [16:14:54] in both urls there is the word extensions which doesn't reflect the lib [16:18:30] joakino, phuedx: holy shit guys the webapp is already looking awesome [16:18:42] i mean, not visually, but you know what i mean [16:21:01] bmansurov: point taken -- request a new one and i guess that we request the extension be deleted [16:21:08] this likely requests phab-fu [16:21:34] ok [16:36:35] QuickSurveys deployed! \o/ [16:36:41] yay [16:37:01] hi jhobs. [16:37:07] we've started receiving responses [16:37:08] :-) [16:37:46] leila: one might be me, I wanted to be 100% sure it worked haha. (but I answered it as I would as a normal viewer) [16:38:00] yeah, I can see that. :D [16:38:29] I mean, now that you explained it, it made sense, jhobs, since it is from an editor's point of view. [16:39:48] I also just tend to lookup stuff to help me with my job fairly often (although maybe not that particular article) :) [16:41:11] yup, same here. :-) [16:42:28] yeah, https://en.wikipedia.org/api/rest_v1/page/mobile-html-sections-lead/Cat has srcset attributes now :) [16:43:16] \o/ [16:47:08] on all counts [16:48:20] :D [16:49:59] jhobs: what should we do when/if we want to stop the survey? what is the process? [16:53:25] leila: tell me when you want it stopped, I write a patch to disable the survey, we let it ride the train. It'll take up to a week to hit production, but as little as two days. Basically, if we write it on a Monday it'll actually end on Thursday, and if we write it on a Friday it'll actually end the following Thursday. We can also SWAT deploy to get one-day [16:53:25] closing power, but I don't see the harm in leaving the survey open a bit longer than necessary [16:54:47] jhobs: i'll let you update T110661 and T113443 [16:54:58] got it jhobs. I'll let you know by the end of today. We can't let this run for a very long time (a week) since the form behind it cannot handle more than 200K responses and we will hit that if we run for a week. [16:55:07] phuedx: yeah, next on my todo list after responding to king's loot email [16:55:46] jhobs: in general, just in case, if we need to kill it due to an emergency situation (I don't expect it but it's good to know what to do), should we contact you or someone else? [16:56:41] contacting me is fine leila, although note that I'll be out on Monday. After me, bmansurov would probably be the next person to contact (or just an open email to reading-wmf). [16:56:58] got it, jhobs. [17:11:36] phuedx, joakino, bmansurov: I'm gonna pull this into the sprint if that's ok (unbreak now bug): https://phabricator.wikimedia.org/T118475 [17:12:38] ok from me [17:12:51] yes [17:12:55] dbrant: i just tried out the new scroll and updated toc funnels from https://gerrit.wikimedia.org/r/#/c/251540/5 . seems to work well. is it cool to rebase and merge? [17:13:31] niedzielski: affirmative [17:14:35] as a note. Don't overwrite the default behavior of an element from your extensions.. that's just guarenteed to give problems... [17:14:47] :D [17:17:58] jhobs: it's also on .infobox btw, that's also not good. [17:18:58] thanks thedj, I'll update the task and get to it as soon as I can [17:19:12] already updated the task :) [17:19:14] oh you already updated the task, thanks! [17:28:41] jhobs: is there a table with the same name as the schema in log database for https://meta.wikimedia.org/wiki/Schema:QuickSurveysResponses ? [17:29:33] leila: I unfortunately know very very little about EventLogging. Maybe JonKatz or bmansurov would know? [17:29:59] i can check [17:30:39] bmansurov: thanks. if you teach me how to do the checking myself, that'd be great, too. so I don't have to bug you guys for low-level requests. :D [17:30:53] ok [17:31:09] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#TOC_problem [17:31:15] leila: you need to ssh to stat1003.eqiad.wmnet first [17:31:34] strangely i cannot myself [17:32:12] jhobs: that's where the first reports came in. I have to catch the bus to make it home now, bbl. [17:32:17] leila bmansurov I don't see it... [17:32:38] in log. tables don't appear until there is some data there, but I would have expected some test data to populate. [17:33:32] On another project we learned from analytics that you need something like >10 events before a table update will go through...it is not done on a per event basis. Maybe testing did not yield enough rows. [17:33:38] leila bmansurov ^ [17:33:46] i see [17:34:20] leila: once in that server use the mysql table log [17:34:23] that's all [17:34:55] ah! JonKatz, I think you're right. I also remember now that a minimum number of events should happen. [17:35:20] bmansurov: thanks. I guess I should just wait a bit more. [17:35:32] np [17:35:56] JonKatz: I expect around 1 response per minute and I'm getting only half of that value, want to check the table to make sure everything is okay. [17:36:07] report back later then. thank you guys. [17:38:42] kristenlans: you there? [17:42:11] phuedx|afk, bmansurov: can either of you tell what clear: both is supposed to even be doing for QuickSurveys in this context? https://phabricator.wikimedia.org/T118475 [17:42:27] I tried simply removing the style in the inspector and the survey box looks completely fine [17:42:54] I'm wondering if it was supposed to be applied to mobile only and got thrown in the wrong media query by accident [17:43:04] jhobs: i guess it was supposed to be a multipurpose rule [17:43:58] well by > 768, I'm assuming it was trying to target tablets using minerva or something, but honestly i don't really see any harm in just removing it i think [17:45:38] jhobs: there are some edge cases I'd consider before removing that rule [17:45:51] maybe you can dig something up by reading the git log? [17:46:00] bmansurov: well it's currently breaking tons of pages :/ [17:46:08] i'll take a look [17:48:17] bmansurov: honestly the only thing I can think of is that it's there to avoid stuff like this https://usercontent.irccloud-cdn.com/file/4EvopApA/Screen%20Shot%202015-11-12%20at%2012.47.30%20PM.png [17:48:33] probably [17:48:38] but I don't even think that looks that bad and is certainly much better than what's happening now in production [17:49:13] ok, do you want to fix it and swat deploy? [17:50:48] yeah, I'm just gonna remove the clear: both completely and SWAT it and we can try to figure out a better solution later. Honestly, it should be appearing above ToC always on desktop anyways imo and it doesn't, so we should open a task around its position [17:51:06] ok [17:55:15] jhobs: bmansurov joakino phuedx|afk kristenlans mbinder JonKatz we need to use a different hangout link for the standup. iĺl invite all of you shortly, plus nirzar. we gotta get nirzar on irccloud...you guys know if heś around? [17:55:59] jhobs: bmansurov joakino phuedx|afk kristenlans mbinder JonKatz disregard, kristenlans updated invitation [17:56:05] dr0ptp4kt: nirzar is nzr [17:56:09] I don't, but how the hell did you manage to put accents on an l and an s? :D [17:56:15] oh wee. hi nzr [17:56:28] o/ [17:58:45] bmansurov: yeah there's a comment in the less file that says the clear:both is intended for mobile beta skin, although the style is being overridden on mobile by another one anyways, AND we're not targeting mobile in production on this survey, so I think we're super safe to remove it [17:59:55] ok [18:00:39] mbinder: there's no one near 3rd floor collab [18:01:44] joakino 1.2 Euros please [18:01:45] bmansurov: you won't be able to ssh to anything as i think yer ssh key has been removed [18:01:45] bearND: i have to go to standup [18:02:05] joakino: ok, no problem. Thank you! That was great info [18:02:08] :( [18:02:18] bearND: we'll talk more about all this! [18:02:42] nzr: should there be...? [18:02:52] mbinder: standup? [18:03:18] nzr: Thursday I believe Web has standup, but Apps is M/W/F [18:04:06] mbinder: yes. the web. sorry i was the only one in office [18:07:52] nzr: it's cool, I think we're still working on getting the google calendar updated. [18:09:45] jhobs, we discussed this briefly yesterday but since it has impact on the impression rate, I think: what is the reason for the widget being so slow? [18:10:06] I /think/ what's happening is that some people are scrolling down the article, before the widget gets a chance to appear, jhobs. [18:10:48] leila: it's loaded asynchronously (and probably after content is done loading) so as not to prevent the page content from loading. As to why it seems to take a while after the box shows up, I'm not sure. [18:11:07] page content takes a while to load because mediawiki loads a shit-ton of stuff [18:12:14] this happens even in small pages, jhobs. I expected I see a much different load time in short vs long pages. [18:12:28] leila: do you have an example page? [18:12:36] so i can look at it further? [18:12:39] 1 sec [18:14:54] sent you one in PM. [18:15:27] basically, in the large pages, we are giving very little chance to the user to see the survey. this can bias the results. [18:28:35] phuedx, joakino, bmansurov: anyone who can review & merge this asap, I'd appreciate it: https://gerrit.wikimedia.org/r/#/c/252736/ [18:29:15] looking [18:30:58] mdholloway: are you coming? [18:31:03] Out to pharmacy [18:31:05] here [18:31:39] dbrant: do you want to join us? (Just curious. It's optional for you) [18:47:07] thanks bmansurov [18:47:31] np [18:47:42] sorry it took longer than expected [18:48:57] bmansurov: that's fine, I gotta wait until the SWAT window anyways [18:49:07] cool [18:52:05] bmansurov: wait, is it gonna be a problem that this is on the dev branch? [18:52:16] i mean, it should be able to just be cherry-picked right? [18:52:29] yes, you can just cherry pick it [18:55:10] heading out, will be back in about 6 hours [19:00:07] bearND: dbrant mdholloway niedzielski my connection is acting up, so i just wanted us to recap the schedule of things for the next few weeks and take into account when people are going to be out [19:00:21] you guys able to speak to that on the hangout? [19:00:32] now my connection is totally broken on the video :( [21:41:18] niedzielski: what do you say we kick off the beta build? [21:41:36] dbrant: oh! right. sorry, i caught up in review fever [21:41:41] got caught* [21:46:26] bearND dbrant mdholloway: release notes are formulating in the usual place [21:49:36] niedzielski: word [21:49:46] niedzielski: want me to merge the follow-up patch for pronunciations? [21:50:08] I'm still trying to figure out why I don't see the button for it [21:54:04] bearND: oof, missed this. i don't know that it matters a whole lot if we're not turning on RB [21:54:15] bearND: do you have a cached copy? [21:54:43] niedzielski: i've tried a new page I never visited [[Half Dome]] [21:55:09] but i also refreshed the Barack page several times [21:57:53] Bummer is that with the current AS version I can't view the values of variables. Switching to Canary. Maybe that helps. [21:58:10] bearND: i don't think half dome has pronunciation audio file [21:58:30] niedzielski: ah, ok. That would explain it [21:58:34] bearND: obama seems to work for me [21:58:53] bearND: i have same issue with as. i can't inspect anything :| [21:59:12] bearND: and, maybe releated, gradlew installDevDebug fails pretty regularly for me [21:59:22] yeah, that's horrible [22:02:40] bearND: anyway, i think the patch can wait if we're going to release a new version before we turn on rb. and if that's the case, we can work out any pronunciation bugs after we get today's release sorted [22:03:17] niedzielski: sure. [22:04:01] niedzielski: I'm not going to merge it today, maybe +1 it. [22:04:15] bearND: sounds good [22:14:06] jhobs: while updating the extensions maintainer list (still doing) the alicia keys new york song came on at the same time i clicked on this https://www.mediawiki.org/wiki/Extension:RelatedArticles . See the first image. [22:14:26] cafe radio... [22:15:18] Hahaha priceless [22:24:04] dbrant: regarding your comment on T114217 [[Wikimedia:Wikipedia-android-strings-nearby empty message/en]] talks about pages not being nearby [22:24:41] dbrant: that 1) I should check the production in some wilderness 2) that unknown error for Nearby is another bug? :)) [22:25:57] etonkovidova: yeah, we just changed the wording of that string, which only appears in production. [22:26:35] dbrant: I see - ok [22:26:47] etonkovidova: and yes, that's a separate issue with the new Maps sdk [22:27:01] dbrant: understood :) [22:41:09] niedzielski: release notes look good to me. I made only a minor change. [22:41:43] bearND: thanks! looks like the other devs cleaned things up quite a bit too [23:02:36] dbrant: everything's looking good. i just noticed one thing on the b preview. if the extract is a little lengthy, it becomes truncated. it's not _really_ truncated, it's actually all there but the text field is very difficult to scroll. i assume this is fine [23:04:53] niedzielski: yeah, it's fine... and release notes look good to me! [23:09:37] bearND mdholloway dbrant: any objections to moving forward with the release? [23:10:08] niedzielski: no objections [23:12:40] niedzielski: none! [23:17:28] jhobs: we'd like to stop the survey on Monday. It's going pretty smoothly so scheduling that now makes sense. [23:17:41] What should I do to communicate this with you guys? [23:18:28] niedzielski: none! [23:19:20] lzia: can you send an email to reading-wmf with the request and rationale? Mainly for documentation [23:19:40] sure. or I can make a phab task and link in the email? [23:19:49] jhobs, ^ [23:19:54] That would be helpful as well [23:19:59] sure.thanks. [23:26:42] niedzielski: btw, I updated AS to the latest Canary build, and now inspecting variables works again. I also get the title pronunciations. Maybe before AS didn't actually rebuild. [23:27:09] bearND: thanks!