[00:57:43] <tgr>	 jdlrobson: speaking of MediaViwer bugs, if someone took https://phabricator.wikimedia.org/T119854 that would be awesome
[00:57:53] <bmansurov_goneee>	 o/
[00:58:27] <tgr>	 it's easy enough, I just keep pushing it off because I would have to unbreak my vagrant setup first that somehow got screwed up by a system update
[00:58:45] <jdlrobson>	 hey bmansurov_goneee. 
[00:58:50] <jdlrobson>	 tgr: sooo many media viewer bugs :(
[00:59:12] <jdlrobson>	 tgr: i'm drowning in the bugs for all the extensions our small team has to maintain :)
[00:59:31] <jdlrobson>	 hopefully we'll have bandwidth to look at that one next sprint
[00:59:51] <tgr>	 I can even write a patch if someone can test it
[01:00:04] <tgr>	 (or I guess I could set a labs machine)
[01:00:40] <bd808>	 I can't reproduce that on Firefox
[01:01:50] <tgr>	 bd808: is there a labs project for reading infra?
[01:01:51] <bd808>	 ah. I can in chrome though
[01:02:14] <bd808>	 tgr: not officially, no
[01:02:49] <bd808>	 there is a reading one though I think and the mw-core-team project
[01:03:12] <bd808>	 Yuvi hates grab-bag projects so I haven't made another
[01:03:34] <tgr>	 how can I get access to the reading one?
[01:03:52] <bd808>	 "ask bd808"
[01:04:53] <bd808>	 we have "reading-web-staging" and "reading-smoketest"
[01:05:26] <tgr>	 I guess staging makes more sense
[01:05:51] <tgr>	 or maybe I should just use the multimedia project
[01:06:33] <bd808>	 that project has lots of open quota
[01:07:18] <bd808>	 there are some issues with wikifarms on the current vagrant setup for labs... I need to get those fixed
[02:53:55] <matt_flaschen>	 jdlrobson, rmoen, or anyone, do you know why the Gather notifications might not be working?
[02:54:09] <matt_flaschen>	 I tried the hide both locally and on Beta, and it didn't trigger a notification.
[02:54:44] <matt_flaschen>	 Also, how do I unhide?  If I just visit the URL again as a privileged user, it gives me a 'Not found' error.
[02:55:24] <matt_flaschen>	 I'm working on https://phabricator.wikimedia.org/T116848 (Write presentation models for notifications in Gather).
[03:20:41] <matt_flaschen>	 Figured it out, the check for applicable notifications is wrong, so apparently all notifications are broken.
[08:00:23] <joakino>	 morning
[08:05:12] <joakino>	 phuedx: yt?
[08:51:22] <phuedx>	 joakino: now i am
[08:52:10] <phuedx>	 matt_flaschen: yt?
[08:52:41] <phuedx>	 matt_flaschen: is "the check for applicable notifications is wrong" on the gather side or on the echo side?
[08:52:45] <phuedx>	 also, o/
[08:54:07] <joakino>	 phuedx: i've merged your search pr, I have a few things I'd like to add to the feature, do you mind if I make a new pr?
[08:55:34] <phuedx>	 not at all
[12:34:28] <bmansurov>	 anyone (i.e. phuedx or joakino) knows why i can't see avatars in the reading web sprint board?
[12:35:38] <phuedx>	 bmansurov: nope
[12:35:44] <phuedx>	 though you can see who it's assigned to
[12:35:57] <bmansurov>	 do you see them though?
[12:40:59] <bmansurov>	 phuedx: does the config at https://gerrit.wikimedia.org/r/#/c/256348/2/includes/config/Experimental.php make sense? 
[12:41:04] <bmansurov>	 phuedx: can control be 0?
[12:42:34] <phuedx>	 control can be set to 0 then you're defining an experiment with 1 bucket
[12:42:48] <phuedx>	 perhaps mw.experiments should defend against that
[12:42:58] <phuedx>	 because an experiment with one bucket isn't an experiment
[12:43:12] <phuedx>	 (it should always evaluate to A)
[12:48:36] <bmansurov>	 ok
[12:48:37] <bmansurov>	 thanks
[16:21:29] <lbertolotti>	 good day
[16:21:41] <lbertolotti>	 I noticed some portal pages are not displaying correctly
[16:33:39] <dr0ptp4kt_>	 joakino: coming?
[16:34:00] <phuedx>	 lbertolotti: could you drop some links in the channel as examples and then maybe we can create a phab ticket
[16:37:17] <lbertolotti>	 this is the worst
[16:37:39] <lbertolotti>	 https://en.wikipedia.org/wiki/Portal:Communism
[16:38:04] <lbertolotti>	 There are problems with boxes and icons
[16:39:47] <lbertolotti>	 on this one
[16:39:48] <lbertolotti>	 https://en.wikipedia.org/wiki/Portal:Socialism
[16:40:06] <lbertolotti>	 some text in the boxes is not aligned correctly
[16:40:22] <lbertolotti>	 ex: the selected biography box
[16:40:50] <lbertolotti>	 Same on this portal
[16:40:51] <lbertolotti>	 https://en.wikipedia.org/wiki/Portal:Business_and_economics
[16:41:44] <lbertolotti>	 Idealy the portals should like
[16:41:45] <lbertolotti>	 https://en.wikipedia.org/wiki/Portal:Capitalism
[16:42:53] <lbertolotti>	 And for some strange reason
[16:43:13] <lbertolotti>	 You can't edit anything using the wikipedia app
[16:44:06] <lbertolotti>	 if it written in a portal page
[16:49:22] <mdholloway>	 lbertolotti: hello!  are you referring to the android or the iOS app?  (i just tried in the android app and was presented with a "cannot connect to the internet" message.)
[16:49:31] <mdholloway>	 lbertolotti: is this what you're seeing?
[16:49:38] <lbertolotti>	 y
[16:51:12] <mdholloway>	 lbertolotti: thanks for the report, i'll write up a phab task.  i think there are some lingering unwarranted assumptions in the app about the page being viewed/edited being in mainspace.  
[16:52:20] <lbertolotti>	 mdholloway: and about the other stuff I said?
[16:54:35] <mdholloway>	 lbertolotti: looking into it.  are you seeing problems in the app or the mobile website? (or both?)
[16:55:18] <lbertolotti>	 in the app
[17:00:52] <mdholloway>	 lbertolotti: i see some alignment issues.
[17:01:29] <lbertolotti>	 can something be done about this?
[17:03:25] <mdholloway>	 lbertolotti: would you mind creating a phabricator ticket using the 'regular' template here (https://phabricator.wikimedia.org/T104086) and attaching some screenshots of problem areas to the new ticket?
[17:04:14] <mdholloway>	 lbertolotti: i already created a separate ticket for the editing issue: https://phabricator.wikimedia.org/T120233
[17:04:36] <lbertolotti>	 I don't know how to do this
[17:05:59] <mdholloway>	 lbertolotti: if it's easier, i can create the task, and you can add screenshots if you'd like.
[17:06:43] <lbertolotti>	 maybe, but how do i get screnshot in a cellphone
[17:06:45] <lbertolotti>	 ?
[17:07:47] <mdholloway>	 lbertolotti: that will depend on the cellphone.
[17:13:00] <mdholloway>	 lbertolotti: created: https://phabricator.wikimedia.org/T120238
[17:19:47] <lbertolotti>	 ok, I got one screenshot
[17:23:10] <mdholloway>	 lbertolotti: ok! you should be able to upload it to https://phabricator.wikimedia.org/T120238 using the form at the bottom of the page.
[17:26:21] <lbertolotti>	 See now
[17:27:46] <mdholloway>	 lbertolotti: got it, thank you!
[17:27:59] <lbertolotti>	 Ok, I will upload some more
[17:45:43] <kristenlans>	 phuedx: had a standup conflict come up can you carry on w/o me
[17:45:58] <kristenlans>	 jdlrobson: ^
[17:48:02] <phuedx>	 kristenlans: sure
[18:06:15] <joakino>	 jdlrobson: yt?
[18:07:50] <joakino>	 jdlrobson: wanna join tracy island? i'll show you the webappy sw stuff
[18:09:57] <joakino>	 dbrant: vysor works pretty good for sharing the screen
[18:10:04] <joakino>	 the animations are a bit janky but that was expected
[18:10:12] <dbrant>	 joakino: good to know!
[18:17:48] <joakino>	 gotta go walk the dog
[18:17:50] <joakino>	 bbiab
[18:19:09] <jdlrobson>	 phuedx: fyi fixed that patch up for you (but no worries if you're off for the day :)
[18:19:20] <jdlrobson>	 https://phabricator.wikimedia.org/T114038
[18:35:26] <codezee>	 just confirming, does mobile frontend make use of user agent strings to detect if the user is using a tablet in its php code?
[18:54:46] <dr0ptp4kt_>	 codezee: there are code segments that speak to this in mfe - https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/4f0db830a8c0e792b944836e201ce07dc47777e2/includes/DeviceDetection.php
[18:54:47] <dr0ptp4kt_>	 codezee: but
[18:55:05] <dr0ptp4kt_>	 codezee: the pertinent file in the varnish configuration for wikimedia hosted stuff has a bearing on redirects -
[18:56:02] <dr0ptp4kt_>	 cf. https://github.com/wikimedia/operations-puppet/blob/ced86bd4a7165d5b9ca91773eb1155b89825ab00/templates/varnish/text-frontend.inc.vcl.erb
[19:02:16] <codezee>	 dr0ptp4kt_: I suppose it is with this device detection that MF is able to get idea of user quite early and decide which resource to deliver (for tablet or mobile)...
[19:05:00] <dr0ptp4kt_>	 codezee: i forget the exact code execution path, but i think basically, yes - https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/dfde634f5614e1fde5f8090196c98bfeccf4e3cd/includes/MobileContext.php#L364
[19:05:22] <dr0ptp4kt_>	 jdlrobson can probably speak better to specifics, although i think he's occupied at the moment
[19:34:26] <FlorianSW>	 jdlrobson: is the 70px fixed width for the thumbs intentional? https://gerrit.wikimedia.org/r/#/c/251445/6/resources/mobile.search/SearchOverlay.less It looks a bit strange from my point of view (especially for the placeholder images)?
[19:35:02] <jdlrobson>	 This is what it was in beta :) nzr any thoughts?
[19:35:21] <jdlrobson>	 nzr: compare search in https://en.m.wikipedia.org/wiki/Islamic_State_of_Iraq_and_the_Levant?mobileaction=beta vs https://en.m.wikipedia.org/wiki/Islamic_State_of_Iraq_and_the_Levant?mobileaction=stable
[19:35:33] <jdlrobson>	 FlorianSW: i think it's better than what's in stable any how. We can always iterate on it
[19:35:38] <jdlrobson>	 stable is extremely squashed
[19:35:54] <FlorianSW>	 jdlrobson: Ok, just to make sure, that you didn't overlook it :)
[19:36:56] <jdlrobson>	 for comparison :) https://usercontent.irccloud-cdn.com/file/zwwcm4zj/Screen%20Shot%202015-12-03%20at%2011.36.08%20AM.png https://usercontent.irccloud-cdn.com/file/ZwK9wpqg/Screen%20Shot%202015-12-03%20at%2011.36.29%20AM.png
[19:41:33] <atgomez>	 go dbrant|mtg! that was great :)
[19:42:01] <nzr>	 jdlrobson: FlorianSW beta looks correct. why is it different? 
[19:42:44] <dbrant>	 atgomez: thx!
[19:44:46] <FlorianSW>	 nzr With the move of the wikidata desccriptions, we forgot to move the appropriate styles, too :] Which are only applied in beta, currently. I merged a change, which fixes that :)
[19:47:29] <nzr>	 FlorianSW: oh great! 
[20:15:03] <niedzielski>	 mdholloway|afk dbrant: i've put a patch in for the infinite loop. please review when you can. thanks! https://gerrit.wikimedia.org/r/#/c/256729/
[20:24:49] <mdholloway>	 niedzielski: looking now
[20:30:19] <spagewmf>	 dbrant: awesome work as always. I updated https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps . But https://phabricator.wikimedia.org/T118965 suggests the RESTBase API is only enabled for a % of Android Beta app users
[20:31:43] <dbrant>	 spagewmf: yes, at the moment we're only rolling this out to a percentage of the Beta app. We just want to take baby steps in understanding how the service responds to increasing load.
[21:05:14] <spagewmf>	 dbrant: thanks. I wonder if a similar RESTBase service for link preview/Extension:Cards/Extension:Popups would be more performant than their current action API approach.
[21:06:41] <dbrant>	 spagewmf: i think that's exactly the kind of solution that the Service can (and does) provide.
[21:13:01] <dbrant>	 niedzielski: mdholloway: got a minute for quick chat?
[21:13:16] <niedzielski>	 dbrant: sure. batcave?
[21:13:34] <dbrant>	 bearND: ^ optional, if around
[21:14:12] <mdholloway>	 dbrant: sure, omw
[21:40:46] <matt_flaschen>	 phuedx, Gather side.  I have a patch at https://gerrit.wikimedia.org/r/#/c/256627/ , which I'll fix now.
[21:41:15] <gwicke>	 spagewmf: https://en.wikipedia.org/api/rest_v1/?doc#!/Page_content/get_page_summary_title
[21:41:28] <gwicke>	 example link: https://en.wikipedia.org/api/rest_v1/page/summary/Foobar
[21:50:07] <matt_flaschen>	 Done
[21:59:22] <niedzielski>	 mdholloway dbrant: ok ima kick off that sweet beta build
[21:59:35] <dbrant>	 +1
[22:04:02] <mdholloway>	 niedzielski: nice!
[22:56:21] <niedzielski>	 mdholloway dbrant: ok, i think beta is good. everyone cool with publishing the beta (and release notes)?
[22:59:11] <dbrant>	 niedzielski: looks good!
[23:02:14] <mdholloway>	 niedzielski: yep!
[23:23:25] <dr0ptp4kt_>	 Krenair: hey, just responded to the phabricator thing on the must-have sessions. i've been lobbying people, is that a problem?
[23:25:04] <Krenair>	 I wasn't expecting people to start giving identical lists
[23:26:28] <dr0ptp4kt_>	 Krenair: right. what i can do is reinforce with people that they should take a look through *all* of the proposals and see if there are others that they think fit as well. cool?
[23:27:07] <Krenair>	 ... do you think those other people have not even done that?
[23:27:41] <Krenair>	 I guess I shouldn't be surprised
[23:30:10] <niedzielski>	 mdholloway dbrant: just a heads up that we will now have 3 apks active in the play store: gb, master (includes mapbox has native libs and EGL requirements), and 134 (nonnative). master supports 9551 devices, 134 supports 9556 :) i think i could deactivate 134 but i don't know which devices it will affect or how many of them there are.
[23:30:27] <dr0ptp4kt_>	 Krenair: most people have at least had a look at a number of sessions, although i and others have been talking about these specific areas for months. i'm going to encourage people to look at everything just to be sure.
[23:32:46] <dbrant>	 niedzielski: i wonder why master supports 5 fewer devices? nothing's changed in the manifest, has it?
[23:33:50] <niedzielski>	 dbrant: i'm not sure how it detected the EGL difference. i assume the 5 fewer is just because of the native libs. maybe mips32 isn't compatible with mips64?
[23:41:47] <niedzielski>	 dbrant: i know we don't plan to promote this build, but i've uploaded to the upcoming apk in amazon for safe keeping. i'll just overwrite it next release. please note that there's a big nasty warning about reduced device support. this has nothing to do with Mapbox. it's because i've updated the device matrix to exclude a GB amazon device we claimed
[23:41:47] <niedzielski>	  to support. the remaining four warnings are due to faketouch requirements previously discussed
[23:42:17] <dbrant>	 niedzielski: cool! good to know
[23:44:39] <dr0ptp4kt_>	 okay, Krenair i've reinforced with others to please take my recommendations with a grain of a salt lest there be confusion, and referred people to quim's email for more details
[23:46:34] <niedzielski>	 dbrant: and just to confirm, we're having tsg test this beta-only build to get ahead of any issues in the real prod candidate?
[23:46:50] <dbrant>	 niedzielski: yes, definitely
[23:47:02] <niedzielski>	 dbrant: ok cool. thanks :)