[09:19:01] <bmansurov>	 o/
[09:31:06] <phuedx>	 good morning
[09:56:07] <d3r1ck>	 morning phuedx 
[09:56:43] <phuedx>	 o/ d3r1ck
[11:37:27] <bmansurov>	 i'll be back late evening
[16:57:35] <niedzielski>	 bgerstle: did you want to do a twn sync today or catch the next one?
[16:57:51] <bgerstle>	 niedzielski: sure, we've added a couple things
[17:02:12] <jdlrobson>	 kristenlans: having trouble joining hangout..
[17:02:39] <jdlrobson>	 i can see who's in it but it just hangsss after clicking join
[17:02:43] <jdlrobson>	 really puts the hang in hangout
[17:56:16] <phuedx_webchat>	 kristenlans: are folk doing standup?
[17:56:22] <phuedx_webchat>	 i do have notes and 5 minutes free
[17:56:37] <phuedx_webchat>	 actually, i can just email them
[17:56:48] <kristenlans>	 phuedx_webchat: yep jump into the kickoff hangout
[17:56:56] <kristenlans>	 phuedx_webchat: or not :-)
[18:05:02] <bd808>	 bmansurov_gone: It looks like Cards is the new extension that needs to be setup for the train. RelatedArticles is already there (as others pointed out).
[18:18:05] <bmansurov_gone>	 bd808: yes, ok
[18:49:53] <ananayarora>	 Hi, Anyone here?
[19:30:43] <FlorianSW>	 ananayarora: Yes, how I can I help you?
[19:33:49] <FlorianSW>	 jdlrobson, you're to fast for me :P
[19:34:13] <jdlrobson>	 :)
[19:34:41] <jdlrobson>	 FlorianSW: i really want to break Minerva out of MobileFrontend. Any interest in helping me do that as a side project in the start of january?
[19:35:26] <FlorianSW>	 jdlrobson, but with a dependency to MobileFrontend? There are a lot of modules needed, and I'm not sure, if a skin should hold them? :/
[19:36:53] <jdlrobson>	 FlorianSW: would be a soft dependency
[19:36:54] <jdlrobson>	 i have a proof of concept
[19:36:54] <jdlrobson>	 https://github.com/jdlrobson/MinervaNeue
[19:36:59] <jdlrobson>	 we'd make a new skin "MinervaNeue" to avoid backwards compatibility issues
[19:37:13] <jdlrobson>	 if MobileFrontend's installed it would load all the code. If it isn't it would be JS only
[19:38:01] <jdlrobson>	 We'd leave all the MobileFrontend resources prefixed with 'mobile.' in MobileFrontend and try and cannabalise them in core where possible.
[19:38:16] <jdlrobson>	 At least other skins that are specifically built for mobile would be able to make use of them
[19:38:47] <jdlrobson>	 FlorianSW: also you may be interested in this i made on Friday - http://future-wikipedia.wmflabs.org/wiki/Main_Page
[19:38:54] <jdlrobson>	 it's MobileFrontend using Parsoid just to load lead section
[19:39:03] <jdlrobson>	 it's faster than production :)
[19:43:25] <FlorianSW>	 jdlrobson: Sounds interesting (the minerva out of MobileFrontend) thing. I'm happy to assist as much as I can :)
[19:43:26] <jdlrobson>	 FlorianSW: cool! I'll try to work out a plan similar to moving out the login screen
[19:43:37] <FlorianSW>	 To the parsoid part: I'm not really sure, if using parsoid for frontend is such a good idea? What are the advantages?
[19:44:16] <FlorianSW>	 jdlrobson: Makes sense :) We should try to build a non-js version first (which doesn't need moilefrontend) and then work on making the JS part working as we want and conditionally if MF is installed or not
[19:44:27] <FlorianSW>	 jdlrobson: can https://codein.withgoogle.com/dashboard/task-instances/5804085592719360/ be approved? I think so? :)
[19:44:47] <jdlrobson>	 lemmeeeee look
[19:45:09] <niedzielski>	 dbrant /cc mdholloway bearND: looks like f-droid is running 135 according to ha, fyi
[19:45:21] <jdlrobson>	 FlorianSW: yup it can
[19:45:56] <jdlrobson>	 what does "Waiting for parental consent approval" mean? :)
[19:46:32] <FlorianSW>	 jdlrobson: I don't mean, have you clicked "Approve"?
[19:46:33] <FlorianSW>	 :D
[19:47:46] <jdlrobson>	 yup
[19:48:11] <FlorianSW>	 hmm, maybe an org admin needs to approve it, too :)
[19:48:46] <codezee>	 jdlrobson: "parental approval" imeans task is finished, but parental approval will close it, mentors part is done
[19:52:25] <bearND>	 niedzielski: yes, they pick up the r/* tags. So, whenever we tag a release, next time they run builds it would be picked up
[19:53:15] <niedzielski>	 bearND: i just meant it as a reminder that we should check both our latest release and there's for crashes
[19:53:48] <bearND>	 niedzielski: ok
[20:03:05] <jdlrobson>	 hi codezee thanks for that info!
[20:03:07] <jdlrobson>	 was my fiest one :)
[20:03:14] <jdlrobson>	 FlorianSW: see any reason not to merge  https://gerrit.wikimedia.org/r/#/c/241077/ ?
[20:04:42] <jdlrobson>	 FlorianSW: also any way i can make https://gerrit.wikimedia.org/r/244816 less scary? :P
[20:04:48] <FlorianSW>	 jdlrobson apart from the fact that I don't like the way paladox work, just the in-transparent "Requires:" line in the commit message. The link brings me to the change that depends on it?
[20:05:17] <jdlrobson>	 Yeh I know :/ I wish paladox would slow down sometimes and think about what his patches are doing
[20:06:24] <FlorianSW>	 jdlrobson: testing would be a nice improvement, too :P Sometimes there are great discussions about that in #wikimedia-dev :P But, let's leave that: I'll take a look :)
[20:24:37] <niedzielski>	 dbrant /cc mdholloway bearND|afk: btw, we do have the actual json that causes the unmarshalling crashes in ha
[20:25:00] <niedzielski>	 dbrant /cc mdholloway bearND|afk: so we can test real world errors
[20:25:51] <dbrant>	 niedzielski: right, we can see the actual date formats that are causing the crash... but to "fix" it, wouldn't we have to account for all of them?
[20:26:09] <mdholloway>	 niedzielski: iirc you can see it in some of the stack traces on hockeyapp (you might have to view the raw logs)
[20:27:09] <niedzielski>	 mdholloway: right. this is what we should test against
[20:27:47] <niedzielski>	 dbrant: can't we use a typeadapter and try to unmarshal the "correct" format? if that fails, we use now instead
[20:29:07] <niedzielski>	 dbrant: maybe something like this? http://stackoverflow.com/a/6875295/970346
[20:31:02] <dbrant>	 niedzielski: maybe, but... just for the purpose of this bug?  I mean, the issue is happening anyway as we speak, in production (for a subset of users). Once we release the current beta to production, the issue will happen one more time, and that's it.
[20:32:25] <niedzielski>	 dbrant: hm, it's a bummer to lose the tabs but you're probably right
[20:33:13] <niedzielski>	 dbrant: er, wait, won't beta users still have the issue since they crash? we have to forcefully drop the tabs for beta
[20:34:16] <dbrant>	 niedzielski: hmm, explain?
[20:34:46] <niedzielski>	 dbrant: er, sorry. this code won't execute on beta because they crash: https://phabricator.wikimedia.org/diffusion/APAW/browse/master/app/src/main/java/org/wikipedia/data/TabUnmarshaller.java;c2bf18e05d48551bf381d3ee35add93b057e4489$27
[20:35:19] <niedzielski>	 dbrant: i think we have to change the logger to logRemoteError
[20:36:08] <niedzielski>	 dbrant: that is, logRemoteErrorIfProd crashes on non-prod
[20:37:09] <dbrant>	 niedzielski: ah yes, that is right, i think
[20:42:20] <FlorianSW>	 jdlrobson sorry, i've -2ed the change https://gerrit.wikimedia.org/r/#/c/241077/ (see my badly formatted comment).
[20:43:52] <niedzielski>	 dbrant: cool i'll put in a patch shortly
[21:04:41] <bearND>	 mdholloway: are you set up for mobileapps deployment?
[21:04:53] <mdholloway>	 bearND: yeah, i can do it
[21:05:33] <bearND>	 mdholloway: ok, great. Thanks
[21:50:22] <mdholloway>	 bearND: have a minute for a quick hangout?
[21:50:53] <tgr>	 jdlrobson: got a minute to review https://gerrit.wikimedia.org/r/#/c/256841/ ? I'd like to get it onto the next train
[21:50:55] <FlorianSW>	 jdlrobson, want to take a look? https://gerrit.wikimedia.org/r/#/c/257438/ :D
[21:51:09] <bearND>	 mdholloway: yes
[21:51:10] <FlorianSW>	 oops, sorry, tgr was earlier :)
[21:51:21] <mdholloway>	 bearND: ok, see you in the batcave, one sec
[21:51:54] <bearND>	 mdholloway: sounds good
[21:53:50] <jdlrobson>	 tgr FlorianSW hah, as soon as i've got related articles ready for the train
[21:53:58] <jdlrobson>	 this is turning into a code review day pretty fast :)
[21:54:13] <FlorianSW>	 it's monday :P
[22:04:16] <jdlrobson>	 FlorianSW: https://www.youtube.com/watch?v=SsmVgoXDq2w
[22:04:44] <jdlrobson>	 oh tgr i tried to look at that friday - will need your help replicating bug
[22:05:12] <jdlrobson>	 FlorianSW: no way i'm getting extension.json riding the train :)
[22:05:45] <FlorianSW>	 jdlrobson, "This video isn't available in Germany, because it may contain music, for which usage we haven't come to a conclusion with GEMA" ;)
[22:05:48] <jdlrobson>	 FlorianSW: i'm really reluctant to switch to extension.json until we pull Minerva out
[22:05:56] <jdlrobson>	 it just seems a lot of unnecessary work...
[22:05:58] <FlorianSW>	 jdlrobson, of course not, that would be a nightmare! :D
[22:07:04] <FlorianSW>	 jdlrobson, I don't think so, we just would wait a long time before we finish this work, even if we could do it now in "one change" :) I think it's easier as doing it while or after moving minerva out (for which we have no plan so far :()
[22:07:27] <jdlrobson>	 FlorianSW: i promise a plan soon :)
[22:07:32] <jdlrobson>	  FlorianSW: also any way i can make https://gerrit.wikimedia.org/r/244816 less scary? :P
[22:08:03] <tgr>	 jdlrobson: open a webpage with an image and a TOC in Chrome, open the image, close the image, click on a TOC title
[22:09:27] <FlorianSW>	 jdlrobson, I'll take a look on it tomorrow, maybe in 2 days, ok? I can't manage to do it now :(
[22:15:34] <jdlrobson>	 FlorianSW: no worries. It was more a general question - keen to understand if my patch was confusing
[22:15:40] <jdlrobson>	 or if it just wasn't a priority for people