[00:03:47] iOS 9.2 is out [00:05:28] jdlrobson: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2015-16_Q3_Goals#Performance [00:58:33] o/ [09:56:02] hi! [16:01:06] violetto: hanging out? [16:55:29] Deskana|Away: FYI you can join #wikimedia-ios to get IRC notifications from phab [16:55:49] also thanks for merging those tickets, forgot that feature existed [16:57:38] bgerstle: Great, I'll join that channel. [17:18:54] niedzielski: wait, it's happening despite my patch? what are your repro steps? [17:19:09] dbrant: i just launch the app! [17:19:20] i have a bunch of tabs open. the one in the foreground is a saved page i believe [17:20:14] i can see most of the content on the page before it crashes [17:25:17] niedzielski: hmm, i can't repro, even with that kind of arrangement [17:25:32] dbrant: i have about 28 tabs open and the one in the foreground happens to be a saved page [17:26:11] dbrant: i'll try to nail it down a bit better [17:31:10] dbrant: ok, it looks like it happens on just a clean install of the app and launch. [17:32:16] niedzielski: ...with just the main page?? [17:32:34] dbrant: yeah :| [17:33:14] dbrant: it looks like it repros on the AOSP API 23 Nexus S emulator [17:33:31] looking... [17:37:32] niedzielski: repro'd on my 5.1 device. checking... [17:38:55] niedzielski: ahh, i got it. The check that I introduced is not quite valid. [17:39:18] dbrant: ok cool [17:42:34] niedzielski: ok, check fixed [17:42:49] dbrant: nice! will try shortly [17:46:11] dbrant: hm, i wonder if this surprising use of index is causing some other bug [17:46:27] kristenlans: are you still our scrum master? [17:46:51] niedzielski: i would not be surprised. [17:52:46] mdholloway bearND dbrant: my wife and i bought pebble time rounds recently. as a former moto 360 and first samsung gear user, i think i recommend these. this is the first smartwatch i've used that hasn't felt like a prototype. now, it's not the most useful thing in the world but it might be a good gift option if you know any tech sorts. the watch a [17:52:46] dvertises ios support as well, so it might be a good apple watch alternative. [17:53:24] niedzielski: awesome! good to know [17:59:59] niedzielski: oh, it's e-ink! that's cool [18:01:52] dbrant: yeah, i think the pebble guys have been eink from the beginning. it's not nearly as vibrant or dense as an lcd, but the animations are still quite prompt, i think because of the small screen size. so far it's had about 60% charge at the end of the day. the moto 360 often wouldn't last the day. [18:02:23] dbrant: i haven't played with it but the sdk looked like an interesting mix of plain C and JavaScript [18:02:35] nice [18:03:04] kristenlans: joining the phlogiston meeting? [18:03:19] dbrant: oh, and i'd also say it's comparably light to a traditional watch [18:03:48] hmm... kind of want! [18:07:46] :) [18:17:12] mdholloway: bearND standup [18:27:21] bgerstle, https://www.mapbox.com/ios-sdk/ ? [18:28:46] dbrant: hey would you have time for quick hangout? [18:28:55] yurik: yeah, we might do that when we add maps to the iOS app [18:29:17] bgerstle, excelente )) any idea of a timeline? [18:29:34] yurik: not likely for Q3, potentially Q4 [18:29:59] yurik: we're really trying to buckle down on this upcoming 5.0.0 release, and want to leave ourselves some headroom for design iteration & bugs [18:30:14] gotcha [18:30:17] thx! [18:30:17] but would love to do maps for a 5.x release, so soon [18:30:39] dbrant, have you considered doing an a/b test on calling it "maps" vs "nearby" ? [18:31:09] mhurd: free now [18:31:23] dbrant: oh cool... just a sec... [18:31:34] yurik: yep, definitely a possibility. Maybe not even a test, just rename it [18:31:51] dbrant: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [18:35:41] jdlrobson: I'm about to fix it, but I don't have any idea why arrow isn't toggling. I've added additionalClassName to arrowUp and in CSS I am transforming it. Maybe you know something? [18:35:41] Did baha leave? [18:35:41] Albert221: I have to leave, jdlrobson (jon) is your guy [18:35:41] jdlrobson: i'm about to [18:35:42] hah [18:35:42] ok :) [18:35:42] bmansurov: so what about the section usage? [18:35:42] jdlrobson: tests are failing, but i made the changes you requested [18:35:42] jdlrobson: i'll have time tomorrow while traveling [18:35:42] bmansurov: oh cool didn't see that. I will take a look. [18:35:42] jdlrobson: i'll try to get the tests passing then [18:35:42] jdlrobson, I think this is a reasonable GCI task: https://phabricator.wikimedia.org/T120864 I would mentor it, if you don't prefer to do it by yourself (?). I think putting an "Uploads of {USERNAME}" is enough? :) [18:35:42] bmansurov: if you work be sure to not treat it as vacation :) [18:35:42] jdlrobson: ok ;) [18:35:43] FlorianSW: yeh i think that would be a good first step [18:35:43] later guys [18:35:43] alright, let me prepare the task :) Thanks for the quick feedback :P [18:35:43] bmansurov has vacation? Hope you enjoy it! :) [18:35:43] damn :D [18:36:14] so, Jon, what should I do? [18:45:26] Hey Albert221 taking a look [18:46:09] because I'm analyzing toggle.js, Icon.js and View.js and I don't see what's wrong [18:49:47] Albert221: replied [18:49:49] the class name is wrong :) [18:50:46] You've got to be kidding me :D Nevermind :) [18:51:40] and what class should I use to reffer as to arrow icon? just .arrow ? [18:51:55] or .mw-ui-icon-arrow [18:55:04] Nevermind, analyzed that in Icon.js [18:57:42] dbrant: hey time for one more quick batcave? i think i ran it correctly, but something may be missing... [18:57:57] mhurd: sure [18:59:07] Albert221: just use arrow - i don't .mw-ui-icon-arrow [18:59:23] i don't agree with Baha on his point (e.g. .mw-ui-icon-arrow) [18:59:44] let me and bmansurov argue about that separately :) [19:01:29] emm, sorry but I don't understand. As I see in the code this arrow clas actually is .mw-ui-icon-arrow (options.base + '-' + options.name) and I should use that, right? [19:01:35] class* [19:06:48] ok, I'm sending code to gerrit [19:07:22] Albert221: let's see :) [19:08:09] em, little mistake in comment [19:08:11] let me fix it [19:08:58] Albert221: you still need to rename .open-section to open-block [19:09:04] but patch looks fine that aside [19:10:12] there it is [19:12:09] refresh :) patchset 6 is (probably) final. uff [19:16:51] bgerstle: hey you around? [19:17:01] mhurd: yeah [19:20:22] Hey, jdlrobson, it's done :) [19:50:24] hello, jdlrobson [19:50:49] hey Albert221 5 mins :) [20:08:02] jdlrobson how is it? [20:08:08] bd808 will you be joining in the fun at the biweekly Product Plannign meeting? [20:08:48] kristenlans: yeah, sorry [20:11:22] jdlrobson: you too ^ [20:15:25] kristenlans: is it now/ [20:15:56] Albert221: looks great [20:17:16] :) [20:18:11] php-composer-test fails but this doesn't seem to be my fault [20:24:21] Albert221: php composer test failure normally means somewhere your php file has code style errors, so its always good to have a look at the error message [20:24:35] it'll let you know which line went wrong [20:25:29] > Line exceeds 100 characters; contains 116 characters [20:25:37] That's the line with my comment [20:26:46] NOW everything is ok :) [20:32:25] dbrant|brb: running late [20:35:44] jdlrobson: can you run these tests again? [20:36:42] dbrant: looks like I just whiffed on the time, sorry team! Did you guys groom? [20:38:11] mbinder: yep! managed to muddle through without you :) [20:45:23] fixed again [20:45:41] trying out the Android beta for the first time in a little while. Great work on the maps! [20:46:16] My first feedback is that I wish it was loading some extra tiles around the intitial view, so that there was less gray space when I start zooming out. [20:47:02] my second wish for it would be to see image thumbnails on the map... and thereby easily see which articles on the map lack images. [20:51:26] and my third feedback is that it's frustrating that all the pins are just in the center region — basically the middle segment, if you divided the view into a tictactoe board. [20:54:19] yay, merged :) [20:54:55] ragesoss: thanks! your third point is a current limitation of the API (10km radius). [20:55:08] ragesoss: the others... we will work on! [20:56:11] dbrant: also where is the article data enpoint you talked about in the metric meeting documented? [20:56:21] I'm working on a project where that might be handy. [20:57:02] ragesoss: that's all here: http://rest.wikimedia.org/en.wikipedia.org/v1/?doc [21:03:57] dbrant: what about like a subtle circle marking the current radius? [21:04:01] just a thought. [21:05:06] ragesoss: yeah; technically there shouldn't really be a maximum radius. The API just needs some work. [21:05:33] or like a super light transparent overlay for outside the radius. That would make it clear what the 'focus' region is. [21:32:26] dbrant mdholloway bearND: testing looks good to me. any objections to publishing the beta? [21:32:42] niedzielski: none from me! [21:33:00] niedzielski: none! [21:34:34] niedzielski: none [21:39:03] niedzielski: hello the apps/android/wikipedia job results are broken now :/ Jenkins now more allow javascript and img to be loaded. Ie https://integration.wikimedia.org/ci/job/apps-android-wikipedia-lint/730/artifact/app/build/outputs/lint-results-alphaDebug.html [21:41:31] hashar: what do you mean by broken? i think we have the configured to be nonvoting [21:41:49] the job* [21:42:04] niedzielski: oh the html contains images and javascript. Jenkins set a content protection policy that prevents the browser from including the css/js/img etc [21:42:49] niedzielski: that is a security update I pushed today. Will fill a task to figure out a good solution, it is something (publish report) we need for other repos anyway [21:43:47] hashar: so basically any sophisticated html in the output folder can't be served, right? [21:44:12] er, the workspace / archives [21:44:16] niedzielski: yeah. We would need to serve them from another domain. Something like ci.wmfusercontent.org [21:45:15] hashar: hm, i think that will be more important to us soon once we get our integration tests up which may include screenshots, gifs, etc [21:45:44] hashar: thanks for the heads up [21:50:48] dbrant: are we tsg-ing this build as well? [21:51:36] niedzielski: yep, no reason not to [21:54:50] dbrant mdholloway bearND: nice! play finally added a delayed release option so you can upload a build for publication at a specific time in the future. amazon has had this forever [21:56:57] yes, I think this could be useful for prod releases [21:57:05] dbrant mdholloway bearND: hm, apk size dropped by almost 3 MB [21:58:13] curious [21:58:30] hmmm, i wonder what caused this drop? I haven't kept track of recent changes very well, I must admit. And library/ProGuard changes? [21:59:37] dbrant mdholloway bearND: maybe the upgrade to mapbox sdk. the proguard rules are actually more conservative now so we should be stripping less [22:00:25] niedzielski: it must be the updated maps sdk... so much the better. [22:02:13] dbrant mdholloway bearND: i looked for a changelog when i updated but found none. there's one for 2.2.0 but not 2.3.0 (https://github.com/mapbox/mapbox-gl-native/blob/master/CHANGELOG.md). the android releases are a bit more sparse than ios (https://github.com/mapbox/mapbox-gl-native/releases). there were many changes added in 2.3.0 (https://github [22:02:13] .com/mapbox/mapbox-gl-native/compare/android-v2.2.0...android-v2.3.0) [22:04:14] dbrant mdholloway bearND: i'm pushing ahead! :) [23:18:17] any folks here experience with browserify ? [23:23:02] tgr: any chance you could reviewhttps://gerrit.wikimedia.org/r/#/c/258061/ [23:23:12] it's only thing blocking enabling the feature and all my team is out sick/vacation [23:23:31] thedj: joakino does [23:23:42] you should ping him during european day time [23:23:44] he's out now [23:23:48] hmm. ok [23:23:58] thedj: any chance you want to review https://gerrit.wikimedia.org/r/#/c/258061/ ? :) [23:24:24] it's all that's standing between me and some exciting experimentations in the realms of service worker [23:26:49] i've never used that extension :( [23:26:59] and it's 00:26 here, so i'm not starting today [23:27:13] sry. bedtime. [23:27:47] but, got another 4 hours of videojs work in, so it was a good day ! [23:28:27] no worries knew it was a long shot ;-) [23:28:56] this was my day: http://jsfiddle.net/TheDJ/7pghk2dv/35/ [23:29:23] dynamic layout of the video ui, depending on the player width [23:31:00] jdlrobson: is this used on mobile or desktop? [23:31:10] the relatedarticles patch [23:31:21] tgr: desktop is the bug [23:31:30] the feature lives in mobile and desktop [23:32:22] re: "need to understand the issue more", you are probably doing stuff on page load instead whichever mw.hook is fired on content change [23:33:31] MediaWiki is doing optimistic parse (submit and parse the wikitext when the editor focuses on the edit summary field, and display it via AJAX when they press save) [23:33:42] tgr: I think actually what is happening is VisualEditor assumes nothing will follow wikitext content [23:33:52] so no page load there, you need to subscribe to the content change event [23:34:21] I'm hiding via css right now as it's the cheapest thing to do - ideally it should just remain in the content area untouched below the editor [23:34:27] but it's not vital for a release 1 [23:44:42] jdlrobson: yeah, sorry, different issue [23:44:43] however still a bug, you just haven't run into it yet :) [23:45:23] in general IMO you should subscribe to events instead of messing with CSS; I am sure VE emits edit start/end events