[00:05:14] <jdlrobson>	 tgr: long term yes, but i want to talk to the VE team about that beforehand
[00:06:03] <jdlrobson>	 and I want to do the minimum possible to get this enabled and collecting data
[00:06:22] <jdlrobson>	 ideally it would update with edits
[00:25:15] <tgr>	 add/remove on events seems fairly minimal to me, ten lines of javascript tops
[00:29:49] <jdlrobson>	 tgr: i'll see if i can work out wht the events are..
[00:31:27] <jdlrobson>	 tgr: i assume it's ve.deactivate and ve.activate  ?
[00:33:46] <tgr>	 jdlrobson: for displaying, wikipage.content should be the right one
[00:39:31] <tgr>	 jdlrobson: apparently VE does not have an "open" event, so hacky solution it is
[00:39:53] <jdlrobson>	 tgr: can you remind me how to use hooks?
[00:40:03] <jdlrobson>	 tgr: i might have found a solution.. not 100%
[00:41:30] <tgr>	 jdlrobson: mw.hook('foo').add(callback)
[00:41:59] <jdlrobson>	 yeh not working as expected...
[00:42:32] <jdlrobson>	 mw.hook('ve.activate' ).add( function () { $( 'aside' ).remove(); } )
[00:42:34] <jdlrobson>	 kinda works
[00:42:40] <jdlrobson>	 but it's visible whilst loading - so css needed
[00:43:21] <tgr>	 I'll file a bug about that, let's merge the patch as it is for now
[00:44:50] <tgr>	 jdlrobson: can you fix the comment in https://gerrit.wikimedia.org/r/#/c/258061/1/resources/ext.relatedArticles.readMore/readMore.less ?
[00:46:36] <jdlrobson>	 tgr: sure - i'm gonna make some tweaks though as i think we can do it a little better
[00:47:11] <jdlrobson>	 tgr: i stand corrected :
[00:47:15] <jdlrobson>	 ill do a follow up
[00:49:09] <jdlrobson>	 tgr: done.
[00:49:20] <jdlrobson>	 tgr: seems there's an issue post edit too :( https://gerrit.wikimedia.org/r/258078 
[00:49:36] <jdlrobson>	 can you add me to the bug report you are creating?
[00:58:47] <tgr>	 jdlrobson: did you try wikipage.content? pretty sure that one works for save
[00:59:02] <jdlrobson>	 testing.. :)
[00:59:21] <tgr>	 not sure if there is an "exit without save" option and if there is whether there is a hook for it, though
[01:00:32] <jdlrobson>	 tgr: nope.. still appends before...
[01:00:43] <jdlrobson>	 oh good point hadn't thought of that use case.
[01:00:57] <jdlrobson>	 thanks for the merge. I'm going to rephrase the bug
[02:57:48] <codezee>	 MobileContext has a private constructor and still an object is being created in the test externally, can someone explain how thats being done
[02:57:50] <codezee>	 here http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/master/tests%2Fphpunit%2FMobileContextTest.php#L38
[03:02:46] <codezee>	 I guess it has something to do with 'unserialize' but I'm not able to figure out
[03:02:46] <codezee>	 I meant *protected constructor
[15:46:35] <codezee>	 FlorianSW: there?
[15:47:00] <FlorianSW>	 codezee, yep :)
[15:47:26] <codezee>	 this task looks fairly east, can we add this for gci - https://phabricator.wikimedia.org/T119918
[15:47:30] <codezee>	 *easy
[15:50:33] <FlorianSW>	 do you think, that an experienced coder shouldn't need more than 2-3 hours?
[15:52:13] <FlorianSW>	 codezee, ^
[15:52:19] <codezee>	 had a look at it earlier, we probably just need to change the "left" property in less
[15:52:45] <codezee>	 of the given icon
[16:01:21] <FlorianSW>	 codezee, I think an easier way would be to change the left property for the search fields only, when the content changes, too. Actually the condition is @media all and (min-width: @wgMFDeviceWidthTablet) { but should be @media all and (min-width: @wgMFDeviceWidthDesktop) {
[16:01:38] <FlorianSW>	 looks reasonable easy, let me import it in GCI :)
[16:09:18] <FlorianSW>	 codezee, imported
[16:12:26] <codezee>	 FlorianSW: if you need help during review, just add me then, I'll be happy to help with basic suggestions, before you do the actual review :)
[16:12:57] <FlorianSW>	 codezee, sure, thanks :)
[16:13:25] <codezee>	 gerrit username -Sumit
[16:13:57] <FlorianSW>	 I know :P :D
[16:21:29] <dbrant>	 apologies in advance for phab spam...
[16:25:20] <thedj>	 joakino: around ?
[17:06:31] <jdlrobson>	 thedj: he's somewhere... just had a hangout with him
[17:06:40] <jdlrobson>	 think he might have stepped away from computer though :)
[17:07:08] <thedj>	 no rush
[17:46:24] <bd808>	 what if you had a standup and nobody came?
[17:50:04] <dr0ptp4kt_>	 bd808: joakino just joined
[18:09:25] <niedzielski>	 bearND: hey! word on reading street is that you have a Nexus 5. would you mind opening Nearby on the latest beta in it?
[18:21:15] <bgerstle>	 bd808: dr0ptp4kt_ is there a recommended way to test accounts, ideally outside production?
[18:21:55] <bd808>	 bgerstle: using the beta cluster? Using testwiki? Not sure what you want to test
[18:22:15] <bgerstle>	 bd808: just creating accounts at this point
[18:22:30] <bgerstle>	 successfully, providing bogus credentials, creating accounts that already exist, etc.
[18:23:33] <bd808>	 I would guess that beta cluster is the best place for that (other than a local MW install)
[18:23:58] <bgerstle>	 bd808: sure. does that tie into central auth at all?
[18:24:10] <bgerstle>	 (just curious)
[18:24:25] <bgerstle>	 or if there's a way for us to delete accounts after testing, just to avoid accumulation
[18:24:26] <bd808>	 not the prod CA, but yes beta cluster has CA setup
[18:24:57] <bgerstle>	 what instances make up the beta cluster, exactly? are there docs on the beta cluster?
[18:25:35] <bd808>	 http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix
[18:25:38] <bearND>	 niedzielski: done. What should I be looking for?
[18:26:01] <niedzielski>	 bearND: thanks! did it not instantly crash?
[18:26:06] <bearND>	 nope
[18:26:15] <dbrant>	 lol
[18:26:23] <bd808>	 bgerstle: you should talk to zeljkof and marxarelli too (the QA folks) for tips and things to watch out for
[18:26:48] <bearND>	 niedzielski: i did a fresh install, it did ask me for the runtime permission, but that's it
[18:28:28] <zeljkof>	 bgerstle: hashar knows the most :)
[18:28:42] <niedzielski>	 bearND: ok thanks
[18:28:45] <bgerstle>	 bd808: was thinking about doing exactly that
[18:28:50] <bearND>	 niedzielski: do you have an HA link with a stack trace?
[18:29:06] <niedzielski>	 bearND: it's a native crash in the mapbox sdk
[18:29:41] <niedzielski>	 bearND: i don't have the tombstone but tsg sent over a logcat
[18:29:53] <niedzielski>	 bearND: ah, this is actually an s4, not nexus 5
[18:30:24] <bearND>	 niedzielski: ah, then you may want to check with dbrant 
[18:30:29] <bgerstle>	 bd808: what's the difference between test.wikipedia.org & beta cluster?
[18:30:35] <niedzielski>	 dbrant: hello! :)
[18:30:41] <bgerstle>	 test == production version & beta is pre-release?
[18:30:45] <niedzielski>	 dbrant: would you mind opening Nearby on your s4?
[18:31:11] <bgerstle>	 zeljkof k, thanks
[18:31:16] <bd808>	 bgerstle: test is part of the production cluster but designated for testing (edits mostly)
[18:31:24] <bgerstle>	 right, makes sense
[18:31:32] <bd808>	 there is also test2
[18:31:37] <marxarelli>	 bgerstle: https://wikitech.wikimedia.org/wiki/Test.wikipedia.org
[18:31:47] <marxarelli>	 and https://wikitech.wikimedia.org/wiki/Test2.wikipedia.org
[18:31:59] <dbrant>	 niedzielski: works. My S4 has API 18... what's theirs?
[18:32:07] <marxarelli>	 bgerstle: what kinds of tests are you looking to run?
[18:32:26] <bgerstle>	 marxarelli: at this point, just manual tests for account creation
[18:33:14] <marxarelli>	 bgerstle: got it. ios?
[18:33:23] <bgerstle>	 marxarelli: you guessed it
[18:33:39] <niedzielski>	 dbrant: looks like 19 http://samsung-firmware.org/download/GALAXY%20Tab4%207.0%20Wi-Fi/5232/XAC/T230NUUEU0AOD1/T230NUXAC0AOD1/
[18:34:04] <niedzielski>	 dbrant: oh it says it right here. yeah, 19
[18:34:59] <bgerstle>	 mhurd: niedzielski dbrant FYI there _is_ a sitematrix API which we should probably use for the site picker https://www.mediawiki.org/w/api.php?action=help&modules=sitematrix
[18:35:35] <mhurd>	 bgerstle: what what!
[18:35:36] <niedzielski>	 bgerstle: do you pregenerate the site picker on ios?
[18:35:48] <bgerstle>	 niedzielski: yes, but not frequently
[18:36:13] <mhurd>	 niedzielski: we were using a json file made by the same script you use on android iirc
[18:36:14] <bgerstle>	 mhurd: i think i discovered this a while ago, ranted about it, and subsequently forgot
[18:36:25] <marxarelli>	 bgerstle: so, in short, beta cluster would probably be the best environment for testing account creation. you can't completely cleanup after the tests, but leaving accounts on BC isn't terrible as long as the tests don't run at an obscene frequency
[18:36:38] <dbrant>	 niedzielski: I also have an S3 with API 19, and it also works... (although it's running CM, not Samsung rom)
[18:37:02] <niedzielski>	 dbrant: hm, i think samsung has special roms often
[18:37:20] <niedzielski>	 dbrant: ok, thanks. i guess i will ask tsg for a little more info.
[18:38:07] <bgerstle>	 mhurd: dbrant this is what we should be doing: https://www.mediawiki.org/w/api.php?action=sitematrix&smtype=language&uselang=en
[18:38:16] <bgerstle>	 where `uselang` is the param we want language names to be localized in
[18:38:38] <dbrant>	 bgerstle: mhurd: veeery interesting!
[18:38:49] <bgerstle>	 i.e. uselang=en => "French" for fr, uselang=fr => "Francais"
[18:39:05] <mhurd>	 bgerstle: dbrant: ya great find!
[18:39:16] <bgerstle>	 even has continuation
[18:39:26] <bgerstle>	 marxarelli: gotchya
[18:39:44] <mhurd>	 bgerstle: i may take quick stab at using this in my pr...
[18:39:46] <bgerstle>	 marxarelli: running lots too many tests would be a good problem to have at this point
[18:39:59] <bgerstle>	 mhurd: let's hold off for now
[18:40:12] <bgerstle>	 i'll file a ticket (or find the one i did before) and see what we can do
[18:40:21] <mhurd>	 bgerstle: that's fine. can make a ticket in backlog 
[18:40:23] <bgerstle>	 but yeah, i'd love to drop the langauges.json file
[18:40:37] <mhurd>	 bgerstle: will make ticket now...
[18:41:12] <dbrant>	 niedzielski: thanks; otherwise the beta is looking pretty stable so far (knock on wood). The only thing left is out-of-memory issues.
[18:41:47] <marxarelli>	 bgerstle: i know you're joking but it _can_ be a real problem if your tests and/or the environment you're testing in is brittle :) what platform/framework/library are you using to write/run end-to-end tests?
[18:42:03] <niedzielski>	 dbrant: i think we removed so many bugs recently, we'll have to tackle OOM issues next to make an appreciable dent
[18:42:13] <dbrant>	 niedzielski: correct!
[18:44:59] <bgerstle>	 marxarelli: Homo sapiens, heard of it? ;-)
[18:45:05] <bgerstle>	 marxarelli: (manual testing only atm)
[18:45:12] <bgerstle>	 we might look into appium or doing an iOS specific thing
[18:45:26] <bgerstle>	 marxarelli: so, one of the things i worked on briefly at spotify was integration testing w/ docker
[18:45:40] <bgerstle>	 i'd love to be able to spin up & tear down our own MW instances for each test
[18:46:04] <bgerstle>	 usually solves most of the kinds of issues you're talking about
[18:46:23] <bgerstle>	 and allows us to run as many tests as we want, even concurrently
[18:47:26] <bgerstle>	 marxarelli: in the meantime, moving our acct-related tests to beta cluster should do just fine
[18:47:41] <bgerstle>	 we can't even point the app at beta atm (relatively minor change)
[18:49:58] <mhurd>	 dbrant: here's a cleaned up version of the sitematrix query: https://www.mediawiki.org/w/api.php?action=sitematrix&format=jsonfm&smtype=language&smstate=all&smlangprop=code%7Clocalname&smsiteprop=code&uselang=en
[18:50:20] <mhurd>	 dbrant: then just change the 'uselang' param like brian said
[18:50:23] <mhurd>	 https://www.mediawiki.org/w/api.php?action=sitematrix&format=jsonfm&smtype=language&smstate=all&smlangprop=code%7Clocalname&smsiteprop=code&uselang=he
[18:51:00] <dbrant>	 mhurd: very cool!! I'm curious where these names actually come from?
[18:51:26] <mhurd>	 dbrant: let me know if you find out! :)
[23:27:20] <quiddity>	 jdlrobson, Heyo :)  Context: We're looking through the existing types of echo notification, and thinking about various bucketing options. One of the buckets is "Urgent?"  --  Specifically: We're currently bucketing <gather-hide> and <gather-unhide> as "Urgent", but we're not sure if <gather-approve> would also be "Urgent".  The current notification text is -- "{{GENDER:$1|Your}} collection was approved. This means that it won't be 
[23:27:21] <quiddity>	 automatically hidden again." --  The Question: Under what circumstances is a gather collection *automatically* hidden?
[23:27:52] <jdlrobson>	 quiddity: super rarely
[23:28:01] <jdlrobson>	 and by super i mean not even once a month
[23:28:33] <quiddity>	 What triggers an auto-hide?  is there a blacklist of keywords?
[23:29:08] <jdlrobson>	 Either manually hidden by an admin or after an arbitary number of flags it gets hidden
[23:29:20] <jdlrobson>	 given the feature is in beta though this happens not so often
[23:29:28] <quiddity>	 Nod.  Thanks much, that helps. :)