[00:20:18] <mbinder>	 sorry for the calendar-email spam, teams. Had to get meetings off of Christmas and New Year.
[00:32:06] <jdlrobson>	 marxarelli: anothr choke :( https://gerrit.wikimedia.org/r/237394
[09:38:27] <phuedx>	 hullo there
[13:09:20] <bmansurov>	 phuedx: hey, do you know why jenkins is complaining here: https://gerrit.wikimedia.org/r/#/c/259267/ ?
[13:12:42] <Reedy>	 03:00:37 File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/MobileFrontend/resources/skins.minerva.beta.userpage.styles/talk.png' referenced by 'skins.minerva.beta.userpage.styles' must exist.
[13:13:13] <Reedy>	 Did you forget to git add?
[13:13:19] <Reedy>	 https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/43444/consoleFull
[13:18:11] <bmansurov>	 Reedy: thanks, looks like so
[13:58:48] <oriciu>	 Hi!
[13:59:53] <oriciu>	 I need some advice on translating Android app into a new language (disabled in Translatewiki)
[14:02:05] <bmansurov>	 oriciu: hi, language team on #wikimedia-i18n should be able to help you
[14:05:46] <oriciu>	 bmansurov: thank you very much
[14:07:30] <bmansurov>	 np
[17:12:54] <dr0ptp4kt_>	 mdholloway: okay if i reschedule our 1:1 earlier?
[17:14:50] <mdholloway>	 dr0ptp4kt_: fine with me!
[17:18:05] <dr0ptp4kt_>	 mdholloway: thx, thx for accepting
[17:18:20] <mdholloway>	 no prob, talk to you in a bit
[17:26:13] <phuedx>	 out for dinner/getting kids to bed
[17:50:42] <FlorianSW>	 jdlrobson: hi :) One question: What is the goal of the code you added there: https://gerrit.wikimedia.org/r/#/c/232029/11 ?
[17:52:01] <jdlrobson>	 hey FlorianSW 
[17:52:18] <jdlrobson>	 what code did i add?
[17:52:24] <jdlrobson>	 you mean the config?
[17:52:30] <jdlrobson>	 It controls the footer
[17:53:20] <jdlrobson>	 I guess best thing to do is try that code on master and see that there is no warning and then with your patch there becomes a warning as it expects that array to be a string
[17:53:53] <jdlrobson>	 Not sure if it's used in production, nor where I picked it up! 
[17:53:55] <FlorianSW>	 jdlrobson: yes, I understand the problem and can replicate, but why are you passing an array instead of a string?
[17:54:13] <FlorianSW>	 As far as I can see, a string is always expected :(
[17:54:27] <jdlrobson>	 maybe we could force that separately then
[17:54:47] <mbinder>	 dbrant: last 4 items in the sprint gonna make it to done?
[17:54:49] <jdlrobson>	 but the fact is it used to work... so i'd just suggest doing a type check to avoid breaking anything that may be relying on that.
[17:54:57] <jdlrobson>	 I think Wikidata uses it
[17:55:08] <jdlrobson>	 because they have a unique dual license
[17:55:13] <jdlrobson>	 aude: ^
[17:55:56] <FlorianSW>	 https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/aa41f910d6c460796640b72b43222bb08c602ed6/WikimediaMessages.hooks.php#L126-L141
[17:56:05] <FlorianSW>	 That's the only usage in wikimedia git: https://github.com/search?q=%40wikimedia+MobileLicenseLink&type=Code&utf8=%E2%9C%93
[17:56:12] <jdlrobson>	 FlorianSW: should be easy to just do a type check no? Happy to merge it then and deal with this issue separately
[17:56:18] <jdlrobson>	 i just remember adding support for wikidata a while back
[17:56:22] <jdlrobson>	 lemme see if i can check the logs
[17:56:56] <FlorianSW>	 jdlrobson: it would be easy, yes, but it would be great to find a usage with an array, because that wouldn't work like expected (the first license should be used, instead of both)
[17:57:05] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/249978/
[17:57:08] <jdlrobson>	 that was the source of it
[17:57:12] <jdlrobson>	 sadly no bug attached :/
[17:57:26] <jdlrobson>	 ahh there we go
[17:57:26] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/242602/
[17:58:07] <jdlrobson>	 so we should just check what Wikidata is doing
[17:58:26] <jdlrobson>	 oh i see that's in the link you postd :)
[17:59:01] <jdlrobson>	 well we do have a deployment freeze... and https://m.wikidata.org/wiki/Wikidata:Main_Page is setup
[17:59:09] <jdlrobson>	 could just merge it and see if anyting breaks ;-)
[17:59:59] <FlorianSW>	 jdlrobson: both changes are meant for the message key, not for the link, am I right?
[18:00:13] <jdlrobson>	 FlorianSW: i pushed the trigger :)
[18:00:24] <mbinder>	 coreyfloyd: JoshM standerp
[18:00:29] <jdlrobson>	 We should check https://m.wikidata.org/wiki/Wikidata:Main_Page after the patch to double check all is good
[18:00:36] <FlorianSW>	 jdlrobson: great, we can test on betalabs, too, right? Let me check :D
[18:00:59] <FlorianSW>	 http://m.wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page
[18:06:19] <jdlrobson>	 FlorianSW: will take a while to be live - i guess 30 mins?
[18:06:53] <FlorianSW>	 jdlrobson: there's already a scap job: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/82791/console but it was started at 17:45, so I think we have to wait for the next run. IIRC 15 minutes
[18:10:00] <FlorianSW>	 jdlrobson: ah, wait, it seems betalabs is updated every 10 minutes
[18:15:36] <mbinder>	 bearND: mdholloway|afk standup
[18:53:50] <jdlrobson>	 FlorianSW: what's going on with the patrol patch?
[18:53:58] <jdlrobson>	  Some design to the patrol link and use ajax to patrol (by Florianschmidtwelzow, 195 days old)
[18:54:37] <jdlrobson>	 FlorianSW: i saw the -1 on the dependent patch "This change reverts some changes of the last half year."
[18:57:21] <FlorianSW>	 jdlrobson: I haven't read my e-mails to this point, yet :/ That seems to be a really really bad rebase from me. I'll have to look at the code and figure out what was removed.
[18:57:30] <jdlrobson>	 sounds good :)
[18:58:59] <niedzielski>	 bearND mdholloway|afk dbrant: here's the card i was thinking of https://phabricator.wikimedia.org/T85766 for gif considerations
[18:59:47] <niedzielski>	 bearND mdholloway|afk dbrant: it looks like the only other contender was ion
[19:01:32] <phuedx>	 hola
[21:00:49] <niedzielski>	 dbrant bearND mdholloway: dumb question: are all the mw requests in the app parameter-only with empty bodies?
[21:06:52] <dbrant>	 niedzielski: you mean, in an HTTP-sense?
[21:07:01] <niedzielski>	 dbrant: yeah
[21:07:09] <dbrant>	 niedzielski: that is correct
[21:07:17] <niedzielski>	 dbrant: it doesn't seem like there's any api for even adding a body in the app layer
[21:07:27] <niedzielski>	 crazy
[21:19:25] <FlorianSW>	 jdlrobson: finnaly (I don't know when :P), betalabs wikidata got the "Correct isPlural" change and is still working :)
[21:19:41] <FlorianSW>	 maybe the change you remember was for the old version of getLicense :)
[21:45:07] <bearND>	 niedzielski: what's the use case?
[21:47:19] <niedzielski>	 bearND: doesn't it seem strange to enter an entire passage of text as a parameter for an edit? that's not actually the problem though. I'm seeing some weird issue where the edit token must appear in the body of the request. some how this is working in the app for prod requests and in ci tests but not in tests on my pc or in curl requests
[21:48:38] <bearND>	 niedzielski: ah, i see now. Thanks for clarifying. Are you saying there is no way in the app code to add request payload?
[21:49:28] <niedzielski>	 bearND: i don't think so. all mw requests go through java-mwapi which doesn't expose a body setter afaik
[21:50:10] <bearND>	 niedzielski: That's correct for java-mwapi. But I think we should move more to Retrofit. Retrofit 2 allows payloads in requests. It's still in beta 2 right now.
[21:50:22] <niedzielski>	 bearND: same things with headers. i think we only expose a user-agent setter
[21:51:19] <niedzielski>	 bearND: yeah, totally agree. i'm just trying to solve this very mysterious behavior... how does it work at all? why does it only fail on my devices?
[21:51:54] <niedzielski>	 bearND: for example, https://test.m.wikipedia.org/w/api.php?action=edit&format=json&title=Test_page_for_app_testing%2FCaptcha&section=0&text=%3D%3D%20Section%202%20%3D%3D%0A%0AEditing%20by%20inserting%20an%20external%20link%20https%3A%2F%2F1450471630598&summary=&token=+\
[21:53:08] <bearND>	 niedzielski: hmm, that section text is relatively small even
[21:53:32] <bearND>	 https://futurestud.io/blog/retrofit-send-objects-in-request-body
[21:55:24] <bearND>	 niedzielski: Idk why it fails on your devices
[22:08:59] <jdlrobson>	 FlorianSW: yay :)