[09:14:08] good morning [13:52:49] jdlrobson: ping :) [16:43:20] hey FlorianSW sorry i missed you [16:43:53] jdlrobson: np :P [16:44:16] jdlrobson: If you respond to my comment: https://gerrit.wikimedia.org/r/#/c/243227/ I think I can merge it :D [16:44:23] FlorianSW: looking [16:45:14] jdlrobson: do you have vacation? Hope I doesn't disturb your spare time :] [16:45:29] nope no vacation :) working today and tomorrow [16:47:41] FlorianSW: you are right it's unrelated [16:47:43] removed [16:49:03] FlorianSW: don't suppose you could pull trigger on i18n change in https://gerrit.wikimedia.org/r/#/c/259550/ ? [16:49:10] it's just been bugging me we point to the workboard [16:49:16] it should be removed or updated [16:50:21] jdlrobson: it would take a bit of time for translatewiki.net to update all translations of the message, wouldn't it be better to introduce a new message-key? [16:50:44] FlorianSW: that's fine. The link still works [16:50:48] ok :) [16:50:54] it's just not the best, so if it takes some time that's okay - it will still point somewhere [16:50:59] and at least will be in their language :) [16:51:23] Ideally we'd have a mediawiki.org page to send them to [16:51:30] but we still have no developer hub [16:59:57] thanks FlorianSW for the merges. I'll take care of the QuickSurveys fall out [17:00:04] (spoke too soon...) [17:03:56] np :) Have a nice day Jon! :) [17:04:10] dr0ptp4kt: btw see my email `Monday estimation meeting` if you haven't already (cc bd808) [17:04:23] you too FlorianSW :) [17:04:33] hope you had a great holiday period so far! [17:05:02] jdlrobson: ugh. I thought that meeting was gone but apparently not [17:06:58] jdlrobson: bd808 joakino phuedx bmansuro_ jhobs yeah, let's just cover stuff in standup [17:07:05] jdlrobson: I'm not even invited to that meeting yet, so I can't mess with it. [17:07:31] dr0ptp4kt: do you have the power to add me to that meeting invite? [17:07:47] i see no invitation too [17:11:01] bmansuro_: you had declined the series from the looks of it. if you look at my calendar, you should be able to go into the event and change your status i think. [17:11:53] dr0ptp4kt: my bad, I see it in the web version of the calendar. [17:12:11] bmansuro_: cool [17:12:13] jdlrobson, dr0ptp4kt: Are we going to need to shift all the sprint related meetings by +1week to kick off on the 11th or are we going to do a week of some other planning to get back on the current cadence after devsummit+allhands? [17:12:38] * bd808 should know the answer to this probably but doesn't [17:16:01] bd808 + jdlrobson - i envisioned the first week back from the summit being for planning, then we get to the hands on tech work the following week. do you think we should shift them back a week just to make it more "in sync" with typical pre-groomed sprints? [17:16:06] bd808: i was wondering the same :) [17:16:46] dr0ptp4kt: sounds good to me (first week for planning). [17:17:07] jdlrobson: thx [17:17:23] bd808: able to spare some time to ghangout? [17:17:31] bd808: that is, right now? ;) [17:17:47] sure. [17:18:53] bd808: hang on, will send you the link [17:34:12] anyone around who knows how to review & submit TWN changes for processing? [17:34:33] bearND: you around? [17:38:19] bmansuro_: should be an easy fix in zuul (hard bit is remembering where this stuff lives :)) [17:39:30] maybe QA folks can help? [17:41:53] bgerstle: yup [17:42:16] how can i help? [17:42:16] bearND: hey, thanks but Nemo_bis just helped me out [17:42:28] great [17:45:24] bmansuro_: lemme take a look [17:45:50] bmansuro_: config/zuul/ext_dependencies.py [17:45:58] in wikimedia/integration [17:46:11] cool [17:46:24] Note MobileFrontend depends on ['Echo', 'VisualEditor'], [17:46:36] Gather a bunch of things [17:46:44] note these are just dependencies for zuul stuff [17:46:55] jdlrobson, bmansuro_, bd808: Just realized I completely forgot to reply to the standup email last Thursday! Sorry about that, I'll include my update from then in today's standup [17:47:10] np, jhobs [17:47:15] bmansuro_: am pretty sure that browser tests will be fixed by patch as well :) [17:47:51] jdlrobson: what's the point of adding @extension-mobilefrontend if we have to enable it anyway? [17:47:58] bmansuro_: the user page stuff is cool btw. You did a real nice job. Did Nirzar's mocks help a lot? [17:48:00] as a dependency [17:48:07] bmansuro_: it gives you meaningful error messages :) [17:48:13] making debugging this sort of thing a lot easier :) [17:48:23] but agreed would be good if it was automatic [17:48:23] jdlrobson: yeah, pretty much, i just copied and pasted his code :P [17:48:25] ok [17:48:31] release engineering team are sadly very stretched [17:48:56] bmansuro_: you should let him and JK/Adam know - i think it's important to show the value of well defined mocks :-) [17:49:11] sure [17:51:32] bearND: mdholloway|afk You guys in today? Also, calendar says Dmitry is, but I don't see him online... [17:53:02] jdlrobson: https://gerrit.wikimedia.org/r/#/c/260764/ [17:54:19] mbinder: i'm in, but Dmitry should be out this week [17:55:05] bmansuro_: sweet. i dont have +2 but hopefully we can find someone to merge. guessing that might be hard this week :) [17:55:25] mbinder: i see a prioritization meeting on my calendar. Is this really going to happen without Dmitry? [17:55:49] bearND: I think we can skip that meeting, unless you guys want to use the time for something else [17:56:13] bearND: mdholloway|afk kaity Do you guys want to standup this morning? [17:57:05] mbinder: standup is fine if the others are around, but i think we should skip prioritization. I niedzielski around? [17:57:10] Is [17:57:37] bearND: I think he is on vacation [18:00:54] I guess I could sync with mdholloway|afk directly instead of standup as well. [18:02:26] bearND: mdholloway|afk OK, since it's just the two of you I think we can skip standup. Feel free to reach out to me if I can help with anything. [18:06:02] bearND|brb: mbinder: yeah, let's definitely skip prioritization. bearND|brb, i'm going to make a quick cup of tea; wanna do a quick hangout when we're both back? [18:12:35] mbinder: yes, let's skip standup. mdholloway|brb : yes, we can do a quick hangout when you're back [18:15:53] jdlrobson: you left hangout before I saw your question; I'm leaving on the 9th like baha [18:15:59] ok :) [18:16:09] so i guess we're not all in the office the following week :) [18:17:35] jdlrobson: should we be? [18:17:40] bearND: back. to the batcave? [18:17:52] mdholloway: omw [18:24:53] bmansuro_: no i was just curious [18:57:49] jdlrobson: your Gather release patch stalled on merging. I /think/ it's just a jenkins error, but I moved to -1 anyways for visibility https://gerrit.wikimedia.org/r/#/c/261209/ [19:08:38] jhobs: corrected [19:08:46] jhobs: so what's going on with the platform stuff - really keen to see the back of it [19:08:52] been dragging far too long [19:08:53] jdlrobson: it's up [19:09:01] ok ill take a look now [19:09:14] like I said before, it was just stalled because of CN discussion [19:10:46] jhobs: yeh but that's not gonna get fixed anytime soon so you were right to work on it. jhobs: out of interest do you know how we distinguish isMobileMode ? [19:10:54] isMobileLayout rather [19:11:01] screen width [19:11:18] so my patch is a mix of screen width and skin basically [19:13:37] jhobs: hmm. But what about Minerva on tablets? [19:14:37] jdlrobson: shit, didn't think of that. [19:14:55] jhobs: might be worth looking for mw.config.get( 'wgMFMode' ) [19:15:01] i think that's only defined in mobile mode [19:16:19] jdlrobson: I'll take a look. Should be able to do it just from the skin though, shouldn't I? [19:18:25] ah nvm, I see the benefit [19:23:08] dr0ptp4kt: is there some way you can add an alias to your username for abaso on phabricator - i can never spell it :( [19:24:18] ^ anyone whose IRC name is not equal to their phab name should do this if it's possible imo [19:24:51] I constantly try to type @joakino before remembering it's jhernandez :D [19:25:51] Not my fault ;) [19:33:05] jhobs: the platform stuff might be better done in server from what i see [19:33:20] i remember flagging the entire platform approach as flawed but that's for another time [19:33:53] jdlrobson: well if we move to CN we won't have to worry about it, so I wouldn't worry about your latter point [19:34:01] but what's your thinking for the server approach? [19:34:06] jhobs: sure but not gonna happen over night :) [19:34:23] jhobs: instead of mode and platform I suggested we just had skin [19:34:30] since minerva beta is minerva-beta [19:34:38] and Minerva could be a desktop skin [19:34:52] platform shouldn't really matter with respect to these kind of things [19:36:15] jhobs: looks like checking wgMFMode won't work.. i think this needs to be done on server side [19:37:22] jdlrobson: why not just base it on skin? Treat minerva as always mobile and differentiate between minerva and minerva-beta. I think treating minerva desktop users as mobile is probably ok [19:37:49] I mean there's not much way to support counting tablet minerva as mobile and desktop minerva as desktop afaict [19:37:57] jhobs: because that's not strictly true - http://en.wikipedia.org/wiki/John_Lennon?useskin=minerva is desktop [19:38:14] but not the same as en.m.wikipedia.org/wiki/John_Lennon [19:38:29] well the former redirects to the latter [19:38:29] (no section editing) [19:38:47] they're fundamentally different in many ways [19:38:59] mobileformatter doesn't run on desktop version [19:39:34] unless I'm misunderstanding something though, the useskin param redirects to m. [19:39:50] clicking on your two links above results in the same site twice [19:40:15] and I'd argue that the mobile site should still count as mobile even if the user is actually on desktop [19:40:46] We need to get out of the mindset of mobile vs desktop. Everything should be the same just built better. There is no mobile. [19:40:50] jdlrobson: nevermind, I had some headers set lol [19:40:56] and no the useskin parameter doesn't redirect to m [19:41:03] yeah I had some headers set I forgot about [19:42:02] jdlrobson: so basically you're suggesting completely changing platforms to target the skin directly then? [19:42:16] i think it's too late for that. I was arguing that at the beginning [19:42:26] now i think we need to move towards CN and make do with what we have [19:42:37] and suffer consequences of not doing it right in the first place :) [19:42:51] ok, so then I'm fine to continue with using skin & mwMFMode? [19:43:21] since it's basically temporary anyways [19:43:30] dr0ptp4kt: do we have quorum for the reading API/services meeting? [19:43:36] or switch to server-side logic? [19:48:52] jdlrobson: new PS [19:50:20] jhobs: k [19:52:21] jhobs: wait.. wgMFMode is always on Minerva so that's no good either [19:52:32] i think this will have to be done server side.. [19:52:48] Want me to take a look? https://phabricator.wikimedia.org/T122516 is more serious at moment anyhow [19:53:36] jdlrobson: sure [20:04:38] bgerstle: yes. [20:04:43] k [20:12:59] jdlrobson: got a minute to ghangout? [20:15:02] dr0ptp4kt: dr0ptp4kt sure [20:15:14] dr0ptp4kt: ill jump in tracy island [20:37:04] mdholloway: i added you to this week's weekly reading eng sync [20:41:19] dr0ptp4kt: col [20:41:22] cool [20:41:24] ha [21:14:51] bd808: able to ghangout again? [21:15:10] 10 minutes? [21:15:36] bd808: K [21:15:47] er, lower("K") [21:16:02] not a screaming K, a gentle k [21:16:38] jhobs: Gather release doesn't seem to have worked as expected... [21:18:33] bd808: don't suppose you could merge https://gerrit.wikimedia.org/r/261274 ? [21:27:38] dr0ptp4kt: wrapping up with tgr. WIth you in a minute [21:27:48] bd808: word [21:29:06] jdlrobson: what do you mean? [21:29:30] jhobs: the release didn't incorporate the change [21:29:32] not sure what happened [21:29:36] maybe lost in the rebase [21:29:51] huh weird... [21:35:10] bd808: i gotta hop on the next call...after that [21:35:37] dr0ptp4kt: k. I've got another coming up too... E_TOOMANYMEETINGS [21:55:46] bd808: talk for 3 mins? [21:55:54] bd808: or am i pushing it? :) [21:56:26] yeah I can be a bit late for robla. I'll join the one you setup that I never made it to [22:05:37] jdlrobson: i'm not sure I understand your confusion on the test stuff [22:06:14] e.g. assert.ok( this.isPanelElement( $locationMinervaTablet.find( '> div > div' ).children().eq( 1 ) ), 'Check on mobile page it is inserted in correct place (before infobox)' ) [22:06:25] so apparently `$locationMinervaTablet.find( '> div > div' ).children().eq( 1 )` means before infobox [22:06:27] jdlrobson: wait nvm I think I get it. You mean add classes to all elements we're expecting to check [22:06:43] but if it say $locationMinervaTablet.find( '.infobox' ).prev() wouldn't that make a lot more sense? [22:06:50] yeah, that's a good point [22:07:01] i basically had to manually check every single output [22:07:03] new norm? [22:07:59] jhobs: doesn't need to be a norm.. just makes sense here no? [22:09:19] jhobs: can you have a go? I merged cos I felt it was more important to fix the bug but I worry if we don't do that now we won't get round to it [22:09:29] jdlrobson: sure. I can start a hygiene patch up [22:10:39] jdlrobson: merge failed :/ should I just add it to the original patch then or still do a separate hygiene one? [22:19:17] jdlrobson: what does https://gerrit.wikimedia.org/r/#/c/261274/ actually do? [22:21:31] post-merge build failed*. i really oughta read things closer -_- [22:26:48] bd808: it changes the pointer position of master [22:27:14] i'm not sure what happened but the original didn't rebase master against origin/dev [22:27:38] basically the patch `Restore the collections link to the mobile personal menu` needs to be in master [22:27:43] it currently isn't, this makes it so [22:29:04] jdlrobson: got it. [22:32:17] thanks bd808 [23:27:48] jdlrobson: thx for merging my Nearby changes :) [23:29:28] np FlorianSW [23:36:40] FlorianSW: don't suppose you want to review https://gerrit.wikimedia.org/r/244816 ? [23:36:55] not as scary as it looks :) [23:37:45] jdlrobson: I remember I looked at this earlier in a free minute, and the huge amount of renames looks scare :P Give me 2 seconds to find out, what you do :D [23:38:40] this is one of those moments where github would make it less scary :) [23:39:07] https://gerrit.wikimedia.org/r/#/c/244816/16/includes/Resources.php is where most of the changes happen [23:39:10] the others are just renaming to reflect [23:39:49] jdlrobson: isn't position => bottom the default? :/ [23:39:52] https://gerrit.wikimedia.org/r/#/c/244816/16/MobileFrontend.php [23:40:09] FlorianSW: yeh i think so [23:40:12] i dont think top is supported [23:40:21] can remove [23:46:00] jdlrobson: commented [23:47:42] thanks FlorianSW [23:48:19] https://gerrit.wikimedia.org/r/#/c/260871/5 < hopefully that's less controversial :) [23:53:12] yep :P [23:56:36] FlorianSW: fixed :) [23:58:00] ok, let's test! :D