[04:53:07] josephine_l, I guess I can merge both PRs? [05:05:40] Hi Nicolas , yes please :) [05:06:25] Nicolas, sorry about the About Activity pull request. I'd branched it off device-bugfix so since that wasn't merged yet, I guess all the commits were brought over as well [05:06:44] Is there a way I can avoid that in the future and only select certain commits for a pull request? [05:08:11] If two PRs are unrelated, the best is to start the branch from the latest master. If you branch from your latest point, then I can't merge the second without merging the first. [05:08:28] from the latest master -> I meant from latest upstream [05:08:51] Nicolas, oh, okay. That wouldn't cause a merge conflict if the 2nd is merged before the 1st? [05:09:43] Merging the 2nd would merge the 1st automatically (or at least the part of it) [05:11:42] Anyway thanks for the About fix, which is not asked for by the internship, but indeed important to get feedback. By the way, I am now trying to fix the crash experienced by the Polish user yesterday. [05:12:37] Nicolas, no probs. :) The Polish user's issue is difficult to resolve without the help of someone who knows the language right? [05:12:47] Since the problem is with the Polish strings [05:16:02] I will try ;-) [05:16:13] with his help [05:17:40] Hahah, cool :) [15:15:53] is the dev branch on Gather not being used anymore? [16:11:03] codezee: i think it is [16:12:54] dbrant: your event logging patch looks fine to me. however, i don't see the table being made on the server. i think this is just a server issue. should i merge or do you want to resolve the server issue first? [16:14:07] niedzielski: yeah, pretty sure it's a server issue... let's merge, if it looks good [16:14:29] dbrant: sounds good [16:17:11] bmansurov_oops: new nick :P ? [16:17:26] ;) while i'm away [16:17:39] nice one :D [16:17:56] yeah trying to be funny, which doesn't always happen haha [17:05:35] dr0ptp4kt: we're at r37 [17:05:41] are we supposed to go somewhere else? [18:13:03] what just happened o.0 ? [18:16:38] kaity: standup [19:07:16] mdholloway: i was able to submit the patch https://gerrit.wikimedia.org/r/263888. Would you mind taking a look and test it, also with the app? [19:08:01] mdholloway: never mind. i see it's already done. [19:08:46] my ISP is having a big outage today, so internet is very flaky [19:14:22] bearND: yep, done :) [19:14:39] bearND: should i put that in the QA column or move it straight to ready-for-signoff? [19:15:04] QA [19:16:08] i assume by the time elena gets to it we'll have the fix deployed [19:24:00] mdholloway: would you do the deployment today? I'm not sure if the connection holds up for me. [19:24:25] bearND: sure, i can do it [19:26:51] thank you [19:56:05] hey dr0ptp4kt did you guys talk at all about keeping tracking working for preinstalls for this Q? [20:02:57] dbrant: joining grooming? [20:50:08] Reading web peeps: how did the last hour of the meeting this morning go? [20:50:18] are there things I can help follow up on? [20:53:21] hey dbrant [20:53:38] kaity_: hello! [20:54:00] dbrant: I'm still not feeling too well from the cold [20:54:13] dbrant: can we meet tomorrow or friday instead of today? [20:54:49] kaity_: :..( totally! no worries. [20:55:00] feel better [20:55:03] thanks! [20:55:08] i'll find a tiem [20:55:17] see i cant even spell [20:55:23] haha [20:56:05] you must be feverish! [20:57:31] jdlrobson, dr0ptp4kt: I made a sprint board for sprint-64 -- https://phabricator.wikimedia.org/project/sprint/profile/1709/ [21:08:46] bd808: thx [22:30:11] dbrant: Is there an API that provides the user-friendly version of the first sentence of Wikipedia articles? ie, filtering out the pronunciation, parens, and other common non-prose elements? [22:31:26] ragesoss: There is! Just text, all junk removed [22:31:43] multichill: where is this API? [22:32:56] ragesoss: https://en.wikipedia.org/w/api.php?action=help&modules=query%2Bextracts [22:33:09] aha! [22:33:15] thanks much. [22:33:37] You're welcome, otherwise you would probably be like the 6th person implementing this on your own island ;-) [22:34:06] ragesoss: multichill: that still doesn't filter out parens / pronunciation, etc, though. [22:34:30] dbrant: that gets done in apps and/or mobile web, though, right? [22:34:45] ragesoss: yep, we do it locally in the app. [22:34:53] oh. darn. [22:35:01] okay, thanks. [22:36:02] True, but you get rid of all the wikitext nonesense. Would be a nice addition to be able to filter out more on this side [22:36:31] dbrant: if it's not to much trouble, could you point me to how that's implemented int eh app? [22:36:39] But pronunciation, parens, and other common non-prose elements are very very language dependent so I don't think there is a very easy way of achieving that [22:37:49] Good luck [22:40:05] ragesoss: to remove parens, it's a pretty naive algorithm: https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewContents.java#L50 [22:40:28] dbrant: cool, thanks. [23:07:41] kristenlans: your email just made me crack up way harder than I'd like to admit :D [23:15:29] jhobs: that was my intent :P [23:30:45] instrumentation meeting anyone?