[09:02:26] good morning y'all [09:12:01] good morning [09:14:29] morning! [09:14:40] hey everyone [09:15:39] hey hashar, joakino, d3r1ck [10:04:07] phuedx: hey [10:04:12] phuedx: long time bor [10:04:16] *bro [10:15:27] hullo d3r1ck. how're you? [10:15:38] what are you working on these days? [10:32:05] phuedx: well just GCI [10:32:18] wrapping up. GCI will end in 5 days [10:33:23] being a mentor was not quite easy as i thought. [10:33:43] phuedx: what about you? [10:34:02] i'm currently getting a suite of browser tests to pass [10:34:41] phuedx: hahaha... and how is it going? [10:35:12] fine, just fine [10:35:26] i have a love/hate relationship with browser tests [10:36:31] phuedx: hahaha... Ok. What is love/hate? [10:41:42] i equally love and hate browser tests [11:40:07] phuedx: Ok [12:02:46] breaking for an early lunch with my children [12:08:37] phuedx: Ok have a nice meal [12:17:46] out for lunch! [12:19:49] cool [12:53:38] o// [14:14:52] bmansurov: yt? [14:14:56] anything i can help with? [14:15:06] yes, i'm here [14:15:17] phuedx: yeah [14:15:35] i see that there are two cards of yours in -1 and one in doing [14:15:37] so… [14:15:43] how i can i help that not be the case? [14:16:02] let me look at the cards [14:16:35] so the language button instrumentation is on hold, kind of. we have a meeting to talk about the schema today [14:16:41] but i need help with the other -1 [14:17:33] ok, so according to the requirement, wikidata description in cards should be one line and have ellipsis [14:17:41] if it's too long to fit in the box [14:18:00] we also need to make sure the contents of the card is vertically aligned [14:18:20] this can be achieved easily when we apply display: table-cell, but we lose the ability to apply ellipsis [14:18:27] so I was wondering if you can help me achieve both [14:19:07] i'll take a look [14:19:10] thanks [14:30:02] bmansurov: do you mind if i assign the card to myself? [14:30:09] just while i'm taking a look [14:30:23] (and hopefully coming up with an acceptable solution) [14:30:24] phuedx: go for it, and you can keep it assigned to yourself until it's closed ;) [14:30:28] ;D [14:30:31] that's the only problem with the patch i think [14:32:17] phuedx: do you know why Jenkins qUnit may fail but all tests pass locally? [14:32:32] jenkins is saying that an api request failed [14:32:47] i'll take a look to see if it's stubbed before i move on to the design [14:33:00] phuedx: sorry, this is a different patch [14:33:04] https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/27124/consoleFull [14:33:05] oh [14:33:11] which patch? [14:33:17] https://gerrit.wikimedia.org/r/#/c/264909/7 [14:33:35] so I can re-produce the issue if I delete the sample rate config variable [14:33:44] but why would jenkins not consider it while it's there [14:34:10] bmansurov: Unknown dependency: schema.SchemaMobileWebLanguageSwitcher [14:34:34] phuedx: which doesn't make sense, does it? [14:35:19] phuedx: commenting out the contents of the last array in https://gerrit.wikimedia.org/r/#/c/264909/9/includes/config/Analytics.php causes the issue [14:35:42] maybe it's just a coincedence [14:41:47] bmansurov: because the event logging subscriber will only be called if there's a non-zero sample rate [14:42:11] mw.eventLogging.Schema.prototype.log (which you wrote ;) ) [14:42:14] (\o/) [14:42:19] hmm [14:42:21] calls mw.track 'foo' [14:42:28] which will try to load the schema [14:42:53] wait [14:43:06] i'd expect that to be the other way around [14:43:59] oh wait, no [14:44:03] that's the right way around [14:44:10] *phew* [14:44:33] you're calling new mw.eventLogging.Schema( 'Foo', undefined, ... ) [14:44:39] which will set the population size to 1 [14:44:56] which will always result in an mw.track( 'event.Foo', ... ) [14:45:20] which should load schema.SchemaMobileWebLanguageSwitcher right? [14:46:06] so I'm wondering why the 2nd parameter would be undefined, when it's already set in the config variable [14:46:39] well, if you're explicitly setting the config variable to an empty array, then it will be undefined [14:47:03] yes, but I'm only doing so to re-create the error. Why would Jenkins do so? [14:48:17] i'm not sure that that's the main issue (it is an issue) [14:48:27] i'd be more concerned as to why your schema isn't being found [14:49:08] ok, i don't want to distract you from your work. thanks for looking into it [14:49:22] i'll take another look at it later [14:51:28] bmansurov: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L1065 [14:51:44] ^ that generates a schema module name of "schema.MobileWebLanguageSwitcher" [14:52:02] and the module that's failing to be loaded is "schema.SchemaMobileWebLanguageSwitcher" [14:52:16] yes and self::getEventLoggingSchemas() already returns SchemaMobileWebLanguageSwitcher [14:58:03] alright, gonna take a break [17:12:44] hrm labs instances randomly shut off... [17:12:45] wtf [17:16:56] dbrant: got a minute to hop in the batcave? [17:20:06] mdholloway: yep, ready now [17:20:25] dbrant: cool, heading over [17:28:52] morning [17:37:07] jdlrobson: morning :) [17:37:18] hey codezee :) [17:39:29] Hi, I hang around here, looking for tasks that I can attempt and learning along, the past month was great in that regard... [17:49:53] codezee: i feel like there's a "but" coming [17:52:02] phuedx: yeah apparently, it was framed in such a manner :P so "but this month has been slow as college has to be managed simultaneously, and sometimes I'm stuck on choosing a task :D" [17:52:20] though the "but" part isn't that strong ;) [19:22:11] niedzielski: +1 on your comment on https://phabricator.wikimedia.org/T115816 :) [19:22:58] etonkovidova: :) [19:33:12] out for the day [19:34:47] later [19:45:52] any changes to the mobile web edit interface in wmf11? [19:45:55] jdlrobson: ^ [19:47:17] tgr: why do you ask? Best to ask editing team. My team hasn't touched that code, so if there are there have been none intentionally :) [19:49:35] jdlrobson: wmf11 just got rolled out to group1, someone is complaining about mobile edit if becoming horrible [19:49:49] at #wikimedia-operations [19:49:52] are they able to be more specific? :) [20:11:13] tgr: did you work it out? [20:13:05] jdlrobson: not yet, but it doesn't look like the mobile UI itself is the problem [22:38:55] jdlrobson: in case you or someone has a clue about https://phabricator.wikimedia.org/T124356 , especially possible connections to session handling errors, that would be cool [22:39:26] at a glance MobileFrontend uses cookies but nothing session-related, but I did not have time to look deeply [22:51:41] jdlrobson: yep [22:52:10] nzr: so how do you want to deal with caching problem on user pages? [22:52:19] The new user styles will take time to roll out [22:52:34] jdlrobson: yes lets talk about it. i didnt quite understand the problem [22:52:43] should we promote the user page to stable separately from turning off the user profile page or just accept the cache issues will be present for 30 days and it won't quite look right [22:52:47] dbrant: niedzielski is it known that 'Go to file' gives 404 error for any image? [22:53:49] etonkovidova: hm, sounds familiar. seems to work in mediawiki though. checking content service now [22:54:31] niedzielski: it's in 2.1.137-alpha-2016-01-20 [22:54:37] etonkovidova: ah, yeah broken for content service on my end too. let me see if i can find a phab [22:57:54] etonkovidova: ah, here we go T121818 [22:58:01] etonkovidova: it's closed so we thought this was fixed [22:58:37] etonkovidova: oh and this T118306 (open) [22:58:44] niedzielski: I clearly see it with 2.1.137-alpha-2016-01-20 on Nexus 5 (Android 5.1.1) [22:59:57] etonkovidova: yeah, looks like bernd's on it so we'll get it fixed :) [23:00:26] niedzielski: the issue was filed long time ago hmmm.... [23:00:46] etonkovidova: it has dependencies on other folks, so it takes a bit [23:01:31] niedzielski: can it be that it's because of enabling RESTbase access? [23:02:08] etonkovidova: right, i think this is an RB only issue (beta, alpha, dev only) [23:02:32] niedzielski: ok then [23:03:06] niedzielski: yup - it's RB [23:03:27] etonkovidova: thanks for checking :) [23:13:22] jdlrobson: lets accept the cache issues [23:13:27] if its only 30 days [23:13:57] nzr: so to be clear, the user link will link to user page and that user page will look like an article page until someone edits it or it becomes 30 days old [23:14:13] can you update / comment on https://phabricator.wikimedia.org/T120685 nzr ? [23:18:40] jdlrobson: done :) [23:18:45] jdlrobson: thanks for your patience [23:18:47] thx!