[00:30:06] Um, is GitHub down for anyone else? [00:30:21] yes [00:30:23] but gerrit is up, so np [00:30:29] I keep getting "Unicorn! No server is currently available to service your request." [00:30:34] Oh, okay, thanks. :) [06:25:38] josephine_l: https://status.github.com/messages this might help you out [06:25:48] or be more informative, sorry [08:54:44] morning [08:55:32] morning [09:07:49] Thanks phuedx. :) GitHub is up already I think. [09:22:35] josephine_lim: yup, but it's a handy link if you suspect something is awry [09:23:33] (it should be up even if github.com isn't) [09:23:36] phuedx: oh, definitely, thanks. :) [09:42:40] out to administer ear medicine to dog [09:42:47] bbiab [09:43:08] ^ :( [09:43:19] joakino: is her ear any better? [09:44:27] joakino: could you review https://gerrit.wikimedia.org/r/#/c/266635/ when you're back [09:44:53] i pushed ps2, so i'm not happy with +2ing it [09:45:04] (despite ps2 being a minor tweak) [09:52:58] phuedx: I think she's mostly cured, when cleaning ears almost nothing comes out of them, tomorrow I have to go to the vet for a checkup [09:53:00] sure [09:54:10] phuedx: it's pretty annoying to check this, (desktop + mobile) * (full size + tablet size + phone size) [09:54:15] should i take screenshots? [09:54:37] seems like we should have a tool for this, non? ;) [09:54:47] blargh [09:54:59] yeah, want me to take the mobile condition and you do the desktop condition? [09:57:21] joakino: ^ [09:58:01] phuedx: don't worry, it's not too much. it looks good [09:58:53] phuedx: there's one thing that itches my inner designer, when the cards are stacked, the border radius middle corners makes the left and right border not straight, there's like a pixel missing [09:59:17] ah [09:59:28] that's the border radius:2px constant [09:59:44] eyah [09:59:45] yeah [10:08:08] phuedx: i've pushed a new patchset that fixes that. now it looks like https://i.imgur.com/BHkdMWB.png and https://i.imgur.com/CMo9Rzz.png [10:08:26] nice [10:08:36] +2able by me for the previous patches, if it is fine +2 it for my patch [10:08:50] otherwise jeff is the only one that would really be able to merge :p [10:09:02] alright -- i'll review [10:09:10] can you add screenshots to the task for nirzar [10:09:14] ? [10:12:15] sure [10:14:46] ok, ps4 looks okay [10:15:09] some quite specific selectors in there but i'm not quite sure how to unpick them [10:16:03] phuedx: yeah, i'm not sure how to do it differently without adding specific classes to the html [10:16:14] on the media query I had to repeat them to override the specificity [10:36:56] thanks joakino -- deployed on our staging node for nirzar [11:06:07] 👍 gj [11:10:37] phuedx do you know why gather & relatedarticles & cards are not here? https://www.mediawiki.org/wiki/MediaWiki_1.27/wmf.11#MobileFrontend [11:20:11] "pouring gasoline on the bonfire of our collective hopes and dreams" is my new favorite tagline [11:20:26] i'm in a mood [11:20:34] joakino: not sure what generates those pages [11:24:03] oooh [11:24:19] phuedx: if there are no commits then it doesn't show up [11:24:25] https://www.mediawiki.org/wiki/MediaWiki_1.27/wmf.10#Gather [11:24:27] nice [11:24:31] oh neat [11:24:38] cool [11:24:42] then we can probably deprecate HISTORY file and the related wiki pages [11:33:24] brb [12:08:55] good noon people [12:09:16] someone mentionned slowness with the mobile app when loading barrack obama articles [12:09:37] and guess what happened to me yesterday? slowness to the point the wikipedia beta apps froze while loading [[en:Sahara]] [12:09:49] I have hopefully submitted a report via the build in apps [12:09:58] seems to be related to some effect on the top image [12:20:10] awesome, thanks hashar! [12:20:21] well [12:20:23] not awesome [12:20:24] obvs [12:27:09] phuedx: obss ? [12:27:12] oh [12:27:17] awesome because I sent the report [12:27:25] but not awesome because it is slow somehow :-} [12:27:33] obvs is my obnoxious way of saying "obvsiously" [12:27:35] yes [12:27:35] that [12:27:36] :) [12:27:38] I wanted to capture a video but haven't managed to found a foss app to record it [12:27:39] and [12:27:49] I have no f**** clue how to take trace / debug etc [12:28:44] my phone is really slow overall, I should factory reset it eventually . Such a pity, it is only from 2011 :( [12:56:25] :( [12:56:31] seems to be the way of phones these days [13:00:09] hasharLunch: is this ios, android? if it's android, you could try telecine (https://play.google.com/store/apps/details?id=com.jakewharton.telecine). it's open sarce but probably requires a newer version of android than your phone has. i don't think there's a lot of options on older devices except screenshots [13:00:21] niedzielski-afk: android [13:01:27] hashar: you could try to install telecine. i don't think any of the screen recording apis came out until lollipop-ish iirc [13:01:55] I guess [13:01:57] thanks for the tip though :} [13:02:28] lollipop :| (http://developer.android.com/about/versions/lollipop.html#ScreenCapture) [13:02:58] Google stopped providing over the air updates for Galaxy Nexus less than 2 years after the phone got released :( [13:03:15] apparently because it has a Texas Instrument chip and TI stopped building/supporting the chip [13:03:16] such a pity [13:03:41] hashar: you could try cyanogenmod [13:04:58] hashar: i have a Samsung Galaxy Nexus (SCH-I515) with CM on it (KitKat) [13:06:09] hashar: on kitkat, you can use the android debug bridge (ADB) to run screenrecord, http://developer.android.com/tools/help/shell.html#screenrecord [13:10:16] niedzielski-afk: yeah I should backup and switch to cyanogen mod [13:28:00] o/ bmansurov :) [13:28:09] didn't see you join [13:28:10] phuedx: mornin [13:28:14] mornin' [13:28:41] not many people can notice me when I join given the speed I use ;) [13:30:26] lol [13:33:59] hashar: niedzielski-afk i've successfully used http://www.vysor.io/ to show the screen on my mac, and then use quicktime to record it while I do things on the phone [13:34:11] morning phuedx [13:34:37] ^^ saving that for later, thanks joakino [13:34:55] so many hacks and apps ! [13:34:58] I am definitely not a mobile dev [13:35:05] phuedx, joakino, jhobs, jdlrobson: can you guys review https://gerrit.wikimedia.org/r/#/c/266957/ and https://gerrit.wikimedia.org/r/#/c/266955/ ? I'd like to SWAT deploy them in the morning window. [13:35:28] i'm going to go prepare boiled vegetables [13:35:36] hashar: who are you calling a mobile dev? [13:35:38] i meant morning bmansurov [13:35:43] i'm a distributed systems engineer [13:35:56] :P [13:35:57] joakino: morning [13:42:01] phuedx: good catch on the schema name btw [13:42:28] 👏 [13:49:06] phuedx: sounds better than "devops" [13:54:28] bmansurov: commented [13:54:38] jhobs: thanks! [13:55:46] bmansurov: judging by the state of #wikimedia-operations right now, I wouldn't be surprised if the morning SWAT gets delayed ;) [13:55:55] ^ that [13:55:59] phuedx: do you want to talk about https://gerrit.wikimedia.org/r/#/c/265292/ here? [13:56:10] no [13:56:15] sure what's up? [13:56:34] why is deploying to beta less risky than beta + prod? [13:56:41] are we not confident about the code? [13:57:01] i wasn't until i tested it [13:57:03] then i wasn't [13:57:04] now i am [13:57:11] ish [13:57:46] ok, if there is a problem with the code then the config patch should be blocked only on that i think [13:57:57] otherwise i don't see a reason not to deploy together [13:58:39] i don't see a reason to deploy both at the same time [13:58:48] i'm cautiously optimistic that the code works [13:58:53] now that it, y'know, actually works [13:59:03] staging isn't production-like [13:59:13] beta is /probably/ more production-like [13:59:20] i'd prefer to use canaries for what they're for [14:00:37] ok then [14:00:41] i'll split up the patch [14:00:53] or we could ask someone else's opinion? [14:01:20] (i'm frequently wrong) [14:01:23] bmansurov: to clarify, the requirements say "stable," but we've already informed leila before that the platform parameter doesn't actually work [14:01:32] so it'll run on beta no matter what [14:01:54] so we might as well make the code show what it's going to do, [14:01:57] jhobs: sure, but that's unintentional [14:02:02] (accidental trailing comma) [14:02:04] if we add beta that would be intentional [14:02:21] weird was getting a pile of 503s in the android app but now that's stopped suddenlly [14:02:23] phuedx: i think you're right [14:02:26] right, but since it's known, it basically is intentional, right? Otherwise we'd block it on a fix [14:02:41] and leila knows about it, so my thinking is the original task just wasn't updated [14:03:41] jhobs: ok, i'll add 'beta' [14:03:45] and commas ;) [14:03:53] the commas were more cheeky ;) [14:31:30] bmansurov: how do you feel about the code layout in https://gerrit.wikimedia.org/r/#/c/267029/? [14:32:24] phuedx: looks better than mine [14:32:26] i think that your patch is fine, but i felt like the sample rate stuff could be broken out and named [14:32:41] wanna squash? [14:32:42] I agree [14:32:49] I'll just abandon mine [14:32:53] that way it's easier [14:33:05] hrrm [14:34:43] wait yours depends on mine? [14:35:18] feel free to not depend ;) [14:37:06] yeah, i'm squashing them locally and pushing a new patch [14:38:29] ok [14:43:02] just reinstalling all of the npm modules [14:53:37] bmansurov: https://gerrit.wikimedia.org/r/#/c/267029/ [14:53:44] i /think/ you can abandon your patch now [14:53:47] * phuedx crosses fingers [14:56:08] bmansurov: did you even test it? ;) [14:56:11] :/ [14:56:15] (that was fast) [14:56:27] not really, i tested my own patch, yours is close enough [14:57:01] rules exist so that we can bend them ;) [14:58:45] waiting for it to merge and then i'll re-test on staging [15:00:19] ok, thanks, [15:00:46] i'll take a break and will be back online in about an hour for swat deploy. it would be great if someone else can +1 those patches [15:01:04] patches mentioned above. [15:18:44] Hi guys, somebody from iOS around? [15:36:01] barbarar: i think someone should be around in an hour-ish [15:36:10] coreyfloyd, bgerstle_afk ^ [15:36:14] (fyi) [15:38:31] thanks phuedx! [15:39:51] barbarar: sup? [15:43:09] I want to understand what is a "TECH DEBT" deprecation? I'm on the WMFDeprecationMacros header file. [15:44:07] barbarar: In one of out build configurations, items tagged as tech debt cause warnings to show up in the issue navigator [15:44:46] barbarar: we do it so we don't normally flood the issue navigator with "#warnings" under normal development [15:45:38] barbarar: basically its a "TODO://" [15:46:03] FYI - we have a specific iOS channel: #wikimedia-ios [15:46:59] good idea, thanks! I used XToDo XCode Plugin sometime ago for similar goal. Cool, I will go to the iOS specific channel next time [15:48:45] barbarar: no prob - leet me know if you need anything else and thanks for helping out! [15:49:52] sure!, I'll do, thanks [16:39:27] Kudos to the team for writing awesome tests for Gather. They were a great reference as I was struggling to write database tests for my own extension. Thanks! :) [16:41:06] Niharika: yes, they are good one's, had helped me a lot too :) [16:41:55] Hey codezee. Are you still in university this year? [16:42:46] Niharika: yeah, its my 3rd year, so it'll be another year and little more ;) [16:43:12] codezee: So I assume you'll be participating in GSoC again. :) [16:44:12] Niharika: I don't think it'll be possible, I'll be interning onsite [16:44:33] codezee: Ah, okay. Good luck! [16:44:48] thanks :) [16:59:23] jdlrobson, joakino: i'll be late to the meeting [16:59:35] tired children are making dinner time hard [16:59:43] http://www.theguardian.com/uk-news/2016/jan/28/man-had-38-stolen-phones-stuffed-in-trousers-at-rock-concert?CMP=twt_gu < phuedx was a little worried for a minute it was a mix up with you and the office phones ;-) [16:59:56] lol [17:00:07] could be a fun activity [17:00:12] rock concert with phones taped to legs [17:00:21] see what happens! [17:00:25] i'll let the meeting know [17:03:07] moving concert :D [17:05:14] bmansurov: joakino ping [17:05:34] ill join later [17:05:40] im a mabe [17:05:44] maybe [18:31:20] bmansurov: jdlrobson phuedx joakino, now that it's passing jenkins, I'm sure eyes (and +1s) couldn't hurt on a core patch ;) https://gerrit.wikimedia.org/r/#/c/267058/ [18:31:33] ok [18:31:49] bd808: still hitting that ios crash with the latest beta installed fresh? if so, able to submit the crash and let @JoshM and @bgerstle know? sorry if you already submitted a phab task for as much... [18:32:01] jhobs: just trying to sign off the language switching stuff [18:32:07] bmansurov: can you confirm it's on beta cluster now? [18:32:09] dr0ptp4kt: he was able to send us the logs, and coreyfloyd should have fixed it [18:32:17] i can confirm which build it's in if needed [18:32:22] jdlrobson: take your time, I just wanted to bring it to attention [18:32:27] bgerstle: i think it might be a different crash. bd808? [18:32:33] jdlrobson: i will soon [18:32:36] I started really early today, so I'm heading off soon anyways [18:32:37] it's on the board jhobs thus it has my attention :) [18:32:37] bgerstle: that would be helpful. The beta as of yesterday still had it for me [18:32:45] fair enough :P [18:32:49] bd808: which version was that? [18:33:13] bgerstle: (643) says the icon [18:35:21] hrmm it should've been fixed in 618 [18:35:55] I'll pull the crash logs later today for you [18:35:56] bd808: i'll re-open the ticket and follow-up w/ someone to investigate further [18:36:02] bd808: that'd be great, thanks! [18:36:52] thanks bgerstle [18:44:01] jdlrobson: How can I make my user script load at the top of the page? http://en.wikipedia.beta.wmflabs.org/wiki/User:Baha/minerva.js [19:18:04] why the top of the page bmansurov ? [19:18:29] jdlrobson: the schema code seems to run before the contents of the user page [19:18:36] of course [19:18:40] user page js runs at the end of the file [19:18:43] oh shoot you're not using the Schema class... yeh you're gonna have a bad time there then. You'll need a config change. [19:18:51] yep [19:18:55] i've submitted a patch [19:19:34] bmansurov: can you find someone to SWAT it ? It's a beta labs config change so should be possible to do right away. mybe bd808 can help? [19:19:49] phuedx: you still around? [19:19:58] yeah [19:20:15] i've got a meeting with adam in about 10 minutes [19:20:24] phuedx: so where are we with lazy loading references.. i saw Tim commented on thread but sounds like we are still not clear where we could store references? [19:20:36] Should I create a spike for next sprint to work this out? [19:20:50] can we not use setExtensionData on the ParserOutput ? [19:20:55] looks like [19:21:13] looks like we are not clear or looks like we can use setExtensionData ? [19:21:31] not clear [19:21:40] okay i'll set up a card! [19:22:05] i think storing /just/ the mobilefrontend-required data would dramatically decrease the required size [19:22:14] i'll add a comment to the current card [19:25:08] phuedx: https://phabricator.wikimedia.org/T125134?workflow=123290 [19:25:23] feel free to update that with details of size increase! [19:25:34] bd808: could you help me SWAT deploy 2 patches when you're free? [19:26:50] bmansurov: sure, but you may be able to get help sooner. Beta config only? [19:27:19] bd808: one of them is, but the other is quicksurveys config for production servers [19:27:36] bd808: who should I ping to get help sooner? [19:27:52] bmansurov: marxarelli is running the deploy train this week and twiddling his thumbs right now [19:28:03] ok thanks [19:31:36] "You’ve been removed from the ios team on the Wikimedia organization." [19:31:55] well i wasn't using the access, but can I still feel nostalgic sadness ? :) [19:32:04] brutal [19:35:25] btw. those github mails are completely confusing. They don't mention "github" at all, i had to deprettify the To: field before i figured out that it was about github. [19:39:42] ping dr0ptp4kt [19:43:38] ping dr0ptp4kt [19:43:38] ping dr0ptp4kt [19:43:38] ping dr0ptp4kt [20:19:26] jdlrobson, bmansurov: before i go to sleep: we want to test specific schemas [20:19:31] we don't want to test all the schemas [20:19:37] ^ i've just come to that conclusion [20:19:52] will do a thing on the patch [20:19:56] then i'm outtie [20:20:26] sounds good [20:24:48] phuedx: still here? [20:25:05] What exactly do I need to do in mobile-labs.php? [20:26:03] ok [20:26:04] bmansurov: look at wmgMFSpecialCaseMainPag [20:26:09] ^ that [20:26:16] but here's an explanation as to why: [20:26:43] the 'wmgFoo' line you've added in initialisesettings-labs will create a new global variable called $wmgFoo [20:27:04] (wikimedia global, bd808?) [20:27:19] but the config we use will be looking for wgFoo [20:27:36] so you have to initialise the wgFoo variable from the wmgFoo variable [20:27:52] i /think/ we can use 'wgFoo' in initialisesettings [20:27:56] but i'm not sure if that's bad form [20:28:16] why don't I do so directly in InitialiseSettings-labs.php? [20:28:29] When wmg* is used in config then you need to map to wg* in CommonSettings [20:28:44] mostly you only need wmg* when you are somehow mergin with other defaults [20:28:49] *merging [20:29:00] can I skip the wmg part if I need wg? [20:29:04] * phuedx is learning too [20:29:05] yeah [20:29:12] cool [20:29:23] okie poke [20:29:24] Our config system is a big dog's breakfast [20:29:29] alright, then changing wmg to wg in InitialiseSettings-labs.php should do it then [20:29:32] just drop the 'm' and you're golden bmansurov [20:29:37] ok [20:29:37] yarrrp [20:29:42] night phuedx [20:29:51] g'night y'all [20:37:31] night phuedx [22:35:36] bd808: hey we might need to get crash logs form you again… we have no crashes in our crash reporter for build 643. [22:36:19] coreyfloyd: I pasted one in the bug. I think before the crash was happening before it could post to the service [22:36:30] * bd808 also has crash reporting turned off again [22:37:05] bd808: yeah the old one I got - and fixed that bug (AFAIK) [22:37:15] bd808: is it a new one? [22:37:21] coreyfloyd: I added a new one a couple of hours ago [22:37:36] bd808: cool - i'll check out - you have the ticket handy? [22:37:59] https://phabricator.wikimedia.org/T123760#1979196 [22:38:18] bd808: thanks [22:38:24] yw [23:37:34] https://gerrit.wikimedia.org/r/#/c/267025/1 < bd808 can you check this for me? [23:37:42] i think it needs the m dropped from wmg too [23:37:54] i'm supposed to be getting it swatted it in 23 mins :) [23:40:48] jdlrobson: I'll amend [23:40:53] thx bd808 [23:44:07] jdlrobson: review and +1 if it looks right to you know [23:44:12] *now [23:44:52] loookinggg [23:45:06] boom! [23:45:07] thx [23:59:37] mbinder: i'll be there in 4 mins [23:59:48] dr0ptp4kt: k