[00:26:35] <leila>	 bmansurov: are you around? :-)
[00:26:52] <bmansurov>	 yes
[00:27:18] <leila>	 grrreat. so two things. first, we definitely have a patch that will go out for both languages this evening right?
[00:27:36] <leila>	 and that will multiply the old rates by 100, bmansurov, correct?
[00:27:38] <bmansurov>	 yes the patch is ready
[00:27:40] <bmansurov>	 yes
[00:27:42] <leila>	 perfect.
[00:28:00] <leila>	 the second thing is, what's the relation between "coverage" and "A" in the code?
[00:28:15] <bmansurov>	 https://gerrit.wikimedia.org/r/#/c/267071/1/wmf-config/InitialiseSettings.php
[00:28:20] <leila>	 I don't see how "coverage" gets eventually used (and that's probably because I'm not looking at the right place)
[00:28:26] * leila checks the link
[00:28:28] <bmansurov>	 let me check
[00:29:02] <bmansurov>	 here https://github.com/wikimedia/mediawiki-extensions-QuickSurveys/blob/master/resources/ext.quicksurveys.lib/lib.js#L223 coverage is used as A
[00:29:25] <bmansurov>	 here the bucket is being compared to A: https://github.com/wikimedia/mediawiki-extensions-QuickSurveys/blob/master/resources/ext.quicksurveys.lib/lib.js#L156
[00:34:09] <leila>	 bmansurov: looking at this code, I agree with you that it seems our estimates are probably off by a factor of 100, not your code. :D
[00:34:20] <leila>	 I'll update the card, and look to see if we can find a reason for it.
[00:34:29] <leila>	 thanks for walking with me through this, bmansurov.
[00:34:39] <bmansurov>	 how can your estimates be off?
[00:35:08] <leila>	 Our estimate of what % of the impressions that result in a response can be off
[00:35:33] <bmansurov>	 i see
[00:35:38] <leila>	 it's an estimate, and we are using some of the learnings from fundraising, but it can be that for some reason those learnings don't apply.
[00:35:43] <leila>	 which is weird, but it's possible.
[00:35:50] <bmansurov>	 ok
[00:36:23] <bmansurov>	 leila: but does the coverage percentage match the impression results?
[00:37:23] <leila>	 the problem is that for the past surveys, we did not register impressions, so we cannot answer this question, bmansurov.
[00:37:33] <bmansurov>	 ok
[00:37:36] <leila>	 This time hopefully we can answer this question.
[00:37:42] <bmansurov>	 great
[00:37:43] * leila checks to see if the table is being created.
[00:57:11] <Krenair>	 leila, fyi, rate is about to go up
[00:57:34] <leila>	 We are ready, Krenair.
[00:57:51] <Krenair>	 done
[00:58:50] <leila>	 perfect. thanks Krenair.
[01:01:37] <leila>	 I'm going to sign off from IRC for some hours, maybe even for the next of the evening. :D Thanks for all your help everyone. It's amazing to see other language responses. :-)
[01:02:01] <leila>	 ciao ciao
[01:08:54] <jdlrobson>	 greg-g: Is beta labs not updating for some reason? I'm not seeing code merged for Cards and RelatedArticles extensions on it
[01:10:23] <jdlrobson>	 dr0ptp4kt: you there? https://phabricator.wikimedia.org/T123932 is ready for sign off by you :)
[01:12:11] <dr0ptp4kt>	 jdlrobson: i'm here.  so those have been swat'd?
[01:12:40] <jdlrobson>	 yup
[01:12:45] <jdlrobson>	 language switching is logging on beta labs
[01:12:52] <jdlrobson>	 so you can investigate if it's logging what you expect
[01:13:17] <jdlrobson>	 i'm seeing events for clicking the button (actually 2 events because of the other schema wwhich we really really should kill...) and for search events, click events and close overlay event
[01:14:42] <Krenair>	 beta-scap-eqiad looks like it's in progress
[01:14:59] <Krenair>	 greg-g went home
[01:15:23] <jdlrobson>	 Krenair: okay. I trust it will resolve itself anyway and I can verify tomorrow :)
[01:15:33] <Krenair>	 hopefully it won't take *that* long :p
[01:15:46] <bd808>	 jdlrobson: this is always the first place to look when you wonder if code changes are going into beta cluster -- https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/
[01:15:52] <dr0ptp4kt>	 jdlrobson: i gotta run, but thanks for checking in beta. labs. i'll need to dredge up the instructions for checking el in beta labs. but i think your check is sufficient if you want to just check the checkbox in the description.
[01:16:16] <bd808>	 beta cluster. beta cluster. beta cluster. beta cluster.
[01:16:39] <jdlrobson>	 bd808: yeh it ust seems weird because it should have been there at 10am this morning..
[01:17:04] <jdlrobson>	 and scap has run previously today..
[01:17:09] <bd808>	 jdlrobson: hmm... yeah
[01:17:19] <bd808>	 did the merge go to the "wrong" branch?
[01:18:27] <jdlrobson>	 bd808: seems like Cards is borked
[01:18:33] <jdlrobson>	 https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FCards.git/194bf336199db5bf3065e6b137f40e838815c0c3 is showing as last updated
[01:18:51] <jdlrobson>	 https://git.wikimedia.org/log/mediawiki%2Fextensions%2FCards.git says 2 days ago..
[01:19:22] <jdlrobson>	 RelatedArticles seems up to date
[01:19:48] <jdlrobson>	 bd808: if i submit a meaningless version bump can you merge tosee if it changes things?
[01:20:59] <jdlrobson>	  https://gerrit.wikimedia.org/r/267202  < bd808 
[01:36:24] <bd808>	 jdlrobson: that version bump patch ended up at https://github.com/wikimedia/mediawiki-extensions-Cards/commits/master
[01:37:43] <bd808>	 jdlrobson: I'm not seeing anything merged this morning on https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/Cards,dashboards/default
[02:09:29] <jdlrobson>	 bd808: it's not showing up on beta labs..
[02:09:32] <jdlrobson>	 something is b0rked
[02:09:43] <jdlrobson>	 any idea what?
[02:09:47] <bd808>	 I wonder if it was the branch switch
[02:10:08] <bd808>	 I can look at the clone on deployment-bastion
[02:11:08] <jdlrobson>	 bd808: i created a tracking bug - i need to retire for the evening :)
[02:12:05] <bd808>	 jdlrobson: I think it is the submodule integration with https://gerrit.wikimedia.org/r/p/mediawiki/extensions.git that is messge up
[02:12:09] <bd808>	 *messed up
[03:19:25] <greg-g>	 01:16 <     bd808> beta cluster. beta cluster. beta cluster. beta cluster.
[03:19:28] <greg-g>	 :)
[03:19:45] <greg-g>	 (I said I wasn't going to check IRC tonight, I failed. adios!)
[09:13:40] <phuedx>	 ^ lol
[09:13:51] <phuedx>	 i think i've been surprisingly good about "beta cluster"
[09:14:09] <phuedx>	 it might have something to do with having text expander set to rewrite beta labs to beta cluster…
[10:10:31] <phuedx>	 joakino: could you review (and merge, hopefully) https://gerrit.wikimedia.org/r/#/c/266635/
[10:10:35] <phuedx>	 it's been signed off by nirzar
[10:10:43] <phuedx>	 but never actually got merged :/
[10:11:25] <joakino>	 will do, just font-weight and margin-top
[10:11:28] <joakino>	 easy peasy
[11:45:16] <phuedx>	 joakino: https://gerrit.wikimedia.org/r/#/c/266635/ won't merge without https://gerrit.wikimedia.org/r/#/c/266697/ being +2'd either
[11:45:31] <phuedx>	 (266697 is a cherry-pick to master)
[13:14:12] <codezee>	 FlorianSW: there?
[14:44:20] <joakino>	 phuedx: i thought that one had been merged
[15:49:38] <FlorianSW_>	 codezee: now, yes :]
[16:16:17] <FlorianSW_>	 jdlrobson: sorry, that I haven't looked at https://gerrit.wikimedia.org/r/#/c/261202/ before :( It seems I missed it in my gmail inbox :/
[16:48:36] <jdlrobson>	 hey FlorianSW_ hey codezee 
[16:49:38] <jdlrobson>	 FlorianSW_: thanks for the comments :-)
[16:50:00] <jdlrobson>	 FlorianSW_: i'm also wondering if we should just bite the bullet and switch to extension.json now
[16:50:07] <jdlrobson>	 so if you want to rebase your patch... :-)
[16:50:43] <codezee>	 jdlrobson: o/
[16:52:33] <FlorianSW_>	 jdlrobson: let me rebase it *yay* :D
[16:52:38] <jdlrobson>	 FlorianSW_: haha
[16:52:47] <jdlrobson>	 it's been around for a year now so i guess it's not going away ;-)
[16:53:00] <jdlrobson>	 and luckily the codebase is getting smaller 
[16:53:05] <FlorianSW_>	 jdlrobson: I currently work on https://gerrit.wikimedia.org/r/#/c/260578/7 and make two changes of it (one to restructure Popups without changing the functionality and one to add the mobile popups)
[16:53:23] <jdlrobson>	 FlorianSW_: awesome. Ping me when it's ready for some review. Am keen to see it in action! :)
[16:53:36] <FlorianSW_>	 jdlrobson: I think that MobileFrontend will need so much time to get away from being such a god extension :)
[16:53:54] <bgerstle>	 bd808: FYI you may want to join #wikimedia-ios if you want Phab notifications from IRC
[16:54:02] <FlorianSW_>	 jdlrobson: ok! :) It still would need a kill switch for the user (to turn it off) :)
[16:54:56] <FlorianSW_>	 bgerstle: have you really thought about that? We (MobileFrontend and Reading-Web) discussed this some time ago and went back to #wikimedia-dev with our notifications :)
[16:57:48] <bgerstle>	 FlorianSW_: we have, and we get the most value (atm) from having our phab notifications pop up the same place we spend most of our time communicating in real-time (our IRC channel)
[16:58:00] <bgerstle>	 including designers & PM
[16:58:19] <bgerstle>	 who most likely won't spend much time in -dev, nor would they be able to easily follow the phab stream as it would be lost amongst a lot of other stuff
[16:58:32] <bgerstle>	 (same reason why we don't put it here)
[16:58:59] <bgerstle>	 for things that span multiple teams, the tickets are naturally associated with multiple projects, causing their update to be multicasted to the relevant channels
[16:59:01] <FlorianSW_>	 bgerstle: ok, thanks for the explanation, I just wanted to make sure, that you'd had the chance to evaluate our results, too :)
[16:59:25] <bgerstle>	 yeah, i think the nature of the web team is quite different atm
[16:59:35] <bgerstle>	 given that your work is much more full-stack in nature than ours
[16:59:47] <bgerstle>	 (for now)
[17:00:06] <bgerstle>	 hopefully that will be less true over time as we start to rely more on the same pieces of infrastructure and have more of an equal distribution of influence
[17:00:28] <bgerstle>	 for now though, the iOS team is mainly focused on iOS-specific matters day-to-day
[17:00:41] <bgerstle>	 though I miss talking with you guys in here :-(
[17:07:07] <FlorianSW_>	 ok, let's hope that works :)
[17:07:33] <FlorianSW_>	 *yay* I love you gerrit :D (It worked)
[17:08:06] <FlorianSW_>	 jdlrobson: Finished splitting the change: https://gerrit.wikimedia.org/r/#/c/267280/1 and https://gerrit.wikimedia.org/r/#/c/260578/
[17:08:55] <dbrant>	 niedzielski: the install referrer is definitely working for me. Are you sure you've got the correct package name in your command line?
[17:19:03] <jdlrobson>	 FlorianSW_: i have never heard those words before ;-)
[17:19:14] <FlorianSW_>	 which one? o.O
[17:28:41] <etonkovidova>	 dbrant: niedzielski: there is a crash every time when I click 'Share' from Image Gallery - I was checking https://phabricator.wikimedia.org/T114658
[17:28:58] <niedzielski>	 etonkovidova: i just saw that :) i'll move it to todo
[17:29:15] <etonkovidova>	 niedzielski: thanks! 
[17:29:20] <dbrant>	 well shoot.
[17:29:24] <niedzielski>	 etonkovidova: thank you!
[17:30:59] <etonkovidova>	 2.1.138-r-2016-01-21  and 2.139-beta-2016-01-22  are fine :)
[17:37:41] <jdlrobson>	 FlorianSW_: love you gerrit hah:)
[17:38:53] <FlorianSW_>	 :P
[17:39:23] <FlorianSW_>	 It's great, that gerrit handles my dependency like I expected, so he earned my love today :P
[18:04:43] <FlorianSW_>	 jdlrobson: rebased https://gerrit.wikimedia.org/r/#/c/257438/ It would be great, if you could take a look asap, the rebase wasn't much fun :P
[18:05:58] <benestar>	 jdlrobson FlorianSW_: would be great if we finally tackle https://gerrit.wikimedia.org/r/#/c/251207/ :)
[18:12:21] <jdlrobson>	 FlorianSW_: dare i merge.. ;-)
[18:12:56] <jdlrobson>	 phuedx: around?
[18:13:07] <FlorianSW_>	 *yay* :]
[18:16:16] <mbinder>	 kaity: android standup?
[18:16:58] <phuedx>	 ish
[18:17:01] <phuedx>	 just packing the car
[18:17:07] <phuedx>	 then i'll be around for ~3 hours
[18:17:18] <jdlrobson>	 phuedx: quick question
[18:17:22] <phuedx>	 no
[18:17:25] <jdlrobson>	 any objections to moving to extension.json
[18:17:25] <phuedx>	 ;)
[18:17:35] <phuedx>	 none -- perf increase iirc
[18:17:36] <jdlrobson>	 i'm gonna +2 florian's patch (fully tested)
[18:17:41] <jdlrobson>	 yup that's what i was thinking
[18:17:43] <jdlrobson>	 ok boom
[18:17:48] <phuedx>	 just mobilefrontend is a complicated //app//
[18:18:10] <phuedx>	 if you and FlorianSW_ are happy, then i'm happy
[18:18:14] <phuedx>	 but don't break shit, obvs
[18:19:00] <FlorianSW_>	 jdlrobson: thanks :)
[18:19:02] <phuedx>	 right
[18:19:09] <phuedx>	 radio silence for 30 minutes
[18:19:11] <jdlrobson>	 like pulling off a nasty bandaid hah
[18:19:13] <jdlrobson>	 see ya phuedx 
[18:19:19] <jdlrobson>	 im heading to coffee shop anyway
[18:33:46] <FlorianSW_>	 jdlrobson: you need to resubmit the change :] https://gerrit.wikimedia.org/r/#/c/257438/
[19:01:34] <mbinder>	 kaity: android retro :)
[19:31:14] <mbinder>	 bgerstle: 5 min
[19:34:17] <lzia>	 Hi dr0ptp4kt. Can you check to see if the DNT is handled as no data collection in EL?
[19:34:30] <lzia>	 dr0ptp4kt: this question came up in our discussions with Chris and Michelle the other day.
[19:34:48] <phuedx|car>	 yo
[19:56:15] <phuedx|car>	 jdlrobson: https://phabricator.wikimedia.org/T125134#1982587 \o/
[19:56:35] <jdlrobson>	 phuedx|car: create news
[19:56:47] <jdlrobson>	 cenarium seems super helpful
[19:56:51] <jdlrobson>	 haven't come across him before
[19:57:08] <phuedx|car>	 enwiki admin i think
[19:57:23] <phuedx|car>	 has been doing work with cite around section previews
[19:57:25] <phuedx|car>	 iirc
[19:57:30] <jdlrobson>	 boom.
[19:57:43] <jdlrobson>	 so.. seems like that spike is done?
[19:57:54] <jdlrobson>	 phuedx|car should i push the API task to next sprint so we can support code review for it etc?
[19:58:00] <phuedx|car>	 plzplz
[19:58:14] <phuedx|car>	 make a note that it tracks the work in that spike thing
[19:58:22] <phuedx|car>	 and tell cenarium obvs
[20:00:00] <phuedx|car>	 FlorianSW_: that's a hell of a commit message!
[20:01:06] <d3r1ck>	 c
[20:06:09] <FlorianSW_>	 phuedx|car: which one? :D
[20:11:13] <phuedx|car>	 https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/1cfe99de0740b8cf1957dd0ab101c9f68f4b973b
[20:11:18] <phuedx|car>	 :D
[20:35:25] <dbrant>	 niedzielski: both intents are working on my API 23 device...
[20:35:52] <niedzielski>	 dbrant: yeesh
[20:36:13] <niedzielski>	 dbrant: neither are working pre or post patch on my 6p
[20:41:05] <niedzielski>	 dbrant: do i just have the command wrong? i'm using what i put in T125250
[20:42:18] <dbrant>	 niedzielski: command is right; i just tried it verbatim on my device, and in the emulator. Both are working
[21:14:00] <FlorianSW_>	 dbrant, niedzielski, bearND|afk  ping :)
[21:14:20] <niedzielski>	 FlorianSW_: \o
[21:14:38] <niedzielski>	 bernd is on paternal leave today. he should be around monday
[21:14:59] <FlorianSW_>	 niedzielski: can I persuade you to do some steps in the Wikipedia app? :P
[21:15:19] <niedzielski>	 FlorianSW_: sure, i've used it once before :)
[21:15:40] <FlorianSW_>	 Ok, please open the app (if it's not open already), switch to english and open the "Microsoft" page :)
[21:15:49] <FlorianSW_>	 Now, scroll down to the infobox and open it
[21:16:24] <FlorianSW_>	 finished? :)
[21:16:31] <niedzielski>	 yep :)
[21:16:53] <FlorianSW_>	 ok, now press the three dot menu at the top right and tap on "Font and color scheme"
[21:17:07] <FlorianSW_>	 Press the "+" sign as often as possible
[21:17:40] <FlorianSW_>	 finished?
[21:18:06] <niedzielski>	 ok
[21:18:11] <FlorianSW_>	 now press the circle
[21:18:22] <FlorianSW_>	 what happens?
[21:19:07] <niedzielski>	 FlorianSW_: i'll go through it again but the text just looks really big and uncomely
[21:19:28] <FlorianSW_>	 do you really scrolled down before doing it? :/
[21:20:09] <niedzielski>	 FlorianSW_: sure, i'll take a video
[21:20:35] <dbrant>	 FlorianSW_: will you tell us what you see?
[21:20:50] <FlorianSW_>	 sure dbrant :P The app (even the alpha, stable and beta) keeps crashing for me :(
[21:22:24] <niedzielski>	 FlorianSW_: hm, i'm on the alpha and it's definitely not crashing
[21:22:32] <niedzielski>	 FlorianSW_: what device are you running?
[21:22:36] <FlorianSW_>	 htc one m9
[21:22:56] <FlorianSW_>	 I already cleared data and cache, should I re-install?
[21:23:11] <dbrant>	 niedzielski: looks like this one: https://rink.hockeyapp.net/manage/apps/226650/app_versions/10/crash_reasons/108644952
[21:23:29] <FlorianSW_>	 singed in people only :(
[21:25:05] <niedzielski>	 (just a stacktrace)
[21:26:11] <niedzielski>	 dbrant: this looks like a platform bug to me
[21:26:18] <dbrant>	 yep..
[21:28:56] <FlorianSW_>	 arghhh, now it keeps crashing from time to time just when I follow links and save some pages! :(
[21:29:07] <niedzielski>	 dbrant: i think i saw something similar on api 23 when i was playing with TextView.setMovementMethod() (https://code.google.com/p/android/issues/detail?id=191430)
[21:31:29] <niedzielski>	 dbrant: i do see a few calls to setMovementMethod in the code. they don't look terribly related but it might be worth trying to comment out the one in BottomContentHandler at least
[21:31:31] <FlorianSW_>	 niedzielski, dbrant https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8952258
[21:31:43] <FlorianSW_>	 ^ crashes, too
[21:31:49] <FlorianSW_>	 from time to time
[21:34:20] <niedzielski>	 FlorianSW_: this looks like a different issue. for crashes, we almost always get the crash report in HockeyApp
[21:35:22] <niedzielski>	 FlorianSW_: i do see two crashes in the history fragment but they look like they only occur when pressing a button there
[21:36:22] <niedzielski>	 FlorianSW_: oh wait, here's one. there's a total of three occurrences
[21:36:35] <niedzielski>	 https://rink.hockeyapp.net/manage/apps/226649/app_versions/11/crash_reasons/105810734
[21:38:17] <FlorianSW_>	 niedzielski: can't open ;)
[21:38:34] <niedzielski>	 FlorianSW_: just a crash trace :)
[21:38:47] <FlorianSW_>	 which can be interesting, too ;)
[21:39:21] <FlorianSW_>	 niedzielski: do youu have some crashes when the infobox is expanded? (https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8942984)
[21:40:07] <niedzielski>	 FlorianSW_: https://phabricator.wikimedia.org/P2545
[21:43:32] <niedzielski>	 FlorianSW_: hm, i'm not sure this one is infobox specific. in general, we work to fix the top crashes for each release. it would be helpful to have the reporter's specific device but if it's a very rare crash we probably won't be able to work on it for a while :(
[21:44:04] <FlorianSW_>	 understandable :)
[22:30:19] <jdlrobson>	 bd808: are you around to debug the mysterious Cards issue?
[22:30:52] <jdlrobson>	 I'm still not seeing 0.4.0 on http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Version
[22:31:06] <jdlrobson>	 @legoktm not sure if you have any idea why Cards is not updating on the beta cluster ^
[22:34:38] <bd808>	 jdlrobson: legoktm is in Australia so probably not responding to pings on Saturday morning :)
[22:35:18] <bd808>	 jdlrobson: I suppose we need to find someone who knows how the automatic submodules bumps happen for mediawiki/extensions.git
[22:35:42] * bd808 wanders over to -releng where there might be such a person