[00:07:29] congrats on the next beta release! [00:08:00] was just looking at the mobileapps dashboard to see if you have turned up prod yet [00:08:52] answer looks like "not yet" [00:12:57] "not yet" is right :) [00:20:27] dbrant: any time soon, or will it be a while longer? [00:21:15] gwicke: most likely another week or so [00:21:37] kk [00:22:36] looking forward to those entry points getting more of a work-out [00:32:45] dbrandt: sharing animated pictures is still crashing in 2.1.140-alpha-2016-02-04 https://phabricator.wikimedia.org/T125270 [09:52:51] morning [09:52:55] hey joakino [09:53:00] was just about to ask if you were there [09:53:05] you feeling any better? [09:53:13] phuedx: yeah better today [09:53:26] it seems like my wifi problems are because el capitan http://www.igeeksblog.com/how-to-fix-wi-fi-issues-in-mac-os-x-el-capitan/ [09:53:40] i've connected another laptop via cable and it never loses connection [09:53:42] pf [09:54:45] no way!? [10:00:57] have you had any problems phuedx ? [10:02:35] i did when i first upgraded [10:02:51] did you do the MTU packet size and dns shenanigans? [10:02:52] but there was a patch fix that came out soon after that appeared to fix my problems [10:02:56] aha [10:03:04] (that's probably what the patch did!) [10:03:31] so annoying [10:03:56] I moved out the pref files and didn't have cuts for hours, but this morning it's done it again a few times [10:04:59] :/ [10:05:08] time for a new router? [10:06:13] its not the router, they changed it last week [10:06:36] turns out i sweared at vodafone but it is osx the problem [14:12:44] jdlrobson: Please we need to have a little chat [14:59:34] d3r1ck: jdlrobson is using irccloud (a hosted irc client and bouncer) [14:59:48] he's probably not awake just yet [14:59:52] but he's still in the channel [15:02:08] phuedx: hmmmm, ok [15:04:52] d3r1ck: sorry, to be clear, he'll get your ping! [15:05:04] he probably won't respond to it for another hour though :) [15:07:21] ok phuedx :) [15:47:16] sup [15:53:02] hey joakino [15:53:04] how's your dog? [16:34:30] phuedx: out of treatment, everything is alright [16:34:36] \o/ [16:34:45] :D [16:40:16] dbrant: I added some comments to T125270 [Crash] Sharing or saving image from gallery crashes app --- Saving is fine; Sharing is crashing [16:40:32] etonkovidova: acknowledged! thanks [16:42:15] dbrant: :) [17:03:27] dinner time! [17:03:47] jdlrobson: looks like we've lost some data on the grafana 2g dashboard thing [17:53:10] yo [18:20:04] baby [18:32:45] kaity: when you install Android Studio and clone our project you might want to check out some of the info at https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking#Download_and_install_Android_Studio. [19:49:39] jdlrobson bmansurov jhobs joakino phuedx do you guys know if the pseudorandom value of the localstorage value 'mobile-betaoptin-token' is sent to the server? [19:51:13] dr0ptp4kt: I don't think so (by looking at the code), but someone else who worked on it may have a better answer [19:51:46] dr0ptp4kt: ^ seconded [19:51:54] looking at the code, it's stored in localstorage [19:51:58] which isn't shared with the server [19:52:34] bmansurov, phuedx thx. do we know its purpose? is it mainly for the beta enrollment CTA? [19:52:50] dr0ptp4kt: yes [19:56:03] phuedx: ok, makes sense. [20:57:32] bmansurov: question, if you have couple mins [20:58:36] or jdlrobson if he's there , holaaa [21:11:04] dr0ptp4kt: dbrant: niedzielski: bearND: so it looks like the x-cs thing won't be resolved 'til monday at the earliest. should we go ahead with the rollback to requesting from mdot then? [21:11:16] er, , then? [21:11:23] (as in today) [21:12:06] dbrant: are we in a hurry to promote beta to prod? i would prefer not to revert the m. changes unless necessary [21:12:07] mdholloway: i would probably say yes. caching stuff can take a little while [21:12:36] nuria_: sure [21:12:57] niedzielski: i suspect not a ton of beta users are zero-rated, but we should do right by them lest they get worried [21:13:16] niedzielski: but we can wait until monday to make the decision, too. that work for you, dbrant mdholloway bearND ? [21:13:33] i.e., there's no point dropping everything and re-issuing a build unless we really have to [21:13:34] bmansurov: the sampling change that neil recently did ... how is it sampling? I think I am missing something or I have been for too long submerged on teh cluster and i do not know how to read js anymore [21:13:55] who was in the pageimages meeting yesterday, and are there notes ? /me was not able to attend at that time. [21:13:56] dr0ptp4kt: niedzielski: mdholloway: agreed for waiting til monday [21:13:58] yeah, my main concern was for any zero-rated beta users out there but i'm ok either way [21:14:07] dr0ptp4kt: that's fine with me. it's not a big change on the client side just a strange concern to remember [21:14:22] nuria_: let me check [21:14:43] nuria_: url to the patch? i can't find it [21:15:00] bmansurov: https://gerrit.wikimedia.org/r/#/c/268568/2/resources/mobile.loggingSchemas/SchemaEdit.js [21:15:04] thanks [21:15:30] dbrant: mdholloway niedzielski bearND it is agreed then, let's make the game day call on monday [21:15:42] dr0ptp4kt: 👍 [21:15:42] ok [21:15:54] nuria_: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.startup/Schema.js#L129 [21:16:39] bmansurov: right but isUserInbucket does this: [21:16:53] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.user/user.js#L73 [21:17:08] game day = this sunday, lol; 👍 [21:17:32] nuria_: i think that's a different module [21:17:36] nuria_: see this https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.startup/Schema.js#L87 [21:19:06] bmansurov: I see. The function is duplicated, the schema implementation is not correct though, will not give you random results [21:19:10] cc jdlrobson [21:19:29] bmansurov: that is why i was saying to use the EL one [21:19:47] bmansurov: because math.random liiieeeeeesss [21:19:51] and it is not random [21:19:53] nuria_: duplicated? [21:20:02] nuria_: yes, we will use Schema soon [21:20:18] ya, isUserInbucket exists also in user module but that is my mistake , nevermind that one [21:20:39] nuria_: that one has a different name [21:21:01] bmansurov: yes -> me read too fast [21:21:19] but you're right and we're aware of the problem [21:21:22] bmansurov: but what i am saying is that the one in Schema.js will not work [21:21:36] bmansurov: for random sampling [21:21:48] because Math.random is not random enough, right? [21:21:50] bmansurov: but as long as yuo know that ... [21:22:01] *you [21:23:31] bmansurov: yes [21:23:40] bmansurov: has quite a few bugs [21:23:54] bmansurov: that will skew your data [21:24:06] ok [21:24:09] bmansurov: now, for "older" browsers you are stuck with it [21:24:39] bmansurov: but the majority of our users use chrome so if you use EL sampling data will be correct for most users [21:24:58] i see