[00:01:09] nzr: yt? [00:01:18] bmansurov: yep [00:01:31] nzr: .language-overlay .site-link-list a div span:first-child { [00:01:44] do you want to make both the language code and the article title bold? [00:01:48] just double checking [00:02:03] bmansurov: no, i think that's the name of the language [00:02:10] not the code or article name [00:02:25] the black text above the name of the article. which says "English" [00:02:28] nzr: yeah ok, but that selector selects the language code too [00:02:32] thanks [00:03:01] bmansurov: oh my bad. [00:03:18] nzr: np, what about .language-overlay .site-link-list a div span { ? [00:03:26] what are you trying to style with that? [00:03:40] what styles have i written for it? [00:03:52] letter-spacing:1px; [00:03:52] padding:0.5em; [00:03:52] min-width:3.2em; [00:03:52] i dont know the names, i copied them from inspecto [00:03:54] margin-right:0.75em; [00:03:56] } [00:04:02] yeah that is the language code tag. [00:04:07] ok cool [00:04:09] on the left, that says EN [00:04:13] no more questions for now [00:04:22] ? [00:04:37] oh no more. [00:04:40] i read One more [00:04:41] :P [00:05:26] nzr: one more actually [00:05:44] nzr: so 3.2em is too short for some langauge codes where the fonts are wide, WW for example [00:05:57] that would make that language code box wider even though it's only 2 chars [00:06:07] should I keep the current 3.5em for this reason? [00:06:31] it's min-width, with wide codes, it will grow? plus i reduced the left and right padding, it should fit. [00:07:02] ok [00:07:11] yep [00:07:13] it will grow [00:07:22] because some langs have more than 2 chars [00:07:29] especially with variants [00:08:26] yes. SIMPLE english has SIMPLE [00:08:37] not so simple haha [00:09:53] zh-min-nan. [00:11:23] be-x-old [00:26:37] nzr: quick hangout? [00:26:53] bmansurov: have a meeting in 2 mins. after that? or is it too late? [00:27:05] how long is the meeting? [00:27:42] nzr: ^ [01:26:09] nzr: still there? [01:26:38] bmansurov: 2 mins [01:26:49] ok [01:30:17] bmansurov: hey, tracy island? [01:30:26] ok [08:47:08] morning [09:03:58] yo [09:21:19] hi phuedx [09:34:03] hey joakino [09:34:05] how're you? [09:35:31] fine, and you? [09:36:05] i'm listening to this now https://www.youtube.com/watch?v=xCQGT3D8uEA&spfreload=1 [09:36:13] post apocalyptic rock or something like that [09:36:15] i have no idea [09:36:55] prog/post metal :D [09:37:09] btw phuedx, i saw https://www.youtube.com/watch?v=S2FUSr3WlPk while having breakfast, excellent talk [09:37:23] bookmarked [09:37:23] ta [11:14:07] Hi, just wanted to let you guys know that on the android app numbered equations are not displayed. e.g. the first one in https://en.wikipedia.org/wiki/Bethe_formula [11:14:57] Will get around to post a proper bug report later [11:19:01] thanks someone_, the android folks are in US timezones, they'll have a look later [11:19:51] pinging niedzielski-afk ^ [11:19:57] maybe he'll see it later [11:20:23] Thanks! Keep up the good work! [12:52:27] hey bmansurov [12:52:34] nice work on the language switcher change [12:52:37] phuedx: morning [12:52:45] thanks, i'm replying to your comments [12:54:17] cool [12:54:22] i'm heading out for lunch [12:54:31] enjoy your lunch [12:55:11] curried lentil and carrot soup [12:55:13] nom [12:57:33] yummy [13:29:12] someone_ joakino: thanks! [14:44:00] back from lunch climbs [16:12:23] yo [16:26:15] yo joakino [16:26:19] yoakino? [16:27:23] sup phuedx [16:27:43] is the lazy images thing in review or are you still on it? [16:31:45] i'm about to put it there [16:31:57] i really don't know about the timeout magic number... [16:33:57] phuedx: i've been thinking about the *do not apply on first section* stuff. wouldn't it be interesting to apply it everywhere and measure the radical version vs the leave-first-section-alone version? [16:34:10] yes [16:34:13] yes it would [16:35:13] so should I add only first section as a config var? a follow up patch that we will merge-deploy after we measure the current one? [16:35:29] the problem with a config var is that it may stay there forever without making much sense [16:36:58] joakino: part of sign off will be creating tasks to turn stuff off [16:37:24] phuedx: so how do i proceed regarding first section stuff [16:37:35] (it's not done ATM) [16:45:51] joakino: per-section post-rewrite in mobileformatter [16:45:52] OR [16:45:57] nope [16:45:59] no or [17:04:43] hangouts is full :( [18:02:05] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Edit_acts_like_it_won.27t_save [18:02:20] report about regression for some one with mobile editing. [19:03:09] joakino: i'm certain you were one of the people still in that stack room just now [19:03:28] totally am [19:03:32] is that you jhobs ? [19:03:52] joakino: I've left now. I was "Boom headshot" and spammed the button to clear the queue [19:03:54] it works awesome [19:03:57] i'm proud [19:04:01] yeah it's great [19:04:11] but for the love of god [19:04:15] rename it to queue [19:04:18] it hurts my soul [19:04:25] to call it a stack [19:04:25] NEVER [19:04:27] tpg forever [19:04:30] worth a try [19:04:47] tpg calls it a stack, so that is what it's called haha [19:05:21] http://cultivate.coop/wiki/Taking_Stack_(Meeting_Facilitation_Technique) [19:05:24] jhobs: ^ [19:05:44] damn heathens [19:08:37] hah [19:09:48] jdlrobson: please which function do you use to fix text on mobile view in the senter? [19:09:53] *center [19:10:34] jdlrobson: for example http://localhost/OpenSource/MediaWiki/index.php?title=Special:MediaStatistics&mobileaction=toggle_view_mobile [19:11:00] the intro text telling the user what the special page does [19:11:13] phuedx, jhobs and joakino, any help on that? [19:11:58] d3r1ck: you can add that text within a class, and style it in the style module of the page :) [19:13:26] d3r1ck: for info, see Special:Uploads, on how it shows invalid user message [19:16:40] codezee: not clear though [19:19:01] d3r1ck: simply, add your message in a div with a class using $out->addHtml( ... ) and then in the style module of the special page, add a center property on the div with that class [19:19:33] d3r1ck: SpecialMobileWatchlist has several instances of addHtml( ... ), have a look :) [19:19:40] ok [19:20:12] I see that but mine is different [19:20:30] it gets the text from the en.json file and there is already a div that centers it [19:20:38] now i just need to check it its mobile then i will tyle it [19:20:44] *style it to center [19:25:01] codezee: In special pages, there is something like this: [19:25:02] if ( !$this->msg( $msg )->isDisabled() && !$this->including() ) { [19:25:02] $this->getOutput()->wrapWikiMsg( [19:25:02] "

\n$1\n

", $msg ); [19:25:03] } [19:25:23] which already has the dive and i can't center it since it will affect the desktop version [19:26:11] Ohhh, wait let me try something [19:32:23] codezee: thanks for helping d3r1ck [19:32:56] jdlrobson: np :) [19:33:25] d3r1ck: is this a bug you are working on? [19:33:48] but yeh codezee is right - you just need to find what is generating the HTML and update the markup [19:35:20] d3r1ck: you can probably link it here, or add me, I can review the changes on gerrit, before its ready to merge... [19:47:38] dr0ptp4kt: yt? [20:01:06] jdlrobson: nope, i was fixing a bug in SpecialPage:Nearby [20:01:21] and on the mobile view, it does centralize the way i expected [20:01:33] so i want to fix that. [20:01:39] codezee: let me add you as revier [20:01:44] *reviewer [20:02:08] codezee: Whats your email or handle? [20:05:58] jdlrobson: I added you already [20:12:46] d3r1ck: Sumit [20:15:27] codezee: I have added you as reviewer, you can now chec it out and see for yourself :) [20:26:21] codezee, jdlrobson, which class centralizes text in mobile frontend? [21:08:47] codezee: How do you see the patcch now? [21:16:33] codezee: So you mean we should leave it centered? [21:16:49] It will apply in both Desktop and Mobile View [21:20:44] d3r1ck: use text-align, but again set "text-align:left" in specialNearbyDesktop.less", ignore my comment regarding removing that rule, just modify it [21:21:58] d3r1ck: also, by convention there's a space after ":" in css rules [21:22:43] Yeah, thanks [21:23:07] codezee: submitting a patch. It looks better now. [21:23:52] codezee: but the mobile view isn't really appealing to me because i wanted the beginning of the text to ba aligned with the mw-wf-nearby div [21:27:32] d3r1ck: by default small messages should be centered on mobile, but if that needs to change, another task can address that :) [21:30:21] codezee: just discoverd a bug on that same page. [21:30:30] load this link on your browser: https://en.m.wikipedia.org/wiki/Special:Nearby [21:32:16] and? [21:33:19] then click on the refresh button at the top right [21:33:30] which is like a maker on a map and see what happen? [21:35:55] d3r1ck: can you raise a bug that looks like a regression! [21:38:04] jdlrobson: sorry, i don't understand please [21:38:53] d3r1ck: simply raise a bug for that in phabricator [21:39:02] codezee: i have done that already [21:39:15] regression is some issue introduced by a side-effect of some other change [21:39:21] https://phabricator.wikimedia.org/T126380 [21:40:14] codezee: Thanks for the definition, i was Googling the meaning of that. [21:40:31] jdlrobson: I filed the bug :) [21:41:09] d3r1ck: i'm just looking at your patch. I think it's fine but unfortunately I think the task needs some more input before rushing to a solution so I've added a comment there. [21:41:23] i'd suggest you pick another task until that conversation gets a solution :) [21:42:26] jdlrobson: thanks :) [21:43:27] you could look into the bug you just filed :) [21:44:47] jdlrobson: Hmmm, will do that. Need to eat something :) [21:44:57] d3r1ck: yeh eating more important :) [21:45:32] jdlrobson: not really but its a necesity so that i can have the energy to code more :) [21:55:03] jdlrobson: I grepped for any existing use case of only centering, and it looks like there isn't any special generic class does "only that" [21:55:33] codezee: anything that does anything similar? Best thing to do is to find an existing pattern where there is a summary before a list [21:55:38] something may need refactoring [21:56:36] i think we used to have a class named "center" [21:56:44] but that might have been en.wp only, or skin specific [21:57:47] div.center { [21:57:47] text-align: center [21:57:48] } [21:58:19] i think that's for centered images or something [22:01:19] closest I could get was to skins.minerva.special.styles/common.less which has a FIXME to apply on all special pages, thats being used by Special:MobileDiff to center h2 [22:03:56] thedj: i used that class but it did not apply :) [22:04:14] it doesn't work for cases like this [22:07:32] also I'm not particular in favor of reusing a class for something like that. [22:08:21] it's either text-align, or margin-righ/left: auto which you need [22:08:43] and there is no real need to reuse something as simply as that. [22:09:07] not sure what you are working on exactly however [22:10:09] jdlrobson: i found something, in the file resources/skins.menerva.scripts/initLogging.js [22:10:18] It could be linked to the bug i filed [22:10:45] it seems that regresh button works only for the minerva skin [22:12:19] hmm, btw. the refresh button is also not behaving as a button. The cursor doesn't change, as it normally would. [22:13:09] which probably is because it's an icon only button of which the textual link has been hidden. [22:13:54] which might or might not be a ooui library issue [22:13:56] thedj: you can also comment on the phab bug :) [22:18:44] i created a new ticket for this: https://phabricator.wikimedia.org/T126387 [22:27:05] d3r1ck: this looks suspicious to me: [22:27:14] // FIXME: initialize is for initialization only, maybe create a "refresh" method or // something similar [22:27:46] translated "likely to break when you refresh" [22:28:55] thedj: it looks suspicious to me too. [22:29:13] First of all it says that it works only for the Minerva skin [22:45:51] time to sleep. just got a webkit dev to fix one of my almost 3 year open tickets, so today was a good day [22:46:09] hahahaha...., Good night thedj [23:39:51] niedzielski: have you seen the new youtube music app? [23:40:14] kaity_: no, i hadn't. will check :) [23:40:18] niedzielski: first app i've seen with hamburger menu and tab bar, its weird! [23:41:41] kaity_: yeesh! hm, doesn't look that great to me. another example is the google+ app (the tab bar is on the bottom though) [23:42:17] kaity_: hm, actually the plus app has a hamburger menu, top tab bar, and bottom tab bar on some screens [23:42:44] niedzielski: ohh yea weird. so much UI [23:43:10] theyre breaking their own rules? [23:54:37] yeah, i think they're experimenting as much as anyone