[16:31:19] I remember, that gerrit user Sumit is online here, too, but I don't remember the irc nick? :/ [16:32:39] aha, codezee, thanks phabricator :D [16:32:57] I will let you know when I see codezee around here [16:32:57] @notify codezee [16:33:41] @seen codezee [16:45:43] Hey codezee :) [16:46:19] FlorianSW: o/ help help help :D [16:46:40] getLicense returns link html in its 'link' key [16:46:51] :P Do you have 5-10 minutes? I would like to finish what I currently do and ping you then, ok? :) [16:46:58] sure... [16:53:25] ok codezee, now I'm here :) [16:53:35] thanks for waiting! [16:54:17] codezee: as far as I can see, getLicense returns a message key: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.skin.hooks.php#L99 or do I misunderstand you? :( [16:59:05] FlorianSW: getLicense returns license html in 'link' key, what is creating problem is inserting the link in the license, because license html gets escaped [17:00:08] the original implementation in EditPage.php use [[wgRightsText]] as link and later parses it as a wikitext [17:02:37] which is why I used an implementation similar to that in EditPage.php [17:04:53] codezee: ah, now I understand the problem, thanks for clarification :) [17:06:34] codezee: I think the best approach would be to add a new parameter to the function to control, if the link should be html or wikitext and build it according to that :) [17:07:29] FlorianSW: you mean in getLicense(), I guess ? [17:07:43] codezee: yep :) [17:07:47] which is where I think we need to modify [17:07:51] I'll write a patch [17:07:53] then [17:08:17] thanks :) [17:09:21] codezee: you can do it in the same change to add the context why you do that :) [17:09:55] okay, same will be good... [17:10:32] thanks codezee :) [17:12:39] FlorianSW: random question, I've seen you work on a lot of patches in core, how do you find relevant tasks there? I look at "Mediawiki-general-or-unkown" board and its a long list of tasks :/ [17:13:04] so I remain more/less in MobileFrontend :P which I enjoy contributing to [17:14:20] codezee: :D That's an interesting question :) Mostly I found the topics while working with MediaWiki (keep the eyes open). Watching the stream in #wikimedia-dev is another good idea, but there're is a lot of stuff, which you can't read. Another things is to check if your focus topic has it's own project, e.g. Special pages has it's own project (that's probably one of my "focus" topic). [17:15:19] ohh... [17:17:06] sorry, that I can't give you a best practice :/ But I know what you mean, it's difficult to get an overview about open tasks in MediaWiki, but MediaWiki core is a really really big area, where you can't get a view of all tasks easily :] [17:19:49] I know, and it isn't even possible to know the entire stuff, just looking for a way in, in core ;) [17:48:30] http://nirzar.github.io/prototypes/mobile-web/index.html [17:48:41] http://nirzar.github.io/prototypes/mobile-web/sticky/index.html [18:36:21] dr0ptp4kt: hey, do you want me to identify the related pages result set for the sampled articles in https://phabricator.wikimedia.org/T125977 ? [18:55:11] dr0ptp4kt: did you see Ori's comment in: https://phabricator.wikimedia.org/T127101 I'll need your help answering it. [19:32:50] nzr: like that sticky bar view ! [19:33:42] thedj: hey yeah, we are putting up a mw page with voting for sticky footer and other two options i have for language switching. would love to get comments or votes over there :) [19:33:51] we will put up a link here [19:33:56] later today [19:33:58] :) [19:34:06] thumbs up [19:37:21] * thedj actually thinks the top bar should also pop to top if you move up again in the document (like safari address bar). [19:38:04] but lets do one thing at a time :) [20:32:33] FlorianSW: https://phabricator.wikimedia.org/dashboard/view/125/ that's what i use for finding work [20:32:40] but obviously reading specific :) [20:32:52] (in answer to codezee earlier) [20:33:42] jdlrobson: ah, interesting :) I tried to build my own dashboard in the beginning, too, but haven't used it so much :) This could be done for mw core components, too :) [21:46:13] legoktm: To be honest: I haven't followed https://phabricator.wikimedia.org/T124356 really, but isn't https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/wmf/1.27.0-wmf.14/includes/MobileFrontend.hooks.php#L1222 what you're looking for? :/ [21:47:47] FlorianSW: it shouldn't be, because that runs *after* ParserCache save [21:49:20] legoktm: hmm, it seems you're right, sorry for interrupting your research :] [21:50:01] no worries, more eyes are always better :) [21:52:34] :) Maybe I would be more helpful, if I would understand the parser caching mechanism a lot more, but unfortunately, I dont't :) [22:26:18] dr0ptp4kt: be in the meeting momentarily [22:28:19] dr0ptp4kt: j/k 10 min early [23:00:58] mbinder: r there only 2 items for qa now? [23:02:41] hello nicholas-tsg! Welcome. :) I assume you're talking about Android, specifically sprint 76? [23:03:01] mbinder: correct [23:03:35] o/ nicholas-tsg [23:03:57] mbinder: should I work on this sprint 76 or on another sprint? [23:03:57] nicholas-tsg: I believe just those 2, for now, yes. dbrant can update the board if there is more. [23:09:49] mbinder: both of the current QA items relate to Wikipedia Zero and there's not enough information for me to test them. [23:11:55] nicholas-tsg: OK. I think best approach might be to comment as much in both tickets, and @mention the currently-assigned engineer. It might be that they are something the devs have to QA themselves, or it might be that they are merely missing key testing information. In the early going of this partnership, we may have some bumps to iron out, but I encourage [23:11:55] you to just call it like you see it and we'll keep the communication going to provide clarity. [23:16:02] mbinder: sorry to keep talking, how do I do @mention in the Comment window? [23:17:21] nicholas-tsg: no worries, please reach out when you need to. If you type "@" into the comments field, and then type the user name of the person you are trying to poke, it should should an autocomplete option, and then you can choose. You'll need a Phabricator account to do it. [23:23:58] mbinder: thank you, I made the comments. I will check again tomorrow.