[14:40:38] <jhobs>	 bmansurov: even if we don't fold the check into the if statement above, I think it's still much easier to read if we remove the comments (after the reference) and put it into a var
[14:40:57] <jhobs>	 bmansurov: right now it's just a mess to look at
[14:41:27] <bmansurov>	 hmm, how is it a mess?
[14:41:27] <jhobs>	 I'm probably wrong on the require thing tho; I was thinking back to king's loot code for some reason
[14:41:51] <bmansurov>	 it's just some conditional testing with comments
[14:41:54] <bmansurov>	 i don't think it's a mess
[14:42:18] <jhobs>	 bmansurov: there's over 10 lines between the opening and closing parens of the if statement. That alone should be telling
[14:42:59] <jhobs>	 at the very least we can remove the comments though. We're already referencing the source so no reason to duplicate the reasoning for each check
[14:43:33] <jhobs>	 and probably move the reference comment out of the if statement
[14:43:48] <jhobs>	 personally I just think having comments inside if statements is very messy
[14:44:01] <bmansurov>	 jhobs: please feel free to upload a follow up to your liking. Having comments are not bad at all. You just need to configure your IDE to not highlight comments.
[14:44:06] <jhobs>	 inside conditionals*
[14:45:00] <jhobs>	 bmansurov: I'm reading the code on gerrit, not in an IDE tho. Also I think "customize your IDE" is a bad excuse for messy code in general ;)
[14:45:16] <jhobs>	 I'll write a follow-up patch though
[14:45:49] <bmansurov>	 calling comments messy is where we disagree I guess
[14:46:52] <jhobs>	 only in this specific instance I think they are
[14:48:14] <jhobs>	 plus, look at the if statement above it. Two variables used for readability even though they're only used for that if statment
[19:06:51] <bd808>	 bmansurov: will you be around for evening swat today? jdlrobson would like this cherry-pick to go out -- https://gerrit.wikimedia.org/r/#/c/273296/ -- and I don't know how to test
[19:07:15] <bmansurov>	 bd808: yes, I already scheduled the patch
[19:08:46] <bd808>	 cool. I prepped the cherry-pick. I'll update your link
[19:15:51] <bmansurov>	 thanks!
[20:48:10] <dbrant>	 niedzielski: those are some pretty great (and relevant!) features in the new support lib!
[21:02:16] <Krenair>	 FlorianSW, any idea what we can do about styling on https://gerrit.wikimedia.org/r/#/c/271994 ?
[21:07:23] <FlorianSW>	 Krenair: have you tried em's? Maybe this works better as percentage? (I'm not sure that it will :()
[21:12:29] <niedzielski>	 dbrant: sorry, must have just missed your message! yeah, i totally agree! i feel like this has been one of the best updates i've seen
[21:15:12] <tgr>	 jdlrobson: are you in the office today?
[21:15:39] <FlorianSW>	 Krenair: what about 10em? That looks good on a mobile and tablet device (at least in chrome developer tools on desktop)? :)
[21:26:33] <Krenair>	 FlorianSW, I was thinking more like 11-12em
[21:27:05] <FlorianSW>	 Krenair: I've no strong preference, as long as the image is visible on mobile and tablets, and 10em was a "working" value for me, so 11 or 12 is good, too :)
[21:28:04] <Krenair>	 let's see if I can hack my phone into connecting to my laptop again...
[21:28:35] <Krenair>	 think I had to shell in and remount /system as rw to edit the hosts file
[21:36:50] <Krenair>	 FlorianSW, yeah looks good, thanks
[21:37:26] <FlorianSW>	 Krenair: np, happy to take a look and merge :)
[21:37:43] <Krenair>	 you're going to merge the ve change?
[21:38:33] <FlorianSW>	 no, the MF, VE only +1 if it looks good :)
[21:45:42] <FlorianSW>	 Krenair: one comment to the desktop welcome dialog now :)
[21:46:29] <Krenair>	 well bare in mind that the MF one depends on the VE change
[21:46:49] <Krenair>	 and will likely get merged by the same person at the same time
[21:48:46] <FlorianSW>	 Krenair: yep, I forgot it and haven't +2'ed it :P
[21:57:18] <Krenair>	 FlorianSW, bah
[21:57:24] <Krenair>	 FlorianSW, 17em looks more reasonable on desktop
[21:57:29] <Krenair>	 FlorianSW, so this didn't fix anything
[21:58:50] <Krenair>	 oh right, I think I know why
[22:00:45] <Krenair>	 every time I try to do anything with MF I run into the Main Page issue
[22:11:09] <nicholas-tsg>	 coreyfloyd: on T127284 are "Most Read" the same as "Top read"?
[22:11:09] <stashbot>	 T127284: Most Read articles appears in feed in non reverse chronological order - https://phabricator.wikimedia.org/T127284
[22:20:07] <coreyfloyd>	 nicholas-tsg: yeah
[22:20:56] <coreyfloyd>	 nicholas-tsg: you can join us in the ios specific channel: #wikimedia-ios
[23:09:29] <tgr>	 jdlrobson: JonKatz: joakino: any update on https://phabricator.wikimedia.org/T127784
[23:09:39] <tgr>	 is there a public export method already?
[23:28:37] <svetlana>	 where are categories on the mobile interface ? they are so convenient for discovering new articles on similar topic
[23:44:29] <bmansurov_break>	 svetlana: at the bottom of the page
[23:44:51] <bmansurov_break>	 svetlana: although you need to opt in for beta
[23:44:55] <svetlana>	 nope, nothing
[23:44:57] <svetlana>	 ok