[00:11:43] 30 days has september, april june and november. All the rest have 31, except february alone blah blah blah [06:04:55] thanks mdholloway|afk [09:47:57] jdlrobson: joakino: phuedx: ori there seems to be an issue with mobile talk page again, posted messages go to [[Undefined]] [09:48:33] (on #mediawiki) [09:48:37] i asked the user to file a report [09:48:43] but i can't stick around to tell you which task number [09:49:01] but please prioritize it, i committed to the user we'd fix it quickly. [09:56:07] sure ori, thanks. we triage every day from here https://phabricator.wikimedia.org/dashboard/view/125/ [09:56:47] sounds like an ugly regression, we tackle those as fast as we can [10:01:14] thanks! [18:02:01] JonKatz, dr0ptp4kt standerp? [18:02:18] joakino: i'll be right there [18:02:47] joakino can't make it today :(, but my plan is to start again this month. it is not cool to never see you guys. [18:02:58] JonKatz: sure! no problemos [18:13:43] FlorianSW: around to talk about https://gerrit.wikimedia.org/r/#/c/273579/ [18:34:43] 300 phab notifos [18:34:46] WOO [18:36:04] jdlrobson: hi :) I'm here now : [18:36:20] i want to swat the fix tonight [18:36:28] but i think we can clean this up some more [18:36:36] is there any reason for us to be using data-title any more? [18:36:40] why not just use wgPageName ?\ [18:39:16] öhm... hmm, I'm currently not sure _why_ we used data-title? :( [18:39:30] I think it was because previously the link was on Special:Userprofile [18:39:40] so it wasn't easy to determine talk link [18:40:07] otherwise the simplest thing to do I think is just .attr( as krinkle suggests [18:41:48] Not sure what the fallback is for... [18:41:53] or if it works [18:41:55] let me try to find out, why we used data-title, and if I can't find it or it doesn't apply anymore, I don't think that anything prevent us from using wgPageName [18:42:03] I guess just for the talk page itself [18:42:17] i'll add your patch to SWAT but i'd like to SWAT a follow up to if that's okay [18:42:37] jdlrobson: sure! :) [18:43:43] jdlrobson: aha: https://phabricator.wikimedia.org/T75476 & https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/2263f2b5a08b107965766bee5c7124a85e9cbdf3 [18:43:57] I think you're right, I only added it for user pages (on special:userprofile) [18:44:42] on calendar :) https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=343349&oldid=342891 [18:45:39] thx :( [18:45:40] :) [18:45:51] FlorianSW: oh wait.. [18:45:55] wont that roll out anyway today? [18:45:55] (":(" wasn't intentional) [18:46:16] mediawiki.org is 1.27.0-wmf.15 [18:46:45] so i just need to swat the new patch [18:46:46] oh, yes [18:46:50] https://www.mediawiki.org/wiki/MediaWiki_1.27/wmf.15/Changelog [18:47:11] heh [18:47:20] okay, cool well i'll swat any follow ups we come up with today [18:47:27] i'm gonna look at your MobileFormatter patch now [18:48:23] jdlrobson: I'm on it already (talk change); thanks for the MobileFormatter change :) I know that it's probably not the easiest and "most secure" change to change the MobileFormatter code, but it would be very helpful I think :) [18:52:06] FlorianSW: gulp [18:57:01] jdlrobson: do you know an easy way to get the title of the talk page for a page using JS? :/ [18:57:22] FlorianSW: i was pondering that. I think you have to add 1 to the namespace number if it's odd [18:57:25] lemme see [18:57:52] jdlrobson: that works for talk pages for the article namespace but not for user pages (or module/file and so on) [18:57:53] :( [18:58:03] bahhhh dammit [18:58:45] FlorianSW: i guess that's why we use data attribute [18:58:47] hi bd808. fyi, I'm going through your analysis of tool labs survey data. [18:58:58] bd808: sorry for the longish delay. I should get my response to you today. [18:59:17] jdlrobson: I think so, too. We could hardcode these things, but it won't work for new namespaces, custom namespaces or namespaces added by extensions :( [18:59:40] let's just use data-attr then [18:59:49] attr( 'data- rather [19:01:22] lzia: awesome. I was going to ping you about that to see where I was in line. :) [19:01:45] * lzia blushes, bd808. [19:02:14] things get busy. no guilt from my side [19:02:56] I'm happy that you stepped up to help us achieve the closing of this task before Wikimania. Maarten will be much happier, bd808. :) [19:04:05] jdlrobson: do you think that changing from class talk to id something still makes sense? I think your concerns still apply :) [19:04:30] probably.. but a little concerned about cache implications [19:04:48] and not sure if this code runs in any other places [19:05:04] or whether there is ever any multiple talk links [19:05:21] I think it's actually a cool feature, if an editor wants to add a talk page link somewhere specific [19:05:25] jdlrobson: hehe :P Talk is only enebaled for logged in users, so don't worry about cache :D [19:05:35] oh true [19:06:03] I think we should enhance all .talk links [19:06:17] but use the data-title attribute on the main talk element with the id [19:06:19] what do you think? [19:07:36] jdlrobson: would be possible, but how do you get the target title for the other links? [19:08:09] I'm currently trying to find a sane way to check, if the given title makes sense (e.g. check, if the current title is the same as the given talk title, stripped out the namespace) [19:08:29] that would give us a bit more security, but doesn't cover all possible attack cases [19:09:50] I'm wondering, if it's a rule, that the talk namespace id is the namespace id of the article namespace +1 (main NS: 0, talk NS: 1, user NS: 2, user talk NS: 3)? [19:10:37] ah, it seems so: https://www.mediawiki.org/wiki/Manual:Using_custom_namespaces#Creating_a_custom_namespace [19:19:52] FlorianSW: Currently, but that rule will go eventually. [19:20:02] grr, damn [19:20:08] FlorianSW: And you can't rely on it entirely. [19:21:25] For WMF production you can right now (NS even == content, NS odd == talk, NS odd == NS-1's talk page) but not every namespace has a talk page, and of course you have NS-1 and so on. [19:21:31] James_F: but for most pages (built-in namespaces) this works, right? This is the main audience of the talk overlay feature, and if the talk overlay can't be loaded because of this, the link still works, it simply redirects to the talk page itself [19:23:52] FlorianSW: Yeah; in future there'll be a magical API where you can say Title::getAssociatedPage( 'talk' ), but for now… [19:24:24] James_F: in JS, too? Do you have a task for it I can link to? :) [19:25:58] FlorianSW: T487. But it's stalled right now. [19:25:58] T487: RfC: Associated namespaces - https://phabricator.wikimedia.org/T487 [19:27:12] James_F: ah, ok, doesn't really matter, I just want to link to something where the plan is documented so if someone looks at the code later knows, where we are :) [19:27:13] thanks [19:28:42] No worries. [19:44:56] dr0ptp4kt: around? ref T91658 [19:44:56] T91658: Hacking: Wiki Radio - https://phabricator.wikimedia.org/T91658 [19:53:50] myrcx: yep, i'm here. what's up? [19:54:59] dr0ptp4kt: Awesome - what's your thoughts on this being a GSoC project? How much work has been done on it already etc [19:57:47] myrcx: it was really just a proof of concept, so it's pretty incomplete. on a personal level, i think it's a fine sort of project. unfortunately, i won't have time to mentor. if you're looking for potential mentors, maybe email mobile-l; just to forewarn there may not be people available to help...i guess it never hurts to ask, though [19:59:52] dr0ptp4kt: It seemed a really interesting project, good to hear you think it'd work as a GSoC project. I'll ask mobile-l, see what comes of it. Cheers! :) [20:00:10] dr0ptp4kt: One other thing, alright to unassign the phab task? [20:10:19] myrcx: cool cool. yes, please do unassign. [20:30:03] niedzielski: can we call this one done? https://phabricator.wikimedia.org/T120415 [20:30:43] dbrant: yep, that one's good to go! [20:31:25] niedzielski: how about a point estimate? it seemed pretty nontrivial [20:31:53] it's probably a low 5 or a high 3. [20:32:33] 10-4 [20:32:39] according to max, you fit a 4 in a 5 bucket but not in a 3 bucket, so i guess 5 [22:05:02] niedzielski: #simonsays [23:48:45] hey mbinder can't find the next sprint column https://phabricator.wikimedia.org/project/view/489/ [23:48:57] mbinder: are we doing it a different way now? [23:49:22] kaity_: I'm sorry, you weren't around when we got rid of it! Since the board is now using visible tags, we are simply tagging items in the 3 backlog columns. [23:49:44] So this time, items that are tagged with sprint 78 will be in the next sprint [23:50:10] We are doing prioritization tomorrow, as usual, so we can talk more then [23:50:19] mbinder: oh i see! thanks [23:50:46] kaity_: As with anything, it's an experiment and worth reviewing whether or not it meets ALL of our needs :)