[00:00:08] niedzielski: Then you can evaluate whether it suits or not [00:00:33] jdlrobson: yeah, you wanna pair? I can't find a reason the requested thumbnail should ever be anything but 80px [00:02:08] maroloccio: i think i would prefer avoiding Toast because i think the implementation will be fragile unless some effort is put in to really abstract it out. especially in this case where an ImageButton seems more appropriate than an ImageView. [00:02:49] jhobs: sure [00:02:53] I agree with your comment re: Button Vs View [00:02:54] maroloccio: a generic view positioning utility that's useful for toasts or tips might be useful for something else but it doesn't feel like the right tool for the job here to me. i'd be happy to look at whatever you have though if you'd like some feedback [00:03:00] i ca spare 20 mins in tracy island [00:03:27] jdlrobson: already there [00:03:36] niedzielski: But @+id/recent_searches_delete_button, the view in question, is indeed an ImageView, not an ImageButton [00:04:04] maroloccio: i'd recommend trying to switch that to an ImageButton and see if the hover text starts working [01:21:34] niedzielski: That's a good suggestion. It seems, though, for what I can see, that ImageButtons don't work that way. Correct me if I am wrong. I studied the thing a little and created this Gist, which was educational for me: https://gist.github.com/Maroloccio/b76378ac5ce3fefe9b22 [01:22:12] maroloccio: checking... :) [01:22:55] What was interesting for me was that getView() on a Toast, even after .show(), is incapable of returning getMeasuredWidth() unless a Runnable is posted on the event queue, at which point it is considered "laid out", it takes the form of a LinearLayout and reports dimensions correctly. [01:23:18] maroloccio: did you try it without calling mageButton1.setLongClickable(true); ? [01:24:10] So, a more accurate positioning of a Toast message is to be excluded, unless somebody knows how to get to the Toast after .show() and thus to its rendered properties (e.g. width, considering font and text length) [01:24:23] niedzielski: I think so, I'll double check [01:25:38] niedzielski: Double-checked. I confirm that there seems to be no way to use setContentDescription() to display a hovering tooltip for an ImageButton either. [01:25:40] maroloccio: the lifecycle of the view makes it difficult to get sizing at construction time. you can also use a layout listener [01:25:53] maroloccio: hm, let me take a peek on my end [01:26:48] niedzielski: Yes, I could trap layout-ing events and respond to the condition of the Toast having "materialised", but I would not know how to move it then, especially how to move it making sure it does not "jitter" as it relocates possibly mid-animation (fade away) [01:28:05] niedzielski: As a summary, we are in this situation because I am editing what was an ImageView, not supporting pop-ups like options menus, and we tried to use an ImageButton with setContentDescription and/or a simple Toast, which is brittle in its positioning. We have proof of this in the form of that Gist. [01:29:46] I did not consider it a waste of time though, it was generally interesting for me to try to catch that pesky Toast just in time to position it and immediately after it had a width/height (I failed to do that reliably) [01:31:26] niedzielski: Perhaps we need to redefine the ticket and the general strategy concerning long-press tooltips on buttons and button-like views? [01:31:31] maroloccio: i think learning to work with the view lifecycle is useful. there's lots of cases where you need to know the size of things. i still feel like the content description should work somehow so i'm checking that out [01:31:45] maroloccio: well, it works fine for the article menu bar, right? [01:32:31] maroloccio: ugh, nevermind. we do hook into the long click listener in the article menu bar :| [01:33:07] maroloccio: check out line line 114 in ArticleMenuBarView.java [01:33:12] niedzielski: I think menus have a built-in tooltip mechanism by their nature, don't they? As in: they do, but ImageViews/ImageButtons don't ? [01:33:22] niedzielski: checking.. [01:33:49] maroloccio: i _think_ the Android toolbar / action bar does and previously thought ImageButton did as well but am wrong about that! [01:34:08] maroloccio: so you'll see we are actually using toast internally :) [01:35:19] niedzielski: no problem. even if you thought and and it wasn't correct, i did enjoy peeking around, as i said [01:37:08] maroloccio: sorry about that! :) [01:37:37] maroloccio: i have to attend to some family things for a bit so i'll be on and off. please feel free to leave messages and i'll try to guide you better :) [01:37:41] niedzielski: I can see you are using a similar mechanism in that line, with setGravity() on Toast and getLocationOnScreen() to stick it to the associated View [01:38:19] niedzielski-afk: Sure, no problem. I'll just implement this using the internal showToolbarButtonToast() then. Or try to.. ;) [01:38:26] maroloccio: one thing i like about that method is it actually gets the string to display in a really generic View way. just calls getContentDescription() [01:38:32] maroloccio: sounds good [01:39:31] niedzielski-afk: that also explains why you were under the impression that getContentDescription() was automatically attached to a hover, because you had "muscle memory" developed using that method, which does that [01:39:45] but it's not part of the Android framework, generally speaking :) [01:40:03] maroloccio: maybe :) i swear we use something that in the toolbar / action bar and just it just works [01:40:30] Yes, the bar does that. [01:40:33] Cool. [01:57:02] niedzielski-afk: I found a bit of magic online that perfectly positions a Toast. It does what I researched and could not do at first. Teaches clearly also how to force an estimation of layout dimensions. I'll post a Gist. Instructive (for me). [01:58:14] This should work on a new sample project already. Long-press the ImageButton below: https://gist.github.com/Maroloccio/9655760a7883327fbf3f [02:16:46] maroloccio: nice, we don't account for the width and height of the toast in the app. i think we just used gravity and it'll float as needed? [02:18:36] niedzielski-afk: I'll try to adapt that as well. I noticed you just use Gravity rather than align the Toast.. If I succeed, I'll include it in my patch. [02:23:04] maroloccio: hm, i'm not quite sure what you mean but i look forward to checking it out! [03:20:41] niedzielski-afk: I am ready to submit a small patch for T104094. First time at this. [03:20:42] T104094: No long press hints in search mode - https://phabricator.wikimedia.org/T104094 [03:50:12] Sorry guys, I have a Change-Id generate. How do I submit my patch for review? [04:04:59] Also, I would gladly take on another "Task" if my patch was any good.. [04:10:04] maroloccio: hey! it sounds like this is your first time with gerrit. i think we have some documentation on getting set up. just a moment [04:10:49] maroloccio: have you taken a look at https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking ? [04:11:27] maroloccio: there's some relevant instructions under #Set_up_a_development_environment [04:16:45] niedzielski-afk: Thanks for that [04:18:25] niedzielski-afk: I might have submitted before reading those.. :( [11:05:17] morning [14:21:00] out to lunch [14:21:05] thanks for the reviews bmansurov [14:21:13] ;) [15:48:12] bBBack [15:52:48] wb joakino o/ [15:54:16] hi jhobs! [15:59:09] bmansurov: if the latest PS on the language switcher icon still fails in jenkins, can you try the tests locally? I can't reproduce the failing test [15:59:24] jhobs: i did, everything passes [15:59:34] bmansurov: i just uploaded a new one [15:59:36] jhobs: the trick is to run it locally against prod URL [15:59:54] I'm hoping it's just a race condition [15:59:58] so I add a "when_present' [16:00:08] ok [16:03:01] btw joakino, your implementation of the core patch is almost identical to what it started as lol [16:03:22] jhobs: i imagined since I saw the reference links at the top in the comment [16:03:25] but enough review turned it into not using jQuery and what not [16:03:33] whatnot* [16:03:37] didn't have the energy to go through the comments though [16:03:43] haha good call [16:04:13] jhobs: it's completely broken so I hope at least we can get it fixed before we bikeshed on details [16:05:05] joakino: yeah, after I wrote the tests I stopped testing as diligently manually [16:05:20] so I actually would've noticed that issue if it existed in one of the earlier patchsets :D [16:05:37] IOW, unit tests are bad for you obviously ;) [16:06:24] this is the proof that they are not infallible, and that people review and bitch about a patch without testing it [16:06:49] 😛 [16:06:57] yep haha [16:07:08] alright I'm gonna go get some lunch before our meeting [17:03:39] phuedx, JonKatz: meeting? [17:26:51] bearND: there are some tasks under 'needs triage' in the content service workboard that seem like they belong under 'tracking' -- mind if i move them over? [17:32:05] dr0ptp4kt: there's still planning to be a live stream, right? [17:32:16] I will youtube [17:32:29] yeah I was just gonna watch the youtube stream [17:32:42] mdholloway: love stumbling on devs talking process :) [17:33:14] mbinder: :) [17:37:55] stream works, but not seeing any screenshares [17:38:03] oop there it is [17:40:18] mdholloway: i've moved a couple of tasks [17:43:50] bearND: looks good, thanks [17:50:53] is https://meta.wikimedia.org/wiki/2015_Community_Wishlist_Survey/Top_10_notes the best current overview of what is being worked on? [17:51:58] and tgr, what is the work on templates about again? couldn't hear that [17:53:24] HaeB: investigation of solutions for https://phabricator.wikimedia.org/T483 [17:54:21] bmansurov: bd808 standup [17:54:24] jhobs: dr0ptp4kt [17:54:27] now? [17:54:30] nzr [17:54:37] jdlrobson: yes [17:54:45] lets do it 6 mins early [17:54:46] why not [17:54:51] ok [17:55:43] bd808: ah, that. cool! thanks [18:05:57] jdlrobson: hey do you know if displaytitle is available in search results? (i don't think they are...) [18:09:10] alright i'm out! [18:09:19] later [18:09:20] jdlrobson: yeah just ping whenever you've got some time, preferably soonish [18:09:23] cya joakino! [18:12:22] hey y'all [18:12:28] sorry i couldn't make the standerp today [18:12:49] lisa was still out of the house at the doctor and i had to get the kids bathed and to bed [18:13:40] A wild phuedx! [18:13:52] * bd808 throws his best pokeball [18:14:16] <~ this guy [18:15:12] jdlrobson: sorry, just saw this message. i had closed my irc client during our readout and i guess i missed it. at least i think that's what happened [18:15:21] jhobs: ditto [18:16:59] mdholloway: how about we catch up now? [18:17:06] mdholloway: if you need 13 more mins, ok, too [18:17:44] dr0ptp4kt: depends on whether you mind if i eat a sandwich while we're chatting :) [18:18:25] mdholloway: no no. eat your lunch and don't work [18:18:31] mdholloway: see you in 11.5 mins [18:18:35] ok, talk in a bit! [18:39:39] nzr: ok if I move the meeting to a little later? [18:39:46] bmansurov: yeah [18:39:50] ok [18:40:40] nzr: not sure if you got an email, but I moved it to an hour later [18:40:50] bmansurov: that's perfect [18:41:08] i didnt because you moved it only on your calendar [18:41:42] oh ok [19:18:26] phuedx: !! [19:18:32] hey jdlrobson [19:38:19] any of you listen to the new esperanza spalding album? [19:55:55] dr0ptp4kt: i've basically just had my bloody valentine on repeat for the past decade ;) [19:56:39] :) [20:01:44] mdholloway: woah, you gotta listen to this album. go directly to track 2, then track 14 [20:01:59] mdholloway: in honor of your past decade i'll listen to mbv next [20:02:15] mdholloway: which album should i listen to? [20:02:25] dr0ptp4kt: it's a deal [20:02:29] dr0ptp4kt: listen to loveless [20:02:53] mdholloway: starting. woah, bold opening. [20:03:27] :) [20:03:59] let's see, do i still have spotify premium... [20:04:30] nzr: ? [20:14:50] mdholloway: i wasn't aware until i was older, but i still forget just how much this stuff influenced everything [20:15:37] dr0ptp4kt: yeah, definitely. especially the shoegaze resurgence lately (although that's probably old news too by now) [20:32:06] bmansurov: joining [20:32:20] bmansurov: there's no one at hangoiut [20:32:39] 1sec [20:32:56] wait it was at 12:30 [20:32:59] not 12 [20:33:06] weird!! [20:33:35] i'm in [20:40:17] dr0ptp4kt: just getting around to listening now. good stuff! [20:40:36] mdholloway: i like mixed time signatures [20:41:55] dr0ptp4kt: me too. did i ever tell you i play drums? [20:42:32] mdholloway: no. me too. and jhobs. well, i played drums when i was young. and as my wife can attest, i play drums on all surfaces. [20:43:06] dr0ptp4kt: nice! [20:44:05] mdholloway dr0ptp4kt: yoooo fellow drummers in the house [20:44:13] although I'm self-taught which == bad [20:44:24] WMF Reading+Percussion Team [21:17:03] thedj: glad to see you are no longer in a hospital bed :) [21:34:38] jdlrobson: me too :) [21:35:22] jdlrobson: but typing is still a problem. mobility in right arm is not yet ok enough. [21:38:09] mobility in wikipedia still not yet ok either ;-) [22:01:52] jdlrobson: i'm going to take a stroll through the sprint 68-j board. anything in there that *really* stands out? i've a bent toward finishing these quarterly goals, of course [22:02:41] dr0ptp4kt: i would suggest punting related articles stuff to sprint k then [22:02:48] it's gonna be a tight sprint i think [22:02:55] jdlrobson: ok, thank you. [22:05:06] JoshM: T65971 I'm trying to understand. I looked in the latest build Beta 786 and I don't see any change from the "Screenshot demostrating issue" screencap in Mhurd's description. [22:05:06] T65971: Support {{DISPLAYTITLE:}} in article view - https://phabricator.wikimedia.org/T65971 [22:05:55] bd808: vagrant doesnt seem to work with VirtualBox 5? [22:06:05] oops should have sent to wikimedia-ios pardon me [22:06:06] * mediawiki vagrant [22:06:13] am getting "NFS is reporting that your exports file is invalid" [22:06:32] I'm running 5.0.14 [22:06:51] that NFS problem sounds like its on your latop [22:07:33] k will look into it [22:07:45] was giving vagrant another go to see if it's usable again [22:09:41] jdlrobson: try using `vagrant config nfs_shares off` [22:09:50] I haven't run nfs for quite a while [22:10:15] you are still going to end up being cranky about the time that RL takes to d some things [22:22:20] bd808: would you be able to create board 69-i for web? [22:22:27] i mean [22:22:35] bd808: 69-k [22:22:58] dr0ptp4kt: https://phabricator.wikimedia.org/project/query/crdWypgnz2dN/ [22:23:07] been there for a while [22:23:41] bd808: thx, sorry [22:23:51] no worries [22:24:05] bd808: i was too lazy, should have typed 'reading-web' to get it in the suggest [22:34:16] hi. niedzielski should i just scrap that patch and submit a new one just with the topical changes? (perhaps add another one of "general clean-up"?) [22:36:28] maroloccio: no, definitely not! there were only minor comments on the patch! my note about keeping patches hygiene xor feature focused was for future work, not for this patch :) i only mentioned it because it was the first patch i saw from you and we generally try to keep these concerns separate [22:43:46] niedzielski: i actually agree with your principle of keeping patches "on topic". 2, 3, n changes, all related to the same topic. [22:44:09] niedzielski: i dont understand what i should do now though. if not new separate patches, then what? [22:45:30] maroloccio: oh, just submit an amendment patch on top of your current review. so you checkout the Git revision your were working on. make some changes, add them to the Git staging area, and commit --amend instead of just commit. when you push, it'll just replace your current gerrit review. [22:45:53] maroloccio: feel free to break it into multiple patches if that's simpler. we tend to prefer more granular patches but i didn't want to put you through any extra trouble [22:50:12] niedzielski: are you sure that you prefer the arbitrary offset of the Toast to the "aligned" change? Currently, it offsets based on Gravity but we haven't tested all cases around the edges of the screen.. I proposed the alignment to at least have consistence. (e.g. prever predictable behaviour to slightly better visuals) [22:50:58] of course you decide, it's just the generally "asymmetry of behaviour" (even inconsist.) gives me a bad irrational "feeling" [22:53:48] maroloccio: i understand the feeling but i think we should design for the best experience and handle corners cases individually as needed. if you want to test the corner cases, why not just stuff a super long string into it and see how it performs? i'm not sure if it makes sense to say this but i think we're trying to be clever by attempting to han [22:53:49] dle all scenarios [22:54:10] er too clever that is [22:56:48] niedzielski: cool. i'll split and resubmit. thanks for your guidance so far. [22:57:16] maroloccio: thanks for the patch! [23:25:20] bd808: Notice: Finished catalog run in 2670.51 seconds [23:25:42] jdlrobson: clean install? [23:25:55] cloning core is slooooow [23:25:57] bd808: that was just vagrant up :_ [23:26:02] anyway it's working now [23:26:45] well `vagrant up` on a clean install clones mediawiki/core and a lot of other crap. [23:27:28] But no argument from me that things can take longer than it feels liek they would manually [23:27:47] but the repeatability is higher by an infinite amount