[00:06:31] jhobs: would you have time to look at https://phabricator.wikimedia.org/T129098 tomorrow (assuming you are done for day)? [00:07:53] jdlrobson: sure [00:10:34] jhobs: awesome.. wasn't sure if Zero was pulling you away from us again (if it is btw lemme know so we can make that more of a maintenance project...) [03:13:33] niedzielski-afk: thanks for flake8. fixed. [04:05:52] kaldari, jdlrobson : ^ looks like you worked on the patch that Sidnicious is referring to [04:07:07] Sidnicious: if you don't get a reply here, it might be easier to email the list https://lists.wikimedia.org/mailman/listinfo/mobile-l [04:08:36] Sidnicious: I'm not working on mobile any more. jdlrobson would be better to ask about it. He was also the author of the patch that removed it. [09:05:27] morning [09:43:55] morning! [09:49:03] hey joakino [09:49:15] o/ [11:56:36] breaking for lunch with the kids [12:43:23] back [15:40:11] mdholloway: up for a quick hangout? [15:40:20] dbrant: sure [15:40:47] niedzielski: bearND: ^ optional [15:41:15] it's about the WebView progress spinner patch [17:04:10] nzr: if you can make standup swell. if not, okay, could you just email? i think bmansurov said your battery was dying. [17:08:44] dr0ptp4kt: i have too many conflicts with standups [17:08:52] :( [17:08:52] nzr: word [17:08:55] need to fix that [17:20:15] bmansurov: can you paste the source code of that page? [17:20:24] ok [17:20:26] bmansurov: https://phabricator.wikimedia.org/paste/edit/form/14/ [17:20:43] bmansurov: jdlrobson: this (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L389-L392) needs to be before here too (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L407-L408) [17:20:58] last section body is not getting the transformations applied [17:21:03] sorry I missed that [17:21:09] yay [17:21:10] i see [17:21:16] no need for the paste then? [17:21:50] bmansurov: it would help [17:21:54] ok [17:22:05] bmansurov: sounds like any page with an image in last section though - but your past would help me writing a test case :) [17:22:32] priority high joakino bmansurov phuedx ? [17:22:39] yeah [17:22:56] yes [17:31:11] dbrant: meeting? [18:12:39] niedzielski: thanks for reviewing my patches. i appreciate that. i answered your comment as thoughtfully as i could [18:14:28] maroloccio: thanks for the patches! [18:15:19] maroloccio: er, did you submit that comment? i'm not seeing it in gerrit [18:19:55] niedzielski-afk: i don't know how to "submit a comment" [18:20:37] maroloccio: oh, just go to the patchset that the comment is on (you should see a red comment icon next to it in gerrit) and then just hit review [18:20:53] maroloccio: you should see your comments underneath an empty text box. just hit submit from there [18:21:06] er, the submit button is titled "publish comments" [18:21:28] maroloccio: nice! just got the comments [18:29:07] jdlrobson, bmansurov, joakino: high-priority [19:01:14] jhobs: i accidentally fixed the width/height issue on the spinner [19:02:31] jdlrobson: wait really? I was literally just finishing up my commit message [19:02:37] haha well that works [19:03:23] jdlrobson: ping me when it's up and I'll get you some quick review [19:04:13] nvm I see it [19:07:12] jdlrobson: shouldn't we also check if the width or height is smaller than the spinner and not show it? [19:07:50] we check the width and height of the image before adding the spinner. 80px will always be bigger. [19:08:29] jdlrobson: right, I mean if we determine that x pixel width/height is too small to really be able to see the spinner [19:08:37] right now you're only checking if both dimensions are big enough [19:09:11] and why if it's at least 80px by 80px would the spinner not show given the spinner is 24px by 24px? [19:09:26] aren't there cases where 1000x40 e.g. would be useful to have the spinner? [19:09:41] that's an extreme ratio obviously, but you get the idea [19:10:28] Basically I just figured we'd want to use an or rather than an and [19:10:49] but it's probably not a super useful edge case, so I'm fine with the current implementation if you are [19:10:58] just wanted to raise it [19:11:48] i'd rather not get too caught up in edge cases at this point. Not showing a spinner for a 1000x40 image is not the end of the world and if it is Nirzar I'm sure will tell us and we can reevaluate once this is out in the wild [19:12:07] until then my feeling is YAGNI (you aint gonna need it) [19:12:16] cool, fine by me then [20:19:25] jhobs: i will have time later today if you want to pair on the browser test issues you are having [20:27:47] I need some advice about the labs ‘mobile’ project — is there anyone left who cares about and/or uses that? [20:29:41] or a mail alias for the mobile team, maybe? [20:32:06] hey andrewbogott [20:32:08] let me take a look [20:32:59] jdlrobson: If the project is defunct I can delete everything, but today I’m specifically gunning for the staging.wmflabs.org and staging-zero.wmflabs.org domain names. [20:33:21] andrewbogott: anything with zero in i'd defer to dr0ptp4kt and yurik [20:33:27] I would like to turn them into web proxies or delete them or move them to .mobile.wmflabs.org subdomain [20:34:00] jdlrobson: both of those names point to the same instance [20:34:09] so they’re part of the same enterprise, whatever it is [20:34:22] but i expect it is no longer used but I'm not 100% sure as I've not had much to do with Zero [20:34:30] jhobs: do you know anything about the above domains? ^ [20:35:01] (confusing context, in case anyone is curious: https://phabricator.wikimedia.org/T130032 ) [20:35:05] dr0ptp4kt: as far as I know we don't use either of those [20:35:09] but yurik would know better [20:35:44] andrewbogott: Looks lik you can delete reading-smoketest [20:36:07] and mobile-smoketest [20:36:35] both are superseded by reading-web-staging [20:36:46] jdlrobson: ok… I don’t know what those are [20:37:08] they are projects I'm seeing on https://wikitech.wikimedia.org/wiki/Special:NovaProject [20:37:09] oh, you mean the whole projects? Cool. [20:37:25] yup they can both go they seem to be old [20:39:02] * andrewbogott deletes all of the things [20:40:36] mhurd: jdlrobson niedzielski bearND dbrant would you guys please add your notes to https://etherpad.wikimedia.org/p/Scrum-of-Scrums ? thx [20:41:07] dr0ptp4kt: did u mean corey? [20:42:00] dr0ptp4kt: are we hanging out [20:42:26] mhurd: if he's around. otherwise, can you handle it this one time? [20:42:40] jdlrobson: we were, but hung up after a few minutes, let's just get the notes out there [20:42:44] dbrant: do you think we'll cut another beta this week or wait a bit? [20:42:45] dr0ptp4kt: i didn't go to scrum of scrums [20:43:31] dr0ptp4kt: oh me and bernd are there now :) [20:43:32] mhurd: i'll go to it, but could you add notes for ios to that etherpad? mainly you just need to say what's happened recently and if there are any interteam things need to be aware of. i rep for reading eng [20:43:54] dr0ptp4kt: ah ok [20:44:03] jdlrobson: bearND we hung up already :) [20:44:21] you missed all the fun! :) [20:44:43] dr0ptp4kt: ok, sorry. will add to etherpad if i come up with anything [20:44:49] jdlrobson: bearND i don't know, i'm now listening to the harlem shake. i don't know that anything's more fun that than. [20:44:51] bearND: no worries [20:45:33] dr0ptp4kt: oh, that's why you don't want to meet anymore. you don't want us to see you dancing [20:46:03] bearND: oh, i'll have to make a mov then use mhurd's animated gif optimizer [20:46:15] lol [20:54:03] * mdholloway looks up [20:54:08] bearND mdholloway /cc dbrant: hello bernd and michael! is there anything we're waiting on for the next beta release (in particular, from a content service perspective)? [20:54:13] animated gif optimizer??? [20:54:15] :) [20:54:53] niedzielski: let's see [20:56:18] niedzielski: nothing i can think of right now. [20:58:46] dr0ptp4kt: i updated the etherpad for iOS :) [20:59:09] mhurd: thx [21:01:18] bearND mdholloway dbrant: ok cool. wrt michael's email, do we want to rotate release responsibilities or should i cut this one? either is fine with me [21:01:23] niedzielski: have to think a bit more about https://phabricator.wikimedia.org/T118306. dbrant was suggesting we could bring back the old ui for the gallery details dialog. But I'm leaning towards not letting this block the release. [21:02:27] I'm still hoping for a server-side fix [21:03:04] mdholloway dbrant ^^ is everyone cool with letting this slide for now? [21:04:23] niedzielski: bearND: yep! slide. [21:04:31] niedzielski: yeah, no need to block the release as far as i'm concerned [21:06:53] bearND mdholloway dbrant: ok cool. i'll cut the release as per usual unless i hear any objections [21:07:14] niedzielski bearND dbrant: i have my head in what i'm working on atm but i'll plan to do the next one [21:07:18] niedzielski: thanks [21:07:19] niedzielski: cool, sounds good [21:08:06] mdholloway: sounds good. no pressure :) [21:15:06] jdlrobson: sry for not responding earlier, had my head down. I'm down to pair on the browser tests if you're still free [21:15:16] sure can do that now if that helps [21:15:22] sounds good. Tracy? [21:17:13] niedzielski: you were right. one gets used to gerrit as one uses it. thanks for your patience at the beginning (and for my future mistakes) [21:18:23] jhobs: omw [21:19:58] maroloccio: thank you for your patches and thoughtful feedback! i hope we get more! if i can help point you to more tasks, or if you have other ideas for contributing, let me know :) [21:25:39] mbinder: so now when i make a new "release the beta" card to put in the current sprint, i should drag it from needs triage to product backlog? [21:31:43] @niedzielski Good question! I'd leave it in "Needs Triage" since that is @dbrant's domain, and just @-mention him in the task comments so he is A) aware the task exists and needs triage, and B) aware that something new has entered the sprint (or more accurately in this case, something which we're already aware is changing the sprint scope is now documented). [21:33:09] mbinder: ok, thanks! [21:33:22] 👍 [22:30:38] niedzielski: thank _you_. i want to read the code a bit more then a new Task would be nice [22:32:23] maroloccio: ok cool. just ping me whenever :) [22:35:25] dbrant mdholloway bearND: release notes are cooking in the usual place. please get your edits in :) [22:42:31] dbrant mdholloway bearND: have you guys seen this error before? https://phabricator.wikimedia.org/P2767 [22:43:16] dbrant mdholloway bearND: i'm testing seven devices simultaneously but this test is read only [22:44:03] niedzielski: i have not encountered that one :( [22:44:17] niedzielski: made one minor edit to release notes, otherwise lgtm [22:45:00] mdholloway: yeah, i want to discount it but it happened on two of the seven devices [22:45:03] thanks :) [22:48:03] niedzielski: which page was it trying to load or save? [22:49:44] bearND: https://test.wikipedia.org/wiki/Ampersand_%26_title [22:50:27] niedzielski: oh, right. Just noticed the title. Duh [22:51:13] bearND: :) [22:51:26] I saw something about savedpage in the trace [22:53:37] bearND: hm, maybe it's a caching issue. i recently changed the test to use prod instead of alpha so we could exercise both mw and content service apis [22:59:54] niedzielski: please point me to another Task, i'll see if it's within what i can do [23:02:12] maroloccio: hm, i'm not sure if this task is sufficiently clear: https://phabricator.wikimedia.org/T103903 [23:02:49] niedzielski: I don't understand your last statement. With either app you could exercise mw or mcs apis. You just need to set it in the dev settings. [23:03:07] maroloccio: the change itself is pretty straightforward. we previously wanted to support custom packages for third parties like org.wikipedia.foobar. this ended up being a bad idea because then those parties never get updates from the play store so we want to remove support for it [23:04:04] bearND: right, but we don't have hooks in place to inject settings as part of the tests. it was easy to just test prod instead of alpha [23:04:56] bearND: i'm not sure why, but testing the prod builds doesn't seem to uninstall the apk upon completion. i'm wondering if there's an issue because of the previous state [23:05:55] niedzielski: I see. This will go away once we roll out the service to the prod app. You could still have a switch by testing zhwiki vs enwiki or with noimages vs. images but that might be more complicated for your tests than changing the dev setting. [23:06:26] I meant the switch between mcs and mw [23:07:26] bearND: i think for the page tests we could add something without too much effort. we currently do this for arabic [23:11:46] maroloccio: here's another one: T121410. i haven't looked into this myself but it sounds like the minimum change would be to retry sooner on failure. i think some networking libs have built in retry policies but that's outside the scope of this task [23:11:46] T121410: Improve error handling in Featured Article widget. - https://phabricator.wikimedia.org/T121410 [23:12:12] niedzielski: ok, i'll read T121410.. [23:12:13] T121410: Improve error handling in Featured Article widget. - https://phabricator.wikimedia.org/T121410 [23:18:03] niedzielski: release notes look good to me [23:18:19] bearND: thanks :) [23:28:38] niedzielski: lgtm, as well [23:29:16] dbrant: thanks [23:55:30] niedzielski: I think the FileNotFoundException re: saved pages in your paste is probably unrelated, and not part of the stack trace. It just happened to be logged at the same time. Note that was logged in debug level, while the rest of the trace is at error level [23:56:52] dbrant mdholloway bearND: i just saw a _really_ weird issue on the $50 Fire. the timestamp and title columns in the history fragment were swapped. this happened in both beta and prod builds but not dev. i pulled the database and it looks good. i uninstalled the prod app, installed the last version, used it for a bit, installed the latest version, a [23:56:52] nd didn't see any issues. beta was still acting up so i rebooted having no other options. beta magically started working again... i'm chalking this up to the $50 fire which doesn't even have a square pixel but thought it was worth mentioning [23:57:29] bearND: i still don't know what's up with that test :( [23:58:53] niedzielski: would you turn on full Retrofit logging next time? It mentions JSON path $.mobileview.revision being the culprit (boolean instead of long)