[09:08:22] <phuedx>	 yo
[17:16:24] <jdlrobson>	 phuedx: so i just slapped a @smoke tag on it
[17:16:45] <jdlrobson>	 since usually @smoke and @integration tags go together and it gives us a bit more prominent coverage for a prominent feature
[17:17:13] <jdlrobson>	 hope that makes sense?
[17:31:06] <jdlrobson>	 phuedx: ?
[17:43:51] <bearND>	 dbrant: do we have a release card for promoting the release to production?
[17:44:43] <dbrant>	 bearND: not yet :)  making one...
[17:45:34] <bearND>	 dbrant: i think we have a template for that
[17:45:57] <dbrant>	 bearND: I just base it off the previous production card
[17:49:17] <nzr>	 bmansurov: https://phabricator.wikimedia.org/T130133
[17:49:30] <nzr>	 bmansurov: check the mock for the language variant section header
[17:49:38] <bmansurov>	 ok
[17:51:02] <bmansurov>	 nzr: do you think we should add a little space to the left of variants to indicate the new heading doesn't apply to everything that comes after it?
[17:52:39] <dbrant>	 niedzielski: i've pushed the prod tag. (that's all i need to do, right?)
[17:53:45] <niedzielski>	 dbrant: right
[17:54:16] <nzr>	 bmansurov: yeah i tried that but it again creates the confusion around... why it is indented 
[17:54:23] <niedzielski>	 dbrant: and i see it's identical to the last beta so i think we're good
[17:54:30] <bmansurov>	 nzr: ok
[17:54:34] <dbrant>	 niedzielski: cool
[18:19:45] <bearND>	 exciting times
[18:23:57] <mbinder>	 dbrant: gonna lunch with rita (new designer) today, so no grooming for moi
[18:24:26] <dbrant>	 mbinder: no worries. say hello!
[18:55:43] <dbrant>	 niedzielski: bearND: mdholloway: Is it cool if we skip grooming today? i need to run an errand...
[18:56:10] <niedzielski>	 dbrant: works for me
[18:56:10] <mdholloway>	 dbrant: niedzielski bearND ok by me
[18:58:39] <dr0ptp4kt>	 bmansuro_: you good on the overlay with that latest patch?
[18:58:49] <bmansuro_>	 yes
[18:59:22] <dr0ptp4kt>	 bmansuro_: cool, wasn't sure if you needed an answer to your latest question on the phabricator ticket. i imagined you were doing some git archaology
[18:59:59] <bmansuro_>	 dr0ptp4kt: i was just pointing out that with the new design we need the parent language notion
[19:00:53] <dr0ptp4kt>	 bmansuro_: tracy island for a moment?
[19:01:00] <bmansuro_>	 sure
[19:28:13] <bearND>	 dbrant: would be fine with me
[19:51:16] <mdholloway>	 bearND: https://gerrit.wikimedia.org/r/#/c/279180/  <-- mind hitting +2 if you agree with this?
[19:57:15] <bearND>	 mdholloway: good catch. Will do
[19:57:37] <mdholloway>	 bearND: thanks
[20:04:55] <jdlrobson>	 bmansuro_: given https://gerrit.wikimedia.org/r/279113 is blocking merges and I can't get hold of Sam can you be the deciding reviewer?
[20:06:13] <jdlrobson>	 also if you wouldnt mind merging https://gerrit.wikimedia.org/r/279153 i'd like to get it swatted before it rolls out tomorrow
[20:15:30] <bmansuro_>	 ok
[20:49:13] <kaity_>	 dbrant: hey do you wana chat before our sync with JK?
[20:49:47] <dbrant>	 kaity_: yes; ready now, if you like
[20:50:43] <kaity_>	 dbrant: sure
[21:16:34] <jdlrobson>	 thanks bmansuro_ :)
[21:16:43] <bmansuro_>	 np
[21:20:55] <jdlrobson>	 bmansuro_: just saw your patch - how can i test that?
[21:21:07] <jdlrobson>	 is there a page on reading web staging with variants i can try out?
[21:21:15] <bmansuro_>	 yes
[21:21:17] <bmansuro_>	 1 sec
[21:21:53] <jdlrobson>	 i was a bit confused about the not bundling things into sub groups
[21:21:58] <jdlrobson>	 i thought we were just changing the sort order?
[21:22:28] <bmansuro_>	 jdlrobson: yes, i, adam, and nirzar talked and came to a conclusion to remove the grouping
[21:22:42] <bmansuro_>	 the ticket has been updated with more info
[21:22:50] <jdlrobson>	 yeh i was there too i just somehow missed that in the conversation
[21:23:08] <bmansuro_>	 jdlrobson: no, we had another meeting
[21:23:24] <bmansuro_>	 jdlrobson: reading-web-staging.wmflabs.org/wiki/Lang?mobileaction=beta has many languages including variants, but they don't show up for some reason
[21:23:40] <bmansuro_>	 jdlrobson: you may want to test locally with the contents of that page
[21:24:19] <jdlrobson>	 bmansuro_: how do i test variants on that?
[21:25:01] <bmansuro_>	 jdlrobson: you should make sure that variants are not grouped together
[21:25:17] <bmansuro_>	 jdlrobson: are you testing it locally given the staging page isn't working correctly?
[21:25:46] <jdlrobson>	 bmansuro_: oh. I thought you were saying that version worked. I have no variants setup, so I'm just keen to verify what i'm expecting to see from the code
[21:27:02] <bmansuro_>	 jdlrobson: is there anything in your sites table?
[21:29:08] <jdlrobson>	 bmansuro_: can the variant thing be detangled from the sort order in https://gerrit.wikimedia.org/r/#/c/279166/ ?
[21:29:39] <bmansuro_>	 jdlrobson: yes, should I change it?
[21:29:55] <jdlrobson>	 yeh with SWATs we should aim to have them as small as possible in case something goes wrong
[21:30:06] <bmansuro_>	 jdlrobson: ok
[21:30:17] <jdlrobson>	 would be good to not have to revert an EL fix if there turns out to be an issue with sort order
[21:38:16] <bmansuro_>	 jdlrobson: updated the patch
[21:42:35] <jdlrobson>	 bmansuro_: im having issues setting up interwiki links :/
[21:42:44] <jdlrobson>	 they are all in the interwiki table but not showing up
[21:43:02] <bmansuro_>	 jdlrobson: don't you have to populate the sites table too?
[21:43:07] <jdlrobson>	 hopefully if i can get to the bottom of this I can work out what's wrong in our @integration tests
[21:43:11] <jdlrobson>	 sites table?
[21:43:13] <jdlrobson>	 i dont have a sites table..
[21:43:25] <bmansuro_>	 jdlrobson: try creating it
[21:43:45] <bmansuro_>	 jdlrobson: i think sent you the table dump some a couple of weeks ago
[21:56:01] <jdlrobson>	 i have the sites table too but still nothing :/