[00:22:14] https://en.wikipedia.org/w/index.php?title=Qandeel_Baloch&action=history [00:22:22] what're all those null edits? [00:22:49] mobile web edits with 'null' summaries and sections [00:30:39] don't see any more occurences at https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+web+edit [08:45:40] good morning y'all [08:45:47] i fell asleep in the car :/ [09:53:42] if you're into this sorta thing: as seas exhale - voyager [09:54:24] stumbled upon it via arctic drones, who gave it a good review [10:44:28] I'm a bit wondering, mostly german people ask, why the Wikipedia app requires the new permission to get the identity :D [13:39:07] FlorianSW: hi there, looks like i missed you, but this permission is needed to access a user's wikipedia account in order to synchronize the user's preferences and saved pages across devices. [13:39:52] FlorianSW: We have explanations of our permission requests on the Wikimedia Apps FAQ, at https://www.mediawiki.org/wiki/Wikimedia_Apps/Android_FAQ#Security_and_Permissions [13:40:07] FlorianSW: you can point users there if they're curious [13:57:09] phuedx: very different than what you linked, but i thought i would share. i was reading about the "loneliest whale" the other day and the wikipedia article led me to this https://www.youtube.com/watch?v=BVYeFRPLc74 [14:01:47] niedzielski: nice find! this is making my day. [14:02:58] mdholloway: :) it's on the far end of what i normally listen to. i really enjoyed it [14:05:51] link to the album i was talking about earlier: https://asseasexhale.bandcamp.com/album/voyager [14:13:17] niedzielski: i've sort of fallen off the wagon in recent years in terms of following music, but i have a soft spot for ambient/drone-y stuff [14:13:49] speaking of which, phuedx, i think i promised you this link back at all-hands: https://www.youtube.com/watch?v=utjKMyoQ-cc [14:14:15] phuedx: ooh, this as seas exhale is good too! [14:14:47] phuedx: lovesliescrushing seems a little different direction from what you're typically into but you might find it interesting [14:24:25] thanks mdholloway! [14:24:42] will give it a listen once i've gone through voyager a few times :) [14:33:34] mdholloway: if you're looking to track drone/sludge/post-metally type bands, then i'd highly recommend arctic drones [14:33:42] http://arcticdrones.com/ [14:34:39] and if you like rss: http://arcticdrones.com/tag/post-metal/feed/ [14:41:13] phuedx: thanks! i'll add it to my routine. [16:55:27] how my brain works: based on one album alone i'm willing to buy another nine albums [17:27:38] phuedx: what album? [20:00:13] phuedx, hey. I know it's late, but if you could look at https://gerrit.wikimedia.org/r/#/c/276689/ or https://gerrit.wikimedia.org/r/#/c/280366/ (GuidedTour patches) tomorrow or some time, that would be awesome. [23:38:37] mdholloway|afk, bearND: ping [23:38:50] gwicke: hi [23:39:28] hey, we found a pretty bad bug in the mobile app service [23:39:34] https://phabricator.wikimedia.org/T131416 [23:40:10] should be easy to fix [23:40:20] gwicke: ok, I'll get in it right away [23:41:04] gwicke: if we fix it should we deploy tonight or are there ways for you to mitigate on your end? [23:41:28] the main mitigation from our side is to break the loops mobile apps enters [23:41:48] but that's a manual thing, based on (newly deployed) sampled logs [23:42:29] so, if it's just a one-line change & safe to deploy, then doing so tonight would be great [23:42:40] that said, we would survive until tomorrow [23:43:12] well, Friday deploys are probably worse [23:43:20] Pchelolo just found the third loop [23:44:19] I haven't looked at the callers of getContent; did anything change in how it is called? [23:45:51] ah, I think I found the culprit: https://github.com/wikimedia/mediawiki-services-mobileapps/commit/5be9a79f0f993bf188c5a2ff8388253bedd2bcfe#diff-4b44c983e4f426ec7b06814aed2fafd5L76 [23:46:09] previously, opts was a separate parameter [23:46:41] that patch removed that, and relied on req.params.opts instead [23:47:04] but didn't make sure that it was actually initialized [23:48:30] gwicke: ok, the one line should fix it then, right? [23:48:55] bearND: yes, it should [23:51:09] gwicke: https://gerrit.wikimedia.org/r/280789 [23:53:19] gwicke: hmm, getting test failures. lots of 400s [23:53:46] yeah, I think line 83 would need a change as well [23:53:51] if (!opts && revision && revision.constructor === Object) { [23:54:18] is revision a number? [23:55:02] good question [23:55:20] that section looks pretty suspect [23:56:45] maybe the best would be to go back to passing opts as a parameter [23:57:53] yet another option: assign back to req.params.opts in line 94 ;) [23:58:04] rather than line 76 [23:58:12] in all the tests we run revision is undefined ;( [23:59:30] yeah, the issue is that it is no longer initialized further down [23:59:59] so, perhaps revert line 76, but add a line after 94 like this: