[00:00:12] <gwicke>	 req.params.opts = opts;
[00:07:34] <bearND>	 gwicke:gwicke i think it would be cleaner to move your line a bit later to make it 105; after the decrement.
[00:08:29] <gwicke>	 bearND: any of those will work; opts is guaranteed to be an object anywhere past 94, and the assignment just creates another reference
[00:23:32] <bearND>	 gwicke: ok, uploaded PS2, tests pass
[07:53:05] <phuedx>	 jdlrobson: lol i thought i'd just lost all my inline comments
[07:53:13] <phuedx>	 anyone else been kicked off of gerrit recently?
[07:56:51] <Reedy>	 kicked off?
[08:16:39] <jdlrobson>	 phuedx: thx
[08:19:08] <phuedx>	 Reedy: poor choice of words
[08:19:19] <phuedx>	 automatically logged out of
[08:19:51] <phuedx>	 a couple of days ago i submitted a review but i'd been signed out somewhere between clicking "reply" and "submit"
[09:01:37] <jdlrobson>	 phuedx: is labs down?http://reading-web-staging.wmflabs.org/
[09:14:48] <phuedx>	 jdlrobson: i think it's just the staging node
[09:14:49] <phuedx>	 http://mobile-reportcard.wmflabs.org/
[09:14:52] <phuedx>	 for example
[10:28:10] <phuedx>	 jdlrobson: still provisioning reading-web-staging
[10:28:18] <phuedx>	 it hasn't been done in a while…
[10:57:05] <phuedx>	 jdlrobson: reading-web-staging is back up after a cd /vagrant; git pull; labs-vagrant provision; labs-vagrant git-update
[10:57:12] <phuedx>	 which i should make into an alias for the vagrant user
[10:57:26] <phuedx>	 something like "kitchen-sink-update"
[16:07:23] <phuedx>	 ok
[16:07:24] <phuedx>	 well
[16:07:33] <phuedx>	 the new explosions in the sky album is fantastic
[18:06:33] <mdholloway>	 bearND: i saw your comment during standup about the tagging script changes.  i originally had it just warning the user if the latest deploy commit is old, but is there any reason not to automatically update the local deploy repo first?
[18:08:58] <bearND>	 mdholloway: that was mainly to avoid surprises and unexpected complications when a git pull fails
[18:09:29] <bearND>	 mdholloway: I don't feel very strongly about it, though
[18:09:34] <mdholloway>	 bearND: that's a good point
[18:09:37] <mdholloway>	 bearND: me neither :)
[18:12:32] <bearND>	 mdholloway: niedzielski: just uploaded https://gerrit.wikimedia.org/r/280952 and will schedule the cherry pick to be deployed on Monday morning once that one is merged
[18:13:09] <niedzielski>	 👍
[18:13:50] <mdholloway>	 bearND: cool
[18:14:05] <mdholloway>	 bearND: now with 100% fewer infinite redirect loops!
[18:14:30] <bearND>	 :)
[20:44:42] <dr0ptp4kt>	 bmansurov: oh, you beat me to it. i'll abandon my patch :)
[21:06:03] <bmansurov>	 dr0ptp4kt: sorry
[21:07:48] <dr0ptp4kt>	 bmansurov: no, that's what i get for not having all of my keys setup
[21:08:02] <bmansurov>	 :)
[21:21:49] <jhobs>	 bmansurov: some of the dependencies for that patch appear to be unmergable due to jenkins errors
[21:21:55] <jhobs>	 just in case it slipped by you
[21:22:25] <bmansurov>	 jhobs: yeah, but can we get the first depedency reviewed ?
[21:22:38] <bmansurov>	 https://gerrit.wikimedia.org/r/#/c/272968/ jhobs
[21:22:43] <jhobs>	 bmansurov: got a link? I'm going through all the patches but there's a bunch linked on the task
[21:22:44] <jhobs>	 ah thanks
[21:23:21] <bmansurov>	 jhobs: yeah sorry about links, the best way to find the first one is to go by the dependency links in gerrit
[21:23:38] <jhobs>	 bmansurov: yeah, I was working my way backwards; should've been doing the opposite
[22:51:57] <greg-g>	 jdlrobson: you're at the hackathon, right?
[22:54:55] <greg-g>	 jdlrobson: I got an answer, you are!