[01:20:16] <brion>	 coreyfloyd: sorry I'm still traveling, on Israel time still :)
[01:22:17] <coreyfloyd>	 brion: ok. I'll try to shoot you an email.
[01:23:00] <brion>	 coreyfloyd: well actually since your stillnonlime go ahead and ask now :)
[01:23:11] <brion>	 I'm awake ATM ;)
[03:12:54] <HaeB>	 mhurd_afk:  FYI https://phabricator.wikimedia.org/T131824
[07:01:31] <jdlrobson>	 hey joakino phuedx 
[08:06:48] <phuedx>	 morning y'all
[08:06:51] <phuedx>	 hey jdlrobson
[08:34:05] <phuedx>	 right, here now, with added power and a sleeping child
[09:14:18] <jdlrobson>	 hey phuedx back again
[09:14:25] <jdlrobson>	 just got lunch didnt i
[09:14:42] * phuedx is just reading email
[09:16:23] <joakino>	 hi jdlrobson !
[09:17:11] <jdlrobson>	 joakino: !
[09:17:18] <jdlrobson>	 i'm trying to make sense of webpagetest
[09:17:30] <jdlrobson>	 phedenskog: http://wpt.wmftest.org/result/160405_YZ_4D/ whoooopss :)
[09:17:31] <joakino>	 what's it doing
[09:17:50] <jdlrobson>	 hopefully i wont offend more people with emails today by not checking my email any more
[09:20:39] <joakino>	 haha
[09:21:04] <joakino>	 written communication is hard when there's that many people involved
[09:21:49] <phuedx>	 so many schema changes
[09:21:54] <phuedx>	 i'd forgotten about gather and thanks
[09:24:37] <jdlrobson>	 joakino: yeh :/
[09:25:41] <joakino>	 i'm going to tattoo "assume good faith" in my face
[09:26:05] <joakino>	 or alternatively put it in my email signature
[09:27:29] <jdlrobson>	 doh i missed out on sprint name voting - Kristen's Lans Stand
[09:42:36] <joakino>	 i've added a new one lol
[09:47:57] <phuedx>	 i'm in tracy island btw
[09:48:03] <phuedx>	 since there's three of us online
[09:48:07] <phuedx>	 -> party time
[09:52:35] <phuedx>	 joakino, jdlrobson: you're both familiar with gather so could you review https://gerrit.wikimedia.org/r/#/c/274115/ plz plz plz
[09:52:50] <jdlrobson>	 phuedx: surez
[09:52:57] <joakino>	 woo i'll head there in a minute
[09:53:01] <joakino>	 EU party time
[09:53:10] <joakino>	 gonna get some coffee
[11:10:44] <phuedx>	 did you just rage quit joakino 
[11:17:07] <hashar>	 he coffee quit apparently
[11:17:42] <joakino>	 command+q closing chrome that was
[11:39:03] <hashar>	 lets try the cheat code
[11:39:09] <hashar>	 Ctrl + F + O + O + D
[15:46:54] <mdholloway>	 dr0ptp4kt: you froze, i'll exit and come back
[16:06:07] <phuedx>	 yo
[16:09:24] <phuedx>	 bmansurov: you're happy with removing all of the dependencies from https://gerrit.wikimedia.org/r/#/c/274123/?
[16:10:09] <bmansurov>	 phuedx: yes that's fine
[16:10:12] <phuedx>	 cool
[16:10:37] <phuedx>	 i didn't want it to get bogged down in a somewhat political debate
[16:10:44] <bmansurov>	 good call
[16:10:45] <bmansurov>	 thanks
[16:12:25] <phuedx>	 bmansurov: C-2 might be appropriate for 273456 or a self C-1
[16:12:36] <phuedx>	 didn't want to offend with a -2 :)
[16:12:54] <bmansurov>	 let me see, i won't get offended by numbers btw ;)
[16:13:19] <bmansurov>	 phuedx: ok so is there consensus already?
[16:13:31] <phuedx>	 i don't think so
[16:13:41] <phuedx>	 i think there's a little debate as to the value of one of them
[16:13:41] <bmansurov>	 alright, i'm -1ing it
[16:14:02] <phuedx>	 so maybe the patch should not remove mobilemenu?
[16:14:11] <phuedx>	 i think i'll ask on the mailing list
[16:14:31] <bmansurov>	 that'd be good
[16:35:30] <joakino>	 if anybody wants to hangout i'm on tracy
[16:42:01] <jhobs>	 dr0ptp4kt: see email if I don't make it back to standup in time. Missed my bus.
[16:55:34] <bmansurov>	 joakino: you're not there
[16:57:21] <joakino>	 bmansurov: just left to walk the dog 5 min before standup
[16:57:32] <bmansurov>	 ook
[16:57:37] <joakino>	 bmansurov: come to standup
[16:57:42] <bmansurov>	 k
[17:01:04] <phuedx>	 dr0ptp4kt: ping ping
[17:01:06] <joakino>	 dr0ptp4kt: jhobs ping
[17:01:43] <jhobs>	 joakino: missed my bus, see email
[17:02:07] <joakino>	 sure jhobs !
[17:46:40] <bmansurov>	 phuedx: yt?
[17:48:38] <bmansurov>	 phuedx: left a comment on https://gerrit.wikimedia.org/r/#/c/281551/, a reply would be appreciated
[18:07:18] <phuedx>	 bmansurov: am now
[18:07:45] <phuedx>	 that's an interesting point
[18:08:18] <phuedx>	 bmansurov: i think that the best we can do is rigorous documentation on SkinMinerva#getPageActions
[18:08:25] <phuedx>	 and maybe inline docs on the first page action
[18:10:01] <bmansurov>	 phuedx: ok
[18:50:53] <jhobs>	 dr0ptp4kt: I noticed you added me on this week's leads sync as optional. Was there something specific you wanted me there for?
[18:51:20] <dr0ptp4kt>	 jhobs: general repping of reading web. you game?
[18:52:48] <jhobs>	 dr0ptp4kt: if you want. Although if I'd just be superfluous I'd probably rather keep my nose to the grindstone ;)
[19:01:57] <dr0ptp4kt>	 jhobs: you'd not be superfluous, maybe just fill in this time?
[19:04:14] <jhobs>	 dr0ptp4kt: ah ok.
[19:22:48] <dr0ptp4kt>	 jhobs: got a few minutes for tracy island?
[19:39:51] <phuedx>	 bmansurov: yt?
[19:41:32] <bmansurov>	 yes
[19:42:04] <phuedx>	 okie poke
[19:43:21] <phuedx>	 the docblock here is ever so slightly incorrect
[19:43:23] <phuedx>	 https://gerrit.wikimedia.org/r/#/c/281551/3/includes/skins/SkinMinerva.php,cm
[19:44:02] <bmansurov>	 phuedx: do you mean the display part?
[19:44:12] <bmansurov>	 should I just add something about jsonly class?
[19:44:38] <phuedx>	 docblocks aren't parsed as markdown so the backticks should be replaced by <code></code> blocks
[19:44:43] <phuedx>	 and there's no mention of the default
[19:45:11] <bmansurov>	 ok
[19:46:01] <phuedx>	 if the is_js_only part is missing, then it defaults to false per https://gerrit.wikimedia.org/r/#/c/281551/3/includes/skins/MinervaTemplate.php,unified (L132)
[19:46:03] <jhobs>	 dr0ptp4kt: sorry, missed that message. Still want to Hangout?
[19:46:25] <bmansurov>	 phuedx: right
[19:46:50] <phuedx>	 aside: i think the default to false is correct
[19:47:26] <dr0ptp4kt>	 jhobs: yeah. see you in a minute or two
[19:48:03] <dr0ptp4kt>	 jhobs: in ti
[19:48:18] <bmansurov>	 phuedx: anything else I should change before pushing?
[19:49:53] <phuedx>	 bmansurov: not that i can see -- i'll test it locally now
[19:50:04] <bmansurov>	 ok
[20:09:28] <phuedx>	 bmansurov: 👍
[20:09:40] <bmansurov>	 cool!
[20:09:55] <phuedx>	 alright, i'm off for the night
[20:10:10] <bmansurov>	 have a good one, phuedx
[20:10:10] <phuedx>	 jdlrobson: i'm going to finish off your review early tomorrow morning
[20:10:20] <phuedx>	 i'm still thinking over the inject-into-dom thing
[20:10:38] <phuedx>	 <3 <3 <3
[22:04:50] * mdholloway -> haircut :|