[08:30:00] o/ [08:55:51] o/ [08:56:02] not like I am active on the mobile front.. [08:58:47] no… [08:58:55] you just support everything we do ^.^ [08:58:57] <3 [09:38:05] my only concern really is mobile apps becoming more and more bloatware [09:38:19] barely running on phones that are considered too old :-D [09:38:32] one sure thing, the Wikipedia app "near by" is a killer feature [09:47:57] hashar: have you voiced your concerns/praise to the apps teams? [09:48:06] (i'm pretty sure they all get scrollback though…) [09:54:25] phuedx: the Wikipedia Android app runs just fine on my old Galaxy Nexus (iirc the first Google phone) [09:54:49] phuedx: I had an issue with image rendering at some point, I did send the crash report and apparently it got fixed :-} [09:55:57] (the apps teams are awesome) [11:02:26] alright -- i'll be out for a while [11:13:01] bb phuedxo [11:21:37] out to walk dog + lunch [13:29:51] brion: hey just sent an email with the issue that I wanted to talk to you about - I know you are traveling - so that may be easier. [15:02:07] joakino: I'm on whenever you're ready :) [15:07:00] hashar: hello! we have a new tab bar design in progress that i think will feel a lot more streamlined. btw, we have an upgrade to 4.0 of the Mapbox library coming very soon [15:07:18] hashar: we do try to support older devices, but it's definitely one of the more challenging aspects of app development and has to be balanced against providing a modern experience for modern devices. it's not just the hardware on old devices that's an issue, it's the OS software that is no longer updated and contains many quirks [15:08:44] niedzielski: yeah I fully understand some new features / experiences needs API that are only available in recentish Androids :-} [15:09:11] my rant is merely that developers seems to have very powerful full and don't really care about performance on older devices (not our mobile team, in general) [15:09:38] or maybe some apps ends up being super slow because they fallback to some crappy back compatibility layer that does not perform well [15:10:40] niedzielski: one sure thing, The wikipedia app works just fine on my Galaxy Nexus ;-} [15:12:49] hashar: i think most of our performance tuning has been focused around network and memory usage. i don't think we do that much computation in app so in some ways we're at the mercy of the os and the third party libraries we choose [15:47:32] yo baby\ [16:09:25] niedzielski: yeah I would blame the OS for most CPU intensive things ;-) [16:09:52] anyway heading back home! [16:58:58] dr0ptp4kt: where (if anywhere) in the Q3 deck should I put all the things that we did instead of the things that were supposed to be our goals? (PageImages, Gather, ...) [16:59:08] phuedx: hi, are you not going to CREDIT (brownbag) which is at 2 today? [17:01:46] bd808: just clone the web slide, i'd say [17:01:54] bd808: and put it below the table row [17:02:21] bmansurov: phuedx jhobs jdlrobson joakino nzr i'll be there shortly, don't wait [17:02:27] ok [17:12:40] dr0ptp4kt: finally found that slide. thanks [17:13:16] bd808: i should have said which number :) [17:32:43] joakino: meeting's starting [18:21:24] mdholloway bearND: are we still doing prioritization today? [18:21:57] not sure [18:22:33] bearND: niedzielski: we have a growing 'needs triage' column but it might be good to postpone for tomorrow or fri when dbrant is back [18:22:58] i could do either way [18:23:31] mdholloway: niedzielski : then let's postpone [18:27:50] mdholloway bearND: ok sounds good [18:30:46] kaity__: fyi, we're postponing the triage meeting [18:31:20] bearND: ok cool thanks for letting me know [18:34:50] bearND: niedzielski: kaity__: doesn't look like i can edit the event [18:35:33] only maxbinder can? (i could just be bad at google calendar and missing something, too.) [18:43:41] i guess so [19:04:01] bearND: mdholloway niedzielski-afk Can you guys groom without me today? DB is out, too. [19:04:35] maxbinder: we're postponing until DB is back but we had not been able to edit the invite [19:04:36] maxbinder: yeah, we were actually thinking of postponing until later this week. [19:04:47] maxbinder: will you be joining us generally or are you busy with web stuff? [19:10:58] mdholloway: bearND niedzielski-afk I will make it modifiable. Generally, I won't join to groom, unless you'd find it useful that I do. Just wanted to call it out today because I have not update the calendar yet. (Slow to roll out new schedule with all the traveling lately). [19:11:41] you should be able to move it now [19:17:35] maxbinder: yep, thanks! [19:21:04] bearND: should i +2 your services patch fixing html entity encoding (https://gerrit.wikimedia.org/r/#/c/281588/) to deploy today or should we see if mobrovac or gwicke want to have a look? [19:26:26] mdholloway: it looked fine to me the last time I skimmed it [19:27:10] mdholloway: just to make sure: html5-entities also does decodeURIComponent? [19:33:32] Pchelolo: i don't see decodeURIComponent as part of it: https://github.com/mdevils/node-html-entities/blob/master/lib/html5-entities.js [19:34:15] mdholloway: I've been making the same thing for restbase (we will move it to RB soon) and got issues with pages like this: http://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User:Pchelolo%2fRedirect_Test [19:34:35] where where redirect contains uri-encoded symbols. [19:34:58] could be nice to make sure new code will work for pages like that? [19:35:00] Pchelolo: i see. i'll add that page to this patch and run the tests [19:41:22] Pchelolo: good catch. this patch fails on your redirect test page [19:41:59] mdholloway: we've just discussed this with gwicke, we also need to consider the possibility of section redirects which have # [19:45:53] mdholloway: One more thing: we're currently working on moving the redirect handling to RESTBase (https://github.com/wikimedia/restbase/pull/591) [19:46:25] To make mobile service independent of this work-in-progress, could you please add ?redirect=no to your requests to RESTBase? [19:46:43] so that our redirecting logic will not interfere with yours. [19:46:43] Pchelolo: sure, i'll do that now [19:47:16] We will remove it once we stabilise our redirect handling and remove redirect handling from mobile service [19:47:17] Pchelolo: do you anticipate that will be merged & deployed soon enough to make this redirect-handling patch moot? [19:47:20] Pchelolo: gwicke: so, should we put my patch on hold then? [19:47:52] mdholloway: actually, better ?redirect=false [19:48:07] Pchelolo: ok [19:48:28] mdholloway: redirecting in RESTBase will not be deployed for some time, so you have plenty of time to add this. [19:50:35] bearND: since i added a test, i just pushed a new version of the patch to gerrit. it'll fail the test suite. [20:08:22] Pchelolo: so just like this https://gerrit.wikimedia.org/r/#/c/281989/1/config.dev.yaml , with a corresponding change in puppet as well for production? [20:14:05] mdholloway: I think it would be easier to just add that in code, because it's a temporary thing and config deploy is harder that normal code deploy. But up to you, the changes look good to me [20:18:30] Pchelolo: yeah, probably better idea to do in code, i'll update [20:46:04] mdholloway: Pchelolo : I've added another test and the decodeURIComponent call to it. https://gerrit.wikimedia.org/r/281588. Not sure why your test fails but my new ones don't. Is it because of using beta labs? I don't see any significant difference in the way the redirect is done [20:47:01] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Pchelolo/Redirect_Test&action=edit vs https://test.wikipedia.org/w/index.php?title=User:BSitzmann_(WMF)/MCS/Test/redirect_test2&action=edit [20:47:44] your URI gives me a 404 when running the test [20:49:14] bearND: I might have written an invalid test, looking [20:53:17] mdholloway: i've updated the URI slightly to use mobile-sections instead of html (Parsoid) [20:54:20] bearND: ok, that's what i was just checking out [20:57:15] bearND: ok, i got it [20:57:57] bearND: the /api/rest_v1/ portion of the path for that request also needs to be changed to just /v1/ [20:58:40] bearND: and then the expected title should be 'User:Pchelolo/Redirect_Test %' [21:00:16] bearND: er, 'Redirect Target %' that is [21:00:57] mdholloway: doh about the URI, lol. Yes I noticed the expected redirected title was wrong, but got hung up on the 404. Thanks! [21:08:20] mdholloway: Pchelolo : updated the test. It's happy now. [21:09:02] FlorianSW: are you here by chance [21:09:19] Deep6: I'm always here :P [21:09:22] No, I'm here, what's up? [21:09:24] yayyyyyyy [21:09:33] using your google auth plugin and well.... [21:09:37] running into some challenges [21:09:45] wondering if you can assist [21:09:50] sorry if it's rude to track you down here [21:10:01] I can try it, if you describe the problem :P [21:10:13] sure may I pm you [21:10:14] ? [21:11:13] you can do it here, or in #wikimedia-dev or if you want, private. [21:11:23] Deep6: ^