[07:27:19] <joakino>	 morning world
[07:34:34] <joakino>	 is there a way to see removed comments in phabricator?
[08:15:10] <phuedx>	 joakino: in your email history?
[08:15:19] <phuedx>	 :/
[08:18:11] <joakino>	 phuedx: I told phabricator to not send me email
[08:18:16] <joakino>	 brr
[08:18:57] <joakino>	 now I check https://phabricator.wikimedia.org/notification/query/unread/ instead
[08:31:13] <phuedx>	 hanging out in tracy
[08:31:23] <phuedx>	 (and rocking out)
[09:20:11] <jdlrobson>	 phuedx: https://gerrit.wikimedia.org/r/#/c/282877/
[09:20:20] <jdlrobson>	 looks like that's the problem. Gonna try work out what happened
[09:25:18] <phuedx>	 jdlrobson: https://phabricator.wikimedia.org/T1321 provides detail (pointed to by hashar elsewhere)
[09:27:55] <jdlrobson>	 phuedx: not sure that's related...? old bug from 2014
[09:27:58] <jdlrobson>	 this only started recently.
[09:30:54] <jdlrobson>	 Not seeing anything suspicious in integration/config but there were LOTS of changes Friday
[10:09:39] <phuedx>	 jdlrobson: any joy?
[10:10:35] <jdlrobson>	 Phuedx Nah couldn't work anything out. I'm off for lunch and am gonna resume working later now. So feel free to do some sleuthing
[10:10:57] <jdlrobson>	 The problem I have is I don't quite understand how that job is all put together and which repos I should be looking at and what can break it
[10:11:07] <jdlrobson>	 Switching to chrome however does seem to fix it
[15:03:56] <jdlrobson>	 \o
[15:10:22] <niedzielski>	 o/
[15:11:12] <phuedx>	 jdlrobson: context is incredibly important, and tracking down what caused the breakage is too, but i'm tempted to merge 282877
[15:11:22] <phuedx>	 and investigate more on the phabricator task/email even
[15:11:25] <jdlrobson>	 phuedx: yeh i know i'm suffering from the same. Let's wait till SF wakes up
[15:11:45] <jdlrobson>	 i'll be working till 11pm and can merge then worse case
[15:42:59] <jdlrobson>	 phuedx: https://gerrit.wikimedia.org/r/#/c/280470/
[15:43:02] <jdlrobson>	 this looks like it
[15:45:02] <phuedx>	 jdlrobson: GET IT IN THE COMMIT MESSAGE :D
[15:45:10] <jdlrobson>	 phuedx: i'm just grokking the code
[15:45:12] <jdlrobson>	 seems to fit
[15:47:57] <jdlrobson>	 phuedx: don't really understand the code, but probably is the culprit
[15:48:12] <jdlrobson>	 because of timeframe and the fact it is fiddling with browser config
[15:49:08] <jdlrobson>	 phuedx: i'm happy for you to merge if you're keen to blast through the pending code review
[15:49:23] <jdlrobson>	 i'm confident enough this is the cause although only 60% sure
[15:49:54] <phuedx>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/280470/5/lib/mediawiki_selenium/environment.rb,cm
[15:50:06] <phuedx>	 browser_spec defaults to firefox
[15:50:43] <jdlrobson>	 phuedx: but our config was firefox before
[15:50:52] <phuedx>	 eh?!
[15:51:04] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/282877/3/tests/browser/environments.yml
[15:52:24] <phuedx>	 ok…
[15:53:36] <niedzielski>	 bearND mdholloway|biab dbrant|brb: Hello! I'm going to remove the page ID from the page list table WIP patch. Page ID is definitely what we want. Unfortunately, there are many places in the codebase where a PageTitle is kept but a page ID is not. I mention it because a) it makes me sad and b) it will be difficult to ever change this since if we lat
[15:53:36] <niedzielski>	 er add the column we'll have to re-query all pages.
[15:55:02] <jdlrobson>	 phuedx am pretty sure that before we ran tests in chrome but i can't find an old test failure video to confirm that.
[15:58:45] <phuedx>	 jdlrobson: so is it that that environments.yml setting is now being picked up?
[15:58:54] <jdlrobson>	 that's what seems to be happening
[16:00:45] <maxbinder>	 jdlrobson: phuedx retro
[16:01:05] <maxbinder>	 jhobs: you joining retro?
[16:01:52] <bd808>	 coreyfloyd: _joe_ ins looking for you in #wikimedia-operations for a puppet swat patch
[16:03:00] <mdholloway>	 niedzielski: is there any harm in keeping it in, with a plan to later incorporate Page ID into the codebase as a (probably pretty epic) tech debt task?
[16:03:34] <phuedx>	 maxbinder: inbound
[16:05:26] <bearND>	 niedzielski: thanks for the heads-up. I understand
[16:05:42] <niedzielski>	 mdholloway: we could. i'm somewhat hesitant to though because then i can't put a constraint on the column and SQLite doesn't directly support column drops (you have to move the table, make a new table, copy the contents, and drop the old table). if we added it, we wouldn't want to use it until we knew the column was fully populated since otherwise 
[16:05:42] <niedzielski>	 we'd have to support two flows
[16:07:00] <phuedx>	 nice work jdlrobson
[16:07:47] <phuedx>	 i see that it's merged
[16:09:35] <mdholloway>	 niedzielski: i see.  yeah, i definitely share your sadness but removing page ID makes sense given the current constraints.
[16:15:48] <Niharika>	 jdlrobson: Around? I'm trying to setup your diff patches on commtech.wmflabs.org instance. I fetched both of the relevant patches. What else do I need to do in order to make them visible?
[16:32:35] <niedzielski>	 dbrant: do you mind if i rebase your UI patches onto the database table patches? it seems like it would be a legitimate (although currently changing) dependency
[16:33:20] <dbrant>	 niedzielski: sure, go for it
[16:33:50] <niedzielski>	 👍
[16:43:09] <niedzielski>	 dbrant: do you want me to push integration changes as amendments or as dinstinct patches on top? i think the latter will create more reviews but be easier to follow
[16:43:43] <dbrant>	 niedzielski: yep, the latter!
[16:56:32] <Pchelolo>	 bearND: mdholloway: quick question: was https://gerrit.wikimedia.org/r/#/c/281989/ deployed in labs?
[17:01:31] <bearND>	 Pchelolo: it should have been deployed automatically in labs a few minutes after it got merged
[17:01:53] <bearND>	 going to check
[17:01:57] <Pchelolo>	 bearND: ah, ok, cool. thank you, just double checking
[17:04:24] <bearND>	 Pchelolo: the latest code has been deployed there. I just checked the output of http://appservice.wmflabs.org/en.wikipedia.org/v1/page/mobile-sections/Cat, and it has the latest output
[17:04:43] <bearND>	 (the 320px lead image)
[17:05:30] <Pchelolo>	 bearND: ok, thank you
[17:07:51] <bearND>	 Pchelolo: btw, https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps#Deployment_on_labs_machine has the info for the labs instance
[17:20:27] <jdlrobson>	 bmansurov: it's fine from my opinion to merge https://gerrit.wikimedia.org/r/#/c/281995/
[17:20:40] <jdlrobson>	 i'm going to ping Erik first though in case he has any ideas
[17:20:49] <bmansurov>	 jdlrobson: ok
[17:22:19] <jdlrobson>	 bmansurov: short of it, is i'd like it merged before 3pm PST today, so I can SWAT it asap
[17:22:35] <bmansurov>	 alirght
[17:46:31] <jdlrobson>	 tgr: are you around?
[17:47:19] <jdlrobson>	 tgr: are you able to help me re-run the queries you made on https://phabricator.wikimedia.org/T121135#1928995 ? I don't have permission to run those queries.. :/
[17:57:40] <jdlrobson>	 ^ phuedx not sure if you are able to do that
[18:00:57] <bmansurov>	 jdlrobson: so should I merge then? or are you still waiting for Erik?
[18:03:20] <jdlrobson>	 bmansurov: I'd like to be more confident going into a SWAT this would fix it, but right now I'm not sure how I can debug further without someone with deploy rights unfortunately :/ can you check back in with me in an hour?
[18:03:34] <bmansurov>	 sure
[18:03:40] <jdlrobson>	 thanks bmansurov 
[18:08:48] <phuedx>	 jdlrobson: phuedx@bast3001:~$ ssh mw1152
[18:08:48] <phuedx>	 Permission denied (publickey).
[18:08:52] <phuedx>	 unfortunately
[18:08:56] <jdlrobson>	 doh
[18:41:01] <tgr>	 jdlrobson: same result; do you want me to look at something more specific?
[18:41:18] <jdlrobson>	 tgr: i'm keen to know what the value of ParserOutput->getTOCEnabled is for that page
[18:41:29] <tgr>	 sorry for not helping with that bug by the way; I do care but I'm really really late with my own work
[18:41:46] <jdlrobson>	 and also the value of getTOCHTML
[18:42:17] <jdlrobson>	 tgr: no worries i completely understand
[18:42:35] <jdlrobson>	 could you look at the page "Monmouth_(Oregon)" as well?
[18:42:37] <tgr>	 first is false, second is https://phabricator.wikimedia.org/P2886
[18:42:58] <jdlrobson>	 ok interesting. I need to work out why the first is false
[18:43:01] <jdlrobson>	 that's unexpected
[18:44:40] <tgr>	 https://phabricator.wikimedia.org/P2887
[18:45:17] <jdlrobson>	 thanks tgr that's super useful
[18:45:24] <jdlrobson>	 so that confirms my suspicions that $parserOutput->getTOCEnabled()  is to blame
[18:46:23] <jdlrobson>	 bmansurov: you can merge now :) ^ i can investigate later
[18:46:29] * jdlrobson hugs tgr
[18:46:32] <bmansurov>	 ok
[19:01:19] <tgr>	 phuedx: you are in deployers so maybe a configuration problem?
[19:01:59] <phuedx>	 indeed
[19:12:33] <tgr>	 jdlrobson: you should be able to ssh into mw1152 / run mwscript as well
[19:13:37] <tgr>	 https://github.com/wikimedia/operations-puppet/blob/production/modules/admin/data/data.yaml#L58
[19:19:28] <phuedx>	 tgr: most likely it's a config problem
[19:19:52] <phuedx>	 … then!
[21:45:14] <FlorianSW_>	 dbrant: quick question: I think we don't have the resources to maintain a new version of the Wikipedia app in Google Play with the only difference, that the GET_ACCOUNTS permission isn't used, right? (Background: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=9096762#), especially that this isn't needed anymore for Android 6.0 devices.
[21:52:37] <dbrant>	 FlorianSW_: i'm sure it's *possible*, but I don't think it would be the right way to go.  This is simply the direction in which the app is going. There's just some really bad nomenclature and connotations surrounding the "identity" permission, but it really is necessary for the current and future features that we're planning for the app.
[21:54:08] <FlorianSW_>	 dbrant: I know that, but I think the request of the user is (like you say) valid and would be *possible* (I don't think that we should do that), but I want to recheck with you, so the user doesn't think, that he just fails on me :)
[21:55:58] <dbrant>	 FlorianSW_: sure, no doubt. We should do our best to provide as much clarity on this as possible. (and thanks for helping with doing that!)
[21:56:18] <FlorianSW_>	 dbrant: np :)
[23:32:15] <dbrant|bbl>	 bearND: I see that the remote config is at 100%! can you confirm?
[23:33:21] <bearND>	 dbrant: yes! It's live. Finally! Sorry I forgot to check today.
[23:33:55] <dbrant>	 bearND: excellent! i'll update the Play store description, and send out a note.