[08:09:48] <phuedx>	 good morning y'all
[08:52:56] <joakino>	 morning!
[08:54:36] * joakino is going to get some coffee
[09:20:50] * phuedx is working from his hammock today
[09:21:15] * phuedx still needs to sort out a wifi range extender
[09:22:02] <joakino>	 noice
[09:41:31] * phuedx is in tracy
[13:57:00] <coreyfloyd>	 niedzielski-apk: what do i need to test to verify this? https://phabricator.wikimedia.org/T129104#2223352
[15:11:37] <niedzielski>	 coreyfloyd: i'm not really sure there's much reason to have an account if you're not doing the translations
[15:12:19] <niedzielski>	 coreyfloyd: i think if you login to translatewiki.net via SSH that should be sufficient to verify the task
[15:28:11] <coreyfloyd>	 niedzielski thanks!
[15:28:20] <coreyfloyd>	 yeah i just want to be able to get that ticket closed
[16:05:31] <joakino>	 i'm in tracy if somebody wants to talk about something
[16:06:37] <FlorianSW>	 bearND: https://phabricator.wikimedia.org/T126101#2223913 hey ya! :D
[16:08:24] <hashar>	 jdlrobson: bmansurov: if you are around  I have enabled selenium tests for Popups extension but the fail right now
[16:08:35] <jdlrobson>	 hashar: yup we've seen. The test is broken
[16:08:38] <jdlrobson>	 we're working on fixing it.
[16:08:40] <hashar>	 jdlrobson: bmansurov should I drop the job and move it to experimental?  (so you can trigger it manuall)
[16:08:46] <jdlrobson>	 ie. they are doing the right thing don't drop them
[16:08:53] <hashar>	 I dont want that to block further dev on Popups
[16:09:01] <hashar>	 oh nice
[16:09:12] <hashar>	 the only thing I "fixed" was to inject BetaFeatures
[16:09:32] <jdlrobson>	 hashar: yeh seems it's exposed an issue in BetaFeatures too which we're looking into
[16:09:37] <jdlrobson>	 well i am :)
[16:09:41] <hashar>	 awesome
[16:09:56] <hashar>	 https://gerrit.wikimedia.org/r/#/c/284443/ is tip of master  +  a config switch to force registration in beta features
[16:10:03] <hashar>	 but apparently Popups doesn't show there 
[16:10:41] <hashar>	 if you get a fix for BetaFeatures,  you can test it out by editing the Popups change with a Depends-On:  header and that should make it green
[16:10:49] <hashar>	 good luck!
[16:11:19] <jdlrobson>	 Yup it's not opting in correctly - bmansurov is on it https://gerrit.wikimedia.org/r/284449
[16:11:40] <bmansurov>	 yeah
[16:21:42] <jdlrobson>	 bmansurov: ill look into the BetaFeatures issue if that's okay
[16:21:57] <bmansurov>	 sure
[16:57:06] <jdlrobson>	 hey bmansurov i got a fix up
[16:57:15] <jdlrobson>	 do you need help with the hovercards browser test?
[16:57:17] <bmansurov>	 cool
[16:57:25] <jdlrobson>	 tgr: https://gerrit.wikimedia.org/r/#/c/284485/
[16:57:30] <bmansurov>	 if you have bandwith
[16:57:38] <jdlrobson>	 bmansurov: sure np
[16:57:42] <jdlrobson>	 i have lots of bandwidth today
[16:57:50] <bmansurov>	 go for it
[17:06:35] <tgr>	 jdlrobson: this sounds like NewHTMLCheckField is broken and needs to be fixed, instead of just changing the test to expect the wrong result
[17:06:59] <jdlrobson>	 tgr: we should revert your patch then
[17:07:03] <jdlrobson>	 since that introduced the issue
[17:07:06] <jdlrobson>	 and investigate this some more
[17:07:14] <tgr>	 it inverts the value twice which does not make a lot of sense to me, so maybe some kind of merge error?
[17:07:26] <jdlrobson>	 i wasnt too familiar with the phpunit test but it looked like it had been written wrong (not clear where it asserts that it should be checked)
[17:08:19] <tgr>	 I might be misunderstanding the situation, but you wrote "The default value of the NewHTMLCheckField was true before but it was not rendering the checkbox as checked" so it sounds like that widget was broken from start?
[17:12:44] <tgr>	 jdlrobson: if this is getting in the way of something more urgent then IMO markTestSkipped is the right way to work around it
[17:13:10] <jdlrobson>	 tgr: if a test is failing i'd rather we revert the patch that introduced it
[17:13:14] <jdlrobson>	 it could be surfacing larger problems
[17:13:20] <jdlrobson>	 we should understand what's going on
[17:13:39] <jdlrobson>	 maybe we can hangout quickly after my standup so i can explain?
[17:14:57] <tgr>	 sure
[17:15:16] <tgr>	 I don't understand what's breaking though
[17:15:34] <tgr>	 shouldn't Jenkins have run this test when the nodata patch was merged?
[17:16:01] <jdlrobson>	 tgr: gimme 5 mins and we'll chat
[17:16:08] <tgr>	 ok
[17:20:08] <phuedx>	 jdlrobson: i had a quick pass at 284449 (which was passing locally) and it's still failing on the build node
[17:25:52] <jdlrobson>	 phuedx: yeh it will
[17:25:58] <jdlrobson>	 phuedx: see my comment. I'm gonna take a new pass at it
[17:26:28] <phuedx>	 jdlrobson: see PS4
[17:27:02] <jdlrobson>	 hah okay :)
[17:27:04] <jdlrobson>	 lemme see
[17:28:57] <jdlrobson>	 phuedx: passes for me locally so I suspect it's a timing issue now
[17:29:00] <jdlrobson>	 lemme try something
[17:40:58] <phuedx>	 jdlrobson: it's not loading the hovercards module?
[17:41:27] <jdlrobson>	 phuedx: that seems to be what's being reported.. am trying to work out why
[17:41:50] <jdlrobson>	 phuedx: ahh
[17:41:58] <jdlrobson>	 if ( !$registry->isLoaded( 'TextExtracts' ) || !class_exists( 'ApiQueryPageImages' ) ) { return true; }
[17:42:05] <jdlrobson>	 PageImages and TextExtracts. We'll need a hashar for this
[17:42:10] <phuedx>	 there it is
[17:42:13] <jdlrobson>	 there is?
[17:42:16] <phuedx>	 derp derp
[17:42:18] <jdlrobson>	 o_O
[17:42:24] <jdlrobson>	 ah i missed the it
[17:42:33] <jdlrobson>	 phuedx: why does it show up in preferences though?!
[17:42:35] <jdlrobson>	 that's super weird
[17:42:38] <phuedx>	 bug
[17:42:40] <phuedx>	 bug
[17:42:40] <phuedx>	 bug
[17:43:05] <jdlrobson>	 yup yup yup
[17:43:06] <jdlrobson>	 on it
[17:43:49] <hashar>	 jdlrobson: if you need more dependencies to be injected, poke #wikimedia-releng
[17:44:07] <jdlrobson>	 hashar: who should i poke there?
[17:44:08] <jdlrobson>	 you?
[17:44:09] <jdlrobson>	 :)
[17:44:41] <hashar>	 jdlrobson: it should be just about editing a dict in integration/config  zuul/parameter_functions.py
[17:44:45] <phuedx>	 jdlrobson: https://gerrit.wikimedia.org/r/284494
[17:44:47] <phuedx>	 hashar: ^
[17:44:57] <hashar>	 get it a +2 / merge then   run  fab deploy_zuul  :D
[17:45:12] <phuedx>	 https://gerrit.wikimedia.org/r/284494
[17:45:28] <phuedx>	 ok, clipboard
[17:45:29] <phuedx>	 w/e
[17:46:02] <hashar>	 poked folks there
[17:46:19] <hashar>	 I am going idle / afk  gotta prepare dinner / cleanup kitchen etc
[17:47:08] <phuedx>	 jdlrobson: i'd be tempted to roll back your patch set on the test change because of the introduction of sleeps
[17:47:14] <phuedx>	 (maybe even mine too)
[17:47:47] <phuedx>	 actually, the tests might even pass w/o 284449
[17:48:17] <jdlrobson>	 lol https://phabricator.wikimedia.org/T125451
[17:48:24] <jdlrobson>	 phuedx: ^^ seems like i wasted some more time
[17:48:53] <phuedx>	 hahaha
[17:49:41] <jdlrobson>	 upped it to medium
[17:56:00] <jdlrobson>	 phuedx: i only introduced one sleep
[17:56:02] <jdlrobson>	 i removed 2
[17:57:00] <jdlrobson>	 the sleep I added is an unnecessary evil as it will always pass otherwise
[18:04:07] <phuedx>	 jdlrobson: v
[18:04:11] <phuedx>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/284495/
[18:04:12] <phuedx>	 even
[18:06:54] <bmansurov>	 phuedx: are you reviewing/testing the ToC patch?
[18:07:05] <phuedx>	 bmansurov: not right now
[18:07:18] <bmansurov>	 phuedx: should I wait until you do, or can I +2?
[18:07:26] <hashar>	 that is lovely
[18:07:38] <phuedx>	 +2 if you're happy with it bmansurov 
[18:07:41] <phuedx>	 i trust your judgement
[18:07:51] <hashar>	 I did not even know about tests/browser/LocalSettings.php :D
[18:08:05] <hashar>	 it has [WIP] in summary though :D
[18:08:30] <bmansurov>	 phuedx: ok, i'll test a little more on real devices and I'll merge it
[18:09:06] <phuedx>	 hashar: removed the wip ;)
[18:09:39] <phuedx>	 (just)
[18:10:33] <phuedx>	 hashar: thanks for your help earlier <3
[18:10:34] <joakino>	 phuedx: get out of here
[18:10:40] <phuedx>	 ok ok
[18:10:44] <phuedx>	 i'm going i'm going
[18:10:53] <joakino>	 ;)
[18:20:48] <jdlrobson>	 bmansurov: did you catch what phuedx had in mind with https://gerrit.wikimedia.org/r/#/c/284495/2 ?
[18:21:03] <bmansurov>	 let me see
[18:21:50] <bmansurov>	 jdlrobson: looks like the patch is just adding the config variable needed for tests
[18:21:57] <jdlrobson>	 but how was it passing before?
[18:22:13] <bmansurov>	 jdlrobson: i don't think tests were running before
[18:22:19] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/284449/ < ?
[18:22:50] <bmansurov>	 jdlrobson: oh yeah that one is a superset of sam's patch
[18:22:55] <bmansurov>	 the config is also enabled in it
[18:23:16] <bmansurov>	 we can ignore sam's patch if that one gets merged
[18:23:24] <jdlrobson>	 oh i see
[18:25:03] <maxbinder>	 JoshM_: where you wanna meet?
[18:25:39] <phuedx>	 mdholloway: don't know if you ended up playing this in your jakob exploration
[18:25:42] <phuedx>	 but play this: https://vimeo.com/11750910
[18:25:49] <phuedx>	 really, really, REALLY loud
[18:28:14] <mdholloway>	 phuedx: doing :)
[18:28:18] <mdholloway>	 phuedx: how was the show?
[18:28:37] <phuedx>	 better than the last time i saw them
[18:28:42] <phuedx>	 and i wouldn't shut up about that time
[18:28:48] <mdholloway>	 phuedx: i got through solace and most of cale:drew before i moved venues and got distracted
[18:28:50] <mdholloway>	 very good stuff
[18:29:09] <phuedx>	 subsets of sets is also worth a listen
[18:29:12] <tgr>	 hashar: is https://github.com/wikimedia/integration-config/blob/master/jjb/mediawiki.yaml#L374 the list of extensions whose tests run on core patches?
[18:32:17] <hashar>	 tgr: yes
[18:32:23] <hashar>	 tgr: it is barely maintained
[18:32:44] <hashar>	 ideally we would need to inject the list of extension dynamically from whatever list we use to cut the wmf branches
[18:32:57] <hashar>	 and for REL* branches uses the extensions we bundle in the tarball
[18:33:04] <tgr>	 is it that short for perf reasons or just lack of interest?
[18:33:05] <hashar>	 guess I have been too lazy so far to finish that
[18:33:11] <hashar>	 lack of interest
[18:33:17] <hashar>	 and some repos conflict with each others
[18:33:38] <hashar>	 Scribunto also used to be there but its tests are taking minutes which slow down everyone
[18:33:53] <hashar>	 moreover, that job could be considered as an integration tests of mw + extensions deployed or bundled
[18:34:07] <hashar>	 so in that context, we should filter out tests we do not care about. Such as unit tests of extensions
[18:34:39] <hashar>	 I had some discussion with releng team about splitting tests in tiers / groups.  But that is only words for now
[18:36:49] <tgr>	 thanks; I was curious after breaking BetaFeatures with a core patch
[18:37:20] <tgr>	 it would certainly be nice if all extensions were tested with core once a day or something like that
[19:06:10] <maxbinder>	 Dbrant I'm out for grooming, took a walk with Josh and ended up far from the office, so I'm gonna explore lunch :-) 
[19:06:29] <dbrant>	 maxbinder: np
[19:30:42] <mdholloway>	 be there 2 minutes