[08:24:42] o/ [09:49:31] even quieter than usual in here today [10:23:11] yow! [10:23:14] hi phuedx [10:23:24] i forgot to open irc :o [10:27:36] lol [15:05:18] dbrant: sprint cards for 81 ready? [15:06:35] maxbinder: will populate now! I should leave the sprint-80 tag on the tasks, as well, correct? [15:07:44] dbrant: yes please, lemme know when you're done and I'll archive 80 [15:09:04] maxbinder: done [16:03:41] joakino nzr kickoff [16:28:36] mdholloway: bearND: Is that possible to access some page from labs in an android app? We're about to deploy redirect handling to prod, I wanted to ask you to make a quick sanity check on how the app handles it [16:29:30] Pchelolo: yes, we have a special developer setting that allows you to change the RESTBase URI pattern [16:30:06] To enable developer options either use the alpha or dev build, or tap 7 times on the logo in the About screen [16:30:06] bearND: could you please try to load this page: User:Pchelolo/Temp/Redirect ? [16:30:18] bearND: I don't have any android devices [16:30:22] Pchelolo: will do [16:33:57] Pchelolo: ok, i guess i misunderstood earlier. FYI, The step I mentioned are for using the MCS instance on labs or a local dev machine. Accessing labs is a bit different. Would have to change the mediaWikiBaseUri for that. [16:34:24] bearND: do you think the app will handle a redirect loop correctly? [16:36:50] Pchelolo: I only find User:Pchelolo/Temp/Redirect2. Is this what you want? [16:37:10] It displays "Test" [16:37:18] bearND: no, we need User:Pchelolo/Temp/Redirect [16:37:45] bearND: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Pchelolo/Temp/Redirect&redirect=no [16:40:49] Pchelolo: hmm, doesn't work. Was using a release build because I was in the middle of code changes. I can send you more details later [16:41:39] bearND: what do you mean under "doesn't work" it should not show you anything, bc this page is a redirect to itself. Just it should not crash the app or something like that [16:42:24] Pchelolo: the app did not crash. It just showed "unknown error". [16:44:19] bearND: aha.. that means the redirect limit exceeded wasn't properly handled.. And what happens for https://en.wikipedia.org/w/index.php?title=User:Pchelolo/Temp/Redirect_Test&redirect=no ? [16:44:26] (note, it's a prod wiki) [16:58:58] bearND: do you think we should proceed with deployment of this new redirect handling? [17:01:01] Pchelolo: ok, just got the result. The automatic fallback we built into the app threw me for a loop first. I get a 400 HTTP code for https://en.wikipedia.org/api/rest_v1/page/mobile-sections-lead/User%3APchelolo%2FTemp%2FRedirect_Test [17:02:19] bearND: and what used to happen for pages like this before (https://en.wikipedia.org/w/index.php?title=User:Pchelolo/Temp/Redirect_Test&redirect=no) [17:02:23] The app then just displays "An unknown error occurred. 400 Bad Request." [17:03:33] Pchelolo: Not sure what you mean with before [17:03:42] before what? [17:04:08] bearND: labs have new redirecting code right now. Prod doesn't have it yet. Before = before this deployment which I'm doing right now [17:05:11] so, could you please have a look at the prod page I've sent you in the app? So that we're sure we don't actually regress and pages like this were already broken before new redirect handling [17:07:33] Pchelolo: it seems to be broken with the old way and the new one. Just the error message in the app was more informative with the old way. [17:08:42] bearND: that's bad we've regressed, but I suppose it's not a blocker? redirect loops a pretty rare.. And we're fixing a lot bigger problem with new redirect logic. Do you think we can proceed? [17:09:18] The error message for a redirect loop is something we can't fix server-side I suppose.. [17:11:33] Pchelolo: i don't think it's a blocker, but I am going to look into logcat later to see what's going on. Have a standup to attend in a few minutes [17:11:51] bearND: ok, thank you for assistance on this one [17:17:28] coreyfloyd: reets standup [17:30:58] niedzielski: i'm sure it's possible to do everything async, but i think it's complex enough to warrant future iterative patches, one interaction at a time. [17:32:43] niedzielski: we could also accept an MVP of single-list membership only... as long as we understand why multi-list membership isn't working [17:35:00] dbrant: i hear ya. it just felt like async was pretty close and this is a little bit of a step back [17:36:54] tgr: around by any chance? [17:56:02] dr0ptp4kt: uh, sorry, missed you [17:56:32] tgr: no worries. i was going to see if you could meet. just sent a meeting for tomorrow. that time look okay tomorrow? [17:58:20] dr0ptp4kt: a gcal invite? [17:58:27] I see one for Thursday [17:58:55] tgr: yes, thursday, sorry - thursday :) [17:58:59] tgr: that time ok? [17:59:12] dr0ptp4kt: need 5 min before meeting [17:59:21] that time is fine, thanks [19:40:17] have to go run an errand, will be back a little later and stay on later as necessary [22:56:12] \o jhobs bmansurov [22:56:26] jdlrobson: yo [22:56:30] welcome back [22:56:44] nice to be wearing flip flops again [22:56:51] :) [23:04:50] welcome welcome jdlrobson