[00:46:35] <HaeB>	 does anyone know if those IPs make sense https://meta.wikimedia.org/wiki/Wikimedia_Forum#Some_Wikimedia.27s_IPs_have_been_Blocking_in_Mainland_China ...
[00:46:54] <HaeB>	 ...i.e. do we generally serve desktop and mobile web version from different IPs?
[00:47:16] <HaeB>	 (i thought not... 
[00:47:32] <MaxSem>	 HaeB, we do
[00:48:17] <HaeB>	 ... i currently get 198.35.26.96 when pinging each of zh.wikipedia.org, en.wikipedia.org, en.m.wikipedia.org and zh.m.wikipeida.org )
[00:48:35] <MaxSem>	 simple way to verify whose IPs are these: $ host 208.80.154.224
[00:48:35] <MaxSem>	 224.154.80.208.in-addr.arpa domain name pointer text-lb.eqiad.wikimedia.org.
[00:49:00] <HaeB>	 well i sure believe that they are ours ;)
[12:05:15] <phuedx>	 mdholloway|afk: was that an ed murrow references?
[12:05:18] <phuedx>	 *reference
[12:05:22] <phuedx>	 boy am i jetlagged
[13:15:22] <mdholloway>	 mornin'/evenin', phuedx 
[13:15:26] <mdholloway>	 indeed it was
[13:15:37] <mdholloway>	 how was the flight home?
[15:36:45] <niedzielski>	 neat, tapping "f" in gerrit brings up a nice patch file menu. i don't see it listed in the "?" cheat sheet either
[15:37:07] <dbrant>	 cool!!
[15:41:48] <phuedx>	 mdholloway: ok
[15:41:53] <phuedx>	 but the jet lag hit me /hard/
[16:06:32] <jdlrobson>	 phuedx: joining us for standup?
[16:06:35] <jdlrobson>	 retro rather
[17:54:44] <phuedx>	 jdlrobson: had a wee nap
[18:21:02] <jdlrobson>	 phuedx: feeling refreshed?
[20:23:56] <EladKeyshawn>	 hey somebody here?
[20:25:59] <EladKeyshawn>	 hey
[20:26:01] <dbrant>	 EladKeyshawn: hello!
[20:26:22] <niedzielski>	 EladKeyshawn: o/
[20:26:28] <EladKeyshawn>	 dbrant: I still did not get how can i update the patch?
[20:26:37] <EladKeyshawn>	 without creating a new one
[20:26:42] <dbrant>	 EladKeyshawn: did you follow the steps I wrote?
[20:27:33] <EladKeyshawn>	 yeah there was nothing special on the 'review' command so i think it just opens a new request
[20:28:31] <dbrant>	 don't know what you mean by that.  If you check out the patch and amend it, git review will upload it to the same patch.
[20:28:55] <EladKeyshawn>	 dbrant: anyways you abandoned the one with latest changes
[20:29:11] <EladKeyshawn>	 so i need to revert back now
[20:29:22] <dbrant>	 EladKeyshawn: correct; it would be better if you made your latest changes on top of the original patch.
[20:30:01] <EladKeyshawn>	 So now if do what you said it would upload to the abandoned one
[20:30:38] <dbrant>	 No, check out your original patch, which is this one: https://gerrit.wikimedia.org/r/287408
[20:30:59] <dbrant>	 Also, please look at the inline comments that I made.
[20:34:47] <EladKeyshawn>	 dbrant: where are inline comments?
[20:35:27] <EladKeyshawn>	 got it
[20:36:37] <dbrant>	 Abandoned patches can be brought back, but it's more consistent to build changes upon a single patch from start to finish. Plus, the changes in this case are pretty minimal.
[20:40:20] <EladKeyshawn>	 dbrant: do you think its still necessary to make a seperate function? since there are'nt that much opportunities to change the title
[20:43:07] <dbrant>	 EladKeyshawn: I would say yes... we adhere pretty strongly to 'clean' code principles, so when there's more than one instance of creating the same localized string (even if it's just two instances), our instinct is to wrap it in a function.
[20:43:17] <dbrant>	 ^ i'm sure niedzielski can attest
[20:45:36] <dbrant>	 EladKeyshawn: good job! i see the updated patch set.
[20:46:18] <niedzielski>	 EladKeyshawn: hey! yeah, we try to keep things tidy. Sometimes it takes a few passes but nice code is one of our goals
[20:46:46] <EladKeyshawn>	 dbrant: Yes but i neglected the function i need to update again
[20:46:56] <dbrant>	 EladKeyshawn: yep, go for it
[20:52:54] <EladKeyshawn>	 dbrant: Done
[20:53:06] <EladKeyshawn>	 Thanks for the help
[20:53:40] <dbrant>	 EladKeyshawn: excellent! anytime
[20:54:27] <EladKeyshawn>	 dbrant: Where can i be updated of improvment tasks?
[20:54:44] <EladKeyshawn>	 of other improvment tasks
[20:55:53] <dbrant>	 EladKeyshawn: well, here's our bug tracking board: https://phabricator.wikimedia.org/tag/wikipedia-android-app-backlog/
[20:56:12] <dbrant>	 Anything in the columns of "Bug backlog", "Tech debt backlog", or "Product backlog" can be worked on, and they're sorted roughly by priority.
[20:56:30] <EladKeyshawn>	 Thanks
[21:56:59] <bmansurov>	 jdlrobson: yt?
[21:57:06] <jdlrobson>	 bmansurov: yup
[21:57:37] <bmansurov>	 jdlrobson: what would be the best way to create a different mark up for beta? right now we use includes/skins/minerva.mustache for stable and beta.
[21:57:55] <jdlrobson>	 for the header change?
[21:57:59] <bmansurov>	 yes
[21:58:46] <jdlrobson>	 bmansurov: I think we use header.mustache partial for the header?
[21:59:24] <bmansurov>	 yes, and I need to change the container which is defined in minerva.mustache
[22:00:01] <jdlrobson>	 bmansurov: I'd suggest splitting out a getTemplateData from render
[22:00:08] <jdlrobson>	 then you can just override that method
[22:00:23] <jdlrobson>	 Oh wait..
[22:00:28] <jdlrobson>	 bmansurov: it's already there - getHeaderHtml
[22:00:44] <jdlrobson>	 unless i'm missing something?
[22:00:53] <jdlrobson>	 bmansurov: want to pair on it?
[22:01:11] <bmansurov>	 jdlrobson: sure, let's jump on tracy
[23:28:22] <jdlrobson>	 bmansurov_brb: back
[23:28:39] <bmansurov>	 ok, we'll be on tracy, nirzar is joining too
[23:29:06] <jdlrobson>	 bmansurov it drops a 1px when you focus search
[23:29:26] <bmansurov>	 jdlrobson: good catch, banner hack