[08:09:55] yo o/ [09:04:03] morning! [12:12:28] out for lunch [16:06:02] jhobs: bmansurov prioritization meeting [16:59:41] maxbinder: router issues -- got d/c'd and now i'm trying to connect to the hangout [16:59:59] phuedx: ok, we hit time so standup is next, thx for the update [17:08:51] dr0ptp4kt: can I grab 2 minutes with you post-standup or do you need to rush to another meeting? [17:09:01] (literally 2 minutes) [17:09:38] jhobs: consolidated app standup after web standup [17:09:56] jhobs: but i can talk after that [17:10:13] dr0ptp4kt: argh, alright, can you give me a call once free then? [17:10:31] jhobs: yeah [17:10:36] thanks! [17:27:40] jhobs: i'm about to hangouts call you [17:30:12] jhobs: hangouts calling... [17:32:14] dr0ptp4kt: lemme know when yer free [17:33:51] maxbinder: i'm joining hangout now [17:33:57] maxbinder: i'm joined [17:34:10] dr0ptp4kt: gah, 5 min, got distracted [17:34:29] maxbinder: okay if i schedule something later? [17:34:38] i have a small window for lunch and should grab that [17:35:01] dr0ptp4kt: ya, anytime in the next 2 hours is fine, even if cal says no [17:35:16] maxbinder: thx, i'll set something [17:35:54] maxbinder: done [17:35:56] ttyl [18:22:11] jdlrobson: just provisioning vagrant… [18:24:08] (different machine) [18:27:33] phuedx: k i need to head into the office now [18:28:47] phuedx: if there's any issues can you communicate clearly what your blockers for merging are clearly and then if there are any i'll fix them up and get bmansurov to merge. Otherwise please +2 since Joaquin and Bman have already given their +1s. [18:28:51] hopefully catch you in a bit [19:03:20] jdlrobson: can you leave some comments for the EL patch? [19:18:07] bmansurov: hmm? [19:18:21] jdlrobson: i see a -1 without comments [19:18:49] bmansurov: oh yeh that's weird... lemme see what happened there [19:19:24] i think i got patchset confused [19:19:27] i dont remember reviewing this one [19:19:38] oh wait [19:19:39] yes i did [19:19:43] why didnt the message show up [19:20:41] good question [19:20:42] bmansurov: reposted. I think there must have been a bug with my command line too [19:20:44] oh i see what i did whoops [19:20:50] i forgot the right parameter :) [19:20:56] ok [19:20:58] thanks [19:29:28] gn y'all [20:31:09] dr0ptp4kt: did we decided to make grooming always at 9 am on Wednesdays, or keep one at 8 am? [20:33:56] maxbinder: i think we can move it one hour later, but there are some exceptions in the next month. mind emailing to confirm no big deal for people? i gotta hop on a call [20:34:04] maxbinder: i'll email, actually [20:35:58] dr0ptp4kt: k thx [20:52:52] mdholloway: regarding #1, i just mean that if I'm on Zero and i connect to Wi-Fi, i'm going to see that my Zero session has ended [20:54:20] mdholloway: since #2 is not a regression, it should probably be in a new patch and i'm not sure what the priority of that is. my vote is that we circle back on the email thread before pursuing. [20:54:58] niedzielski: for #1, isn't that expected? [20:55:15] niedzielski: for #2, yeah, i suppose that makes sense. [20:55:49] niedzielski: yes to new patch for sure. [20:56:17] mdholloway: re #1, i sort of think so... i wasn't sure. when i think about it, it makes perfect sense. however, as a user, i could picture myself initially experiencing a worry because my free internet had appeared to ended but in reality i just switched to Wi-Fi [20:57:25] mdholloway: so it sounds like the patch is ready to merge but it needs a rebase [20:57:27] niedzielski: Hmm, yeah, I see your point. [20:58:11] mdholloway: BTW, do you happen to know if we still need the ACCESS_NETWORK_STATE permission now that we're ripping this receiver code out? [20:58:50] niedzielski: I'd vote no change for now on that, but it's an interesting point. I'll bet dr0ptp4kt and the Zero folks thought about that at some point. [20:59:25] niedzielski: I think we do still need ACCESS_NETWORK_STATE for something, but I'd have to look back to remember just what [21:00:52] mdholloway: i guess i'll try taking it out locally and running with it for a few days. maybe i'll remember or empirically figure it out [21:06:12] niedzielski: actually, when I looked at that it was before the revision in which I took out the remaining bits of the old onReceive method. we might not need it at all. Maybe I'll take out it as an experiment and do a few quick functionality tests. [21:06:53] mdholloway: 👍 [21:10:53] niedzielski: it does indeed seem safe to take out. any objection to my taking it out when i rebase? [21:11:14] mdholloway: sounds good. i'll give it a spin on a couple of devices on my end too [21:27:22] bmansurov: can you elaborate by what you mean with "Yes, trying to follow the convention. I'll update the commit message in the follow up patch." [21:27:40] jdlrobson: i think the right term is 'sampling rate' and not 'sample rate' [21:27:54] jdlrobson: that's what we use in multiple places [21:27:59] okay, so yeh if you update https://gerrit.wikimedia.org/r/#/c/288534/4/extension.json to be sampling rate i'll happily merge [21:28:41] ok [21:29:55] jdlrobson: done [22:22:27] jdlrobson: do you know why jscs is complaining here: https://gerrit.wikimedia.org/r/#/c/289065/3/resources/ext.popups.schemaPopups.js ? [23:37:04] bmansurov: looking.. sorry missed that [23:38:08] bmansurov: your editor must be messed up [23:38:12] whitespace everywhere