[06:12:42] morning [08:04:30] yo [08:08:58] hi phuedx [08:09:43] joakino: how're you? [08:09:45] good weekend? [08:10:20] phuedx: pretty good, nothing special, u? [08:12:00] ^ that [08:12:11] long, LONG walk through london on saturday [08:17:35] just for fun? [08:21:03] yeah [08:21:12] lisa and i have a book of 100 walks through london [08:21:41] boys didn't appreciate the length of the walk though :/ [08:27:21] joakino: i'm setting up a new staging server [08:27:41] i was able to create a new instance just now [08:27:47] nice [08:28:07] thanks [13:34:17] Ilya Grigoriks talk at i/o was interesting: https://www.youtube.com/watch?v=aqvz5Oqs238 many facts about what impacts performance on a phone [13:45:21] phedenskog: thanks, i'll check it out! [13:45:44] phedenskog: i caught the talk by colt mcanlis on image compression, but not the one you linked [13:45:54] ah cool [15:59:54] dbrant|brb: when you get a chance, please resolve the appropriate tasks for 82, and tag whatever you think needs tagging for 83. I'm out this week but will check in periodically. [16:02:57] joakino: sprint kickoff [16:04:26] dr0ptp4kt: coming [17:04:06] dr0ptp4kt: can you send me an invitation to the meeting? [17:48:44] bmansurov: shoot, just saw this messae [17:49:00] bmansurov: generally, you can look at calendar invitations of others [17:49:19] np, i heard it was optional, and thanks for the tip [17:50:36] bmansurov: well, i would have liked it if you were there. i somehow missed the notification. anyhow, the outcome was this: tentatively, planning to actually finish hovercards [17:51:25] cool [17:57:05] joakino: are you slouching more now? [17:57:16] i think you've slowly slipped down the chair [17:57:57] haha no i'm still :) [18:09:42] dr0ptp4kt: "[GOAL]" cards in 73-O have some blockers in 74-P. Recommend we replace those with placeholder cards, or bring the blocker tasks into the sprint. [18:19:35] maxbinder: will put placeholders [18:19:51] tgr: wanna have 1:1 now? [18:20:18] dr0ptp4kt: ok [18:20:32] tgr: same hangout [18:31:23] jdlrobson, dr0ptp4kt, joakino: i've submitted a test case for the ubn bug [18:31:28] but i gotta go get some zzZ [18:32:04] also, dr0ptp4kt: i sincerely recommend all of sylosis's back catalog if you like thrash/death metal [18:32:07] \m/ [18:38:37] mdholloway bearND dbrant: ok i'm starting ye old beta release process (https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process#Beta_release) [18:39:35] 👍 [18:44:27] bearND: what do you think about renaming parsoid-access to restbase-access? [18:46:43] mdholloway: what are you planning to add that's not parsoid specific? [18:48:12] bearND: the pageview api is also served from restbase but has nothing to do with parsoid, and i've been putting the code to grab and process that data in parsoid-access [18:49:16] bearND: just thought restbase-access is probably more accurate since even for parsoid page html our request is going to restbase, not parsoid [18:54:14] mdholloway: I'm just thinking that I don't want to make that library too big. So keeping the parsoid specific portion separate would be good IMO [18:54:36] mdholloway: I don't mind changing the name to something else [18:54:53] bearND: ok. i can put the pageview stuff elsewhere [19:18:00] bearND: btw, i can deploy today unless you want to [19:18:28] mdholloway: i can do it. Got most of it already prepped [19:18:38] bearND: oh, ok, sounds good [20:06:36] bearND mdholloway dbrant: i saw this weird crash on two devices so far: https://rink.hockeyapp.net/manage/apps/226649/app_versions/20/crash_reasons/122452429 [20:06:58] i've never seen it before [20:08:33] it'o possibly due to previous debug state but i'm not sure. both devices were api 19 [20:10:23] er, sorry. actually 3 devices. 1 was api 16, 2 were 19. other crashes here https://rink.hockeyapp.net/manage/apps/226650/app_versions/20/crash_reasons/122455080?scope=devices&type=statistics [20:13:06] bearND mdholloway dbrant: dang. this is 100% repro-able on api 16. will open a phab momentarily [20:13:38] :.( [20:14:28] ouch [20:32:48] niedzielski: it looks like we're expecting to catch those exceptions, but we're looking for IOException instead of RetrofitException [20:45:41] dbrant: sorry, i missed this. that seems to be half the problem [20:46:04] dbrant: when i fixed that, i see that we're preserving an anoymous edit token for logged in user in some cases [20:46:15] dbrant: forthcoming patch will address both [20:46:21] nice [21:01:36] hey we're facing some issues with the MobileFrontend extension [21:02:13] it's failing to correctly render html elements in some cases [21:04:34] example: [21:04:35] https://psychonautwiki.org/wiki/2C-P/Summary [21:04:56] in the version rendered through mobilefrontend: [21:04:56] https://psychonautwiki.org/w/index.php?title=2C-P/Summary&mobileaction=toggle_view_mobile [21:05:19] some elements escape their parent elements [21:06:34] (I hope this is the right channel for mobilefrontend?) [21:10:52] niedzielski: hey i was late reviewing/merging last week's TWN update - just merged it [21:12:49] mhurd: ok, i should probably revise today's patch. please hold off on merging that guy [21:13:38] niedzielski: hmm i don't see a patch for today... [21:13:43] jdlrobson: are you the right person to ping for kenansulayman's issue? [21:16:01] mhurd: weird, my mistake. i pushed the branch but never opened a pr. sorry, about that. well, i will just delete that branch and rerun the translations later [21:16:17] niedzielski: oh gotcha. thanks so much :) [21:16:35] mhurd: np! :) [21:31:45] bearND mdholloway dbrant: hm, the underlying issue for the anonymous token storage is that the session cookies were dropped. i can no longer repro this so i will have to punt for now. i'll uploaded the fix for the exception [21:37:43] bearND mdholloway dbrant: patch is here https://gerrit.wikimedia.org/r/#/c/290353/ [21:44:04] dbrant: i'm going to merge this edit timing fix too since we gotta start over [21:44:23] niedzielski: excellent [21:50:29] bearND mdholloway dbrant: i think i will update the version minor number too to reflect the change in reading lists and networking libs if there aren't any objections [21:51:11] +1 [21:51:21] +1 [22:23:23] kenansulayman: still there? [22:23:39] dr0ptp4kt: yt? [22:23:49] bmansurov: yep. what's up? [22:24:03] dr0ptp4kt: image a situation where the user hovers over a link and opens it [22:24:13] dr0ptp4kt: so the action will be "opened in the same tab" [22:24:20] bmansurov: ok [22:24:53] dr0ptp4kt: however, since the user is leaving the page and not hovering any more, dwelledButAbandoned will also be triggered [22:25:04] dr0ptp4kt: should I not trigger the second action? [22:25:32] btw, popup didn't have enough time to open in the above example [22:25:59] bmansurov: one moment [22:26:05] dr0ptp4kt: ok [22:26:12] kenansulayman: i believe you might be able to fix by wrapping the entire page in a
tag but I'm not sure. The problem is it's trying to enable section collapsing on a page that doesn't support it. Also the use of headings is going to cause you problems. https://en.m.wikipedia.org/wiki/Portal:Communism is a page with similar problem.s [22:28:55] bmansurov: don't trigger dwelledbutAbandoned in that case [22:29:19] dr0ptp4kt: ok, another similar question [22:29:25] bmansurov: sup? [22:29:40] dr0ptp4kt: when the popup shows in the above example, then 'abandoned' should also not be triggered, right? [22:31:06] niedzielski: dbrant: bearND: i can't reproduce the user option syncing crash but the patch seems to work at least as well [22:31:17] bmansurov: are you saying in the case where the user (a) dwells on the link, (b) the preview displays, then (c) the user clicks on the link (as opposed to the hovercard)? [22:31:44] dr0ptp4kt: yes [22:32:36] bmansurov: in that specific case the options are the "opened in..." ones [22:32:39] bmansurov: make sense? [22:32:50] bmansurov: if you want to talk on video i can do that for a few minutes [22:33:04] dr0ptp4kt: sure, tracy? [22:33:27] bmansurov: yep, c u there [22:38:34] jdlrobson that works, why does it work? [22:40:42] actually I'm not sure, let me check something [22:44:20] jdlrobson https://psychonautwiki.org/w/index.php?title=UserWiki:Apx/playground&mobileaction=toggle_view_mobile [22:44:59] doesn't work, some elements like h3, ... are still moved out of the div [22:45:21] kenansulayman: if you can put that page in a separate namespace you can use wgMFNamespacesWithoutCollapsibleSections global [22:45:36] e.g. Portal:2C-P/Summary [22:48:09] jdlrobson that's not a feasible option unfortunately because alot of pages embed the Summary page inline as {{Summary/}} [22:48:44] not sure how the rendering issue cascades throughoutt namespaes though [23:53:41] how hard is it to implement justified text? There is alot of space wasting with the left aligned text ;(